It is possible to group objects from different layers, so it is an error
to rely on layer ID when checking visibility of a group. This problem
was partially obscured by the fact that SdrObjGroup::GetLayer() returns
0 if its subobjects are on different layers and 0 is a valid layer ID.

Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
(cherry picked from commit 09d4525b)
Reviewed-on: https://gerrit.libreoffice.org/2962Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Project: translations  78ffe851c7f86318bd0e21f93caf3ccb7d1b98b9

Change-Id: I532f27aee60a2e60110e9edea75e7cbe7d614b1e
Reviewed-on: https://gerrit.libreoffice.org/2940Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>

It turns out this is not actually a performance problem but an oversight
in implementation (or a bug, if you want .-)

Every manipulation with a table (e.g., move, resize; actually even a
selection of the table) leads to creation of a full copy of the table
(SdrObject::getFullDragClone()). One of the actions the table copy impl.
does is to call sdr::CellProperties::SetStyleSheet() on every cell of
the new table. CellProperties is derived from
sdr::properties::TextProperties and CellProperties::SetStyleSheet() just
passes the call to TextProperties::SetStyleSheet(). This is where the
trouble begins :-)

The SDR representation of a table, SdrTableObj, is derived from
SdrTextObj. Because of that, SdrTextObj needs to be able to contain more
than one SdrText (because a table needs one for every cell). This is
handled correctly by TextProperties. But, because there is no SDR
representation of a single cell, CellProperties uses the SdrTableObj as
the SDR object it works on. Therefore TextProperties::SetStyleSheet()
processes all SdrText objects of the _whole table_, not just a single
cell. And this is repeated for every other cell...

Change-Id: Iab2e2d0e1e8038710645c0bd24666e6032b0a003
(cherry picked from commit 91864e19)
Reviewed-on: https://gerrit.libreoffice.org/2925Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: I887b11646efb9a839da11cd3e20cdf7e532caf3e
(cherry picked from commit 7a25aa28)
Reviewed-on: https://gerrit.libreoffice.org/2913Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Adds support for the UP, DOWN, LEFT, RIGHT and RETURN keys in the
thumbnails view but doesn't handle the modifiers yet. There are still
some problems with the focus and key input outside the top level

(cherry picked from commit ee819bdd)

Conflicts:
	sfx2/source/control/thumbnailview.cxx

Change-Id: I5ba67583c835bcc00b075071411c0d6590a07f9a
Reviewed-on: https://gerrit.libreoffice.org/2912Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

(cherry picked from commit bfd1bcb2)

Conflicts:
	sfx2/source/control/thumbnailview.cxx

Change-Id: Ib5ebcd928e77a115f4f62a50724656c33ae13c61
Reviewed-on: https://gerrit.libreoffice.org/2911Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: I6e542ecc0e0f5a2b3e0ca59a52bb809b1a23284f
(cherry picked from commit 5fa5f956)
Reviewed-on: https://gerrit.libreoffice.org/2909Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>

Change-Id: Ie012e010ca92728725535345c76fc9f5eb31a254
(cherry picked from commit ec2f84b3)
Reviewed-on: https://gerrit.libreoffice.org/2910Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>

Regression from 4a507f73. The problem
was that in some cases \pard can't reset all paragraph properties. The
original commit just made this keyword a noop when it occurred between
\cell and \row, but this is too much. At least margins do need
resetting.

Change-Id: I5cbb1df72bf1211f85ef69ab64d5b46cbce5c742
(cherry picked from commit 24d5261f)
Reviewed-on: https://gerrit.libreoffice.org/2906Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

...at least due to dependency of librelogo.xcd on writer.xcd, see
82c53d53 "Missing dependency."

Otherwise, having librelogo installed but not writer will cause an uncaught
RuntimeException from configmgr::Components::parseXcdFiles
(configmgr/source/components.cxx) early on in soffice.bin.

(cherry picked from commit 4e69b356)
Conflicts:
	setup_native/source/packinfo/packinfo_office.txt

Change-Id: I97565fe5c790ed182bb27fd722c650acf8a8ee08
Reviewed-on: https://gerrit.libreoffice.org/2897Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: Ifb74ce0c60e0d0796d5d04a67e9d58721b58593c
Signed-off-by: Andras Timar <atimar@suse.com>

Change-Id: Ic6ea83338d1f821277d97ca368bb0b9f648eeb23
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>

(cherry picked from commit 190b9257)
Conflicts:
	desktop/source/migration/services/oo3extensionmigration.cxx

Change-Id: I9cc8acac54bd5a02652462c3967b4c81f7cf8ee3
Reviewed-on: https://gerrit.libreoffice.org/2877Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

(cherry picked from commits 287c254d5ebf9b58ca63a8c271e523adf0d34b82 and
1fba17854b2be4fdbe436f44da3ae57a1f75a27c)

Conflicts:
	sw/qa/extras/odfexport/odfexport.cxx

Change-Id: Ifb850438586eb6589fde79d10ed9eef727368f42
Reviewed-on: https://gerrit.libreoffice.org/2873Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>

(cherry picked from commit 26e91b07)

Change-Id: I504ec85fa7b94a4473905b7e2720b2169c53e6cf
(cherry picked from commit e6a7c555)
Signed-off-by: Eike Rathke <erack@redhat.com>

In case we know there is a non-section paragraph at the end of the
document.  Intentionally not adding a unit test as David Ostrovsky is
working on one already.

(cherry picked from commit 62344016)

Change-Id: Ia6026846981b5af014246a8a604c5f762d34c891
Reviewed-on: https://gerrit.libreoffice.org/2876Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>

Code wrongly replaced decimal separator with '.' and used atof() to scan
the number string which itself may be localized on *iX systems but not
on Windows. Hence on *iX the numbers may had been truncated where on
Windows they were not.

Additionally made this work with Unicode separators if defined for the
locale, removed the awkward conversion to ASCII byte string and
eliminated use of toupper() and isdigit() calls. Also eliminated a
possible buffer overflow.

(cherry picked from commit 9e9f39d1)

Conflicts:
	basic/source/sbx/sbxscan.cxx

replace decimal separator at correct position, rhbz#919020

(cherry picked from commit e96c7a60)

Change-Id: I35d82e8f267ecb925783bf6f2de044a29c08f688
Reviewed-on: https://gerrit.libreoffice.org/2859Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>

Change-Id: I7f1bddbed85076f1c909d0d9f4ecdd1cda6f1880
(cherry picked from commit 4158ae52)
Reviewed-on: https://gerrit.libreoffice.org/2861Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Iab2dd8ef71fd84e9d147d90e9cad46d69a8fe650
(cherry picked from commit eff94128)
Reviewed-on: https://gerrit.libreoffice.org/2845Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>

Change-Id: Ic5ef64ba3ed4c98397b0c4911de491df4c79946a
(cherry picked from commit b6ba0463)
Reviewed-on: https://gerrit.libreoffice.org/2844Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>

Conflicts:
	sfx2/inc/templatedlg.hxx
	sfx2/source/doc/templatedlg.src

Change-Id: Ibff35bf24873a38c9a09d71fb3630a57e06f1a3c
Reviewed-on: https://gerrit.libreoffice.org/2843Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>

Change-Id: I71e8658453e0e96e631cc2ef3996d660950c49cc

Because autodoc is unmaintained and broken, the description of all IDL
types is missing in the generated HTML documentation.
Work around autodoc bug by starting the license header in IDL
files with "/**", which can be done in less time than understanding
autodoc sufficiently to fix the bug.

Change-Id: Ia548ab412178efc2acb87f0f4d4ae1854d0b4bfa
Reviewed-on: https://gerrit.libreoffice.org/2842Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>

We need to use "touch --no-dereference" on the delivered files.
Otherwise, it creates empty target file when you touch symlinks and
delivering the real target file might fail.

This caused many build failures when delivering:

    liblcms2.so -> liblcms2.so.2.0.4
    liblcms2.so.2 -> liblcms2.so.2.0.4
    liblcms2.so.2.0.4

Change-Id: Ibd61815c12e002b495e848a125a959b8524b0935
Reviewed-on: https://gerrit.libreoffice.org/2840Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: Iac87870c0f50a74b7f4db4c674adcded1494c055
Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>

Change-Id: I203be719a6ee19c87ed232218f7700d875c2871f
(cherry picked from commit 094bab7f)
Reviewed-on: https://gerrit.libreoffice.org/2821Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: I344448db559de8435dcc26e2be4597c385724a7b
(cherry picked from commit e15d8ef4)
Reviewed-on: https://gerrit.libreoffice.org/2820Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: Ic2651defd0ec8846dc0b0a81faee5dd6743310fb
(cherry picked from commit 7b12b467)
Reviewed-on: https://gerrit.libreoffice.org/2819Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: I36ede89ccb8836708a4f87c4815bbe2fb6d6f3cf
(cherry picked from commit a6d12acd)
Reviewed-on: https://gerrit.libreoffice.org/2818Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Broken with 842c95519a35174238c728784662f854031993d7 were things like
;;;@  or  _;0

Change-Id: Idf99378beedacf97a0376d1cd11ee78d3f7c9aff
Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>

(cherry picked from commits 60c17b28 and
c412cba2)

Change-Id: Ifa7b14e88231e5053c84dfbdd9b453715df1aaa6
Reviewed-on: https://gerrit.libreoffice.org/2817Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

this patch will fix the incorrect border when you use
the cell format dialog.

Change-Id: Ieeeae4060a15e96e0de0f335f3c460df86f7dbf9
Reviewed-on: https://gerrit.libreoffice.org/2781Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
(cherry picked from commit 02c04319)

Change-Id: Idb73d3029880b66602f163b2ab03c2b37c2306db
Reviewed-on: https://gerrit.libreoffice.org/2782Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
(cherry picked from commit 84e4bf88)

unwind problem introduced by cleanup in:
fd226710

Change-Id: Id5f7b20087cbbdeffe1a2e64e039ee0a11995faa
Reviewed-on: https://gerrit.libreoffice.org/2814Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

I also merged (manually) the changes of the cleanup
commit of Michael Stahl ( commit id 859e9429 )

Change-Id: Ibcd0373110fde848dccf93ffe9100459c7cc64a5
Reviewed-on: https://gerrit.libreoffice.org/2572Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-on: https://gerrit.libreoffice.org/2777Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>

- remove PD_FIRST and GetFirstFmt:
  This flag makes no sense at all, since there are no "first-only"
  page styles (while there are left-only/right-only).
- instead add a parameter to GetLeftFmt/GetRightFmt to request a
  first page format, if such exists and is not shared
(regression from 02a934d0
 and fa0f42ba)

Change-Id: I4d50c2c0cc4f3cf231eacba891df22d0bcf6c4df
(cherry picked from commit 4dc78aee)
Reviewed-on: https://gerrit.libreoffice.org/2764Tested-by: Miklos Vajna <vmiklos@suse.cz>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>

Change-Id: I0421253d363fbe82a833011d22eb86e61d3ad264
Reviewed-on: https://gerrit.libreoffice.org/2810Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: I5919fbb272f82deeb951906f5b82dc196e856a48
Reviewed-on: https://gerrit.libreoffice.org/2807Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: I6ae07e61b67fa321e80605e6e3a6fcdd56012b95
Reviewed-on: https://gerrit.libreoffice.org/2790Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>