Kayıtlar (commit) · 70dba37ef6c7a329d6009ae6de70fbf061e7d46e · LibreOffice / core

13 Mar, 2019 4 kayıt (commit)

Tor Lillqvist Mar 13, 2019 yazdı

There are enough problems making the dialogs look and work sanely in
the iOS app without the preview being placed completely wrongly and
covering other controls.

Change-Id: If6018f41ba0c250a630e3a917f69174eb0782620

70dba37e

tdf#124057: Do call RegisterControls() on non-DESKTOP · 265e3fa0

Tor Lillqvist Mar 13, 2019 yazdı

Otherwise the Tools > Word Count dialog doesn't show up in the iOS
app.

Change-Id: Ic425749cc8f3245d7a16d7784d77b02f6d47253f

265e3fa0

Revert "Temporary hack to make iOS app dialogs look better" · 9efe3886
Tor Lillqvist Mar 13, 2019 yazdı
```
Not surprisingly, it broke everything else.

This reverts commit 30d012a3.
```
9efe3886

tdf#124042: There are no progress bars that vcl would handle on iOS or Android · 0fd1dd8e

Tor Lillqvist Mar 13, 2019 yazdı

Don't even bother trying to dislay such. Any progress feedback to the
user will be handled through LibreOfficeKit callbacks.

(Sure, the code probably thought it had created a "window" for the
progress bar, but there wasn't anything real in the data structure
that would actually display anything anywhere, no CG context (on iOS)
etc.)

Change-Id: Ie0ca18bbb22da41882bdaba4a0ce77a52112a059

0fd1dd8e

12 Mar, 2019 9 kayıt (commit)

Temporary hack to make iOS app dialogs look better · 30d012a3
Tor Lillqvist Mar 12, 2019 yazdı
```
Change-Id: I6b1fe798cb1af7419e12f1b9e41ca13608e3ee4b
```
30d012a3
Bump version to 6.0-26 · 006dfaf6
Andras Timar Mar 12, 2019 yazdı
```
Change-Id: I6b48f441475f10bb8893978546052950875a3a1a
```
006dfaf6

Move the Help URL to a different config path · 0c80a474

Ashod Nakashian Mar 12, 2019 yazdı

This partially reverts e5a0bafa
and simplifies the Help URL configuration.

Change-Id: Icc7c31b8955f3df978b57dbd8aa8816a9e1f98ad
Reviewed-on: https://gerrit.libreoffice.org/69106Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

0c80a474

poppler: upgrade to release 0.74.0 · 86d07d01

Michael Stahl Mar 12, 2019 yazdı

Fixes CVE-2019-7310.

Add patch to fix CVE-2019-9200 too.

CVE-2018-20662 looks irrelevant because we don't build pdfunite tool.

Change-Id: I5e7ddabbb341f6bfefb376d552b50c4006f41906
Reviewed-on: https://gerrit.libreoffice.org/69094
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

86d07d01

initialize caches in the constructor · abbb137d
Tomaž Vajngerl Mar 12, 2019 yazdı
```
Change-Id: I1aa89afcb5d399b653e270ae18342afa7103a680
```
abbb137d

LOK: don't segfault when reporting error · 9fa568dc

Ashod Nakashian Mar 10, 2019 yazdı

Change-Id: Ia6d614eb15b15f43ddd3e0b5742b888060dfd581
Reviewed-on: https://gerrit.libreoffice.org/69069Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

9fa568dc

sd: document the left pane classes · 0b3c2cb3

Ashod Nakashian Kas 12, 2018 yazdı

Change-Id: Id037e2f5f733ef7266ef6d48ff2ff7dea956ea25
Reviewed-on: https://gerrit.libreoffice.org/69070Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

0b3c2cb3

Make the Help URL configurable · e5a0bafa

Ashod Nakashian Mar 12, 2019 yazdı

When the Help URL is blank, the Help
buttons are hidden LOK (but not desktop).

Change-Id: Ibd76452108d1e3a92fb43f2c0af0586b0cbed073
Reviewed-on: https://gerrit.libreoffice.org/69071Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

e5a0bafa

fix build failures because of diff against master · ab71569a
Tomaž Vajngerl Mar 12, 2019 yazdı
```
Change-Id: Iefe4683f456750b53c96e1634d7930f4b042e573
```
ab71569a

11 Mar, 2019 27 kayıt (commit)

widget theme: change the tab item height to (min) 32 px · fe4da4c2

Tomaž Vajngerl Mar 11, 2019 yazdı

Change-Id: I1919300071a06242fe832880b46c944989daa4b6
Reviewed-on: https://gerrit.libreoffice.org/69057
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 212a40aa)

fe4da4c2

better adjustment algorithm for dynamic sized widgets · 7a6e7ed1

Tomaž Vajngerl Mar 11, 2019 yazdı

A algorithm that gives better results for dynamically sized
widgets is to increase proportionally only the points in shapes
that are over the half of the widget width (or height, when
adjusting the other dimension). This preserves the margins and
doesn't distort the shape of the paths, which is especially
visible when the source needs to be largely resized in one
dimension only.

Change-Id: I2cceb249063387c0f7400ef8d75adb5899aa8c23
Reviewed-on: https://gerrit.libreoffice.org/69056
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 897f6f62)

7a6e7ed1

cache file based widget images and draw commands · 8307ecbd

Tomaž Vajngerl Mar 11, 2019 yazdı

It is wasteful to parse svg icons all the time so lets cache the
result when this make sense in a LRU map.

Change-Id: I95cc317c9301138a9e384d270223ba147a123e59
Reviewed-on: https://gerrit.libreoffice.org/69055
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 805b15ce)

8307ecbd

Fix build · 8a828146

Mike Kaganski Mar 11, 2019 yazdı

[CXX] svgio/qa/cppunit/SvgRead.cxx
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): error C2440: '<function-style-cast>': cannot convert from 'Color' to 'sal_Int32'
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): note: No user-defined-conversion operator available that can perform this conversion, or the operator
cannot be called
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): error C2672: 'CppUnit::assertEquals': no matching overloaded function found
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string
&)': expects 4 arguments - 3 provided
C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals'
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): error C2440: '<function-style-cast>': cannot convert from 'Color' to 'sal_Int32'
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): note: No user-defined-conversion operator available that can perform this conversion, or the operator
cannot be called
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): error C2672: 'CppUnit::assertEquals': no matching overloaded function found
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string
&)': expects 4 arguments - 3 provided
C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals'
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): error C2440: '<function-style-cast>': cannot convert from 'Color' to 'sal_Int32'
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): note: No user-defined-conversion operator available that can perform this conversion, or the operator
cannot be called
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): error C2672: 'CppUnit::assertEquals': no matching overloaded function found
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string
&)': expects 4 arguments - 3 provided
C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals'
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): error C2440: '<function-style-cast>': cannot convert from 'Color' to 'sal_Int32'
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): note: No user-defined-conversion operator available that can perform this conversion, or the operator
cannot be called
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): error C2672: 'CppUnit::assertEquals': no matching overloaded function found
C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string
&)': expects 4 arguments - 3 provided
C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals'
make[1]: *** [C:/lo/src/core2/solenv/gbuild/LinkTarget.mk:293: C:/lo/src/core2/workdir/CxxObject/svgio/qa/cppunit/SvgRead.o] Error 2
make: *** [Makefile:166: CppunitTest_svgio_read] Error 2

Change-Id: I4e1cf222a416772f1920194ccfcf459f40b577d6
Reviewed-on: https://gerrit.libreoffice.org/69064Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

8a828146

tdf#123939: string and error are same type for pivot cache in XLSX · ebc7f46f

Mike Kaganski Mar 08, 2019 yazdı

Change-Id: Id39d322661f7537e8999acafee655c0cc16a78c1
Reviewed-on: https://gerrit.libreoffice.org/68911
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/69063Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

ebc7f46f

tdf#123923: make COUNTIF propagate errors in its first parameter · 0640e800

Mike Kaganski Mar 07, 2019 yazdı

In a specific case, Err:504 was emitted by COUNTIF when its 1st
parameter was #REF!. This value was written into pivot cache definition
when exporting to XLSX. Clearly Excel only expected propagated #REF!
there, emitted error to user, and dropped the pivot table.

This problem made XLSX pivot table cache generated by Calc unusable
by Excel, despite ECMA-376 Part 1, 18.10.1.27 tells that the error
value is application-dependent.

The change makes COUNTIF to propagate errors received in its 1st
parameter, instead of owerwriting them with own Err:504. This will
likely need to be extended to other functions, if similar problems
would arise.

Change-Id: I459fa163a0e3e5f2c658631d66e096f4d46b1ace
Reviewed-on: https://gerrit.libreoffice.org/68868
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 1f970c20)
Reviewed-on: https://gerrit.libreoffice.org/69039Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

0640e800

We need share/theme_definitions in the iOS app · c074ef82
Tor Lillqvist Mar 11, 2019 yazdı
```
Change-Id: I460a71f363eb3b7f89786b8bd02f4b8f9521f4c7
```
c074ef82
fix build failures (diff between mastwr and cp-6.0) · 8a74c846
Tomaž Vajngerl Mar 11, 2019 yazdı
```
Change-Id: Ieb9be180b3a9f8fb33c7a1089a8ef35e66b082ec
```
8a74c846

widget theme: slight window borders, use font 10 instead of 12 · 7dddccee

Tomaž Vajngerl Mar 10, 2019 yazdı

Change-Id: I6b0ba769817894b99c3f757d23948783a66fce12
Reviewed-on: https://gerrit.libreoffice.org/69023Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 2513e686)

7dddccee

widget theme: support disabled pushbutton · b30f2bb8

Tomaž Vajngerl Mar 10, 2019 yazdı

Change-Id: I8c6e019f5d1f12c85334f3440e09ef755ed6863d
Reviewed-on: https://gerrit.libreoffice.org/69022
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 5d535ffb)

b30f2bb8

widget theme: add support for menubar, menupopup and tooltip · 4ca6f4bf

Tomaž Vajngerl Mar 10, 2019 yazdı

But they are not used - for now.

Change-Id: I93a74f5a9e52791fd08afbb5502427a0684d60cf
Reviewed-on: https://gerrit.libreoffice.org/69021
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 7e5fe834)

4ca6f4bf

widget theme: change color for window background and frame · 1e1fc114

Tomaž Vajngerl Mar 10, 2019 yazdı

Change-Id: I37f1524db71eea2912ffb65fdd7a00605e6b1d4d
Reviewed-on: https://gerrit.libreoffice.org/69017Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit e089b75b)

1e1fc114

widget theme: take into account scaling factor for images · 1b965b28

Tomaž Vajngerl Mar 10, 2019 yazdı

Change-Id: I65bd71dfd113fae33aee7c2b60b945e065314f80
Reviewed-on: https://gerrit.libreoffice.org/69016Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit cbfe46bf)

1b965b28

widget theme: draw slider button from svg, left and right track · 65ed1177

Tomaž Vajngerl Mar 10, 2019 yazdı

Change-Id: Iaba4a67845699d795c719d0259e93bb6c72df470
Reviewed-on: https://gerrit.libreoffice.org/69015
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 100ea303)

65ed1177

widget theme: draw listheader button and arrow · 424fc5ef

Tomaž Vajngerl Mar 10, 2019 yazdı

Also adds support for signaling if arrow points up or down, which
is signaled through extra attribute.

Change-Id: I5a87cdb31e18150495df521bf925c7b983e2313a
Reviewed-on: https://gerrit.libreoffice.org/69013
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 8ff3e9a4)

424fc5ef

widget theme: support "height" for editbox and set to "32" · a946badc

Tomaž Vajngerl Mar 10, 2019 yazdı

Change-Id: Iff48c83b6f1b28bc7fbf7646c399a844a3155970
Reviewed-on: https://gerrit.libreoffice.org/69012
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 3ae8b930)

a946badc

widget theme: toolbar drawing definition - separator, buttons · 9dd81227

Tomaž Vajngerl Mar 10, 2019 yazdı

Change-Id: Ic8574c0f0c3c51526254c34d820977a0fbb520a0
Reviewed-on: https://gerrit.libreoffice.org/69011
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit cdabde59)

9dd81227

widget theme: adjust draw positions of editbox, combobox, listbox · 922fb093

Tomaž Vajngerl Mar 09, 2019 yazdı

Change-Id: Id14b5530c994e10bb9f45f036b43025c73c7ac83
Reviewed-on: https://gerrit.libreoffice.org/68977Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit a66e0f83)

922fb093

only read and parse widget definition once from the file · 73112b38

Tomaž Vajngerl Mar 09, 2019 yazdı

Change-Id: I71c095e5e5dd21650663e6fb717bcb22958a597f
Reviewed-on: https://gerrit.libreoffice.org/68976
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit e9393e39)

73112b38

Separate style colors from WidgetDefinition into its own class · 9bfd89b0

Tomaž Vajngerl Mar 09, 2019 yazdı

Change-Id: I11cd695da81bae7b49b2319b89e5c560ba64f04e
Reviewed-on: https://gerrit.libreoffice.org/68975
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 4e25914b)

9bfd89b0

Fix multiline tabs drawing of first / last tab · 4156d3b9

Tomaž Vajngerl Mar 08, 2019 yazdı

Use is{Left,Right}Aligned instead of is{First,Last}. In multi-line
tabs, not only first/last item needs to be drawn differently, but
also some middle, which is now the first in the new line now.

Change-Id: I81ddde192eca794f16df98d629f47991c59732c7
Reviewed-on: https://gerrit.libreoffice.org/68945
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 86d9b85f)

4156d3b9

Fix crash in widget drawing of a SVG as image · a1750a87

Tomaž Vajngerl Mar 08, 2019 yazdı

Change-Id: Iaa7e01b49b9c2dcdfa98e4e8bc431dba82fe6bb4
Reviewed-on: https://gerrit.libreoffice.org/68942
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 8de89e1c)

a1750a87

make it possible to use FileDefinitionWidgetDraw in more backends · b3783c28

Tomaž Vajngerl Mar 08, 2019 yazdı

Reviewed-on: https://gerrit.libreoffice.org/68898
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit a2bf2ca1)

Change-Id: I8871eb49e11d8c72c469230967c3c979091a0f9b

b3783c28

don't need "spinbox-entire" svg anymore · b6eeacd7

Tomaž Vajngerl Mar 07, 2019 yazdı

Change-Id: I8385acf7ecd46b7c8b990abb688bd2ddddcb6bc5
Reviewed-on: https://gerrit.libreoffice.org/68867
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit c8919fcb)

b6eeacd7

widget theme - update editbox, draw from svg · ecf3e407

Tomaž Vajngerl Mar 07, 2019 yazdı

Change-Id: I0dfdaaf74c9b31ecd9b1de511b48dacf2e90f59f
Reviewed-on: https://gerrit.libreoffice.org/68866Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 27b43f1d)

ecf3e407

widget theme - update combobox/listbox, draw from svg · fffd4098

Tomaž Vajngerl Mar 07, 2019 yazdı

Change-Id: Ie5e28883d70ad61340c58bcacd8c2ffb2ced1536
Reviewed-on: https://gerrit.libreoffice.org/68865
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit ce4c4864)

fffd4098

widget theme - update scrollbars, draw from svg · 7effd1ce

Tomaž Vajngerl Mar 07, 2019 yazdı

Change-Id: I7e7cd05ce516ab24d380bb8b6a264fd45e1d553c
Reviewed-on: https://gerrit.libreoffice.org/68864
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 79b9d387)

7effd1ce