Kayıtlar (commit) · 70ed8c321e0f8a6058d92876de2eb49f8f0ebbb8 · LibreOffice / core

18 Agu, 2018 6 kayıt (commit)

coverity#1438404 Identical code for different branches · 70ed8c32

Caolán McNamara Agu 18, 2018 yazdı

Change-Id: I19a7bb7a142ddb90d9b42fe589900bd74d09e153
Reviewed-on: https://gerrit.libreoffice.org/59290
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

70ed8c32

tdf#116436 doc export: add missing table background fill · b576ab50

Justin Luth Agu 17, 2018 yazdı

MS formats only have support for Table and Cell fill.

Interestingly, MS Word doesn't let the cells inherit from
the Table fill setting,
so that value also needs to be written out into every cell.

Since Word apparently ignores the table color, I didn't
bother trying to search out how to export that in DOC
format.  (I did add it to DOCX since it was so easy to find.)

Change-Id: I8946f07b45f72fed5959369182882a7bf013b1d0
Reviewed-on: https://gerrit.libreoffice.org/59281
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

b576ab50

tdf#116436 docx export: add missing table background fill · 8cc753d5

Justin Luth Agu 17, 2018 yazdı

MS formats only have support for Table and Cell fill.

Interestingly, MS Word doesn't let the cells inherit from
the Table fill setting (even though LO docx import currently does),
so that value also needs to be written out into every cell.

Change-Id: Ib49fddf52758ff641428de747ea290d1fcb894f3
Reviewed-on: https://gerrit.libreoffice.org/59260Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

8cc753d5

uitest Impress-rename,new slide ; tdf#85360 · 991ff3d6

Zdeněk Crhonek Agu 17, 2018 yazdı

Change-Id: Id080fdeb3d47f27f9a8b83b7720e96eb46eb716b
Reviewed-on: https://gerrit.libreoffice.org/59267
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

991ff3d6

loplugin:useuniqueptr pass SmNodeList around by std::unique_ptr(2) · 9fd7808f

Noel Grandin Agu 16, 2018 yazdı

Change-Id: I53b7f39ddc150367bc5f9c4a7ee7049d59e9f485
Reviewed-on: https://gerrit.libreoffice.org/59231
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

9fd7808f

new loplugin intvsfloat · 2caee0fa

Noel Grandin Agu 17, 2018 yazdı

This was a good idea from mike kaganski as a consequence of
   https://gerrit.libreoffice.org/55359

Unfortunately, clang/llvm is not yet up to the job of doing floating
point evaluation, I get tons of crashes all over the evaluate
infrastruction inside clang, so this will need to wait until clang's
code matures.

So park it in store for now

Change-Id: I5ba4de8323e462b4fd4db301e4d116a81fd56ed3
Reviewed-on: https://gerrit.libreoffice.org/59254
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2caee0fa

17 Agu, 2018 34 kayıt (commit)

Avoid further downstream overflow · 4cb69cf3

Stephan Bergmann Agu 17, 2018 yazdı

...after 004304eb "try to avoid overflows in
some compare functions" had changed the return type of just one function, but
not its callers.  Found with Clang's new -fsanitize=implicit-conversion during
CppunitTest_sd_filters_test:

> Testing file:///home/sbergman/lo/core/sd/qa/unit/data/ppt/pass/hang-17.ppt:
[...]
> sot/source/sdstor/stgdir.cxx:101:19: runtime error: implicit conversion from type 'sal_Int32' (aka 'int') of value -57120 (32-bit, signed) to type 'short' changed the value to 8416 (16-bit, signed)
>  #0 in StgDirEntry::Compare(StgAvlNode const*) const at sot/source/sdstor/stgdir.cxx:101:19 (instdir/program/libsotlo.so +0x217699)
>  #1 in StgAvlNode::Find(StgAvlNode const*) at sot/source/sdstor/stgavl.cxx:43:29 (instdir/program/libsotlo.so +0x1db72b)
>  #2 in StgDirStrm::Find(StgDirEntry&, rtl::OUString const&) at sot/source/sdstor/stgdir.cxx:907:57 (instdir/program/libsotlo.so +0x22f2dc)
>  #3 in Storage::IsStream(rtl::OUString const&) const at sot/source/sdstor/stg.cxx:773:39 (instdir/program/libsotlo.so +0x1d2cdf)
>  #4 in SotStorage::IsStream(rtl::OUString const&) const at sot/source/sdstor/storage.cxx:654:27 (instdir/program/libsotlo.so +0x29ebdb)
>  #5 in PropRead::PropRead(SotStorage&, rtl::OUString const&) at sd/source/filter/ppt/propread.cxx:543:19 (instdir/program/libsdfiltlo.so +0x6b72ee)
>  #6 in ImplSdPPTImport::Import() at sd/source/filter/ppt/pptin.cxx:262:32 (instdir/program/libsdfiltlo.so +0x5d0dc4)
>  #7 in SdPPTImport::Import() at sd/source/filter/ppt/pptin.cxx:167:21 (instdir/program/libsdfiltlo.so +0x5cf733)
>  #8 in ImportPPT at sd/source/filter/ppt/pptin.cxx:2761:26 (instdir/program/libsdfiltlo.so +0x618f64)
>  #9 in SdPPTFilter::Import() at sd/source/filter/sdpptwrp.cxx:106:32 (instdir/program/libsdlo.so +0x2877ed3)
>  #10 in sd::DrawDocShell::ConvertFrom(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:474:46 (instdir/program/libsdlo.so +0x2e1607c)
>  #11 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:786:23 (instdir/program/libsfxlo.so +0x2c8c762)
>  #12 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:75:31 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19771)
>  #13 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5724c)
>  #14 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x57ec9)
>  #15 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19d6d)

Change-Id: Iaffd35d33f0e1109195e3bd56538104d395af01b
Reviewed-on: https://gerrit.libreoffice.org/59274
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

4cb69cf3

sw: Replace std::list with std::vector for simplicity · abb78009

Takeshi Abe Agu 13, 2018 yazdı

Change-Id: I239df7b0009711eeaf025221bec9c95887681c8d
Reviewed-on: https://gerrit.libreoffice.org/58918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

abb78009

Use for-range loops · 319b187e

Caolán McNamara Agu 17, 2018 yazdı

Change-Id: I7bf26258b8330a5f81657a3684c81ce429b37090
Reviewed-on: https://gerrit.libreoffice.org/59262
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

319b187e

Update git submodules · a2adca5f

Olivier Hallot Agu 17, 2018 yazdı

* Update helpcontent2 from branch 'master'
  - Fix dup ID
    
    Change-Id: I4c21333e6738edc39153ed2f9b276f361190d396
    Reviewed-on: https://gerrit.libreoffice.org/59276
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

a2adca5f

Update git submodules · 387c70dc

Olivier Hallot Agu 17, 2018 yazdı

* Update helpcontent2 from branch 'master'
  - tdf#115254 Some branch bookmarks are'nt working 16
    
    Module svx
    
    Change-Id: I0ce6c3c004ee8ef68b7114692ffcc6f9e912ccf3
    Reviewed-on: https://gerrit.libreoffice.org/59273
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

387c70dc

tdf#105998: Enhanced fix for MetafileToBitmap at better place · 046df0a8

Armin Le Grand Agu 16, 2018 yazdı

Change-Id: I220bdbe196a68ef2df25885dceee70e15b760410
Reviewed-on: https://gerrit.libreoffice.org/59220
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

046df0a8

ofz: make ValidNewTabName faster wrt collisions · bc28d51c

Caolán McNamara Agu 17, 2018 yazdı

Change-Id: Id2058719c3bc822518faa922a6cd0409b4088ac7
Reviewed-on: https://gerrit.libreoffice.org/59253
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

bc28d51c

Remove unused includes · 2291c110

Stephan Bergmann Agu 17, 2018 yazdı

Change-Id: If51bdcb4bd426ddbd563861a0cf3eeb5f2756b06
Reviewed-on: https://gerrit.libreoffice.org/59268
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2291c110

Consolidate: basegfx::clamp -> o3tl::clamp · f4351535

Stephan Bergmann Agu 17, 2018 yazdı

Change-Id: Iffd8b0a19d4479b6c70dc834c6f64499e87e01b1
Reviewed-on: https://gerrit.libreoffice.org/59265
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

f4351535

tdf#119117: get phonebook sort work by tweaking ICU call mechanism · 13db6e86

Julien Nabet Agu 10, 2018 yazdı

Using "phonebook" as variant does't work with de_DE
since it gives de_DE_PHONEBOOK whereas icu expects de__PHONEBOOK
See http://userguide.icu-project.org/locale#TOC-Variant-code,
   Level 2 canonicalization, 8.

So let variant empty and use the fourth arg of icuLocale "keywords"

See constructors in http://icu-project.org/apiref/icu4c/classicu_1_1Locale.html

Change-Id: I6c216c86cdd32abfa477c14a80d1b8794b536900
Reviewed-on: https://gerrit.libreoffice.org/58870Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

13db6e86

Resolves: tdf#118983 do not expand range if sheet references not affected · da0dc858

Eike Rathke Agu 17, 2018 yazdı

Change-Id: Ib207d3723ce1d370a953e652957aaed399affc9c
Reviewed-on: https://gerrit.libreoffice.org/59255Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

da0dc858

Update git submodules · a0d9200f

Olivier Hallot Agu 17, 2018 yazdı

* Update helpcontent2 from branch 'master'
  - Add MACOSX for =INFO("system")
    
    Change-Id: I23bd4706bf7f0eba4334e15c21e750b2f2cf2883
    Reviewed-on: https://gerrit.libreoffice.org/59266
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

a0d9200f

Update git submodules · 8af4ea70

Olivier Hallot Agu 17, 2018 yazdı

* Update helpcontent2 from branch 'master'
  - Mute l10n in numeric table and InfoType strings
    
    Numeric cell are not to be translated
    InfoType either.
    
    Change-Id: I320b78c2c84212ece5c080e47c78cef2550ae066
    Reviewed-on: https://gerrit.libreoffice.org/59263
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

8af4ea70

make GetCodeName accessor more standard · 519dfa1f

Caolán McNamara Agu 17, 2018 yazdı

Change-Id: Ieee004ef7f6c7db5503a8a0d1660785105ec0511
Reviewed-on: https://gerrit.libreoffice.org/59251
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

519dfa1f

Resolves: tdf#119325 tooltip position should be relative to widget · 0994fcef

Caolán McNamara Agu 17, 2018 yazdı

Change-Id: I244f2d6cd89fd53d7a874cac593f3759d75966da
Reviewed-on: https://gerrit.libreoffice.org/59256
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

0994fcef

loplugin:useuniqueptr pass SmNodeList around by std::unique_ptr · 0662f319

Noel Grandin Agu 16, 2018 yazdı

Change-Id: I263a7afd23a38f68ee54ecb11f00bcfbdda30c64
Reviewed-on: https://gerrit.libreoffice.org/59230
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

0662f319

ofz#9934 null deref · 49d08ac5

Caolán McNamara Agu 17, 2018 yazdı

Change-Id: I6833ad8a556b561a37e468da8845914cabfac4c5
Reviewed-on: https://gerrit.libreoffice.org/59246
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

49d08ac5

a11y: Use ATK "footnote" role · 5ee3c68d

Samuel Thibault Agu 09, 2018 yazdı

instead of "comment" which is less precise.

Change-Id: Icca55a3c440748f311d896aac648a7a6d89f3bc4
Reviewed-on: https://gerrit.libreoffice.org/58763
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

5ee3c68d

tdf#116542 a11y: Make R/O accessibleedit use STATIC role · ac475d8d

Samuel Thibault Agu 08, 2018 yazdı

as improvement to tdf#86661 which had made it a LABEL as first improvement
over TEXT.

Change-Id: I0e5ee7b680ec943f38526b98cb904d0f9f916d85
Reviewed-on: https://gerrit.libreoffice.org/58736
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

ac475d8d

make GetName accessor more standard · aa0adc7a

Caolán McNamara Agu 17, 2018 yazdı

Change-Id: I8cb4853be09e37499d26acb6889b3d9b2c70dcf8
Reviewed-on: https://gerrit.libreoffice.org/59252
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

aa0adc7a

fix crash on Windows on assert enabled builds · 173b2649

Noel Grandin Agu 17, 2018 yazdı

regression from
    commit 9cceba9a
    make DBG_TESTSOLARMUTEX available in assert builds

Change-Id: Ifbedc3c16f341a12ba026fc598fb5386da91c50c
Reviewed-on: https://gerrit.libreoffice.org/59245
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

173b2649

ofz: infinite loop · c05692cb

Caolán McNamara Agu 17, 2018 yazdı

Change-Id: Ie42e73ebe02cd4c2bb10c9d0e55a5256b1fffd15
Reviewed-on: https://gerrit.libreoffice.org/59248Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

c05692cb

loplugin:override · b83fac89

Stephan Bergmann Agu 16, 2018 yazdı

Change-Id: Id884bdd1f1b5314df05b4d8839b13922f19f01cb
Reviewed-on: https://gerrit.libreoffice.org/59236
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

b83fac89

loplugin:useuniqueptr in Tcg255 · 200b4f33

Noel Grandin Agu 16, 2018 yazdı

Change-Id: I68aa80fbd9d1b1dcd22ecee3a8c51fefe5574ece
Reviewed-on: https://gerrit.libreoffice.org/59226
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

200b4f33

loplugin:useuniqueptr in SwPagePreviewLayout · 99aad471

Noel Grandin Agu 16, 2018 yazdı

Change-Id: Iecec5b3d4651eb6a1d8fe0b29a691c945a3eb19c
Reviewed-on: https://gerrit.libreoffice.org/59228
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

99aad471

loplugin:useuniqueptr in ScFormatRangeStyles · d94ec445

Noel Grandin Agu 16, 2018 yazdı

no need to store a ref-counted thing like OUString on the heap, just put
it directly inside a std::vector.
And no need to store a dynamic container like std::list on the heap
either, just put it directly inside a std::vector.

Change-Id: If14a620916caab543d799ca868ee94129a51c672
Reviewed-on: https://gerrit.libreoffice.org/59224
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

d94ec445

Print (raw) exit code on system() failure · 070254c2

Stephan Bergmann Agu 16, 2018 yazdı

Change-Id: I5d99319aa336c02dc0c20ab2bc3a1302840d100d
Reviewed-on: https://gerrit.libreoffice.org/59242
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

070254c2

tdf108064 OOXML export: keep preset dashes in shape outlines · f5f23505

Adam Kovacs Agu 16, 2018 yazdı

Extending commit d7551e32
to all default MSO 2016 preset dashes:

Saving an ooxml file with LibreOffice now preserves the
prstDash tags with the values sysDot, sysDash, dash, dashDot,
lgDash, lgDashDot, lgDashDotDot, instead of converting them
to custDash tags.

Note: the import of the preset dash outlines are still not
relative to the line width, in spite of their original
behaviour in MSO.

Change-Id: I65eaf06952a968019495664067010c874fce1352
Reviewed-on: https://gerrit.libreoffice.org/59203
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

f5f23505

insert->envelope->printer->setup crashes · 849cedc4

Caolán McNamara Agu 16, 2018 yazdı

Change-Id: I06d91941eaab0f622b384e9b3379d033890fd92f
Reviewed-on: https://gerrit.libreoffice.org/59184
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

849cedc4

Fix typos · 51e73ccb

Andrea Gelmini Agu 16, 2018 yazdı

Change-Id: I75b38bbbef895901c7b5188fc7b47860b9e9ff89
Reviewed-on: https://gerrit.libreoffice.org/59241
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

51e73ccb

Override [sd-IN] with [sd-Deva-IN] · f000f9f1

Eike Rathke Agu 16, 2018 yazdı

Deva is not listed as Suppress-Script for sd in
https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry

Also, this seems to be what MS expects, see
https://msdn.microsoft.com/en-us/library/cc233965

Change-Id: I974b0032c1c0485135690e68ed0a71c43f2adf6e
Reviewed-on: https://gerrit.libreoffice.org/59217Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

f000f9f1

Do not convert YMD date order to YDM and vice versa, tdf#107012 follow-up · a4c9e453

Eike Rathke Agu 16, 2018 yazdı

Change-Id: I6362caae4dd0764a5f99f1b0453c17ecde4b53f1
Reviewed-on: https://gerrit.libreoffice.org/59213Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

a4c9e453

update loplugin returnconstant · 42580b44

Noel Grandin Agu 16, 2018 yazdı

to find more stuff, and return less false positives

Change-Id: I24cacbb825c1f7484fd568230051b1a57dbc663f
Reviewed-on: https://gerrit.libreoffice.org/59137
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

42580b44

loplugin:useuniqueptr in PDFGrammar · e4e39a48

Noel Grandin Agu 16, 2018 yazdı

Change-Id: I8eff505de0d2821a33bbbc8e4acc2cbee7c1058e
Reviewed-on: https://gerrit.libreoffice.org/59232
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

e4e39a48