Change-Id: I718829fe4821f36a37b0503be18c56d1151abd9c

It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361

Change-Id: I54a175ce1e4cb624d94770ee849d97675987e7b2

Change-Id: I2002f7278b63b7678a5274e4213ab9dfb50e525e

We can no longer rely on the width being zero for no border condition.

Change-Id: I02c5c825661b4a0aa4190306e8276bdfd8bff944

The clip region in fact cuts off the lower part of the bottom border, both
on screen and when printing / exporting to PDF.

Change-Id: Id350531f09b3ded66fd05ea7ebeefe8771260b62

- Shape name: com.sun.star.drawing.OpenGLObject
- Drawinglayer object: SdrOpenGLObject
- Uno object: SvxOpenGLObject
- View contact: ViewContactOfOpenGL
- Primitive: OpenGLPrimitive2D

Change-Id: I7fc0829d58cb4a8432d0e3007c90223707e5dd84

1) Use ods format and store the expected formula results as numeric cells,
   to avoid having to load the same file twice (which is slower).

2) Use rtl::math::approxEqual to evaluate two numbers that may be subject
   to numerical instability especially when the expected values are very
   small.

Change-Id: Ie08e91f797065f4593f996df3541da84019cc53c

Change-Id: Ie2ffa39f6aad8df127e99109618a64fb0d32599e

This patch is to preserve the sdt blocks for several simple sdt types:
equation, picture, citation and group.

This patch reuses the infrastructure created at commit
55211e61 to grab-bag the properties of
the sdt block and write them back on export, with small modifications
in particular related with the fact that these tags don't have
children.

The type of the property tags equation, picture, citation and group
was modified in the ooxml model file to be able to process them. They
were previously empty.

A unit test was added to check the preservation of these fields.
Another had to be modified.

Change-Id: Ica1a340f589f5d6c85c1a35d2a3a4bf930eb2d8a

Change-Id: I0a5fbfc0b33b16e0eba7410957ab83ffbff4e008

This is working version of fc27a685

Change-Id: I48e861b5b7692ea051edf52d7ad9cc54ca989e22

Thanks to sayt@mailinator.com for the idea.

Change-Id: Ib79abafe3d4d3ba21f7914aeb284d86ce662824c

Change-Id: I5286db18d3d273f4678c9f332d5184b46e5bb720

Change-Id: I53dfb7f9d49a4b383dc8a32e4cd3b30a4db47819

Change-Id: I97290c2504992f4a92e6aeb71e02a2542dd35faa

Change-Id: I677abeb9e313b983f750331ec925c24ade04e95b

Change-Id: I4d83ab49187590728326f4f60bb205d1d0b3dfe7

Change-Id: I99a0b6dea0b1de2ed1afe51e2584699819eadf04

Change-Id: If05ef86284c4ed7bf66a6a6de17a4bf8d49e89e1

Change-Id: I14a77fc3fbf225862bc01f677d09d5b5a52bb1aa

Description:The RT file is getting corrupted.
The <w:fldChar w:fldCharType="end" /> tag is there inside the hyperlink tag where as the <w:fldChar w:fldCharType="begin"> is starting before the hyperlink tag.This is causing the issue.

The rootcause found is in DocxAttributeOutput::EndRun().
A check is introduced before the code that writes the <w:fldChar w:fldCharType="end" /> after the hyperlink to check if the m_startedHyperlink is false.

I have added test case to verify that now the RT file is opening
I also verified this change on a set of 440 real world documents (containing many combinations of MS Office features) to make sure there is no regression because of this change.

Conflicts:
	sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
	https://gerrit.libreoffice.org/8603

Change-Id: Ibc3ca8edcfb68d52a9394580bac1ce878eda9405

- In case of multiple paragraph comments/ page comments there used to be a
  mismatch while relating the comment id's in document.xml and comments.xml
- This was happening because the annotation mark id's were getting overwritten.
- Fixed this issue and added UT for the same.

Change-Id: Ie0ac6b5c865555d143115a79b3fc146f9a4ef5fc
Reviewed-on: https://gerrit.libreoffice.org/8602Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

...now that it is obvious that they both do the same

Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115

...and consequently unused framework::ELockMode

Change-Id: Icba47a9007e7250871be4bf5ee151504cad43f75

...and its implementation, and the now-unused E_READLOCK cases.

Change-Id: I2df514f9351a1b63da3063c8db9892e11e9bf83b

Change-Id: I2f8b8c07b943f8aea47523db99a019c7c4541248

Change-Id: I26c8dbfb2ad3b159d3b32dea450e063f1552d714

...of which framework::LockHelper is the only implementation

Change-Id: I235bb699ff26b1579803f617990fc4f71fe18b22

Change-Id: Ie4135353c7917fddf3efd15d0f3022b3aada8025

Change-Id: I91adf908aaa399186ff69d3a07eb945aed0c90f5

- DOCX file containing fields BIBLIOGRAPHY on first line, BIDIOUTLINE on
  second line and CITATION on third line is getting crashed while opening in LO
- Fixed this issue and added unit test case for the same.

Change-Id: Ia8394a3a26157f88693edcf60b0161947d8a9ac0
Reviewed-on: https://gerrit.libreoffice.org/8589Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

The <w:docPartObj> property inside <w:sdt> blocks determines a block
inside the document that can be dinamically updated and enables Word
2010 to show a hover button to update it. It is used for TOCs,
bibliography, etc. LibreOffice ignored these blocks and removed them
from the document on export.

In this patch, we make the importer save the <w:docPartObj> tag and
its contents in the paragraph interop grab bag.

On export we read the paragraph grab bag and restore the sdt block
back to the document; we don't know if the paragraph must be enclosed
in a sdt block when we start it, so we used the parser marks to be
able to prepend the start of the block before the paragraph opening
tag.

The grab bag on import is managed by the SdtHelper class. Added a set
of methods for that purpose.

The ooxml model file was modified to assign token ids to the children
of w:docPartObj.

Fixed several unit tests that didn't expect the <w:sdt> tag to be
exported. Also modified testBibliography inside ooxmlexport test
suite to add checks for this patch.

TODO: in the imported documents the sdtContent block may contain
several paragraphs but the exporter code as it is can only wrap one
paragraph. As a result, if the sdt block contained several paragraphs
the second and next paragraphs will be outside the block in the
exported document.

Change-Id: I5333fc5ad91a3c50198a4f7647424a2101268c12

I could not reproduce the crash of that bug (probably having more memory
available), but the backtrace had nTabSpan = -2 implicitly casted to
size_t leading to allocation of a huge amount of memory with
vector::reserve(), which ScRange::Justify() exactly prevents.

Change-Id: Idb79e1be62649922ba793cab01e00011479fade9

Change-Id: I848d8afbec17dd5cfb5063942d1e504aa548c759

Change-Id: I1690f5b88b7bd04d336a45b1d745185285e13070

Change-Id: I283c883bf49e33941de33b9e58d355f683c96ea3

Change-Id: Ic411b2776d0c054d59bfdc847f67785c85c5cb9e

Change-Id: I23c2ac9ef6bfc3eedb8ad6cb199c12d42ed642c8

Change-Id: Iec1fb3fd063d73f04a1600a21d6129e4cd5476b4