Change-Id: I5d657fa4d6f63b93ad3775a5641d08c6e0f3a615

Also remove macroni.

Change-Id: I0b2914e9f0e2aba9d8ca10338b515b598126e315

Change-Id: I89dcf5a102be19fd1bc314a89538a121522f4a43

Change-Id: Ib1afbb0b5647048f24d4ea6f9859b76328568dac

Change-Id: Iff50f7aeb471870230e9e822657deed6aefad268

Change-Id: I7cae61e1fa9cf74b98627d557890fd41047421df

Change-Id: Ibc425d8e630460547d66723ccabeaf4ac29d2719

Change-Id: Ic189aecf092b9cffd800e410d2d6e88016c43052

Change-Id: I1962a4a1397363b1c15e49d57b0bbcc9c232ce30

Use ColorData for custom widget themes to
make it more readable and consistent.

Renamed and split out colors to be more accurately
named and representative of how they are used.

Fixed a number of inconsistencies in how colors
were used across widgets.

Change-Id: I1cbb5f19223bd55107379b049beccaf1de4e26b2

The old logic threw away the result of updateSettings
by applying the styles saved and modified after calling
it, which lost all the custom colors thereby breaking
custom-widgets and themeing altogether.

Change-Id: Ic3750f145b67cd6a379f3b628a10c213a31656e7

Change-Id: Icd6367fa40f9655cd58816461f0d2fca6f6932e2

Change-Id: I70f46f94747f468a2bb79f8baa4576e4460bef31

Change-Id: I45b7ffdce2d470ed2f30b5408d8d861deb00514a

Some theme colors are set using the style settings, which are
implemented by each backend to correspond to the system theme.
For custom widgets these need to also be set by the library
itself. This commit adds the ground work and sets some of the
colors for windows backgrounds.

Change-Id: Ia65b1605b2b7bef7f01ff1feff2e7470479e626a

Change-Id: Icb8cfbe09caf5cbfcf1d3f461c297c052056250d

Change-Id: I05f01058d7886dacec3b00dcf31313aea3939164

Stock buttons like OK/Cancel/Help need sometimes to be drawn
differently than just another button. For this we need to mark
such push buttons as "stock" when building them from a glade file
and transfer this information down to the NWF backend when drawing
the widget.

Change-Id: I131657f026a731208db47f4c8220622c8aabb464

Change-Id: I5d038d165d5ff08a07d24906f6a7cc2d6176f1ac

Change-Id: I1d740b4a3840f73015f34bd2143663a919db2956

Change-Id: I050d8534cacdee63109158dbc150d9d13b43fe5e

This implements getting the region rectangle from the widget
library so it is possible to redefine the size of the widgets if
needed.

Additionally increase a tab width which are too small by default.

Change-Id: If662c44e02631715efd137ecbfc4a5770fa9f6ab

Change-Id: Ia4efe711c07213f2edf472602c5b2acc81876906

also added ListNet as noop

Change-Id: I033f908a8fc9ce9ec4b3d202e1299f7c0a9cad6c

Change-Id: I573a6c28f5ddb538ca3b0abf15197695fc113802

Don't require eButtonValue as a constructor parameter as it mostly
isn't necessary and required.

In addition add nValue instance variable.

Change-Id: I927714f715fce1549d87cec633330a0dc313f569

Change-Id: Ie2192edfcfc49a1953059c5947b8ea7bb03a3c7d

Slider drawing didn't we ask if native drawing is supported using
IsNativeControlSupported method.

Change-Id: I0672114337516ff763fd710d949ab6a982db2992

Change-Id: If9acc47b9a7751858d3394741e3984b3c2a49936

Change-Id: I1a3b709fdc4fb21fc4ad22542ff669c98b13487d

- Radiobutton
- Checkbox
- Combobox
- Editbox
- Spinbox
- Scrollbar

Change-Id: I46bd2753a7c1806f4cd4583455e76c77494225b4

..and fallback the headless dawing also in gtk3 where needed

Change-Id: Ic5da8fa7a04089342db8e2f334ced69691a15217

A native widgets aren't part of a VCL metafile so they are ignored
when the metafile is replayed. When drawing a dialog to a custom
device, the first draw goes to the metafile, which is then replayed
to the final device, but no native widgets get drawn. This commit
changes this behavior for LOKit where it draws without using the
intermediate VCL metafile.

Change-Id: I823db30c8bceb83830c6c993d4238b39e1331c09

Change-Id: I7ec57d18fe99f906aeb6dbb40d0d30c2ac8b51c4

ever since
    commit a3b0ee88
    Date:   Sun Jul 10 22:17:35 2011 +0100
    strip out unused methods

found by loplugin:singlevalfields

Change-Id: I4feab1195f78549a48f4b1a9017bc5101474228f
Reviewed-on: https://gerrit.libreoffice.org/63173
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Under (new-in-Clang) -fsanitize=implicit-signed-integer-truncation,
CppunitTest_sc_filters_test failed with

> Testing file:///.../sc/qa/unit/data/xls/pass/crash-7.xls:
> warn:sc:27699:27699:sc/source/filter/excel/xlroot.cxx:158: XclRootData::XclRootData - cannot get output device info: N3com3sun4star3uno9ExceptionE msg: invalid attempt to assign an empty interface of type com.sun.star.frame.XFrame!
> warn:legacy.osl:27699:27699:sc/source/filter/excel/xilink.cxx:631: XclImpSupbook::XclImpSupbook - unknown special SUPBOOK type
> warn:sc:27699:27699:sc/source/filter/excel/xilink.cxx:703: XclImpSupbook::GetExternName - index must be >0
> warn:legacy.osl:27699:27699:sc/source/filter/excel/xistream.cxx:802: XclImpStream::Ignore - record overread
> sc/source/filter/inc/xladdress.hxx:72:47: runtime error: implicit conversion from type 'int' of value -511 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65025 (16-bit, unsigned)
>  #0 in XclRange::GetColCount() const at sc/source/filter/inc/xladdress.hxx:72:47 (instdir/program/libscfiltlo.so +0x2510655)
>  #1 in ImportExcel::ReadDimensions() at sc/source/filter/excel/impop.cxx:255:27 (instdir/program/libscfiltlo.so +0x24e52c4)
>  #2 in ImportExcel8::Read() at sc/source/filter/excel/read.cxx:1110:49 (instdir/program/libscfiltlo.so +0x2589a90)
>  #3 in ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT) at sc/source/filter/excel/excel.cxx:145:35 (instdir/program/libscfiltlo.so +0x230df62)
>  #4 in ScDocShell::ConvertFrom(SfxMedium&) at sc/source/ui/docshell/docsh.cxx:1265:52 (instdir/program/libsclo.so +0xcc8db50)
>  #5 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:787:23 (instdir/program/libsfxlo.so +0x389f0df)
>  #6 in ScBootstrapFixture::load(bool, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned long, rtl::OUString const*) at sc/qa/unit/helper/qahelper.cxx:582:21 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x869b5)
>  #7 in ScBootstrapFixture::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned long, rtl::OUString const*) at sc/qa/unit/helper/qahelper.cxx:597:12 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x86fa6)
>  #8 in ScFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sc/qa/unit/filters-test.cxx:125:51 (workdir/LinkTarget/CppunitTest/libtest_sc_filters_test.so +0x4623a)
>  #9 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x7526d)
>  #10 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x79127)
>  #11 in ScFiltersTest::testCVEs() at sc/qa/unit/filters-test.cxx:146:5 (workdir/LinkTarget/CppunitTest/libtest_sc_filters_test.so +0x4729d)
[...]

so it smells like the given XclRange (with maFirst.mnCol=512, maFirst.mnRow=0,
maLast.mnCol=0, maLast.mnRow=0) already is the result of some previous lenient
parsing of invalid input.

Change-Id: Ib7915eac5526fc295e7fbbc1c001549b991ddbf7
Reviewed-on: https://gerrit.libreoffice.org/63200
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Idf73b21ae2f27f4966705c8faf9fd38abc502ae4
Reviewed-on: https://gerrit.libreoffice.org/63178
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie63da823faf9067e61ca4870f464d49425bbc907
Reviewed-on: https://gerrit.libreoffice.org/63123
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8e16746fc8d89adc8882303f67760341c1968aed
Reviewed-on: https://gerrit.libreoffice.org/63190
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This takes over for gtk3_kde5 what was done for kde5 in commit
c0f45c89.

Change-Id: Ieca71498bd0cc00ca07b83f6e1178d983169d5be
Reviewed-on: https://gerrit.libreoffice.org/63172
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>