- 18 Ock, 2014 14 kayıt (commit)
-
-
Matúš Kukan yazdı
And avoid css::uno::XInitialization protocol.
-
Matúš Kukan yazdı
This was forgotten in commit bdeb57c2. Change-Id: Idd339222e3c464abc2524f78f16c8fe0a02dcd5b
-
Jacobo Aragunde Pérez yazdı
This tests checks that the shape style attribute for fill color is preserved, that the theme attibute for shape fill is preserved too and that the interaction between them and direct assignment of some color works properly. Change-Id: Ia934c46731ed38be14ed851e083d0ed6fc151b01
-
Jacobo Aragunde Pérez yazdı
Users can select the fill color for a shape among the theme-defined colors. This results in the following XML: <wps:spPr> ... <a:solidFill> <a:schemeClr val="accent2"/> </a:solidFill> ... </wps:spPr> Now we store both the original fill color and the name of the theme-defined color, if it exists, on the import phase. They are put into the InteropGrabBag of the shape with the names OriginalSolidFillClr and SpPrSolidFillSchemeClr. Additionally, we needed to to store the decoded theme color inside StyleFillRef. On the export phase we have to take into account several combinations of factors: * If the final color for the shape fill is different from the original color, we must ignore any theme attributes and write the new color. * If the fill color is unchanged and some theme color exists, we must write the theme color. * If the fill color is unchanged and no theme color exists, we must check if the original color matches the style-defined color. If it does, we must not write any <a:solidFill> tag. * Otherwise we must write the <a:solidFill> tag with the RGB color. The method putPropertiesToGrabBag was added to the Shape object for convenience. The data files for some /sd/qa/ unit tests were updated to reflect the new properties inside the Shape InteropGrabBag. Change-Id: If0915c5442872a8acab0a8a081f60c89c97277bd
-
Jacobo Aragunde Pérez yazdı
Shape style attributes contain the default format for the shape in case that no direct format is specified for it. This is an example of the attribute we want to preserve with this patch: <wps:style> ... <a:fillRef idx="1"> <a:schemeClr val="accent1"/> </a:fillRef> ... </wps:style> The relevant values in these tags are stored at the maShapeStyleRefs member in the Shape object. The storage happens at ShapeStyleContext::onCreateContext which is run when the <a:fillRef> tag is opened. The ShapeStyleRef object contains the idx value and a Color object which will contain the inner tag <a:schemeClr>. The Color object has been modified to store the string value of schemeClr. The storage happens at ColorValueContext::onStartElement which is run when the tag <a:schemeClr> is opened. Later, Shape::createAndInsert is called by the ShapeContextHandler to create the actual XShape, this happens when the tag <wps:wsp> is closed. createAndInsert puts idx and schemeClr values into the InteropGrabBag property of the XShape with the name StyleFillRef. On export time, when the shape data is written at ShapeExport::WriteCustomShape, we added a call to DrawingML::WriteShapeStyle. This method will check the existence of the InteropGrabBag property in the shape, read the StyleFillRef prop inside it and output the proper XML to the style definition. DrawingML::WriteShapeStyle also writes some mock tags into the <wps:style> because we found that they are compulsory. We will replace them with the proper data in further patches. The method putPropertyToGrabBag was added to the Shape object for convenience. The data files for some /sd/qa/ unit tests were updated to reflect the new property StyleFillRef inside the InteropGrabBag. Change-Id: I5ffa5242852461a1a709a8f169d40f0d7a2c9aa3
-
Miklos Vajna yazdı
Change-Id: I594d854db54a74ddf3f32d4b30b1c4f1aa38d431
-
Miklos Vajna yazdı
Change-Id: Idcb74c5e911ec2337f1e8743dc4627464f1cfd27
-
Miklos Vajna yazdı
I almost broke this during refactoring... Change-Id: If38e73f3b7d66e97bbcbad87447b8aa611ff79d1
-
Miklos Vajna yazdı
Change-Id: I762e4f09b55d957bdd57e76651417bed11cb1e74
-
Miklos Vajna yazdı
Change-Id: I2e3315584e66b7a99003512b197062807674f8aa
-
Miklos Vajna yazdı
Change-Id: Icb124a2f7445ca17f04dc0024dc17cbcc4b0ca6d
-
Miklos Vajna yazdı
Change-Id: I79e0fa9d0ee35e31912d36ec213acf1a83b3547e
-
Kohei Yoshida yazdı
Also remove the files used for the old tests. Change-Id: I4fbf6acce205d15a35780524120e351e01dc6642
-
tsahi glik yazdı
-
- 17 Ock, 2014 26 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
-
Stephan Bergmann yazdı
Change-Id: I39d15f863f4e1fd585b03bfc5f8854fb66af3b4c
-
Stephan Bergmann yazdı
Change-Id: I4b25d70c1009fbc714208452c2a646161189ff24
-
Stephan Bergmann yazdı
Change-Id: I18ef9f11adce64be7ce93b077d1703ab505918a6
-
Khaled Hosny yazdı
Change-Id: Ie3fbda69c5747f4ca42d84c272356ba9f435194e
-
Khaled Hosny yazdı
Change-Id: Id018e985110b024ff107f4221501ece2cf27f5d3
-
Khaled Hosny yazdı
Change-Id: Iefaa98350c8d6116aa07d4d91be29104a930b8db
-
Khaled Hosny yazdı
This implements http://www.unicode.org/reports/tr24/ by using ICU’s implementation of it, but since the code in question is private API, I simply copied the two self-contained files. This commit is best viewed with --ignore-space-change. Change-Id: I38c385d4fb6f8a2edc804d48f0aa14df9f0a8b3b
-
Khaled Hosny yazdı
It is not immediately clear what maRerun is, besides it can be confused with regular maRuns. Change-Id: Idc754a185149a9a4d5e7495b76d8e61f783b42d2
-
Takeshi Abe yazdı
Change-Id: Ib05c6d509a71e01b50b2e23588da607f29036711
-
Eike Rathke yazdı
... to match installed UI locales Change-Id: If0ad0fde392bc5ea3cf454f4858330f5e93a6666
-
Noel Grandin yazdı
Change-Id: I6749307d5b72ddc69581b4aa685091383117073d Reviewed-on: https://gerrit.libreoffice.org/7369Reviewed-by:
Michael Stahl <mstahl@redhat.com> Tested-by:
Michael Stahl <mstahl@redhat.com>
-
Michael Stahl yazdı
Soft hyphen was not detected if there is no hint (-1). (regression from ebeff3f0) Change-Id: I09108796a32429a01eff93f797a6de521ab1d08a
-
Martin Srebotnjak yazdı
Project: dictionaries 2c29ae21dc3d2889812b456737474278e82c023b
-
Tor Lillqvist yazdı
Change-Id: Ia49cb02b2374e1c284bb4dee77e333fe6c8839ce
-
Kohei Yoshida yazdı
Change-Id: Ide87ccfe71f42d77246b6b3a2e864b5c89d80647
-
Stephan Bergmann yazdı
Change-Id: Ib41ed9ace428081e1948cf109de095ea9e7c45c2
-
Stephan Bergmann yazdı
Change-Id: Ia6c6d6fe484789722987cea7d8b4b4bfc1c28953
-
Stephan Bergmann yazdı
...as they are often enough errors, like a typo in brace placement in if (foo == (FOO || bar == BAR) && baz) or a literal true passed as an argument to a function that rather expects an integer bit mask, etc. The plugin is smart enough to detect interaction with logically boolean return/parameter types of C functions that use [unsigned] int instead, and knows the relevant boolean typedefs (sal_Bool, gboolean, etc.). Change-Id: I5f0e4344fe86589bec35a71018c7effdedf85e3e
-
Stephan Bergmann yazdı
Change-Id: I9324483db587be43238af79c2148d724397a4622
-
Stephan Bergmann yazdı
Change-Id: I19b429741a2ba972bef8863008657823b9bb7f91
-
Stephan Bergmann yazdı
Change-Id: Ib7c2e846885812b5352b06d568d62f744a3c07c4
-
Stephan Bergmann yazdı
Change-Id: I89e8351001dcdda9303473f38ece3b57c0d9e72c
-
Stephan Bergmann yazdı
Change-Id: Ic46fa46c200b94e2e6c5a073ba89b9aae5c14542
-
Stephan Bergmann yazdı
Change-Id: I9f5564100aa64ff4940dd93a81ff5a8d8edc7a07
-
Stephan Bergmann yazdı
Change-Id: I7ec4f5b2e691ec03e9e2c5ca3a004f1e04efbc27
-