the motivation is SwWrtShell::CalcAndSetScale

and the assert/crash triggered by

ooo58458-1.odt ooo84729-2.odt ooo75058-1.odt ooo123605-1.odt ooo102990-1.odt
fdo57249-1.odt fdo50880-1.odt fdo70223-5.odt ooo30052-2.odt ooo119280-1.odt
ooo79009-1.odt ooo58182-2.odt ooo59992-1.odt ooo123607-1.odt ooo89304-1.odt
ooo91578-5.odt ooo89303-1.odt ooo30052-1.odt fdo65664-3.odt ooo119941-1.odt
ooo55761-1.odt fdo57249-2.odt ooo83229-3.odt ooo84729-1.odt ooo102990-2.odt
ooo37749-1.sxw ooo38798-1.sxw ooo27909-1.sxw

getMapUnit activates the object which can cause chart object to load data from
the current document and appears to attempt to stop and resume pending layout
actions which can't be done if layout is underway, hence the assert from the
inner SwLayAction::SwLayAction triggered by the runstate while an SwLayAction::SwLayAction
is already active for counting the number of pdf output pages.

getMapUnit always returns the same result regardless of anything else and the
assumption is that we don't need to be in run state to setVisualSize on it

Change-Id: Ie75b159b140de223a56324b39699d703c3b40bb9

Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5

Change-Id: Id796b799f8e2fcc3eae98d43800c5e31fec27fef

Change-Id: I982ba552579019e4902ae59fddf14a6b34ba5954

Genius suggestion from Tor Lillqvist, write a clang plugin that finds
methods that can be static.

Change-Id: Ie6684cc95d088e8750b300a028b49f763da00345

Change-Id: I4e654419221b39dfd64d85a18ae0919bbe2fab5a

Change-Id: I4dfc27cb4567146a20a4de50a04831fcd6863935

Change-Id: Ifb5d85866d35cdd1c4150ea841194ee5ca8a496e

Change-Id: I2a2e8094aba0d227a9b60902133092cc33f1f586

some tinderboxes are complaining with:
could not deduce template argument for 'std::initializer_list<_Elem>' from 'int'

Change-Id: Ib6bb1c9958a86fd7bb98d5ce855764f381d2ba43

so that the enum names remain consistent

Change-Id: I656069b484038d3bf17ecbb4f3e26395ca5a1b6d

Change-Id: I3d14b96b6b51e497bde33f0177b377e7fe3dbad9

Change-Id: I453d6e1840445a03c6918173dc93f32e3028ea74
error: no matching function for call to 'max(int, sal_Int32&)'

Change-Id: I236caa9e2dc80455198b442e72e8d9df58f03adc

Change-Id: I98dc5488954a4d46f7e0158790a4c3dabebfc1b3

Change-Id: Ic4918f57a1575a24cf0b9251cc7e7c6180ee25fd

Change-Id: Iecc1400809212f56915cad56b739378cda49b90f

Change-Id: I0fd391a6b2850e5d7dcbf2cb95cfa39ee5561bd9

Change-Id: I51578e83a6a44beece174792c9e3e59f7f8c5fef

Change-Id: I793ed80a07d9488c5f75b3abdca6db344d80d3d8

Currently object handles are defined in the bitmap which is a pain
when using in HiDPI as they have to be scaled and don't look
pretty. They are also hard to change and non theme-able (change
of color needs a change the bitmap). This commit experimentaly
enables the drawn handles (enable with environment variable
SVX_DRAW_HANDLES) which currently exchanges the default some
basic handles.

Change-Id: If80aa7fe756a6d8d6991e9515f2951ee21b31b72

Change-Id: I09d00c4492d2866aeb79d1a4818a55f9cdfdc4f0

Change-Id: I4b64a70e185f061c7d7e1e895d85ffb47ee60101

Change-Id: I53d6e70018477abb9f98140a52697c1de0f90934

Change-Id: I7c9941731789be3553d473d64716484bfceaf8b4

As the crash tests have shown, the assert introduced with
71b630e5 to force verification of the
assumption made in 8e2293e0 was hit in
120 documents.

Citing from https://gerrit.libreoffice.org/#/c/14427/ comment:
"The assumptions behind this patch are wrong. This only works if every
single part of the export goes through StartRecord/EndRecord calls. We
have some features that don't use that and need the STREAM_SEEK_TO_END
in the beginning of the StartRecord."

Revert "replace an OSL_ENSURE() with assert(), tdf#89319 related"

This reverts commit 71b630e5.

Revert "tdf#89319 remove redundant file seekings in XLS export"

This reverts commit 8e2293e0.

Change-Id: I234defd865e6bf5d9d9eccc85cde7e69c0549c3f

if we're from the menubar we never set it, but if we are
a submenu from a menu in the menubar we set it.

with it set, and on right click, the right click is passed
through to what ever is underneath the pointer

I don't see why we want to do that, especially the inconsistency
from e.g. the File menu, vs the "File->New" menu

Change-Id: I548f5c95e2511b5e921e8b74600f65eecdd8f498

Change-Id: Idd06653813e3f4863a5186eb6dce074227c25579

Change-Id: I95ae2e2d564ec1c45de6df5158e4dec1d93053cb

This reverts commit fa022a9c.

because if a right-click context menu is active and we click outside it in
order to remove it then that click goes to whatever is underneath the mouse
which is undesirable

the list dropdown part of this looks good, its the general menus that are the problem

Conflicts:
	vcl/source/window/winproc.cxx

Change-Id: Ib96e52f22cdeefd59dbf4333f555d9f52b3385e2

Change-Id: I6c91d94f7eec6001980fb221891157d1e436e1fb

Change-Id: Ieed83781b89ff18f870ad8c64ca00d306b097aea

Change-Id: I2b7ed81511c6f89240f192cd6efaf8698e73f8ff

Change-Id: I43cf4ca6f8cf66b045eedd99108941ea44d56086

Change-Id: I9dcf00607bac820c3dbb26c6de9f6e326df7fb99

SvxZoomItem includes text zoom level Ids unlike SfxUInt16Iem which only
includes zoom percent id.SfxUInt16Item is the base class for SvxZoomItem.

Change-Id: I8ad2a8cf48632853538aa2d99993f8dfccf49f4c
Reviewed-on: https://gerrit.libreoffice.org/14488Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

so a long press shows the context menu to e.g. allow switching on/off
draw-on-slide mode

Change-Id: Icd6ea52d2172217794f4fc802246ccf13020e134

Change-Id: I876736d18db6676629c283fccd65e1b6fb2bb2be

Change-Id: I42fdc042ed7317b5b6c337e7b38966e616f8e24b