Kayıtlar (commit) · 7990bfd3998508dd3454c408613cf66e53af56eb · LibreOffice / core

03 Ara, 2018 28 kayıt (commit)

Jenkins' lo_tb_master_linux needs --disable-werror too · 7990bfd3

Stephan Bergmann Ara 03, 2018 yazdı

...similar to d3f2c61e "Make Jenkins
linux_gcc_release_64 pick up Developer Toolset 7":

> In file included from /opt/rh/devtoolset-7/root/usr/include/c++/7/vector:69:0,
>                  from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx:39:
> /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc: In function ‘javaPluginError jfw_plugin_startJavaVirtualMachine(const JavaInfo*, const JavaVMOption*, sal_Int32, JavaVM**, JNIEnv**)’:
> /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc:407:15: error: variable ‘__new_finish’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
>        pointer __new_finish(__new_start);
>                ^~~~~~~~~~~~
> cc1plus: all warnings being treated as errors

(<https://ci.libreoffice.org/job/lo_tb_master_linux/32166/>).

Change-Id: Ifae8705bfafe4caed21713909ff6eeee158f1361

7990bfd3

Add AnyCompareFactory_get_implementation and... · f0b83878

Tor Lillqvist Ara 03, 2018 yazdı

... com_sun_star_comp_util_OfficeInstallationDirectories.

Needed when loading a .ott document.

Change-Id: I6074869074b47d2fb679132975520b18659b5c67

f0b83878

sw: convert assert(bSelected out of sync) to SAL_WARN for now · d1138d72

Michael Stahl Ara 03, 2018 yazdı

This evidently happens sometimes, but when it does it it's
impossible to reproduce... Let's use SAL_WARN for now.

Change-Id: Id724fd52060bfae45f9eeb16163ddfc94e53af03
Reviewed-on: https://gerrit.libreoffice.org/64447
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

d1138d72

Enabling Developer Toolset 7 for Jenkins' lo_tb_master_linux · 0adc21fc

Stephan Bergmann Ara 03, 2018 yazdı

...aka "Tinderbox on Master for Linux-DbgUtil",
<https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/>.  This is similar to
ab8454eb "Enabling Developer Toolset 7 for
Jenkins' lo_tb_master_linux_dbg".  However, unlike lo_tb_master_linux_dbg, which
is restricted to CentOS-based tb75-lilith, lo_tb_master_linux is restricted to
label TB_Rel, which is currently matched to CentOS-based tb75-lilith,
tb76-maggie, and tb76-pollux, plus non-CentOS based gandalf.  The latter thus
doesn't have Developer Toolset 7, so setting CC/CXX this way won't work for
gandalf.  I'm thus removing gandalf from
<https://ci.libreoffice.org/label/TB_Rel/>.

Change-Id: Ied305476347d107db4087f710c05300c84ae7e85
Reviewed-on: https://gerrit.libreoffice.org/64444
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

0adc21fc

ofz#11611 build failure with std::unexpected_handler · f3905c9d

Caolán McNamara Ara 03, 2018 yazdı

Change-Id: I0340ce6b89dd7edb91a4a4e0c1e21aeb307f3d9f
Reviewed-on: https://gerrit.libreoffice.org/64445
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

f3905c9d

Revert "Check against concrete expected values in PdfExportTest::testTdf115262" · c1feb713

Stephan Bergmann Ara 03, 2018 yazdı

This reverts commit 3bb64c0b, at least Jenkins'
lo_tb_master_win builds started to fail with

> C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win/vcl/qa/cppunit/pdfexport/pdfexport.cxx(1581) : error : Assertion
> Test name: `anonymous namespace'::PdfExportTest::testTdf115262
> equality assertion failed
> - Expected: 199
> - Actual  : 198

(<https://ci.libreoffice.org/job/lo_tb_master_win/19796/>).

c1feb713

tdf#121620 Opening Image tab of Bullets and Numbering dialog resets selection · c9e70af2

Noel Grandin Ara 03, 2018 yazdı

regression from
	commit 39e6bae2
	loplugin:useuniqueptr in cui numpages

Change-Id: I77e16880d0590793545da38b7a3c8c5d2626d8f5
Reviewed-on: https://gerrit.libreoffice.org/64441
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

c9e70af2

tdf#120781: Proposed DnD operation is not always 'move' · 3ac46abd

Katarina Behrens Kas 30, 2018 yazdı

sometimes drop target doesn't accept drops, dragged objects must not
disappear in such case

Change-Id: I5de3c6c4afc305ea98bd15c7ff55e218364e9475
Reviewed-on: https://gerrit.libreoffice.org/64338
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

3ac46abd

sw: prefix members of SwTableField · 097da565

Miklos Vajna Ara 03, 2018 yazdı

Change-Id: I02dd9227ee43967d8cf49d99791bada5d1231566
Reviewed-on: https://gerrit.libreoffice.org/64440Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

097da565

Fix undocking sidebar with tab bar menu undock locks focus · f3a19b12

Jim Raykowski Kas 03, 2018 yazdı

Missed this in
I91194db3cc23a24e805a90edaf1566f950ac129d

Change-Id: I9a9bb3cb47b19929577f4ee36206ea1c052adeca
Reviewed-on: https://gerrit.libreoffice.org/62833
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

f3a19b12

Simplify containers iterations in sdext · 05684540

Arkadiy Illarionov Ara 02, 2018 yazdı

Use range-based loop or replace with STL functions

Change-Id: I760c1aaeae9afc99effee6a2645bb77439260ddf
Reviewed-on: https://gerrit.libreoffice.org/64435
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

05684540

sw: paragraph-sign: formatting · 83a72f46

Ashod Nakashian Eki 02, 2018 yazdı

Change-Id: I9bf1b58aa6e18202a5f7eba010cc5b914e1d33d4
Reviewed-on: https://gerrit.libreoffice.org/63005
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

83a72f46

sw: paragraph-sign: validate current SwTextNode directly · 6ad096ae

Ashod Nakashian Eki 02, 2018 yazdı

When invoking undo, it turns out that the cursor position
is updated after the text modification, which triggers the
paragraph signature validation. Relying on the cursor
position, then, results in the wrong (previous) paragraph
to be validated (if the undo is in a different paragraph).

Since we have the correct SwTextNode when it's modified
(due to undo or otherwise), there is no reason why
we shouldn't use it and try to deduce it from the cursor.

Change-Id: I4c3283d59738988dcc1c592a9f3ef2c818ce675d
Reviewed-on: https://gerrit.libreoffice.org/63004
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

6ad096ae

sw: paragraph-sign: get graph-names only once · 3750d053

Ashod Nakashian Eki 01, 2018 yazdı

And reduce other overheads to make the paragraph
signature validation significantly faster.

Change-Id: I631bd0f15200bb8f0b85b40c0d4819a7bc4d562e
Reviewed-on: https://gerrit.libreoffice.org/63003
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

3750d053

paragraph-sign: exception-safe metadata graph enumeration · 1c17aa50

Ashod Nakashian Eki 28, 2018 yazdı

Metadata graph enumeration can throw from a number
functions and break things in horrible ways.
Here we sanitize against the most egregious offenders,
but not all possible sources.

Change-Id: I40e006ea433dd7274d4fa08f3e8f8507680ef2f4
Reviewed-on: https://gerrit.libreoffice.org/63009
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

1c17aa50

sw: rdf: Split graph-name lookup from getStatement · 7ddfd67e

Ashod Nakashian Eki 01, 2018 yazdı

The graph-name lookup is significantly costly (compared
to the statement lookup, esp. when no statements exist).
Luckily, the graph-names do not change often and in the
course of enumerating all paragraphs (as happens for
paragraph-signature validation) it doesn't change at all.

This split allows for doing the graph-name lookup only
once and also allows for passing custom graph-names
directly, if we know them already.

Change-Id: I75425df201becb41105ba1fa6ba580af202d035c
Reviewed-on: https://gerrit.libreoffice.org/63002
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

7ddfd67e

sfx2: Combine metadata graph lookup and filtering · 8c84672e

Ashod Nakashian Eki 01, 2018 yazdı

The graph lookup is suprisingly costly and so is
filtering. By specializing the lookup with filtering
the logic is more readable and slightly faster (~35%
in debug build).

Change-Id: Id35a562c76a84a81362f47b61ed67fb74d0a6dc7
Reviewed-on: https://gerrit.libreoffice.org/63001
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

8c84672e

sw: paragraph-sign: erase metafields from copied text correctly · b402d011

Ashod Nakashian Eyl 28, 2018 yazdı

This is relevant for paragraph signatures where the
metadata is not yet copied and so we exclude it.
The issue was that in some cases we didn't use
the proper range of text and an assertion was
triggered in debug builds.

Otherwise there should be no change of behavior
in release builds with this patch.

Change-Id: I90bc2ca56d586b96d39f34c68de53d3dac6099d7
Reviewed-on: https://gerrit.libreoffice.org/63000
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

b402d011

sw lok: delay processing idle jobs to let LOK finish initialization · 349748e6

Ashod Nakashian Eki 20, 2018 yazdı

When loading document, LOK needs to setup the client view, register
callbacks, get document size and type, etc. All of these need
to take SolarMutex, which is taken by the idle jobs immediately
after loading, blocking LOK from finishing initialization
and rendering the first tiles for the user. This gives the
user the impression that the document is loading for far
longer than it actually is, due to lack of interactivity
(or indeed any activity on the screen besides the spinning wheel).

By delaying the idle jobs, we allow time for LOK to finish
initialization and render the first tiles before the idle
jobs kick in and hog SolarMutex.

Reviewed-on: https://gerrit.libreoffice.org/56572Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 1056640a)

Reviewed-on: https://gerrit.libreoffice.org/58157Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit e5225f15)

Change-Id: Ic6f437bfd6f43dfed2aaa1a9d3510d43f5ec30ae
Reviewed-on: https://gerrit.libreoffice.org/64013
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

349748e6

Compute (un-)premultiply_table at compile time · 644188bf

Stephan Bergmann Ara 02, 2018 yazdı

Change-Id: I34e624fcd5d11d02c26e775f5acdddec1fca9d87
Reviewed-on: https://gerrit.libreoffice.org/64428
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

644188bf

Fix typo · 1ee8d4f6

Andrea Gelmini Ara 02, 2018 yazdı

Change-Id: I69e4d471c806159d6748016a79f041c01b40b888
Reviewed-on: https://gerrit.libreoffice.org/64430
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

1ee8d4f6

tdf#45904 Move XElementAccess Java tests to C++ · cee3278a

Jens Carl Ara 02, 2018 yazdı

Move XElementAccess Java tests to C++ for ScLabelRangesObj.

Change-Id: Icf49fb7e8c24b169e4fe33ffed8cc1412d21f9e8
Reviewed-on: https://gerrit.libreoffice.org/64432
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

cee3278a

tdf#45904 Move XIndexAccess Java tests to C++ · 184d0c4b

Jens Carl Ara 02, 2018 yazdı

Move XIndexAccess Java tests to C++ for ScLabelRangesObj.

Change-Id: I448561be2395beb9448ffcfc29434a94468166cb
Reviewed-on: https://gerrit.libreoffice.org/64431
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

184d0c4b

Fix JunitTest_chart2_unoapi failing DBG_TESTSOLARMUTEX on Windows · a0ac944b

Mike Kaganski Kas 21, 2018 yazdı

The failing call stack:

ucrtbased.dll!issue_debug_notification(const wchar_t * const message) 
Line 28
	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28)
ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154
	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154)
ucrtbased.dll!abort() Line 61
	at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const 
expression, const wchar_t * const file_name, const unsigned int 
line_number) Line 187
	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(187)
ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, 
const wchar_t * const file_name, const unsigned int line_number, void * 
const return_address) Line 420
	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(420)
ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * 
file_name, unsigned int line_number) Line 444
	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(444)
vcllo.dll!ImplDbgTestSolarMutex() Line 46
	at c:\lo\src\core\vcl\source\app\dbggui.cxx(46)
tllo.dll!DbgTestSolarMutex() Line 78
	at c:\lo\src\core\tools\source\debug\debug.cxx(78)
vcllo.dll!OpenGLSalBitmap::Create(const Size & rSize, unsigned short 
nBits, const BitmapPalette & rBitmapPalette) Line 164
	at c:\lo\src\core\vcl\opengl\salbmp.cxx(164)
vcllo.dll!Bitmap::Bitmap(const Size & rSizePixel, unsigned short 
nBitCount, const BitmapPalette * pPal) Line 108
	at c:\lo\src\core\vcl\source\bitmap\bitmap.cxx(108)
vcllo.dll!o3tl::make_unique<Bitmap,Size &,unsigned short &>(Size & 
<args_0>, unsigned short & <args_1>) Line 29
	at c:\lo\src\core\include\o3tl\make_unique.hxx(29)
vcllo.dll!vcl::PNGReaderImpl::ImplReadHeader(const Size & 
rPreviewSizeHint) Line 665
	at c:\lo\src\core\vcl\source\gdi\pngread.cxx(665)
vcllo.dll!vcl::PNGReaderImpl::GetBitmapEx(const Size & rPreviewSizeHint) 
Line 342
	at c:\lo\src\core\vcl\source\gdi\pngread.cxx(342)
vcllo.dll!vcl::PNGReader::Read(const Size & i_rPreviewSizeHint) Line 1732
	at c:\lo\src\core\vcl\source\gdi\pngread.cxx(1732)
vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const 
rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat, 
unsigned short * pDeterminedFormat, GraphicFilterImportFlags 
nImportFlags, 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> * 
pFilterData, const WmfExternal * pExtHeader) Line 1813
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1813)
vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const 
rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat, 
unsigned short * pDeterminedFormat, GraphicFilterImportFlags 
nImportFlags, const WmfExternal * pExtHeader) Line 1281
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1281)
vcllo.dll!GraphicFilter::FilterCallback(ConvertData & rData) Line 2509
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2509)
vcllo.dll!GraphicFilter::LinkStubFilterCallback(void * instance, 
ConvertData & data) Line 2481
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2481)
sofficeapp.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 84
	at c:\lo\src\core\include\tools\link.hxx(84)
sofficeapp.dll!desktop::Desktop::ImplInitFilterHdl(desktop::Desktop * 
__formal, ConvertData & rData) Line 1752
	at c:\lo\src\core\desktop\source\app\app.cxx(1752)
sofficeapp.dll!desktop::Desktop::LinkStubImplInitFilterHdl(void * 
instance, ConvertData & data) Line 1749
	at c:\lo\src\core\desktop\source\app\app.cxx(1749)
vcllo.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 84
	at c:\lo\src\core\include\tools\link.hxx(84)
vcllo.dll!GraphicConverter::Import(SvStream & rIStm, Graphic & rGraphic, 
ConvertDataFormat nFormat) Line 44
	at c:\lo\src\core\vcl\source\gdi\cvtgrf.cxx(44)
chartcorelo.dll!chart::ChartModel::impl_loadGraphics(const 
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & 
xStorage) Line 621
	at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(621)
chartcorelo.dll!chart::ChartModel::impl_load(const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
rMediaDescriptor, const 
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & 
xStorage) Line 576
	at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(576)
chartcorelo.dll!chart::ChartModel::load(const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
rMediaDescriptor) Line 543
	at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(543)
chartcontrollerlo.dll!chart::ChartFrameLoader::load(const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
rMediaDescriptor, const 
com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & xFrame) 
Line 170
	at c:\lo\src\core\chart2\source\controller\main\chartframeloader.cxx(170)
fwklo.dll!framework::LoadEnv::impl_loadContent() Line 1149
	at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(1149)
fwklo.dll!framework::LoadEnv::startLoading() Line 383
	at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(383)
fwklo.dll!framework::LoadEnv::loadComponentFromURL(const 
com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> 
& xLoader, const 
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & 
xContext, const rtl::OUString & sURL, const rtl::OUString & sTarget, 
long nSearchFlags, const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
lArgs) Line 170
	at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(170)
fwklo.dll!framework::Desktop::loadComponentFromURL(const rtl::OUString & 
sURL, const rtl::OUString & sTargetFrameName, long nSearchFlags, const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
lArguments) Line 619
	at c:\lo\src\core\framework\source\services\desktop.cxx(619)
mscx_uno.dll!`anonymous 
namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * 
pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, 
_typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, 
_typelib_MethodParameter * pParams, void * pUnoReturn, void * * 
pUnoArgs, _uno_Any * * ppUnoExc) Line 214
	at c:\lo\src\core\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(214)
mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const 
_typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, 
_uno_Any * * ppException) Line 429
	at c:\lo\src\core\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(429)
binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny 
* returnValue, 
std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny> > 
* outArguments) Line 239
	at c:\lo\src\core\binaryurp\source\incomingrequest.cxx(239)
binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
	at c:\lo\src\core\binaryurp\source\incomingrequest.cxx(79)
binaryurplo.dll!request(void * pThreadSpecificData) Line 83
	at c:\lo\src\core\binaryurp\source\reader.cxx(83)
cppu3.dll!cppu_threadpool::JobQueue::enter(__int64 nDisposeId, bool 
bReturnWhenNoJob) Line 108
	at c:\lo\src\core\cppu\source\threadpool\jobqueue.cxx(108)
cppu3.dll!cppu_threadpool::ORequestThread::run() Line 170
	at c:\lo\src\core\cppu\source\threadpool\thread.cxx(170)
cppu3.dll!threadFunc(void * param) Line 186
	at c:\lo\src\core\include\osl\thread.hxx(186)
sal3.dll!oslWorkerWrapperFunction(void * pData) Line 58
	at c:\lo\src\core\sal\osl\w32\thread.cxx(58)
ucrtbased.dll!invoke_thread_procedure(unsigned int(*)(void *) procedure, 
void * const context) Line 92
	at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(92)
ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void * __ptr64)>(void 
* const parameter) Line 115
	at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(115)
kernel32.dll!BaseThreadInitThunk()
ntdll.dll!RtlUserThreadStart()

Change-Id: Ia22ebb2361192c30549b0f01ac0b709295e1dbdc
Reviewed-on: https://gerrit.libreoffice.org/63700
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

a0ac944b

test: enable clang-format for xindexaccess · 06b1e244

Jens Carl Ara 02, 2018 yazdı

Accidentally formatted the files with commit
d0a6f8a8. Might just enable them.

Change-Id: I2f017a17d29f63721be10eb3bff388ed1a5a49bb
Reviewed-on: https://gerrit.libreoffice.org/64418
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

06b1e244

Let so_activex learn to work with Win32 errors and HRESULT properly · aa4427f3

Mike Kaganski Ara 02, 2018 yazdı

Previous code made ~no sense from error handling PoV. Closing registry
keys could be skipped because of prior errors; booleans were cast to
HRESULT to be checked later using SUCCEEDED macro.

Change-Id: I0735ab7e2f3b29682ab19adb0e96a581e997b8b5
Reviewed-on: https://gerrit.libreoffice.org/64425
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

aa4427f3

tdf#120703 PVS: V560 A part of conditional expression is always true/false · eddee22b

Mike Kaganski Ara 02, 2018 yazdı

Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11
Reviewed-on: https://gerrit.libreoffice.org/64429
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

eddee22b

tdf#120703 PVS: V560 A part of conditional expression is always true/false · 6ed52ecf

Mike Kaganski Ara 02, 2018 yazdı

Change-Id: Ieff0dde4faee209200b8f4e809e8bb4eb1b8f4a6
Reviewed-on: https://gerrit.libreoffice.org/64433
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

6ed52ecf

02 Ara, 2018 12 kayıt (commit)

Resolves: tdf#121810 wrong column order · 3abcd34f

Caolán McNamara Ara 01, 2018 yazdı

Change-Id: Ie82c47ea772b6eb5fc7b84426bb3c1cc98dc9c14
Reviewed-on: https://gerrit.libreoffice.org/64409
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

3abcd34f

ofz#11679 avoid config using path · 3aa48124

Caolán McNamara Ara 02, 2018 yazdı

Change-Id: I5629c4e0bbe29390db5350b05523409c48bbb84d
Reviewed-on: https://gerrit.libreoffice.org/64434
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

3aa48124

no need for approxFloor · bbe7ce06

himajin100000 Kas 27, 2018 yazdı

Change-Id: Ie69be492f41e42714edea252af9054414b0b841a
Reviewed-on: https://gerrit.libreoffice.org/64134Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

bbe7ce06

Fixed header include guard in offapi/com/sun/star/sheet/XConditionEntry.idl · 4f47b7a7

Vikas Mahato Kas 22, 2018 yazdı

Change-Id: I159affa46a13b5ea6b501aeec43cc809885b6e11
Reviewed-on: https://gerrit.libreoffice.org/63811Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

4f47b7a7

-Werror,-Wc++98-compat-extra-semi · ec7ad2a0
Stephan Bergmann Ara 02, 2018 yazdı
```
Change-Id: I15d67108b4a80a4788982ad6bea65e32fd941a35
```
ec7ad2a0

loplugin:intvsfloat get this working reliably · 93e0622d

Noel Grandin Kas 30, 2018 yazdı

Change-Id: Ifdf1a152f6bc2e2f6edae97a5191120f630f7e49
Reviewed-on: https://gerrit.libreoffice.org/64374
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

93e0622d

use same [un]premultiply · 48d1df74

Caolán McNamara Ara 01, 2018 yazdı

Change-Id: Idd1ca1243b64a9ec606382a0895e11376a2ec186
Reviewed-on: https://gerrit.libreoffice.org/64406
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

48d1df74

weld ScShareDocumentDlg · cd5bef5e

Caolán McNamara Kas 30, 2018 yazdı

Change-Id: I790f957c9ebc6d87a94a355c30215245aaabeb30
Reviewed-on: https://gerrit.libreoffice.org/64345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cd5bef5e

Caolán McNamara Ara 01, 2018 yazdı

Change-Id: I1a27d82ef94f1052171f7a3f6c5c80c0ec66b547
Reviewed-on: https://gerrit.libreoffice.org/64408
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

e84d236a

can pass window directly to CreateTemplateDialog now · 9da741ce

Caolán McNamara Kas 30, 2018 yazdı

Change-Id: Ic7ff388a338b2b90f4509c807f7ffcb34e468edb
Reviewed-on: https://gerrit.libreoffice.org/64343
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

9da741ce

weld SwGlossaryGroupDlg · c650658f

Caolán McNamara Kas 29, 2018 yazdı

Change-Id: I142123b474e0e35f6da375977e33d40e0ad39054
Reviewed-on: https://gerrit.libreoffice.org/64324
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

c650658f

tdf#120703 PVS: logical AND had been used instead of bitwise · 4da61d4c

Mike Kaganski Ara 01, 2018 yazdı

V560 A part of conditional expression is always true:
     sal_Int32(0xFF) != 0.

Change-Id: I5f19c4ff20e91767d22a85239f9693d68ff360b1
Reviewed-on: https://gerrit.libreoffice.org/64414
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

4da61d4c