Change-Id: I1b5424df5b26cd18b6f28e48b8a1c3e4a3f1d0c8
Reviewed-on: https://gerrit.libreoffice.org/70576
Tested-by: Jenkins
Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Look for places we are assigning to the same variable twice
in succession, which means we can simplify that to a single assign

Change-Id: I499d20e28f5595e81e927bef8e1bf364eea8ba91
Reviewed-on: https://gerrit.libreoffice.org/70531
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Despite being optional as per ECMA-376-1:2016, Excel 2016 seems to
require the presence of "name" attribute in dataField element of
pivot table definition, so make sure to write at least empty string
there.

Change-Id: Iaab5674f86b7dd0b267776678e11af47086635d7
Reviewed-on: https://gerrit.libreoffice.org/70522Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

It turns out that this change revealed unit tests written incorrectly
(and untested), or maybe which became broken (not testing) because of
some previous assertXPath change? They incorrectly used 3-arg form of
it to check node content equality to passed string, while in fact, an
attribute was looked for with that name, and its empty return tested
to match default empty 4th argument.

Change-Id: If24e18518543102d115a22a6282e4cca9cf694e2
Reviewed-on: https://gerrit.libreoffice.org/70581Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: If9f93b6d244652ae6756df76cefa5e69310a67b1
Reviewed-on: https://gerrit.libreoffice.org/70552
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I8a16cbb0ed64cd75859127f7e9bb235aaf04ec7d
Reviewed-on: https://gerrit.libreoffice.org/70322
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

presumably this makefile should actually be in extras (?)

Change-Id: Ie38c7f5662c5577f5de11600645049757031a697

Change-Id: I1560aac1ed7c6119aabf1410a592ac0a9bcc357b
Reviewed-on: https://gerrit.libreoffice.org/70532Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I895280286d5d48e709255e75201b22aa9d4044af
Reviewed-on: https://gerrit.libreoffice.org/70533Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I2df9e24ff0d4683819db8fa17bd6a0dfda223e13
Reviewed-on: https://gerrit.libreoffice.org/70534Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iee5dcd363e87318fa17695d9d069a462b55e4a44
Reviewed-on: https://gerrit.libreoffice.org/70535Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

this is first of the calc dialogs with a range selector, so some temp
scaffolding is required during interim case of both welded/unwelded
in existence

Change-Id: I5480179092da7b56864cef066af781b35f735ebc
Reviewed-on: https://gerrit.libreoffice.org/70474
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6d42b994c9ae177c707d33e18f7edfac7cae6145
Reviewed-on: https://gerrit.libreoffice.org/70502
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I22d556fe4719fc8e7b53c66b778f6b4196f8f024
Reviewed-on: https://gerrit.libreoffice.org/70523
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

S.a. commit 8dbe0af7 which already
did the same for Gtk3KDE5FilePicker.

Change-Id: I35f837b7b8fdaebc5625ff8ea5e20b3f48a3b4ec
Reviewed-on: https://gerrit.libreoffice.org/70519
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

When we drag a entry in TreeListBox, we execute a PaintDDCursor
which paints a "cursor" of a possible drag target (for example
to show where the entry will be moved to if we want to change the
order). The problem with this fuction is that it paints a line
directlly at that location, and that it uses invert raster
operation to draw a line. So to hide the line it just needs to
draw again. On MacOS this invertion causes a problem and draws
the whole area black, which is the cause of this bug.

So instead of inverting the drawing of the drag target cursor
has now been moved into the main Paint method, where it redraws
the whole entry, and if present, also the drag target cursor.
This means that all we need to do is Invalidate the entry,
which then just gets redrawn in a normal Paint pass.

One exception is still MacOS, which doesn't invalidate the entry,
but redraws the entry directly. DnD is MacOS is a bit different
as it is not async (if I understand correctly) so the invalidate
has no effect.

Change-Id: I8542f47940a3b90114ea4bbbac57fd303ca3434b
Reviewed-on: https://gerrit.libreoffice.org/70521
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

... and doesn't change any code or API.

Change-Id: Ic769831130bb78b8192ffd33375760bef9b76911
Reviewed-on: https://gerrit.libreoffice.org/70466
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

The fix for tdf#37223 creates native text tables
from the RTF clipboard data to insert them cell
by cell in Writer tables instead of OLE embedding.
Unfortunately, using Calc RTF clipboard data inserts
also the cells of the hidden rows (tdf#118676).
This improvement uses the HTML clipboard data
to paste only the visible rows.

Note: first the original patch 1) converted the clipboard
data to a temporary nested text table at the cursor position,
and 2) copied its already native table content to the
clipboard, and inserts it into the original target table.
This doesn't work with the HTML format (that inserts plain
text data within a text table cell instead of a nested
table). As a workaround, the patch removes the target text
table with the insertion point temporarily, creating the
native text table from the HTML clipboard data at the place
of the removed text table. After copying the converted
native text table data to the clipboard, the removed
table is restored, and the native clipboard data is inserted
at the original cursor position.

Change-Id: Iee5bb4027729ca1eab373029f176eeadc59388a8
Reviewed-on: https://gerrit.libreoffice.org/70425
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

In FindBuiltInNameIdx(), check the duplication by
using the exported symbol of the ranges, instead
of the (in the case of whole rows) always different
XclTokenArray data.

Change-Id: Iba439d765bbbfaf5379113548f3d86d1c984e71c
Reviewed-on: https://gerrit.libreoffice.org/70507
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

New dialog

Change-Id: If1e501de26eb5a9c20a59e621f9e805c3b5e2cf8
Reviewed-on: https://gerrit.libreoffice.org/69498
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

* Update helpcontent2 from branch 'master'
  - New Python page + updates to existing pages to support embedded references
    
    Change-Id: Ie7bd884db45e3ca59dee1ffa79b2ea14ced3d160
    Reviewed-on: https://gerrit.libreoffice.org/70420
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Where it can be done by removing useless / duplicate code.
For XFListStyle I removed the copy operator entirely, because it
was bugous and it seems not to be used anyway.

Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22
Reviewed-on: https://gerrit.libreoffice.org/70482Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

...that got added with 36883a9f "Sifr icon
theme: add sc and extension icon folder" and broke PythonTest_solenv_python.

Change-Id: Ifb1c3dd29dbc969f05f3bfb0e121699fcbeb9007

It turns out that the situation fixed in commit
1be0a3fa also applies to the definition
of the styles themselves.

To implement the same style import as Word, the style definitions need
to be stored twice: once as read from the file, and another time with
attributes defaulted and deduplicated vs. the parent style; the second
representation is then sent to the domain mapper.

To make this easier, add a bool parameter to cloneAndDeduplicate()
to disable the implicit pPr dereferencing that happens when creating the
hard formatted paragraph properties (this could potentially be cleaned
up further if those paragraph properties would use pPr wrapper
themselves).

Also implement defaulting of line spacing in getDefaultSPRM().

Change-Id: I4810e917697b3af244e5dbdd7f5a45b4767c93fc
Reviewed-on: https://gerrit.libreoffice.org/70320
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I1c94090c4846e232bd6bb9c86a0c94b750ccbf5c
Reviewed-on: https://gerrit.libreoffice.org/70499
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3799788cd72b34d603f4bffc6820f5b656cbf427
Reviewed-on: https://gerrit.libreoffice.org/70471Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Missed one call where the return value must be forwarded.

(regression from 7d481f7a
 and 943d9be7)

Change-Id: Ic405b29a1dce982bfdd81eeb5d678ceb79690bfc
Reviewed-on: https://gerrit.libreoffice.org/70469
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

(regression from c180c944)

Change-Id: Ie3c935ee5dd42187ca8ad2b28406b80e63c0d1e3
Reviewed-on: https://gerrit.libreoffice.org/70467Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

There were some changes since last run and some omitted files

Change-Id: I666ac8ed7d06684e252ca590e3d7d454e9e10975
Reviewed-on: https://gerrit.libreoffice.org/70497
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I20ed4c7daa9cde48ba65f92e5b4cc7e00972fe81
Reviewed-on: https://gerrit.libreoffice.org/70477
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

It's cleaner to avoid member functions and constructors when we inherit
from a C struct and we pass it to pdfium's C API.

Change-Id: Iac9ab99b3d1b66241bb49d3a7707e242078ab5df
Reviewed-on: https://gerrit.libreoffice.org/70472
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

now all transition arrows are created in cycle diagrams

Change-Id: I69e932f0060786b702dbecae72245bb624fa602b
Reviewed-on: https://gerrit.libreoffice.org/70457
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Ida96d8a0a993daac87c4e03fe4ba0d22a69f90cb
Reviewed-on: https://gerrit.libreoffice.org/70487
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id9d19965511760839e8e93488b1cc6a98fbd4a5c
Reviewed-on: https://gerrit.libreoffice.org/70493
Tested-by: Jenkins
Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia0dd6a96a039056f15e494baf844e11fb9b5e9aa
Reviewed-on: https://gerrit.libreoffice.org/70488
Tested-by: Jenkins
Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I1cb16b180f4cc5bf4d65485f03c44a06414d3580
Reviewed-on: https://gerrit.libreoffice.org/70481
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I91f04cae91cbb5510f70baaf8c31ecc59f6402c7
Reviewed-on: https://gerrit.libreoffice.org/70479
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ibdcae261ee19e95a36b094401c9b526c41e261ad
Reviewed-on: https://gerrit.libreoffice.org/70484Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I0a3ba3beb671cae6956fa616308997fcc2bd3d1f
Reviewed-on: https://gerrit.libreoffice.org/70476
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

After recent additions of 61c4f96d "Support
AdoptOpenJDK" and 41507db5 "Support Amazon
Corretto" to our hard-coded list, there is now reports that at least Debian and
Ubuntu tried to distribute versions of OpenJDK with the java.vendor propety set
to string like "Debian" or "Ubuntu".  Instead of trying to catch up with an
ever-growing hard-coded list, it is probably better to stop relying exclusively
on such a hard-coded list, and for unknown vendor values, try out whether the
SunInfo backend (which supports the "generic" OpenJDK) would be able to handle
the given JRE.  (For simplicity, assume that any versions of such JREs are
supported.  Our baseline is Java 6, and there are unlikely any older versions of
JREs from unknown vendors out there.  If this turns out to be problematic, we
could include information about problematic vendors after all, or add a general
check that JREs from unknown vendors are at least Java 6.)

Many functions in jvmfwk/inc/vendorplugin.hxx that used to take a set of
sVendor/sMinVersion/sMaxVerison/arExcludeList paramters had to be revised to
take a vendorSettings parameter instead, and
VendorSettings::getVersionInformation has been changed to return a
boost::optional, so that unknown vendors can be handled gracefully.

Change-Id: Ibf915f2ddd59e09b77e2c03be688cac0547b9ac9
Reviewed-on: https://gerrit.libreoffice.org/70460
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>