Change-Id: I3276c2c368c755e070fd8b19a15a954948a68df7
Reviewed-on: https://gerrit.libreoffice.org/67008
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib8c86179a3d13852cbb02b389b6103aca5456dba
Reviewed-on: https://gerrit.libreoffice.org/67013
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie64a300a73db666231ae7b37f15e5d7556e594bc
Reviewed-on: https://gerrit.libreoffice.org/67039
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Move XPropertySet Java tests to C++ for ScFilterDescriptorBase.

Change-Id: I86a16f3c53a5aacea0ce88a54ec8b340d13dff4f
Reviewed-on: https://gerrit.libreoffice.org/67038
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

ODF 1.2 section 19.145 says 'If a moveto is followed by multiple
pairs of coordinates, they are treated as lineto.' The patch does
this on import.

Change-Id: Ib493ca49288cdb2d34b7ee801bd052281617d2e8
Reviewed-on: https://gerrit.libreoffice.org/66888
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: I6232615f15b52a1f004a13ed97fc0b8002a22269
Reviewed-on: https://gerrit.libreoffice.org/66694
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Rename ScFilterDescriptorBaseObj to ScFilterDescriptorBase so it
matches the object name we test against.

Change-Id: Ia5ce59997e99b2b537e50ddfeaa9d96b2b55555f
Reviewed-on: https://gerrit.libreoffice.org/67033
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

The hope is that this should allow both system's libgpg-error.so.0 and
LO's bundled libgpg-error-lo.so.0 to be loaded by soffice.bin without
unintended hilarity.

Change-Id: I94498097a847b9756de86051798cb4ce022f6c83
Reviewed-on: https://gerrit.libreoffice.org/67012
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

* Update helpcontent2 from branch 'master'
  - tdf#121571 Solve cognitive dissonance with note icons and colors
    
    More often than not, the alarmist colors given to note boxes didn’t
    match their content.
    
    Change-Id: I88d7a8e2d07ffba661c218887fd54638506d21c8
    

Change-Id: Icb2f745851ba3de31f6a672d1bc20659de687d2e
Reviewed-on: https://gerrit.libreoffice.org/67031
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ia7d6c103956c8e3cebd6ebe656fd88586d33a9c8
Reviewed-on: https://gerrit.libreoffice.org/67032
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

* Update helpcontent2 from branch 'master'
  - Drop this pitiful, bothersome, gimmicky animation
    
    Change-Id: If533f8565e38e02d503cc1ab59f65e2445f1369b
    

* Update helpcontent2 from branch 'master'
  - A couple of articles and tag vomit cleanup
    
    Change-Id: I5e3d9c7f9ce78807d1acfa190a740f41ddd8a378
    

so write something that does

Change-Id: I294b9288af0ddf49cbb5a8a69b4509e1ae03d9b8
Reviewed-on: https://gerrit.libreoffice.org/67018Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I669d8cb18ed78fcdb50aa3f452661500d75ad880
Reviewed-on: https://gerrit.libreoffice.org/67021
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I75c1b6d3933a5773d9e1dce40744c2342ab63ee8
Reviewed-on: https://gerrit.libreoffice.org/67024
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Regression from

    commit e2e47898
    CommitDate: Fri Aug 31 12:50:52 2018 +0200

        Use tools::Time::GetClock() in number formatter for wall clock time

This partly reverts the change for the affected time duration []
formats, which truncated the value within the magnitude that due
to the imprecision of floating point values lead to "false"
precision of h:m:s.999999...

This might again yield imprecise display values (old behaviour)
for a difference of two wall clock times that now are not rounded
up into the next magnitude for display. If so, a
tools::Time::GetDuration() might be appropriate.

Change-Id: If8fbcc2e4c2e0da04ca742a2837f57cd313d0367
Reviewed-on: https://gerrit.libreoffice.org/67005Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Regression from commit 50223ea6
(tdf#98987 sw: add AddVerticalFrameOffsets compat mode, 2016-03-31),
SwFEShell::ImpEndCreate() was not adapted to call
SwTextFrame::GetBaseVertOffsetForFly() when determining the vertical
position of the inserted shape.

The call can be unconditional, the returned value is already 0 when the
DocumentSettingId::ADD_VERTICAL_FLY_OFFSETS compat setting is false.

Change-Id: Iec6af5a6d1ff3466e08377853cc8ca84f33a76d1
Reviewed-on: https://gerrit.libreoffice.org/67017Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

which adds the problem that GtkComboBox doesn't send a focus-in,
but its toggle does, to find and use that instead

Change-Id: I18d46511bf2e6997539a8413f574a94b24b4583f
Reviewed-on: https://gerrit.libreoffice.org/67009
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cf. <https://github.com/ivmai/libatomic_ops/> (as mentioned in
external/libatomic_ops/README)

Change-Id: Ibd50ca81695cbcd73e005b0bbbd46ceb62b1e9dc
Reviewed-on: https://gerrit.libreoffice.org/66912
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...from <https://github.com/ivmai/libatomic_ops/wiki/Download>.  (The md5sum
given there is 99128f05e3e3f4e0cd39aa23f23bbe0c.)

The old version of external/libatomic_ops failed to build at least when building
a Flatpak for aarch64, see
<https://flathub.org/builds/#/builders/39/builds/702/steps/5/logs/stdio>:

[...]
> Making all in src
> Making all in atomic_ops
> Making all in sysdeps
> In file included from atomic_ops_stack.h:32,
>                  from atomic_ops_malloc.c:20:
> atomic_ops.h:343:4: error: #error Cannot implement AO_compare_and_swap_full on this architecture.
>  #  error Cannot implement AO_compare_and_swap_full on this architecture.
>     ^~~~~
> atomic_ops.c:97:1: error: unknown type name ‘AO_TS_t’; did you mean ‘AO_TS_T’?
>  AO_TS_t AO_locks[AO_HASH_SIZE] = {
>  ^~~~~~~
>  AO_TS_T
[...]

(cf. <https://github.com/flathub/org.libreoffice.LibreOffice/pull/67/commits/
48b22dbabc06f1822df74f755096cf0ea5ba2499> "Upgrade libatomic_ops to latest
libatomic_ops-7.6.8.tar.gz")

Change-Id: Icc040cc47f45f71577995a2ff9c63df97150bdea
Reviewed-on: https://gerrit.libreoffice.org/66983
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I78db6ab6fcc677247716f42d3c102314415c34d2
Reviewed-on: https://gerrit.libreoffice.org/66993
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(cf. LO's configure.ac, needed for external/firebird on non-x86[-64]), but
org.freedesktop.Sdk//18.08 apparently doesn't provide it (while
org.freedesktop.Sdk//1.6 apparently did)

(cf. <https://github.com/flathub/org.libreoffice.LibreOffice/pull/67/commits/
b2762523a4678bedd55c11db232868cbaf9c7bdd> "aarch64 and arm need libatomic_ops")

Change-Id: I6eb060251ce85bfd399b72d9c90a93497a3a9029
Reviewed-on: https://gerrit.libreoffice.org/66987
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

(cf. <https://github.com/flathub/org.libreoffice.LibreOffice/pull/67/commits/
deda15380b436ca8fe62e2ebc1feec8bcb6dd43e> "org.freedesktop.Sdk//18.08 `uname -i`
always returns 'unknown'")

Change-Id: Id158d769edb07aa09189907d120cb1e9cd8d9b17
Reviewed-on: https://gerrit.libreoffice.org/66985
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

regression from weld-ing this tabpage

Change-Id: Id79ff793842982e9dba79478ad7da23ea17f97c3
Reviewed-on: https://gerrit.libreoffice.org/66989
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

regression from
    commit bf359d01
    add a Dialog::runAsync for the non-controller case

Change-Id: I02e3f62b8304139003af1c137ea59750afb4be4c
Reviewed-on: https://gerrit.libreoffice.org/66988
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

/sw/source/core/draw/dview.cxx:967:39: runtime error: downcast of address 0x6060006d1cc0 which does not point to an object of type 'SwDrawContact'
0x6060006d1cc0: note: object is of type 'SwFlyDrawContact'
 1d 02 00 2e  b0 3e 06 87 15 7f 00 00  18 3f 06 87 15 7f 00 00  50 1c 28 00 50 61 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'SwFlyDrawContact'
    #0 0x7f157de946d8 in SwDrawView::DeleteMarked() /sw/source/core/draw/dview.cxx:967:39
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /sw/source/core/draw/dview.cxx:967:39 in

When executing testPasteListener in CppunitTest_sw_unowriter since
commit 2a054445 (sw paste listener:
expose pasted images as well, 2019-01-24), though that code was added
much earlier in commit 33141f99
(SwDrawView::DeleteMarked: delete textbox of shape as well, 2014-06-23),
just no testcase invoked it.

Change-Id: I22a384ab7cc4b3eb00198b28de294896c2d1e3bb
Reviewed-on: https://gerrit.libreoffice.org/66986Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

ooo#103156-1 has a quite complex cycle of cells, some of them (and only some)
in formula groups. And the complex Interpret() nesting confuses its cycle
detection into believing that Interpret() can simply return without providing
a value, which is ok if it's called from dependency checking of threaded
calculation, but is not ok when it's called for a single cell evalution.
So make the code set cyclic-dependency error even when it's possibly
inside dependency checking, since if it's really that case, the error
will be later overwritten by the actual value.

This is still not a completely correct fix, as the document on repeated hard
recals alternates some cells between correctly reporting an error and providing
some bogus values (e.g. column S in the second sheet). But the document uses
iteration, which complicates all this stuff even more, and after spending
quite some time on this I'm still not sure on how to fix that. So at least
for now, at least avoid the assert.

Change-Id: I395f97d104d98b5c043d1f17878338d3f1b31146
Reviewed-on: https://gerrit.libreoffice.org/66911
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I17515ea4e444986f50d554c864540a625a521970
Reviewed-on: https://gerrit.libreoffice.org/66984Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I1fd28f7dc0911bfdb8fd46aee91c3a81ce034ba6
Reviewed-on: https://gerrit.libreoffice.org/66899
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one

Change-Id: I6eea0877eaa1886b64c0cce06a43b8088cbccd8e
Reviewed-on: https://gerrit.libreoffice.org/66751
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I372918497b91bd2da0432df7b27795cbf29dc6b8
Reviewed-on: https://gerrit.libreoffice.org/66982Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If648e007a6db44e26021c12ac919d81ccceaa081
Reviewed-on: https://gerrit.libreoffice.org/66981
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I31e4c28322a3492a603bce5c7226e2dbcf131173
Reviewed-on: https://gerrit.libreoffice.org/66980
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7851f4952ca2c863d92fd14fa19005ed35634033
Reviewed-on: https://gerrit.libreoffice.org/66941
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Related to patches for tdf#122241

Change-Id: I0ce46a3a362855aaa6c11f375d20c2212f1cb20b
Reviewed-on: https://gerrit.libreoffice.org/66973
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix regexp for cl.exe
This command returns some special characters preventing regexp to work.

For more details, see:
http://document-foundation-mail-archive.969070.n3.nabble.com/Could-not-determine-MSC-version-Visual-Studio-2017-td4256538.html

Change-Id: I734dcd533b0f38430d1be8852f1e4f721221e580
Reviewed-on: https://gerrit.libreoffice.org/66959
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I7c0bb328def955efce7b3866776e4d47a0ba32c0
Reviewed-on: https://gerrit.libreoffice.org/66947
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I8cdaef18329543cbbe316b9499d6707d645a789d
Reviewed-on: https://gerrit.libreoffice.org/66644
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: Ic0e343f80ef91aad9baef8cc48648207b0365c68
Reviewed-on: https://gerrit.libreoffice.org/66642
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>