Change-Id: Ic3f7aa6d247af8a422899549b7238c7fb6cf2406
Reviewed-on: https://gerrit.libreoffice.org/29338Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>

because SwXShape::supportsService always returned true for
com.sun.star.drawing.Shape I surmise that getSupportedServiceNames
should always list com.sun.star.drawing.Shape as a supported service

This went awry with...

commit 2f50ce6c
Author: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Date:   Thu Dec 5 19:17:18 2013 -0200

    fdo#54938: Convert sw to use cppu::supportsService

    Change-Id: Ic27bf31e5eb991ccceb8b97713d1e50a736709c8
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I9821a620da8bac3b6b59da976a8c25bb2deafcf1

In that scenario, of 36791233 calls only 9217 were necessary as most times
nRow2 equals nRow1.

Change-Id: I14228d065175addee76b9142c98110efe59701e7

Change-Id: I734f4bb6a6347487d210cde2639cb704e3aedae1
Reviewed-on: https://gerrit.libreoffice.org/29337Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>

... because only checkbox marks with only one dummy character should
have rEnd == rStart; the 2-dummy-character ones have the end position
behind the 2nd dummy character, see lcl_AssureFieldMarksSet.

... and "fix" some more "unused variables".

Change-Id: I25fb33891c1a74213bbeb2bbd7f3843809ee7273

i.e. if you select it, then the General::UILocale is unset and a new
default generated based on the L10N::UILocale and what langpacks are installed
but what the entry string claims is "Default - Current Language", rather than
"Default - The Language That Will Be Used", so split out the language selection
code into a reusable bit and use that to get the name of the language which will
be selected if this entry is used

Change-Id: I13d901c9a47ef213aea86417501114d4231efae5

Change-Id: I1d437077ac1bf7bf6a53e1348ccbdce7b8b20bc3

Change-Id: I67f368c84dee85102c63bb4e3f811454a03c9560
Reviewed-on: https://gerrit.libreoffice.org/29348Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

...after it had already been removed from compilerplugins/Makefile-clang.mk with
4d54e240 "Who needs that
$(CLANGDIR)/tools/clang/include anyway?"

Change-Id: Ie99bb87a10cbf78ce1ab39d35dad976c51995b8f

In CppunitTest_sw_ooxmlfieldexport testFdo81492 a TextFieldmark is
inserted at a position where already another TextFieldmark starts. The
defensively programmed lcl_AssureFieldMarksSet notices there is aleady a
dummy character at the start position, and does not insert another one,
but then the dummy character for the end position is inserted, moving
the start position index, which puts the start position behind another
bookmark.

So we end up with a field mark that has a end character but not a start
character and an un-sorted m_vAllMarks.

Change-Id: Icd15e83471e18f607eb41b2f7b0c2ce61c94ff9f

Change-Id: I48c402e3dcd9606d7f40ee2096fa8803d5499d73

Change-Id: I45e412e107601947221d679992356b47d29ad4a7

Change-Id: Id9e61dc624a34012dc7a53e262c76f8d25c4a455

The recently added tdf90697.rtf caused a libstdc++ assertion about
non-sorted m_vAllMarks.  This is because a SwXParagraph was disposed, a
bookmark on it was moved by correctMarksAbsolute onto the first
paragraph in a table, and there was a SwXTextRange with a UnoMark
pointing to the SwTableNode, so the sort order was not maintained.

So if at least one mark was moved, re-sort the array.

Change-Id: I0efc7827c826e696f29f8480bab1044b31ccfe39

Change-Id: I7188f6b94ca8782fc9c5fb106cb08801fc5ef5c0

Change-Id: If00c42235d6ec92634dc8c23fdcbb50e332ffa68

Change-Id: Ia3a97b08e1280e3665a56cdbb25ad07687dc7040

Change-Id: I71464b20c5897a2af3b4069f7f0963ef55dcd8c4

...from configuration (see issue for details).  Also, remove mention of that
configuration tree from the documentation of the css.util.PathSubstitution UNO
service.

Change-Id: Ia0373bc7d19e650b7954b7dbb934a578c96fcab5

Change-Id: I829a39f5b013f14a867c509052a5719a878a3a81
Reviewed-on: https://gerrit.libreoffice.org/29325Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>

Change-Id: I8be8f510cecab8ec8aa07f2f81795bbfdf727a26

Change-Id: Ib832509bc4c4daa5eddb9a8e1a341a5892436455

... when leaving bulk broadcast.

Change-Id: I3d456094ecc7759ed3e58af7901d544126c30b27

Fixed with 3b64a198

Change-Id: Ideea06ea95f6c565e1487f2b27ef249c38c5d4dd

this still isn't brilliant I guess

Change-Id: I18b6647133329afa85826a8014f839986a9b68de

Why is “wiki” always capitalized? It’s not a proper name.

Change-Id: I55941f192e149dc93a6576e5ca21edac78299cb4

Change-Id: I92ea37754f057c560d19b41f814a1d649ea74876

Multiple callers involved. Most significantly ScDocument::Broadcast()
calls ScDocument::TrackFormulas() individually. Track/collect pending
formula cells at the end of the bulk broadcast instead, which gives an
instructions read speedup by factor 6 for the broadcast, and an overall
speedup in the scenario for inserting the rows by factor ~2 wall clock
time.

ScDocument::InsertRows()
Before, Ir Incl: 282,227,033,656
 After, Ir Incl:  66,307,994,805

With cycle detection:

ScDocument::TrackFormulas()
Before:
        Ir Incl          Ir Self
 66,981,644,959   11,913,444,899

After:
        Ir Incl          Ir Self
 10,819,556,073    1,973,232,494

Change-Id: I85fe8b03ecb52cffaa6fa14354b3cc3467ecc111

Change-Id: I90bd5e8042e3157286774c97d2ea3c109da2b658

Change-Id: I759107eeb074698d5e4987c76005788aee33287d

...apparently unused and broken (see issue)

Change-Id: Ic20d287b59d3317fecdba03a3edf8f51611c91ba

Change-Id: Idf75ffa042c4858ef9bea99d603adb691b295139

Change-Id: I5849ce78407675150ca1fd96388a4569bcd14f4a

the problem being that the attempt to restore the focus in the document in the
floatingwindow tear down is blocked because the menus have set that window as
modal so the focus isn't set.

The attempt to set the focus in the floatingwindow teardown causes the
SavedFocus in the menufloatingwindow to be dropped, so the extra layer of code
to restore focus after modality is removed doesn't do anything

this is fallout from...

commit dd46727b
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Apr 5 15:27:38 2016 +0100

    Resolves: tdf#87120 no keyboard navigation inside floating windows

which allows the focus to "truly" enter the menus, triggering the
floatingwindow attempt, which fails but blocks the menufloatingwindow attempt

easiest thing seems to make the restoring modality, and then restore focus,
something that MenuFloatingWindow does before it finishes

Change-Id: I97a4ac71419dcb04709e4667586d8343e89ddbeb

Change-Id: I2e4a498bb9c4d5e887f55d38cdae6c6aeef44a4d

commit 9b7dfb10
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Thu Jun 9 16:52:21 2016 +0100

    EndSaveFocus does nothing on the !bRestore case

removed the code that made it look like it made sense

Change-Id: I2e7280fd6643e86d65cba04c8302be099d6f3d0e

the argument is (effectively) equal to the default

Change-Id: I26fcd43d2bc8e37e6887c244f728e3231328e34e

Change-Id: I526c45ecf3c7e21b87c16eef5047707f74da7668

Change-Id: I39a2a65e06cdf421786fbbfedecad604fcb3abd2

Change-Id: I0c65720a3db88242bdf36338864f6961478f547f