Change-Id: I8d2c4bb95ae50e7d23a89db1dd6bb197d3af65c0

Its use has been removed with e161e35f
"installer: Remove packager.pl" (and changes to the file itself also stopped in
2013).

Change-Id: I3bf18849a80abd5b774f1a6030c514e5891e0350
Reviewed-on: https://gerrit.libreoffice.org/54769Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

and the modeline should be on the last line

Change-Id: I6032fdee6fc29d11cac1e4b8ec9c36e004258e73
Reviewed-on: https://gerrit.libreoffice.org/54752Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

As agreed at the ESC - lets see how this goes for 6.1

This reverts commit 4696d372.

Change-Id: Ic2be53c53dd7573972cd54c390443dc136739b6c
Reviewed-on: https://gerrit.libreoffice.org/54774Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Using the system ("native") menubar works fine since a long time
surely. No reason to keep a fallback possibility.

Change-Id: I0d9ed86c28b0d832c8123b18980740dbf895ec1c
Reviewed-on: https://gerrit.libreoffice.org/54775Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Can happen at least when LibreOffice is started from the command line
using the 'open' command line and passed a file name.

Change-Id: I93145974a56e124550579cae8fd69ccb4a7d3bda
Reviewed-on: https://gerrit.libreoffice.org/54758Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Id6f2b9036832e581aa6ccb45fd3f7a56191db980

Change-Id: I53b7f514be2e015445eb9cb0471c22d41c464e4e
Reviewed-on: https://gerrit.libreoffice.org/54767Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Since ScEditUtils::GetString() requires EditEngine, which is probably not
completely thread-safe.

Change-Id: Ie3d64f56b76a5861fa4b0a1f9cb683cd26806b35
Reviewed-on: https://gerrit.libreoffice.org/54766Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Also removes dead code because SwTabFramePainter::Insert()
is always called with a cell frame and IsTabFrame() always
returns false.

Change-Id: I2505d876d20e44ded1faf760bc3b7b1d34b0fd8d
Reviewed-on: https://gerrit.libreoffice.org/54684Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

mistake in commit
    commit f6063153db8951ca21ac3a2e36973f1d73eda4d1
    tdf#117706 Multi-select copying rows between sheets broken
noticed by erack

Change-Id: Ia5ed3726c8f02750eec3551f7dd908120edb2553
Reviewed-on: https://gerrit.libreoffice.org/54765Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

a linear loop builds a recursive structure, if it gets too deep then later
processing, e.g. releasing the tree, can exhaust stack

Change-Id: I4421b9bae62ac2b6ffe32531d1167a482103bfde
Reviewed-on: https://gerrit.libreoffice.org/54762Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Also tdf#76476, and probably more.

Make it so that when a window is in full-screen mode from
LibreOffice's point of view, it is also full-screen from the system's
point of view, and vice versa.

All three ways to enter and leave full-screen mode can now be used
with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full
Screen" menu entry, and the green bubble on the title bar.

Don't disable/deactivate/etc menus while in full-screen mode. The menu
auto-hides so there is no harm in having it function normally.

Don't display the floating toolbar with a single "Full Screen" button
in it as the way to leave full-screen mode. Instead, the same three
ways that can be used to enter full-screen mode work to leave it, too.

Sadly I could not figure out a way to set a window properly to
full-screen at the point where a document window is created and set to
be the same size as that kind of document window was the previous time
it was open in LibreOffice. Thus don't save state for full-screen
windows as we can't properly restore them. At least not for macOS. It
is not good to just restore them as non-full-screened but still at the
size they had when full-screen.

One irritating glitch remains, and I was unable to fix that properly:
I now prevent closing the document window that is in full-screen mode.
Otherwise, if it is closed, the full-screen mode remains even if no
window is open there; the desktop is completely black. Moving the
cursor to the top edge, the LibreOffice menu is there, though. I tried
to fix that but with no fully satisfying result. (Some attempts even
lead to crashes, so just disabling closing is better than crashing at
least.)

Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f
Reviewed-on: https://gerrit.libreoffice.org/54760Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Project: help  31d3025c0610319fd545b52f41211f86530eedec

tdf#117752 HID for table background in Writer

Change-Id: Iba29f40457261d833c01c53ca3d9f530887fb0b6
Reviewed-on: https://gerrit.libreoffice.org/54714Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: translations  ed31445a5c607b49bf71cd37055578de6785cb85

update translations for master/6.1 beta1

Change-Id: Ib85491aac55698f0db45945f3fbaa332e8ec25dc

Change-Id: I0d391b3fe9d2d610ae41e2a03cd2e195a866e103
Reviewed-on: https://gerrit.libreoffice.org/54681Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

regression from

   commit 6529cd54
   don't use heap for elements in ScRangeList

where I converted some loop variables from pointers to refs, forgetting
to assigning to a ref is quite different from assigning to a pointer

Change-Id: I4a365006317d16a24cbb1b43994906a0d4b4d424
Reviewed-on: https://gerrit.libreoffice.org/54756Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

... and pass it as the sole argument to XMLSignatureHelper::SetDateTime().

Change-Id: I7f3e8dc90bb34ca347a1ad5a79717a338af3bed9
Reviewed-on: https://gerrit.libreoffice.org/54706Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

by changing parsing process a bit

Change-Id: I77c06ba218e9bc0d241dbff10f76860d0ca5ed44
Reviewed-on: https://gerrit.libreoffice.org/54542Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

so use ellipsize instead and set the height to one single line

Change-Id: Icb124669410c041880ce468f3cf56fdb4bc1c9f1
Reviewed-on: https://gerrit.libreoffice.org/54751Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I778feac0b50390f59a3621279636f8b09ed3def2

since /usr/lib{,32,64}/jvm/**/jre/bin/java doesn't exist since OpenJDK 9

Change-Id: Ic9c052a756ba4a93595595da98148ff22169d333

Change-Id: Ic24d79f39d9cc36cf229c7410e1f96c4c3d316f9
Reviewed-on: https://gerrit.libreoffice.org/54671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I1bb2be7d3636b70018276eb3d6b23ba7ace6e62a
Reviewed-on: https://gerrit.libreoffice.org/53926Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

...that previously ended up in language-independent parts of installation sets.

The structure of that media/ tree doesn't allow to directly mis-use the existing
AllLangPackage machinery (which expects the language to be encoded in the first
pathname segment within the tree; and which is already mis-used for the
helpcontent2/AllLangPackage_html_lang.mk parts).

So introduce gb_AllLangPackage_add_files_for_lang that allows to specify the
language explicitly, independent of where it is encoded in the pathname (if at
all).  The underlying gb_AllLangPackage_add_file sets a
gb_AllLangPackage_ALLDIRS that is used by `make packageinfo`, which may need
further fixing by anybody actually using that target; see the mail thread
starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-May/080242.html>
"Broken --with-help=html `make packageinfo`".

All files in $(SRCDIR)/helpcontent2/source/media/ must now explicitly be listed
in either helpcontent2/Package_html_media.mk (for the language-independent
files) or helpcontent2/AllLangPackage_html_media_lang.mk (for the language-
specific files).  Also note the two TODOs in
helpcontent2/AllLangPackage_html_media_lang.mk.

What is not quite right yet is that content from
helpcontent2/AllLangPackage_html_lang.mk and
helpcontent2/AllLangPackage_html_media_lang.mk is ending up in both per-language
helpcontent installation sets (as intended, via the instructions in
helpcontent2/CustomTarget_html.mk) and per-language languagepack installation
sets (which is unintended).  This needs to be fixed with a follow-up commit.

This is the core part of a commit spanning core and helpcontent2.

Change-Id: Ib29e52cf8a3ca7bcd234a8f6919c8eac6157cdbf

Project: help  33551e7fd85aa327f76bb343a3740bceb162bbfa

Properly handle language-specific parts of --with-help=html media/ sub-tree

...that previously ended up in language-independent parts of installation sets.

The structure of that media/ tree doesn't allow to directly mis-use the existing
AllLangPackage machinery (which expects the language to be encoded in the first
pathname segment within the tree; and which is already mis-used for the
helpcontent2/AllLangPackage_html_lang.mk parts).

So introduce gb_AllLangPackage_add_files_for_lang that allows to specify the
language explicitly, independent of where it is encoded in the pathname (if at
all).  The underlying gb_AllLangPackage_add_file sets a
gb_AllLangPackage_ALLDIRS that is used by `make packageinfo`, which may need
further fixing by anybody actually using that target; see the mail thread
starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-May/080242.html>
"Broken --with-help=html `make packageinfo`".

All files in $(SRCDIR)/helpcontent2/source/media/ must now explicitly be listed
in either helpcontent2/Package_html_media.mk (for the language-independent
files) or helpcontent2/AllLangPackage_html_media_lang.mk (for the language-
specific files).  Also note the two TODOs in
helpcontent2/AllLangPackage_html_media_lang.mk.

What is not quite right yet is that content from
helpcontent2/AllLangPackage_html_lang.mk and
helpcontent2/AllLangPackage_html_media_lang.mk is ending up in both per-language
helpcontent installation sets (as intended, via the instructions in
helpcontent2/CustomTarget_html.mk) and per-language languagepack installation
sets (which is unintended).  This needs to be fixed with a follow-up commit.

This is the helpcontent2 part of a commit spanning core and helpcontent2.

Change-Id: Ie7916b75eee0dde3106e784d19e99fde5bb93195
Reviewed-on: https://gerrit.libreoffice.org/54749Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Idb0c27933b42f3aef65f0bce098f9bd7a81dc034

Change-Id: I9f42fd6179c0a64cc14a051ca7c9e2ed9300f5c8

Change-Id: I876ffc1511b2115562039b97961c28d7b30e2c06
Reviewed-on: https://gerrit.libreoffice.org/54730Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

and

coverity#1399120 Uncaught exception

Change-Id: If411cd6a392636c6ac99f1ae330b16611b24df93

Change-Id: Iba303276f9c9564eb4afe2a9238b009dc8bbc9d3

and reduce unnecessary work in ScRangeList

Change-Id: I0ee767fe28571f75f8a2ff980cea27c97c9797dc
Reviewed-on: https://gerrit.libreoffice.org/54705Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This patch is sponsored by ULAKBIM/Pardus project.

Change-Id: I5ecca4f58ec0ecf6a639153b52a4424af1966820
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/54687Tested-by: Jenkins <ci@libreoffice.org>

Found with bin/find-unneeded-includes
Removal proposals are dealt with here
With fallout management as necessary

Change-Id: Iaef9eec626334c480dd5a2def63bb476350ceebb
Reviewed-on: https://gerrit.libreoffice.org/54617Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I4d2ca93ff01e27ee3400adab230cb8679aacdaa9
Reviewed-on: https://gerrit.libreoffice.org/54727Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I0635a5f4f02a1de222656133bca1ff2da8ce59f6
Reviewed-on: https://gerrit.libreoffice.org/54711Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

FullScreen in this context means a top-level window that is both
full-screen from the desktop environment's perspective (which
depending on the desktop environment might simply mean that it is as
large as possible to fill its screen, leaving any system menus etc
visible), *and* is in LibreOffice's full-screen mode (with no toolbars
or other UI elements except the document contents visible).

Not yet used, will be used in follow-up commits.

Change-Id: Ia6f86e0d2a7c5a621c6f19d897d3b17ba6bfb8b4
Reviewed-on: https://gerrit.libreoffice.org/54733Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

...on indirect dependencies too.

Here a self reference to any formula-group
means if there are any references in a formula
(of the formula-group itself or any of its dependencies)
that points to any element inside the formula-group.
If there are any self-references, then that formula-group
can't be computed in parallel.

For example, with this patch we can detect the following case:-
  Suppose the formula-group that we want to check is:
  "=(F2+G2-10)*10.0" spanning A2:A100. Let the formula-group
  starting at F2 be "=A1*0.1-10". The indirect dependency
  formula-group starting at F2, references back the elements of
  our original formula-group at A2. This makes the F.G at
  A2 unsafe for parallel computation.

Concretly, this patch fixes a recalc crash on tdf#63638/1

Change-Id: I7b999a34571b191d2f70da6a3831f78b24a6b0a7
Reviewed-on: https://gerrit.libreoffice.org/54433Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I660bc8efd441e9fc5b6f83f69dc632a26add193b
Reviewed-on: https://gerrit.libreoffice.org/54712Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

tdf#50774 has an example document which was broken by 6.1 commit
8e9e705d.

Reverting does a couple of things:
-go back to previous behaviour (right or wrong) - no regression.
-gives an opportunity to find documents broken by reverting -
i.e. it will give an indication as to which state has more broken
docs. Can be re-visited in 6.2.
-gives me an option to escape from this horrible mess without causing
a regression in a production release of LO.

Change-Id: Ib594b76d5533a0c4807cf70ef706c107e52cddcf
Reviewed-on: https://gerrit.libreoffice.org/54293Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>