Change-Id: Ie2860cf1a279d08cf8a08b72c20539ddaa00be15

Change-Id: I29633cfe7b378796bec5fe822941193ded8a9aa9

The original OUString is destroyed along with its containing
object part way through the call to PaletteManager::PopupColorPicker(),
so a copy must be taken

Change-Id: I8417ff23a17003e80a4f65e0cf1ad2a8dda5386c
Reviewed-on: https://gerrit.libreoffice.org/12031Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic705fe6bb7c3b9bae4b09d0b487f48056675b4b8

regression from...

commit 06562c67
Date:   Sat Oct 18 10:36:36 2014 +0200

    convert SV_BMP_ constants to enum

    Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05
    Reviewed-on: https://gerrit.libreoffice.org/12018Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I29486e8fe17d9e06e01c33f93d99ffc6ae3d017c

Change-Id: If6b9355c6992eb6651f71c0944a93af0856ef1c7

Change-Id: I1377dfded1246c8e96db3addc28489886c7f2d99

This reverts commit 53c83670.

because it means that all disabled buttons get their "click" delivered
so disabled buttons are only visually disabled.

e.g. writer: insert->table->autoformat, click on the disabled "rename" or "add"
or "remove" and the sub dialog appears. Or in calc insert->object->chart and
click on the disabled "back" -> crash

The VAxisBase::m_xNumberFormatsSupplier refers to the ChartModel itself,
and apparently that is a cyclic reference.  Naively using the
ChartModel's m_xNumberFormatsSupplier in
ChartView::impl_createDiagramAndContent() because it will later be passed
to AxisHelper::getExplicitNumberFormatKeyForAxis(), which expects to be
able to convert it to a ChartModel.

Since passing around the ChartModel as an XNumberFormattingSupplier is
sort of un-intuitive anyway, refactor some methods to use XChartDocument
instead, and only create the VPolarAxis / VCartesianAxis with the
ChartModel's m_xNumberFormatsSupplier.

The drawback is that if ChartModel::attachNumberFormatsSupplier()
is called after ChartView::update() has created the axes, it may not
have an effect on them; not sure if that is a real or hypothetical
problem.

Change-Id: Ib5f0d5882b85adaf44f80e086f19178b3e64882f

Change-Id: If5aac87876b139bfb394ec124136de131c3518ae

Initially this didn't help at all, but with some tweaks it now finds
the leaked ChartModel as the #3 and #4 printed stacks, with a very bad
score of 40.

Change-Id: I918bcb64bad0b9432bf2b670b03915836fb34a11

Change-Id: I153d92e94319bd1e7f0d425288f184bd8d13542d

Change-Id: I2738ea2a5c6714d8e43c06aa2eb4c53500a5afe9

Change-Id: I2e7c2206872dfe22c77555f3a14ea2a10c2453c2

Change-Id: Ie36cc7444fe5d685393e06d3d3a3a8d827b2f775

...and only use getCaughtException as first statement in catch block.

Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910

Also:
* Something I missed from the HIG: standardize Help button position

Change-Id: Iaac65bd277d87ff58883f287808a5c5b804cc04e
Reviewed-on: https://gerrit.libreoffice.org/12015Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...not allowing certain o3tl::is_typed_flags::Wrap conversion operators to be
explicit, thus causing ambiguities here.

Change-Id: I5108885229eb185ceac57042e67405b393cdcf3b

Change-Id: Ie24687cd1c54b1fed04745c83f507c17a5574175

Change-Id: Id128f19dee056189a34a02156fd0bf3ac14c2454

Change-Id: Ia4ee76743c640c0c5b92ec169e619f6c8788480e

... for now"

This reverts commit 599473a13e3c5ba669d995c913ad415bd674a16c.

moggi says the unspecified crash happened with the tests following the
comment in chart2import.cxx:75, but the tests run fine in valgrind now.

The commit creates a memory leak in the CppunitTests as
SfxBaseModel::dispose() returns early, because mbDisposed is set.

Change-Id: I987dce6a4090784d166a4a3b2e7f9e2c0cddd289

We used to ignore this element with a "false" logical attribute, but
that causes a problem when an inherited style wants to explicitly
disable this element from a parent style.

Change-Id: I2fc4c5b2002987d44679d863ea3f19114b9ab7a4

Change-Id: I6101099c57d429987e06bca0652c843f4a94f8cc

Change-Id: I676de4ca59524e858bf24133d7c54f424922ef26

Change-Id: I9f03ecc6d67ad77ccb0d5240fe0b5968c8063bd3

This reverts commit a2deca9d: config_map had
been introduced on purpose with bfb97833
"configmgr: faster / simpler compare for keys."

Change-Id: I3ae0edc4d23977c6537bd2f462f90a702266de6d

Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b

Change-Id: Idb6337bed1c32444f9644d54eba5240f09c13ef6

Change-Id: I2cb764db97469654f977de63e273874d43745bf8

Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9

Change-Id: I276535b007bbb55555148d5937076b86da5de825

Change-Id: I9a16e24e79d22b0af1710d6ac25eaa5fb19c71ff
Reviewed-on: https://gerrit.libreoffice.org/12047Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I2f183bc0bb9c67e3873e13a4bdbc57be9471b8a3

Change-Id: I2ba45c49fb00fdd53b8e388e25df503e82c2332e

Change-Id: I54025f46394ec1b16443ba75ff9edf9d8e1f6738

Change-Id: Iba88c7e54ba83132a859124d51f88be72cb3e3e1

Change-Id: I175050b5ab66f4eeaa658f0aab1739b175d38d51

Change-Id: If23396c545e7add653fa9e5ac6e544aaa794120d

Change-Id: I90750c51ce3b38defdba7ecdb7734172983efa8c