Change-Id: Id6bb9ed65f94a56e82c0c4a6fee241dec4eb9138

Change-Id: I584e6d0c34f972c1ae5105a80d201f32dd8590d9

Change-Id: Id87e120d80b823db9be989db7a7b2ac383304f77

Change-Id: I1c4a0897c46458d6ee086e7f72ab8a03aa54c9e0

Change-Id: Idfd4081245905cdc88ad0da195b81be7e34ebf21

Change-Id: If20e0ebf5410af0b7655f36f7e4fc06f53d8b14b

Change-Id: I4857bb3a1804d4cd53c3e25a7586bd68ab95a202

This reverts commit 7cf9ea71ad1364d00eaca95b309cc6c0f35cf6cb.

We can do this on the main thread.

Change-Id: I58a32d9e0ce2599c5822903393a5b698233599df

This reverts commit fc04b55f7f96a4f70f31c145dafd44c1d9276a41.

Change-Id: I31e2cf3a479e385aa0fca4678a3a2c7fa6cc4b5f

Change-Id: I995668d1e183dc0dae4f354889bc13053e858723

They are accessed from multiple threads frequently.

Change-Id: I3f9720ede076109efe0b7eaa4a05dd50f2e38102

Change-Id: Ic8508f693f8a6e9bae513d6b5b6eaaaae618194b

Change-Id: Ie3208844b523463954c482d080f02d726ae749f9

Just set this once before spawning multiple worker threads.

Change-Id: I9cb60721f633f939d4a95f1d80e2ed8e4542a8fa

Change-Id: I40b4c0ff90055e4d388f97fbe19be30d3f66b1b4

Change-Id: I90fa5aff94de38d950a78811dad301b91ced89f3

Otherwise the background will paint over the graphics...

Change-Id: Ic62c563026daa9c4173148cd68652d8aba608089

The image I got from TDF wiki.

I tried to show the text semitransparent also, but set font color
with any alpha degree (eg. setTransparency(254) ) made it invisible.
Maybe just a gray shade?

Change-Id: Iaf7efb8433e9db03862825148ed2013588a5468f
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com>

- from libxslt-configure.patch:
  * drop config.sub Android stuff (obsolete)
  * drop MinGW archive checks (obsolete)
  * split out libxslt-config.patch.1
  * split out libxslt-freebsd.patch.1
- drop libxslt-aix.patch:
  presumably don't need special check for V7BETA since it's released now
- drop libxslt-mingw.patch (it's for msys build so obsolete)
- drop libxslt-win_manifest.patch:
  this can just be passed on configure.js command line so no need for a patch

Change-Id: I8a2cad0a70a86ba1dffbe3c8fce60babb70a61f6
Reviewed-on: https://gerrit.libreoffice.org/6641Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

- from libxml2-configure.patch:
  * drop config.sub Android stuff (obsolete)
  * drop Makefile.in disabling targets for Android (hypothetically obsolete)
  * drop xmlversion.h changes (pointless - configure.js generates it)
  * split out libxml2-freebsd.patch.1
  * split out libxml2-config.patch.1
- drop libxml2-long-path.patch (integrated upstream)
- drop libxml2-gnome599717.patch (obsolete)
- drop libxml2-xpath.patch (obsolete)
- drop libxml2-latin.patch (obsolete)
- drop libxml2-aix.patch:
  presumably don't need special check for V7BETA since it's released now
- drop libxml2-mingw.patch:
  actually appears to patch a MSVC-specific part of the file so is
  obsolete anyway

Change-Id: I87bf8968bd4a554852a2791420a5d0db822beeaa

Change-Id: I963549beb45112504d5edfef169d4970fbec822d

The type "application/macwrite" does not appear to exist, but
"application/macwriteii" is officially registered at IANA:
https://www.iana.org/assignments/media-types/application/macwriteii

For Freehand the "application/x-freehand" has just 6 hits on Google
whereas Adobe recommends "image/x-freehand" on
https://www.adobe.com/support/config.html

Change-Id: I36d498888601778b1359ff58ee60b25af436a74e
Reviewed-on: https://gerrit.libreoffice.org/6639Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>

Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2

- look at more interesting packages on lanuchpad, not just libreoffice.
- the searchTasks method by default does not return closed tasks,
  and there does not appear to be a documented wild card search,
  so stupidly enumerate all possible status.

Change-Id: I51691506874722a1d8eea4755513edf50164cf9d

Change-Id: I208a74d11945986d0712970999dbd33c03efe488

... which are officially registered on
https://www.iana.org/assignments/media-types/application

... plus some more non-standard ones for FreeHand, Keynote, ClarisWorks.

For Apple Keynote there are 2 different ones that appear to be widely
used.

Change-Id: I26d4a85733a744188cc87a78fdba0d9d3f44da96

... and also fix the print functions that shouldn't output a newline.

Change-Id: Ifd866cb33b3ef9a2e83625ed03d5cb836c1ba56b

Change-Id: Ib97256e3c00db61e53998571114dab5d74ce18be

Change-Id: I735005f2e311abf7b64cce6b67002fe6e0d60281

Change-Id: I62e953c886886158f227362fef7048459192217b

Change-Id: Ib188b2a8dbfbc91f2e89952d6df2c0c357091a78

ScGlobal::FindUnquoted
  - return -1 instead of STRING_NOTFOUND
  - change return type from xub_StrLen to sal_Int32
  - remove last two parameters because noone was using them

ScCompiler::GetDocTabPos
  - return -1 instead of STRING_NOTFOUND
  - change return type from xub_StrLen to sal_Int32

inputhdl.cxx/lcl_MatchParenthesis
  - return -1 instead of STRING_NOTFOUND
  - change return type from xub_StrLen to sal_Int32
  - make function static, no-one outside this module is using it

Change-Id: I141ab082db180ff2da5a7ca6813cd3607b9ea7f7

And convert some xub_StrLen to sal_Int32 in the same patch of code.

Change-Id: I72c92bf9413dbca14688cb8d46a023df49a5d41a

The code was interchangably using the two anyway.

Change-Id: I4f3fe8f1d699a9725bbcce0138a9d978a1eff28a

...otherwise running e.g. "soffice slot:5410" would crash with

> Invalid read of size 8
>  at 0x712DCCC: SfxItemSet::~SfxItemSet() (svl/source/items/itemset.cxx:317)
>  by 0x65B4990: SfxAllItemSet::~SfxAllItemSet() (include/svl/itemset.hxx:166)
>  by 0x65B2CC4: SfxAllItemSet::~SfxAllItemSet() (include/svl/itemset.hxx:166)
>  by 0x674CD94: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:784)
>  by 0x674CF46: SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:376)
>  by 0x674D03E: non-virtual thunk to SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:378)
>  by 0x4F21028: desktop::DispatchWatcher::executeDispatchRequests(std::__debug::vector<desktop::DispatchWatcher::DispatchRequest, std::allocator<desktop::DispatchWatcher::DispatchRequest> > const&, bool) (desktop/source/app/dispatchwatcher.cxx:581)
>  by 0x4F2CDB3: desktop::OfficeIPCThread::ExecuteCmdLineRequests(desktop::ProcessDocumentsRequest&) (desktop/source/app/officeipcthread.cxx:1061)
>  by 0x4EE3159: desktop::Desktop::OpenClients() (desktop/source/app/app.cxx:2493)
>  by 0x4EE14E7: desktop::Desktop::OpenClients_Impl(void*) (desktop/source/app/app.cxx:2012)
>  by 0x4EE0127: desktop::Desktop::LinkStubOpenClients_Impl(void*, void*) (desktop/source/app/app.cxx:2007)
>  by 0x927B9E6: Link::Call(void*) const (include/tools/link.hxx:123)
>  by 0x999AD8F: ImplHandleUserEvent(ImplSVEvent*) (vcl/source/window/winproc.cxx:1976)
>  by 0x9997E64: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (vcl/source/window/winproc.cxx:2591)
>  by 0x99ADCFC: SalFrame::CallCallback(unsigned short, void const*) const (vcl/inc/salframe.hxx:243)
>  by 0x99ACD47: SalGenericDisplay::DispatchInternalEvent() (vcl/generic/app/gendisp.cxx:91)
>  by 0x1783C027: GtkData::userEventFn(void*) (vcl/unx/gtk/app/gtkdata.cxx:935)
>  by 0x1783C13D: call_userEventFn(void*) (vcl/unx/gtk/app/gtkdata.cxx:945)
>  by 0x37B6847E05: g_main_context_dispatch (usr/src/debug/glib-2.36.3/glib/gmain.c:3054)
>  by 0x37B6848157: g_main_context_iterate.isra.22 (usr/src/debug/glib-2.36.3/glib/gmain.c:3701)
>  by 0x37B68481FB: g_main_context_iteration (usr/src/debug/glib-2.36.3/glib/gmain.c:3762)
>  by 0x1783AC3F: GtkData::Yield(bool, bool) (vcl/unx/gtk/app/gtkdata.cxx:576)
>  by 0x1783FEF6: GtkInstance::Yield(bool, bool) (vcl/unx/gtk/app/gtkinst.cxx:425)
>  by 0x9299F40: ImplYield(bool, bool) (vcl/source/app/svapp.cxx:364)
>  by 0x9295B52: Application::Yield() (vcl/source/app/svapp.cxx:396)
>  by 0x9295B1F: Application::Execute() (vcl/source/app/svapp.cxx:345)
>  by 0x4EDE2C9: desktop::Desktop::Main() (desktop/source/app/app.cxx:1715)
>  by 0x92A6397: ImplSVMain() (vcl/source/app/svmain.cxx:162)
>  by 0x92A7B55: SVMain() (vcl/source/app/svmain.cxx:198)
>  by 0x4F35980: soffice_main (desktop/source/app/sofficemain.cxx:85)
>  by 0x40098C: sal_main (desktop/source/app/main.c:48)
>  by 0x400966: main (desktop/source/app/main.c:47)
> Address 0x1d719700 is 0 bytes inside a block of size 32 free'd
>  at 0x4A078DE: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>  by 0x6A02EA1: CntItemPool::~CntItemPool() (sfx2/source/explorer/nochaos.cxx:123)
>  by 0x6A02C85: CntItemPool::Release() (sfx2/source/explorer/nochaos.cxx:154)
>  by 0x6A02BF8: NoChaos::ReleaseItemPool() (sfx2/source/explorer/nochaos.cxx:89)
>  by 0x65E1A31: SfxApplication::Deinitialize() (sfx2/source/appl/appquit.cxx:147)
>  by 0x65A29B0: SfxApplication::~SfxApplication() (sfx2/source/appl/app.cxx:242)
>  by 0x65A2828: SfxApplication::~SfxApplication() (sfx2/source/appl/app.cxx:223)
>  by 0x65C021C: SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) (sfx2/source/appl/appinit.cxx:121)
>  by 0x65C033E: non-virtual thunk to SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) (sfx2/source/appl/appinit.cxx:123)
>  by 0x1F176DD2: framework::Desktop::terminate() (framework/source/services/desktop.cxx:353)
>  by 0x1F177E1B: non-virtual thunk to framework::Desktop::terminate() (framework/source/services/desktop.cxx:357)
>  by 0x4F217FD: desktop::DispatchWatcher::dispatchFinished(com::sun::star::frame::DispatchResultEvent const&) (desktop/source/app/dispatchwatcher.cxx:637)
>  by 0x4F2190E: non-virtual thunk to desktop::DispatchWatcher::dispatchFinished(com::sun::star::frame::DispatchResultEvent const&) (desktop/source/app/dispatchwatcher.cxx:640)
>  by 0x674CD77: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:782)
>  ...

Change-Id: I6b4fb9b6f0d2afc9caecf3dd5355d11edb6abbe8

Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f

Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b