See commit f33eb08a for details

TODO: reimplement defaults to be taken from the Drivers.xcu, not from
ODatabaseModelImpl::getDefaultDataSourceSettings.

TODO: always write settings, even if they are equal to defaults (unless
they are schema defaults) - that will allow to change a default, and not
break existing configurations.

Change-Id: Ic0fa9a03bf801aeca3e6373eb7019f5ad7e8eb46
Reviewed-on: https://gerrit.libreoffice.org/69076
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Regression from the commit 740b9978
"tdf#120413 LibreLogo: handle complex Logo expressions".

Change-Id: Iaae54efacf86a03a6611c154a40068ed058d43e7
Reviewed-on: https://gerrit.libreoffice.org/69138
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Reverted as suggested in https://bugs.documentfoundation.org/show_bug.cgi?id=123582#c4

This reverts commit 31ba2a6b.

Change-Id: I574bacd227bdd6b0364251b060327a3e5f820965
Reviewed-on: https://gerrit.libreoffice.org/69132
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

As registered at IANA: https://www.iana.org/assignments/media-types/media-types.xhtml

Change-Id: I6d66f2cd1f96e487562a1042583e08a5beefc262
Reviewed-on: https://gerrit.libreoffice.org/69125
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Anz -> Count

Change-Id: I26f85cee2dff12377dbf0b21f8ad7b98d15b95c3
Reviewed-on: https://gerrit.libreoffice.org/69103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iaa16fd2c04f5168bcb58d71d48f563ae1856a901
Reviewed-on: https://gerrit.libreoffice.org/69145
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2ee16355545c059ad5e58c0097d8097df3eea426
Reviewed-on: https://gerrit.libreoffice.org/69139
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Iea9ca5fed98f1040dd697324f9818d0014f5f79f
Reviewed-on: https://gerrit.libreoffice.org/69149
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Create a brand new odb file (embedded HSQLDB)
Create a simple table in it
Launch Query wizard, you'll see these on console:
...
at com.sun.proxy.$Proxy69.addNew(Unknown Source)
at com.sun.star.wizards.common.NumberFormatter.defineNumberFormat(NumberFormatter.java:96)
at com.sun.star.wizards.ui.FilterComponent.addNumberFormats(FilterComponent.java:504)
at com.sun.star.wizards.query.QueryWizard.buildSteps(QueryWizard.java:233)
...

...
at com.sun.proxy.$Proxy69.addNew(Unknown Source)
at com.sun.star.wizards.common.NumberFormatter.defineNumberFormat(NumberFormatter.java:96)
at com.sun.star.wizards.ui.FilterComponent.addNumberFormats(FilterComponent.java:506)
at com.sun.star.wizards.query.QueryWizard.buildSteps(QueryWizard.java:233)
...

Root cause is FilterComponent.java uses "YYYY-MM-DD" and "YYYY-MM-DD HH:MM:SS" (lines 504 and 506)
If it's ok for English locales, xNumberFormats.queryKey calls fail at least for French locales.
Use addNewConverted instead of addNew method to take into account the difference of locales
and avoid these stacktraces

Change-Id: I5ef6325b8a213ae6758e378c4d3b8560c117042f
Reviewed-on: https://gerrit.libreoffice.org/69131
Tested-by: Jenkins
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

Move XEnumerationAccess Java test to C++ for ScTableColumnsObj.

Change-Id: Icb2b61a323e69bfc5d7cef1f574bac79eaa2b220
Reviewed-on: https://gerrit.libreoffice.org/69147
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XElementAccess Java tests to C++ for ScTableColumnsObj.

Change-Id: Id7128fbf5fe885045173d62eb954959e1f8aca44
Reviewed-on: https://gerrit.libreoffice.org/69146
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XIndexAccess Java tests to C++ for ScTableColumnsObj.

Change-Id: Id5b6296e405c108129df0bce4ed4204ede320f3c
Reviewed-on: https://gerrit.libreoffice.org/69144
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XNameAccess Java test to C++ for ScTableColumnsObj.

Change-Id: I3c9acde1b9e390c6a088bde567996728db855c2e
Reviewed-on: https://gerrit.libreoffice.org/69143
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XNameReplace Java tests to C++ for ScStyleFamilyObj.
Fixes i#23594 by creating a new "com.sun.star.style.CellStyle"
rather then using an existing one.

Change-Id: Ie42e627020aff475173af5bc014bc28d7a11ec56
Reviewed-on: https://gerrit.libreoffice.org/69140
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

The Galaxy theme was the only odd duck to use 26 × 26 pixel icons.
We’ve removed it, but the Change Icon dialog was still reporting
this misleading value.

Spotted by Rizal Muttaqin.

Change-Id: I4f82727b93239a32f7eab5473baa3b8705abde29
Reviewed-on: https://gerrit.libreoffice.org/69148
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

If the user explicitly gives a background color to the field portion,
then respect that, don't overwrite with the field shading (the UI does
the same).

Change-Id: I7c35618f82a37ef1dd16c03b82651268767813af
Reviewed-on: https://gerrit.libreoffice.org/69127Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I12af13094df0952326656293fa96bf3e9c82d2e7
Reviewed-on: https://gerrit.libreoffice.org/69111
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I6d8b5ffa4b9db27335e771153119264216c0b8f7
Reviewed-on: https://gerrit.libreoffice.org/69084
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I77cc250197658fed57175b775976a3194050c0da
Reviewed-on: https://gerrit.libreoffice.org/69117
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4938ea338a71e3c83d4d847317ba49b9c7088561
Reviewed-on: https://gerrit.libreoffice.org/69116
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I34cb3f1739c6c3ee983be6ca0c70051a5fcfcb5d
Reviewed-on: https://gerrit.libreoffice.org/69115
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib4591197b17811a37b3a33f943fff03f1efd9550
Reviewed-on: https://gerrit.libreoffice.org/69114
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I672ea969efccf660d9a23847b26535031144e3da
Reviewed-on: https://gerrit.libreoffice.org/68473
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: Ic37967dedb2378106db2f3f437781c8ad20cad56

To me it looks like pArr is leaked in the bAgain = true case, or the code
is rather misleading.

Change-Id: I41ea26052671f127141d5421d0c446da4606da28
Reviewed-on: https://gerrit.libreoffice.org/69091
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The max-opencl-group-length ugly hack splits too long cell groups
into smaller ones, but 60a66bd5 accidentally made the temporary
group delete the array if the HW triggered this hack.
Testcase: 'SC_MAX_GROUP_LENGTH=1000 make CppunitTest_sc_copypaste'

Change-Id: I47ab08cd8511ad66e887c3c2d5eef25b08858c60
Reviewed-on: https://gerrit.libreoffice.org/69090Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I813b166a8c4658e08b185a43a464b6b370b62c66
Reviewed-on: https://gerrit.libreoffice.org/69099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

as opposed to the SfxTabDialogController case which already works

Change-Id: If72ca14803e3ff4d716ecab56454a8e2324f460c
Reviewed-on: https://gerrit.libreoffice.org/69098
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4bee58ab65a45d140fcb44a1def71ff505b78539
Reviewed-on: https://gerrit.libreoffice.org/69097
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6a363142945fc0b77e6c84649d32ffc27a5e2f04
Reviewed-on: https://gerrit.libreoffice.org/69082
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Use range-based loop or replace with STL functions

Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76
Reviewed-on: https://gerrit.libreoffice.org/69010
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Fixes CVE-2019-7310.

Add patch to fix CVE-2019-9200 too.

CVE-2018-20662 looks irrelevant because we don't build pdfunite tool.

Change-Id: I5e7ddabbb341f6bfefb376d552b50c4006f41906
Reviewed-on: https://gerrit.libreoffice.org/69094
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

==26032==ERROR: AddressSanitizer: odr-violation (0x7f3b41f544a0):
  [1] size=96 'vtable for svgio::svgreader::SvgCharacterNode' master/svgio/source/svgreader/svgcharacternode.cxx
  [2] size=96 'vtable for svgio::svgreader::SvgCharacterNode' master/svgio/source/svgreader/svgcharacternode.cxx
These globals were registered at these points:
  [1]:
    #0 0x43a090 in __asan_register_globals.part.13 (workdir/LinkTarget/Executable/cppunittester+0x43a090)
    #1 0x7f3b31e6e86d in asan.module_ctor (instdir/program/libsvgiolo.so+0x6186d)

  [2]:
    #0 0x43a090 in __asan_register_globals.part.13 (workdir/LinkTarget/Executable/cppunittester+0x43a090)
    #1 0x7f3b41da5bad in asan.module_ctor (workdir/LinkTarget/CppunitTest/libtest_svgio_read.so+0x82bad)

Change-Id: Id2b32936d603ac2ed7df12d7e6f3ade094621578
Reviewed-on: https://gerrit.libreoffice.org/69092Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins

DispBlanksAs=gap mode of OOXML is different from
treat-empty-cells=leave-gap mode of OpenDocument,
because formulas with no numerical values and
strings are no gaps in OOXML line charts, but zeroes.

When the data source of the line charts contains
formulas with no numerical values or strings,
but it doesn't contain empty cells, as a workaround,
the charts will be imported with the
treat-empty-cells=use-zero setting to get the same
line chart as in MSO.

Note: now result of ScChart2DataSequence::getData(),
a sequence of Any values contains UNO void values for
empty cells instead empty strings, allowing the
distinction of the empty cells and cells with empty
string values.

Change-Id: If9a101d66b5b750051928fa7b10b05cea6040071
Reviewed-on: https://gerrit.libreoffice.org/69054
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Each plugin currently uses its own recursive AST run, which adds up.
This patch adds another shared plugin which internally contains all
(suitable) plugins and dispatches to them from the same one recursive
run. This patch converts ~25 plugins and for starmath's accessibility.cxx
reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any
plugins). As there are almost 50 more plugins to go, this can theoretically
result in 4.56s final time, although probably not all plugins can be
that easily converted, if at all.

This mostly requires very little change in many plugins (see e.g.
BadStatics), some even work without any functionality change (e.g.
CharRightShift). Traverse* calls require some changes but are often
not that difficult. WalkUp* probably can't be supported, although some
plugins can(?) possibly be adjusted to not rely on them. And of course
some plugins can be left as they are, using their own recursive run.
See description at the top of generator.cxx for description of how to
convert a plugin.

The sharedvisitor.cxx source is generated based on scanning relevant
plugin sources using a clang-based scanner/generator. The generated
source is intentionally included instead of getting always generated,
as the generating currently takes some time, so it should get updated
in git whenever a change in a plugin triggers a source change in it.

Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01
Reviewed-on: https://gerrit.libreoffice.org/68026
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I3b32a8f657078ba76d92bee7bff6bab1b226e31e
Reviewed-on: https://gerrit.libreoffice.org/69083
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Separator added before the popup menu
Extends patch 9ccdb944

Change-Id: Ie7d0beb45004985b25ae41458399ec979ca474ce
Reviewed-on: https://gerrit.libreoffice.org/69078Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

Regardless of the value of the View -> Field Shadings option, shadings
were always lost when saving to HTML.

Implement handling of this in the HTML conditionally, so in case that
UI option is on, then shadings are preserved in the HTML result;
disabling that option results in the old behavior, though.

Change-Id: I1bd19f4c6e22aff2f84fac25f0a506ad0127cc3c
Reviewed-on: https://gerrit.libreoffice.org/69081Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

This code was automatically converted from Java to Python.
It might be used at some point if the remaining java wizards
are converted to python, however that's not the case as
per today, thus this code is unused.

Let's get rid of it as it might create confusion

Change-Id: Ic58ade24b10f7a0654b3e8ae39f6afa712589c3d
Reviewed-on: https://gerrit.libreoffice.org/67868
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

This table has style:row-height="2.014cm" on its 2nd row (1142 twips).

In the 1st call of FormatLayoutTab(), the 1st row of the table is split
and the 2nd row moves to the next page.

In the 2nd call of FormatLayoutTab(), the 1st row grows from 400 to 454
twips, presumably due to the style:min-row-height="0.801cm" on it.

In the 3rd call of FormatLayoutTab(), the GetFollow()->ShouldBwdMoved()
returns true and the 2nd row moves back again, because
SwTabFrame::CalcHeightOfFirstContentLine() determines the height of the
2nd row as the maximum height of cells with rowspan=1 (400 twips), which
fits on the 1st page, ignoring the style:row-height="2.014cm" on the row
(1142 twips), which does not fit on the 1st page.

This loops until "LoopControl_1 in SwLayAction::InternalAction" is
triggered, and then eventually stops in 5.4 but loops even more since
commit 18765b9f, for unknown reasons.

Change-Id: I1a5c50d21c241e593419e63644ee758cdd9ed319
Reviewed-on: https://gerrit.libreoffice.org/69061
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>