cell values are added in parentheses to make sure negative values are handled
correctly

Change-Id: I7366493e3cd6c25607e311d4b610ef8aa704a8bb
Reviewed-on: https://gerrit.libreoffice.org/19821Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
(cherry picked from commit 0bd2a5ee)
Reviewed-on: https://gerrit.libreoffice.org/19826Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 74d6d268)

...as ImpEditEngine::ImpRemoveChars (editeng/source/editeng/impedit2.cxx) calls

  pCurUndo->GetStr() += aStr;

Regression introduced with d5e11f5f "convert
editeng/source/editeng/editundo.hxx from String to OUString."

Change-Id: Iab3dd3b861bca715a90e89e3a63a6f298657367d
(cherry picked from commit e31205f3)
Reviewed-on: https://gerrit.libreoffice.org/19857Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 5889d97f)

Change-Id: I3bb5980e53b5a9d922ca401dd9927ee64f7cef98
Reviewed-on: https://gerrit.libreoffice.org/19843Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit a148fe14)
Reviewed-on: https://gerrit.libreoffice.org/19845Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit e5a78bec)

Our current Maven based Java toolchain produces JARs, which
have a different "version needed to extract" in the ZIP local
and central directory header.

I had a look at 7zip and unzip and they already ignore the version
but compare other data LO already ignores - sig. The "standard"
document from PKWARE doesn't help.

So just compare the file path and calculate the data offset and
otherwise ignore all (duplicated) information from the local index
and rely on a correct central directory entry. Various programs
produce(d) "broken" ZIP files; even LO at some point (see git log).

Change-Id: I8d63abb0d49a1087c7654f401b62355c147c3118
Reviewed-on: https://gerrit.libreoffice.org/19779Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 912c0344)
Reviewed-on: https://gerrit.libreoffice.org/19809Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 7ae36d37)

instead of bittwiddling which ends up trying to resolve the
system language

(cherry picked from commit a1ff0745)

more tdf#76964 fall back to primary language via getLanguage

(cherry picked from commit 97893e56)

sw: fix SwUiWriterTest pointlessly loading an "empty.odt" ...

... instead of just creating a new document.

(cherry picked from commit 98ddd7a3)

Change-Id: I545bd5e39f99003ddedf3c90031e8b818edc1de2
Reviewed-on: https://gerrit.libreoffice.org/19545Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit de1cb403)

With commit ebf767ee, some previously
hidden bugs manifested themselves, this is one of them.
The margin size calculated incorrectly when border offset was from
page. The border is drawn from the margin inwards, so the margin
should be equal to OOXML w:space attribute, and border distance
should be OOXML page margin - border distance - border width.

Incorrect calculation gave negative margin, with IllegalArgumentException
thrown in SfxItemPropertySet::setPropertyValue.

Change-Id: Ifcf4a348e975df53410933aab3684d17f68b688c
Reviewed-on: https://gerrit.libreoffice.org/19586Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
(cherry picked from commit 061d98cc)

LOOL requires to filter a requested command values message

Change-Id: If2eeb9990e0f9aec6410a70f7a6c132c080bda80
(cherry picked from commit c615699a)

Change-Id: I977d1fbedb1b784cb95273184ec5e5a7fa156eef

I still have no idea what is the root cause here (why the accellerators do not
work 'automagically') - I suspect it is because we don't have a shell there,
and instead only a vcl::Window, or something like that :-)

Either way, when we handle the accellerators already in PreNotify(), it works
as expected, so let's live with that for the time being.

(cherry picked from commit 51c14b1c)

Conflicts:
	sfx2/source/dialog/backingwindow.hxx

Change-Id: Id050fd8f5fff38914821cb64eaa3ae7281fc6d50

Change-Id: I1730f23e920702ea4f06b4403c47e0167fe758c5

This essentially reverts commit 8865ed2e
and implements a different fix for tdf#90812:
If the formatting of entire cell is uniform, remove formatting of the
leading text run and create corresponding cell style. In all other cases,
write out formattings for each individual run.

Change-Id: I7724b7a474f773f2cdc39e9150d843642fb05bbe
Reviewed-on: https://gerrit.libreoffice.org/19811Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit dd971d00)

This follows the syntax for .uno:ViewRowColumnHeaders
(which was implemented somewhat concurrentl with CellCursor)

Change-Id: I8ef03a969abc1716a0e95d95fb7043d75910c828
(cherry picked from commit e7e0d46d)

This allows the client to rerequest the current cursor position,
which is necessary e.g. on zoom-level changes.

Conflicts:
	desktop/source/lib/init.cxx
	sc/inc/docuno.hxx

(cherry picked from commit 2bcaffd1)

Conflicts:
	sc/inc/docuno.hxx

Change-Id: I10d81e220a56a36e2ec0c59005cd1d4f134857d5

I.e. single click selects cell, typing activates the EditView
(and hides the cell cursor). (Previously: single click activates
the edit view, text cursor is shown, and no clean way of hiding
the cell cursor again.)

(cherry picked from commit f859dac5)

Conflicts:
	sc/source/ui/view/gridwin.cxx

Change-Id: I184630277e8935e9f8a97a856191497ec5d62111

As of a1605d68 we reset the zoom
level to the default when processing LOK mouse events. The exact
cell cursor position is dependent on the zoom level (due to the
rounding in the cell position summing calculations), hence we need
to make sure we have the correct zoom level for those calculations
(or else the rounding errors will result in incorrect cell cursor
positions). Caching the zoom level and reusing it only here seems
to be the most efficient way of solving this for now.

(An alternative would be to only send the cell ID in the callback,
 and have the frontend then request the pixel positions together
 with the current frontend zoom level - however especially for
 LOOL minimising the number of trips is probably wise.)

(cherry picked from commit fab3c48a)

Conflicts:
	sc/source/ui/inc/gridwin.hxx

Change-Id: Iae3aabfd7ea9bec7057be7b63670885766870c4f

This only works correctly for the default zoom level - since
the updateLibreOfficeKitCellCursor call happens during the
internal / hidden rendering, it uses the internal zoom values,
which can differ from the tiled-rendering zoom values.

Conflicts:
	include/LibreOfficeKit/LibreOfficeKitEnums.h

(cherry picked from commit 79940606)

Conflicts:
	libreofficekit/source/gtk/lokdocview.cxx
	sc/source/ui/view/gridwin.cxx

Change-Id: Ie4f344fe771078fca10ad9d6f7a93e88fb93880a

Change-Id: I94ac57881dc3a3628413b9198ea750fdc282accb
Reviewed-on: https://gerrit.libreoffice.org/17278Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 3e3c5369)

Change-Id: I74bc0ee02279152bec9ecc54b0d948a6978fa6c8

the index variable m_FrameList used to reference the current frame uses
the state EMTY_FRAMELIST to mark as invalid, which is the max integer
number. Thus all usages have to be secured to not use m_FrameList
if set to EMPTY_FRAMELIST. This was missing in some places.
the max integer
number. Thus all usages have to be secured to not use m_FrameList
if set to EMPTY_FRAMELIST. This was missing in some places.

Reviewed-on: https://gerrit.libreoffice.org/19753Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Cherry-picked from f0cef70c

Change-Id: Ie1cf4ae2cb79d821f634ec78b621a2647abc61a8
Reviewed-on: https://gerrit.libreoffice.org/19787Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 6b3b080f)

Change-Id: I75354ffea2daede55b34e4cf3321d57196be3d9b
Reviewed-on: https://gerrit.libreoffice.org/19652Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c7a52086)

During import, as well during export, "0.--" must be considered
as 0 min decimal places

Change-Id: I33d06dd95c0678660bc0bb222972f82ef54f2c6e
Reviewed-on: https://gerrit.libreoffice.org/19647Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 3f970cf2)
Reviewed-on: https://gerrit.libreoffice.org/19781
(cherry picked from commit 18be99af)

(cherry picked from commit 50d48709)

Conflicts:
	sw/qa/extras/ooxmlimport/ooxmlimport.cxx

Change-Id: I977930d59ef1ae9ae8bd2dfa9a7f3816c46d982c
Reviewed-on: https://gerrit.libreoffice.org/19758Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 36fa2b8c)

Change-Id: Ib0eaba0767ff18d03464ba7d1ec1ffdd2ba3ca78

Added missing part from tdf#39080 to SwXViewSettings
to handle 'HideWhitespace' property

Change-Id: I8d8098810ba36b6ade6e4476464a72348ef4db8d
Reviewed-on: https://gerrit.libreoffice.org/18291Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit a1fd9730)

... PageMasterExportPropMapper

Make the properties optional, like XMLTextExportPropertySetMapper
already does.

(cherry picked from commit 18a712d2)

Change-Id: Iee5d8ac113360937d8f3a3b867a6e6c7a18bbfa4
Signed-off-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Id84259ff8bf27475d63c0ab31c4312bc78cb55d8

Change-Id: If2526647221fef2c6b18b21b589192239d8a89ad
(cherry picked from commit 2bed1867)

This simplifies both LOK API implementation and client code, and also
clients are no longer required to floor() the twip -> pixel conversion
result.

(cherry picked from commit 84dedf4f)

Conflicts:
	libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx

Change-Id: I63dbc05f53e8f7582b964c43d5da3aad51ede10d

Change-Id: Ifffa41c896f2126ee557636ae6d0106b3ab51c4d

Change-Id: Iaae0f4d1bd30e0439c39d9060bb2ad2dba4f16f8

Yay for unit tests! :-)

Change-Id: I06b3f929b53d5c03f5722acfdaf0eaf841325e34

Change-Id: I917d47478504dc6fafd3fc675fe8458690c7cc2a

Change-Id: Ib4234314705e8ffd770ecd23552e254aa32c8e3a

Change-Id: Ic024f8dd3aaf368877f5914c6106164508760da8
Reviewed-on: https://gerrit.libreoffice.org/19752Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 5ae015fc)
Reviewed-on: https://gerrit.libreoffice.org/19755
(cherry picked from commit 0da689ec)

VCL Image/Bitmap/BitmapEx instances must not have static life-time
because then they will be destructed after DeInitVCL() and that
likely segfaults.

(cherry picked from commit bf18f1b3)

Omitting the plugin itself, the fixes should be enough for release
branch.

Change-Id: I3ff8d32de729c971b190028094cb4efe206395e2
Reviewed-on: https://gerrit.libreoffice.org/19742Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit a93c08e8)

Change-Id: I305163b691a8fa51ef5da0c940c59c3a3440a2dc
(cherry picked from commit 96d03636)
Reviewed-on: https://gerrit.libreoffice.org/19738Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit f4b8ebbd)

Change-Id: I687a58e17ce30ced101c4585884106cff9b6292b
(cherry picked from commit 63e13695)
Reviewed-on: https://gerrit.libreoffice.org/19737Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 8fa03e0f)

(cherry picked from commit 9fbdb3d3)

Conflicts:
	cui/source/customize/cfg.cxx

Change-Id: I8955bee3ac2bb7a757c1f70dd46141833a068517
Reviewed-on: https://gerrit.libreoffice.org/19739Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 13ef923c)

FormatObjsAtFrm() returns false, indicating that the result is not
perfect, and the caller hopes that formatting all children of the frame
again will help. Make sure that in case that assumption turns out to be false, we at
least do not loop.

The loop limit is enough to make the original i#43771 bugdoc still laid
out properly.

(cherry picked from commit 51438e87)

Change-Id: Ife9bd99a628a72edb922d04e05081971b6adf340
Reviewed-on: https://gerrit.libreoffice.org/19407Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 47e8bcd7)

Change-Id: Ib3a1ccda738091466d5e2866823f64b254ed5bab
(cherry picked from commit 6e3c3625)
Reviewed-on: https://gerrit.libreoffice.org/19740Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
(cherry picked from commit c3495847)