Let's be sure that nMaxcolorIndex < 256

Change-Id: I349184ad92c8e7b10a90a32e093972bfaee52467
Reviewed-on: https://gerrit.libreoffice.org/6970Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia034c4a8cc034405c5ba4f7fc3a233a5efdadc74

Change-Id: I3a0f4cdfc8b229efb65d3aae94de9e1cabd002ec

Change-Id: I9542771fe3caf77757d81641752ab5463ead4deb

Change-Id: Iade61f598e1122aae7667de684a68e8164817327

Change-Id: If77b213deba85d49e1e8d09015fa81aa6df6aa94

This attempts to solve several deficiencies in the script:
1. If the first attachment of a bug is already downloaded, the bug is
   not checked for newly added attachments (or attachments with newly
   fixed mimetype).
2. If neither of the eligible attachment(s) of a bug is the first
   attachment, the bug will be processed (and the attachment downloaded)
   time and again (because the shortcut is only applied for the first
   attachment, see 1).

But it also ensures that if the script is killed, the download is
restarted on the next run.

Change-Id: I7f3d1922825bb314f96ec3b1ee2a0ac47604b018

Change-Id: I838250e41a397320d965690527241d2518746141

Change-Id: I61cf2a40f80f27005229b4a06f3c1e32802be4cd

Change-Id: I28970c5bd919640bb3b5dd6ac38d93673cce1002

Change-Id: I23110e5ab98068c2e046c6f6539759a1dc6d1191

Change-Id: I42e7fbc62d455d909f50864371a321058d4ac2ad

Change-Id: Ie0a5824ddbc3e75a1bb22121e620378ad3e0dfde

The code path was assigning one ScDPObject to another via assignment,
but we didn't define one. So we were using the compiler generated
assignment which only shallow-copies data members, which ultimately
caused double-deletion of one of its data members.

Change-Id: Ie98d0789e51aebff683dbcc0e533a9a0a87943d5

Change-Id: I92f2dbbe12956ee9432d592851f10bceaa5ce25d

Was lost with 2ce72093 and previous
restructuring.

Change-Id: Ie4c8bdb287b56448406c873840c26ec4759de375

PPDValue::m_aValue is simply an optional parameter description, whereas
m_aOption is the actual option being passed to cups.

For example, for the key "PageSize" (which was previously passed
without problem), a typical PPDValue could be:
m_aOption = "A4"
m_aValue = "<</PageSize[595.3 841.9]/ImagingBBox null>>setpagedevice"

However for the key "InputSlot" (which was previously not passed
to the printer), a typical PPDValue could be:
m_aOption = "RearPaperFeedSlot"
m_aValue = ""

Change-Id: I7959317c9f9d67bfafd911e710927a70edfa8792

Change-Id: I4858667f781f4e8142dcd096222e98316cf1b9b6

Change-Id: I9625958e4139dd595f269ebac72b9a037118a9f5

So f22006dc changed the SwDrawTextInfo
to contain not a pointer but an actual OUString, and then
d908422f changes
SwSubFont::DoOnCapitals() thus:

-    const XubString& rOldText = rDo.GetInf().GetText();
+    const OUString& rOldText = rDo.GetInf().GetText();
     rDo.GetInf().SetText( aTxt );

That used to _copy_ the string, but now it just references the
member, and so the SetText(aTxt) below overwrites rOldText.

Change-Id: I06d7ee7084c15d88b3e748ef18877b62e79bdd0e

Change-Id: I65476b98a58b749619003965c41cfe0f32ae2e13

Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa

We apparently support this syntax for ODF-backward compatibility.

To fix this, I resurrected ScDPObject::ParseFilters() which was removed as
unused, adjusted it for the String->OUString change, and changed the filter
data structure to the UNO one rather than using the old one we no longer use
elsewhere.

Change-Id: If52b38aaa1e8b208fb0ef9d92a6e853decdf43e3

which should silence that annoying "unknown packing: homogeneous" warning

Change-Id: I826908024063909ddd5f975829b7a5727944d399

Change-Id: Ib4e17723ba9e2bb4dae0eb86cf55513a4b68de6f

Expecting that the shapes are on the drawpage in the same order as they
are in the file and providing zorder info at the same time doesn't work.
Either using names is required or the simpler way is not providing
zorder info. Fixed earlier bugdocs not to provide zorder info, so when
zorder will be handled, these tests will still work.

Change-Id: I771b0574eba489322998c84a60d5acb94fd09189

Change-Id: Iaa2b7df4246ab3fa31737126f27e4a9da3814048

Change-Id: If0b413a4fdd93465074548c7ea5451288c1d12aa

This is not a full fix, this just trims some of the fat in
CuiAboutConfigTabPage::FillItems.
Specifically
  - improve string handling
  - don't use catch/throw unnecessarily

Change-Id: I5b4987407bd007fbbb18f76fcf26f4a33282c0c0
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>:
 reintroduced lost "/" into path of recursive FillItems calls

Change-Id: I30844062bf4d4f15ca70d9f441f0505fa4f26bb7

regression since 58fa3d50

Change-Id: I499704d18872da6f2f01cf955a6496104c53dd3f

Change-Id: Ib4ead1d64dc6b8e76bf2c7bf0f007e8962acb1e2

Change-Id: I9c1df594457a8ccbbebf4ede61cc3a637ecc7023

Project: help  ee5d5c120418303a51af8ae9f0cf6a73a8447f38

Change-Id: I737da11ed6978edf824f00dfb3dfc29c2c5416ed

Change-Id: Icb44f91219f75103f469f38f96d843b8e8251e92

Change-Id: I7b53a8f18e1fb24b1ae0322bdf0980e431a0725f

Change-Id: I626345b34332d7797f1df412545d8d718e9c634c

Change-Id: I1247af709baf250b82a4156ea2cbf29c758f0c78

Change-Id: I3ab3777a65fd68f8cbaf17a8e2a989dc4ad7b1cc