... for now, because this is the only thing that deletes existing
sw::MergedPara instances.

Change-Id: If092df52e63de28de38129f0aa11ad08156855c4

The nTFIndex is used to insert into the merged string; the correct index
is at the position corresponding to itInsert in the extents array.

Once the itInsert is found, the nTFIndex is no longer used inside the
loop, so just stop updating it.

Change-Id: Idc073cc758bad42b0d8b44d15f0f8e732eeb2a25

It turns out that there was a small problem in the interpretation of
sw_JoinText(), or rather, its caller,
SwRangeRedline::DelCopyOfSection(), which, since about OOo 3.2 and
i#100466, passes in bForceJoinNext, so the result is that the first node
wins always, not just for RES_BREAK/RES_PAGEDESC items.

This means that pParaPropsNode and pFirstNode are the same thing really.

Another little problem is that the SwAttrIter was initing the font
wrongly: the relevant items are the items in the *current* node's item
set on top of the item set of the paragraph style, i.e. the *first*
node's style.

Simple reproducer: ooo79457-1.odt

Change-Id: I06ef3c1695b8f3cdbded238864a60d5eb9ce4c44

The iteration was stopped as soon as the first start-node of a table
cell was reached, because the SwTableNode case didn't skip over the
table section in the nodes-array.  As seen in ooo67621-1.odt.

It looks like the same problem can't happen with sections or flys
because only tables have nested SwStartNodes and the Fly's nodes
can hardly all be in a delete redline.

Change-Id: Ib21a758c588d5dc8193ba171353f872de71bd65a

As seen in ooo50225-1.sxw.

Change-Id: I9f0bc0838cbf216b9a73e3ce6bc06b4340064077

SwCursorShell::GotoMark(), GoNextBookmark(), GoPrevBookmark() check
visibility of mark in layout.

SwWrtShell::GotoMark() returns whether it was successful.

EnhancedPDFExport skips marks that are not visible when creating links.

Change-Id: I36c0706c18a5f861b15eaf451a97daec04104056

SwEnhancedPDFExportHelper should not create links to things that are
hidden by the layout:

* SwCursorShell::GotoFormatField() skips deleted fields
  (this triggers an assert in GetCharRect() with ooo69593-1.odt)

* SwEditShell::GetINetAttrs() skips deleted INet attributes
  (which, as an additional bonus, hides then in the Navigator too)

* SwDoc::GotoOutline() skips outline nodes where we know they have
  been deleted (as seen in ooo66088-9.odt)

* SwFlyFrameFormats are skipped by EnhancedPDFExportHelper itself

* footnotes dito

Change-Id: Ife77dc7724688631d20cbaf8531b3c826a8ece94

moz55970-4.odt has a delete redline containing
 <text:p text:style-name="Standard">&#13;</text:p>
which the silly whitespace normalisation of course imports as an empty
SwTextNode.

A delete redline containing no text (or at least a fly?) appears quite
useless as the user can't do anything with it, so just delete it on import.

Change-Id: I657eeb627235adf90d7d7c1e44f505e2c6eacd46

It must use the start position that GetNextRedln() returned, not the
start of the end redline that GetNextRedln() returned, obviously.

This triggers an assert in CanSkipOverRedline() in ooo31961-27.odt.

Change-Id: I40b9647e0b8be9768e49047d309dd22470e658bd

This is really stupid...

Change-Id: I487ded0c0268ee9b7426e08109a9e8d447a0dfac

As seen in ooo95711-1.odt, the ODF import may create a redline that
starts on a SwTableNode - though i haven't been able to figure out how
such an odd creature might arise from UI actions.

Try to fix the obvious places so we don't crash easily; there might be
more trouble elsewhere though with code that assumes that a redline
starts on a SwTextNode.

Change-Id: I8431c1416ac4503ff0209a946398656f1c28366d

This was another IsDelLastPara() redline in ooo27109-1.sxw.

Change-Id: I1f4198a4bcbed7bdd52991af3cb3322ebacc65fe

CheckParaRedlineMerge(): Fully deleted SwTextNode followed by a table,
as seen in ooo81405-1.odt and ooo31961-16.sxw.

Also avoid creating an extent for the node in which it starts,
e.g. ooo31961-27.odt.

Change-Id: I2a7d935a9cedcb66aeaa9dce418b1fab758f1784

SwPostItMgr needs to hide the comments that are in delete redlines.

Also notify SwPostItMgr when redlines are created/removed.

SwPostItMgr is owned by the ViewShell but there is currently only one
layout so SwRootFrame still needs to broadcast to all of them.

Also an EndListening call was missing in
SwPostItMgr::CheckForRemovedPostIts() which caused asserts.

Change-Id: Ic0fccde50f6fdaa449afb535476c00c41ba94287

Clearly this is wrong, the first node might be deleted; triggered e.g.
by ooo69593-1.odt.

Change-Id: I8f491372fcc375e68f2f7611924d8d4c7f673f17

since...

commit 08a43cc9
Date:   Sat Oct 28 02:28:18 2017 +0200

    related: tdf#103884 remove gltf/collada feature

Change-Id: I7671746f2b33f8d4eae207448267d0284a3f9804
Reviewed-on: https://gerrit.libreoffice.org/65336
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The MS Office UI allows values only in range of [-90,90].
Because of this, we should reflect the angle if the Textrotation
is between 90 and 270 degree. Also we have to recalculated the
the Textrotation between 270 and 360 degree, because the OOXML
counts clockwise.

Change-Id: I2fbd53d93ab2e8ea4e26840fd056de20b337daa3
Reviewed-on: https://gerrit.libreoffice.org/65194
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: I464ab7aec8290966555337ffb712f6c6eb9008f7
Reviewed-on: https://gerrit.libreoffice.org/65341
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

* Update helpcontent2 from branch 'master'
  - Python: fix location description / references
    
    Change-Id: I0b6339716d8a26dda84d0904c4a536d2173d3f1e
    Reviewed-on: https://gerrit.libreoffice.org/65347
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I6b94e0eec328e5b94d20fad011f1ce79e0b2fe84
Reviewed-on: https://gerrit.libreoffice.org/65335
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

fixing leak in SwGlobalTree::DialogClosedHdl

Change-Id: I4a8e883bfe62181d4e332b3a0bbb85bbb332f711
Reviewed-on: https://gerrit.libreoffice.org/65333
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I54d0f2138763acf5addae53051ca842b878f5680
Reviewed-on: https://gerrit.libreoffice.org/65334
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8c466b04748da44af97b6e21fc8cced7f40304af
Reviewed-on: https://gerrit.libreoffice.org/65314
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Provide a visualizer specialization for this case

Change-Id: I54c293972c7e883b8328958f748dba5f2dbd0636
Reviewed-on: https://gerrit.libreoffice.org/65327
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

... and also print the invert mode name into the inverted region
when running "./bin/run vcldemo --show ellipse".

Change-Id: Id461a32756583df1ef778320c29c45c0e7e4fbc8
Reviewed-on: https://gerrit.libreoffice.org/65326
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I6a74b94adc26923f9e83dd09d9b1d077a73b5d05
Reviewed-on: https://gerrit.libreoffice.org/65322Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Iea8547089a0ce2dc9f6a06b84552f4261fbfa0f1
Reviewed-on: https://gerrit.libreoffice.org/65311
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Move XIndexAccess Java tests to C++ for ScScenariosObj.

Change-Id: Idfe41c83adcec7a9cb6b29da9aafcb8c7c25c711
Reviewed-on: https://gerrit.libreoffice.org/65306
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

With this patch the text break is allowed for column chart
X axis if the text is rotated with 0, 90 or 270 degree.
(The MS Office only allowed the text break of X axis
text when the rotation is 0, 90, or 270 degree.)

Change-Id: I0914f6208d5a5c0c864dc0227032ef858b044445
Reviewed-on: https://gerrit.libreoffice.org/65165
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: I530d26a489a130c9fdfa105b3891d21cbfeb3379
Reviewed-on: https://gerrit.libreoffice.org/65305
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Follow-up to 43a63b72

Change-Id: I39d80abdb541909b3cfa4651317c9c9f478e42ca
Reviewed-on: https://gerrit.libreoffice.org/65312
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: If69941920060bb34894ea399aa7f15052502b078
Reviewed-on: https://gerrit.libreoffice.org/65288
Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Regression from commit 22e94ab1

Change-Id: I66a6e0b5069fe459b887a52f1ea26904dfc2d37b
Reviewed-on: https://gerrit.libreoffice.org/65303Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

...after fd34a19b "Seems that we don't need the
com.apple.application-identifier after all" dropped the last @...@ replacement
there

Change-Id: Id6f4d1065b28be12e5d727bab553daa17fc4dfcb
Reviewed-on: https://gerrit.libreoffice.org/65275
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

It wouldn't be terrible to duplicate headers/footers
unnecessarily, but it is terrible to have them disappear.
If the last SectPr has no idea about the section start,
it can't know whether it is continuous or started with
a page break. In that case, just ensure that the
header and footer are explicitly written out.

This seems to be a DOCX problem only. I think that
doc and rtf both write the section information at the
BEGINNING of the section, but DOCX writes it at the END.
So, sharing code between these two opposite approaches
is difficult.

A followup commit can try to make it smarter about
knowing the start of the section (because usually
pPDNd is zero).

Another followup commit can add the missing page breaks.

Change-Id: Iff54ed097b4f8692d7d7764089002b00fbde4f51
Reviewed-on: https://gerrit.libreoffice.org/64821
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Regression from commit d5c934d1
(n#792778 DOCX import: parse group shapes in oox only, 2012-12-14),
where where manual wordprocessingML -> drawingML translation did not
handle this character property.

Change-Id: I87481bc9c26651fd15dd39a58a92f467e8311256
Reviewed-on: https://gerrit.libreoffice.org/65289
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I6a048a51eacaa7063318cdc27d5bc25cc96d557b
Reviewed-on: https://gerrit.libreoffice.org/65304
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id62a2e4cd2d8d8b6aa79e43448513a9791a55d91
Reviewed-on: https://gerrit.libreoffice.org/65302
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

tabbed and groupedbar_compact add context-form support

Change-Id: I4a59d4b71bbbc253ee4188c4c15a7353e623e2f1
Reviewed-on: https://gerrit.libreoffice.org/65295
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Commit 8051bb7e had removed its "String"
counterpart.

Change-Id: Id873a259e7f4b2794e94dec83d08ed6b57298beb
Reviewed-on: https://gerrit.libreoffice.org/65299
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>