Change-Id: I1f697ff32f13fea72c04803d56a25d486bcc3cd3

Change-Id: I7890755f754ee21d2e6db84f169b52bf4737f524

Change-Id: I0238d8f4ae6b92f92f8bb92df33da5552a158cbe

Change-Id: I28f2b4df57b8bc521e36e72b1f788fc89cfa7caf

Convention is that public functions used by other non-implementation classes
use uppercase function names.

Change-Id: I9a57b231b6a92dc8ac37dc417fdb8177a8c2fa11

Change-Id: I747199b0cf7079bcebef396865942876f592da8d

Change-Id: If8b3e4dc04ff0ecdc358b91784c1f2b60c159498

Change-Id: I9ba9044ef9603ec9050b40d3dd6f01cfb45df134

Change-Id: I02c84b1cb6e38e93e268bb388aecca1594917400

Change-Id: I9c7d9da944361f3d148752f8dff64c6e0a44d861
Reviewed-on: https://gerrit.libreoffice.org/13802Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I61934fc2ebfaeaa0527f70f038e5aaae87ef730e

Change-Id: I747fee3feb431f8a3f340184b999ce41cf2b615c

Change-Id: I7a097c849eaa49eab688660cb229222cdf658b81

Change-Id: Ib5b2a3840e2f3ca1b7e2faf57182a262e06cb74e

Change-Id: I82b48b3bb35b1120a5d7fdaee19275c8b1f8eb72

Change-Id: Id92bb3ed5c19cefed41eeaafe8b956cd2d563bf6
Reviewed-on: https://gerrit.libreoffice.org/13853Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>

ADO is not available on 64bit.

Change-Id: Iaad115219eac0051346b99ecb9076e29d528df2b
Reviewed-on: https://gerrit.libreoffice.org/13367Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>

25e29143 changed Link class to
use sal_IntPtr instead of long, but missed to adjust number of
occurrences.

Change-Id: I966185083a41b41c7385947a03369a8ce65c61b8
Reviewed-on: https://gerrit.libreoffice.org/13852Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>

Using 0 as index offset to set user data in window handle,
is failing on x64 platform with:

ERROR_INVALID_INDEX 1413 (0x585)

To find it out GetLastError() can be used:

SetLastError(0);
LONG_PTR salFrameBack = SetWindowLongPtrW(hWnd, 0, (LONG_PTR)pFrame);
DWORD status = GetLastError();

Switching to documented GWLP_USERDATA instead, solved the problem.

Change-Id: I496ed2915e44309eaaaa4b576dca30b0051bdbfd
Reviewed-on: https://gerrit.libreoffice.org/13807Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>

Change-Id: I7e483efd3aa96c34fb02affa73ee5ffb9840209c

Change-Id: I68bacfc41dc7b104a07c44135c0124e3f6464d67

Change-Id: Iea8552570146bd516ca2ee241caa4fcc3047b9f7

Change-Id: I584045f8b626ff3a51e868c586581219bf4a758c

Change-Id: Icb6d782a4a3aa91e05c6466edb3d84c5dfc08f08

Change-Id: I43463b56cabfea4c9ee2b98445f7fb522221197d

Since we have a SwContentTree::Notify() now, might as well clear our
pointers to recently deceased SwWrtShells when the obituary arrives.

(regression from b5c1f352)

Change-Id: I44282658468f1b758038fbf1c7fc13dfe1b4b8ed

Probably 03cca068 was not sufficient,
because the ~ScCellRangesBase may access a deleted ScDocument after the
early return.

READ of size 8 at 0x61b000191cb0 thread T7 (cppu_threadpool)
    #0 0x2b3c8fd7c8b3 in ScDocument::RemoveUnoObject(SfxListener&) sc/source/core/data/documen3.cxx:863:9
    #1 0x2b3c94517824 in ScCellRangesBase::~ScCellRangesBase() sc/source/ui/unoobj/cellsuno.cxx:1467:9
    #2 0x2b3c9459cf98 in ScCellRangeObj::~ScCellRangeObj() sc/source/ui/unoobj/cellsuno.cxx:4786:1
    #3 0x2b3c945eca28 in ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6088:1
    #4 0x2b3c945ecef1 in ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6087:1
    #5 0x2b3c945ed093 in non-virtual thunk to ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6088:1
    #6 0x2b3c56cb35ec in cppu::OWeakObject::release() cppuhelper/source/weak.cxx:205:9
    #7 0x2b3c94523d63 in ScCellRangesBase::release() sc/source/ui/unoobj/cellsuno.cxx:1772:5
    #8 0x2b3c945a77ec in ScCellRangeObj::release() sc/source/ui/unoobj/cellsuno.cxx:4835:5
    #9 0x2b3c945f842c in ScCellObj::release() sc/source/ui/unoobj/cellsuno.cxx:6128:5
    #10 0x2b3c945fb953 in non-virtual thunk to ScCellObj::release() sc/source/ui/unoobj/cellsuno.cxx:6129:1
    #11 0x2b3c7f305faa in bridges::cpp_uno::shared::freeUnoInterfaceProxy(_uno_ExtEnvironment*, void*) bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:42:5

freed by thread T14 (cppu_threadpool) here:
    #0 0x43436b in operator delete(void*) (/data/lo/build_clang/instdir/program/soffice.bin+0x43436b)
    #1 0x2b3c9382462e in ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2722:1
    #2 0x2b3c93824d46 in virtual thunk to ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2755:1
    #3 0x2b3c58e2058a in SvRefBase::ReleaseRef() include/tools/ref.hxx:194:29
    #4 0x2b3c58e12726 in tools::SvRef<SfxObjectShell>::~SvRef() include/tools/ref.hxx:52:24
    #5 0x2b3c5a8a8f99 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:247:5
    #6 0x2b3c5a8a9141 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:246:5
    #7 0x2b3c5a7b1905 in SfxBaseModel::dispose() sfx2/source/doc/sfxbasemodel.cxx:795:5
    #8 0x2b3c5a7c8146 in SfxBaseModel::close(unsigned char) sfx2/source/doc/sfxbasemodel.cxx:1418:5

Change-Id: Ia041dc6596d1b0b6b979a20fa93e1490c657e15b

Change-Id: Ia53dc393e4284989f6e967c4fa42e7ba6fc58183

Change-Id: Ia8471c9745b86c4137297fd9cd0a3fea712a14fa

Change-Id: Id8524328f1bdacbc37dd6846f053e5bcfbcd782c

Would be nicer to fix it though.

Change-Id: Ia5f49a69374e9e79a9a16542bc44f279b9e5a6f7

At least on some 64-bit Cygwin installations, the input gbuild-to-ide gets
include \r\n EOL. Python3 regex excludes \n from .* but leaves \r in the matching
group. This training cr ends up in the file paths in VS project files, breaking
it as they are invalid characters.

Change-Id: I481c1adbf6f6db7ab0ee0d3a768b7a397dc78ee5
Reviewed-on: https://gerrit.libreoffice.org/13803Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I9fd7b873b6e64a6450c1bd946cd9bb08c293290a

Change-Id: I844532d08123ed0c91ccec73cc806277fd821089

Change-Id: Iaa46849742c215798722d03d9ee59bb39d8033f7

Also OOXML calls these API functions, this is the central place to handle it.

If there are no matching tab names for a FileId, preserve at least the known
reference parts. In case of 2D references the sheet name is in the token if
for example read from .xlsx, only for 3D references the second sheet name
would be needed. The underlying makeExternalRefStr() and its subroutines
handle the missing tabname elements gracefully.

Still this situation is worth an assertion.

Change-Id: I3df065af8e4ef44734f468fd455c3b7c93d7fbc6

This reverts commit 808b0bf8.

This is not the right fix, it cures a symptom but probably will break
other cases. See also my comment on https://gerrit.libreoffice.org/13670

Change-Id: I5bb661ba2bcbd387a69aacf08cb13b503315c5b1

Change-Id: Ica5ebb04ec50c6579f71d1152ae7619dd37b879e