- 25 Şub, 2015 30 kayıt (commit)
-
-
Michael Stahl yazdı
TransliterationImpl::transliterate() has a slow-path for the case when more than one trasliteration module is cascaded which swaps 2 uno::Sequence. This is unbelievably slow because non-const Sequence::operator[] does a function call into cppu to check whether COW has to be done. This speeds up transliterate() from 344 billion to 101 billion callgrind cycles when built with GCC 4.9.2 -m32 -Os. Commit d2771b63 added a second transliteration module that is enabled by default, making the problem visible, especially with long paragraphs in Writer. Change-Id: I2799df9173ac73aab8c4eb4cc6f592976b06c8da
-
Michael Stahl yazdı
Change-Id: I84c7a4cde694395fa70c60edffd63fb45ffcb3a8
-
Michael Stahl yazdı
Change-Id: Ifcd5766ce10de44f38d5c383cd7dc35b75152e88
-
Tor Lillqvist yazdı
... it could not be verified" I got some insight reading this question and reply on stackoverflow: http://stackoverflow.com/questions/18761993/steps-to-include-timestamp-in-pdf-signature I had been doing the timestamping wrong in the same way: I had timestamped the hash of the PDF document, not of the signature. That is wrong. If you think hard, it is obvious: It is the (rest of the) signature that needs an authenticated timestamp, not the PDF document contents. After all, if the document contents is timestamped, but not the signature, that doesn't prevent tampering with the signature after the timestamping. When you timestamp the signature, that proves the date of the signature. (And the signature proves the authenticity of the document contents.) So I had to re-engineer the code a bit. I create two originally identical NSS CMS messages with signatures, encode one signature into DER, take the hash of the signature, get a timestamp from the TSA for that hash. Then I add that timestamp to the other CMS message as an unsigned attribute of its signature, sign it, encode it, convert to hex, and store it the document. (I first tried to use just one CMS message, but NSS stopped with an assertion when I tried to encode the signature of the same message a second time, after adding the timestamp attribute to the signature. Go figure.) (I did verify the the encoded signatures, taken from what should be identical but separate CMS messages, was in fact identical. So I am fairly sure the idea described above is sound.) But, it doesn't help. Adobe Reader still complains "The signature includes an embedded timestamp but it could not be verified". Change-Id: I4e4cd0443005e82f597586942badc7145ef64160
-
Tor Lillqvist yazdı
No change to functionality or end result. Preparation for an attempt to fix the remaining problem with RFC3161 timestamped signature. Change-Id: I5790a85399e9f94d816e8fab791a03d607113116
-
Caolán McNamara yazdı
and assert is bollox as well Change-Id: I966aa4efe1191f1a7957d3117d9c3ccabe041178
-
Caolán McNamara yazdı
Change-Id: I249fe09319d6e0995d9ffdc7e4396b9b1787ad28
-
Caolán McNamara yazdı
Change-Id: Ibf176df1e54138480030086abad0d045d27f19d1
-
Caolán McNamara yazdı
That way the conversion from basebmp to cairo becomes unnecessary on blitting the thing onto a cairo surface for gtk3 and opens a route to using cairo, e.g. especially for text, to render to basebmp surfaces. Change-Id: I1d11f503410af9c92a97018e9ee20045412b157e
-
Caolán McNamara yazdı
Change-Id: I0f28b986542b4d30c0a2cb75e15fb258af98e9cd
-
Caolán McNamara yazdı
Change-Id: I60e1951fe56e4b00ee0caa142eb0e19dcb6d12b7
-
Caolán McNamara yazdı
Change-Id: I69ab0ca9c017c9a1c10d18fd850f32a92c641d12 Reviewed-on: https://gerrit.libreoffice.org/14631Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Chris Sherlock yazdı
Change-Id: I15b64f874f72715cea04f656e1b883c6cf45a86c Signed-off-by:
Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
where each unit is actually 32bit with unused upper 8bit. Change-Id: I5c406cebe406d2db6fda73d744dfd22a99b80ba3
-
Stephan Bergmann yazdı
Change-Id: I9c3a6afea188d04c0d31d5685468b3d45a342840
-
Andras Timar yazdı
Change-Id: I7af6b84da0ebfe9067690153665fb2470fdebcf4 Reviewed-on: https://gerrit.libreoffice.org/14607Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Andras Timar yazdı
Change-Id: I6e0b093d99dba731ff5723d6575f887346463908 Reviewed-on: https://gerrit.libreoffice.org/14605Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> Tested-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Ashod Nakashian yazdı
Fast bitmap scaling overflowed the LUT used by the nearest-neighbor algorithm. When a bitmap has 46k pixel on a side and is enlarged, the scaling code overflows the 32-bit long, resulting in negative indexes, which then segfaults. This isn't as rare as it sounds. At least in web-view in writer the border/shadow bitmap is as long as the document (which is an issue in its own right,) which can overflow for large documents during scaling and segfault. Change-Id: I1ccf73d02469f6601a9a7e67b30524cb497cf6bc Reviewed-on: https://gerrit.libreoffice.org/14597Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Stephan Bergmann yazdı
At least in JunitTest_sw_unoapi it happens that this downcast is called from ~SwCharFmt -> ~SwFmt -> SwClient::ModifyNotification -> SwDepend::Modify -> SwClient::ModifyNotification -> SwEndNodeInfo::Modify, i.e., the downcasted object is in destruction and no longer an SwCharFmt but only an SwFmt. Whether or not that chain of calls is actually sane---casting down to merely an SwFmt is a quickfix at least. Change-Id: I33f0d76c42daa2530b8d417df059de57190c5070
-
Noel Grandin yazdı
Change-Id: I8eb0c9bda0883bc08aed3acd7eaa72480848c6f3
-
Jan Holesovsky yazdı
With this, ODF_text_reference_v3.odt does not report any broken services, but the app still crashes anyway - tdf#89642. Change-Id: If73835534184ffbac1c91b2c5bca33bded50c41f
-
Noel Grandin yazdı
.. in favour of just using the underlying constants from css::util::NumberFormat Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
-
Noel Grandin yazdı
Change-Id: I8484b985e46ad34fa45b02aa07130d3259336082
-
Noel Grandin yazdı
Change-Id: I795ce25011509de8f2aff488d4d46b86290ab3a3
-
Noel Grandin yazdı
Change-Id: Ic2391f4da06e26ee11a2463d2508b0dccdbf52bd
-
Noel Grandin yazdı
Change-Id: Icc3aad14d9d0c59c1c1c8f124f0626a9f947b93f
-
Stephan Bergmann yazdı
Change-Id: I352702ac50708a8f8c40e2752821178223052b7c
-
Miklos Vajna yazdı
Also remove code from SwRangeRedline::dumpAsXml(), where that extra data pointer seems to be ~always 0, so don't bother dumping it. Change-Id: I4509b9366c1862248fcd3cc7ca6bb257ea7517f8
-
Yousuf Philips yazdı
Change-Id: Ib6e23cbbcc7037dfdab53c4243091afbf819d445 Reviewed-on: https://gerrit.libreoffice.org/14613Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
Laurent Godard yazdı
with unit testing Change-Id: I2a0e09f699c8489f61453b4144dd6181bd9b47fd Reviewed-on: https://gerrit.libreoffice.org/14603Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by:
Eike Rathke <erack@redhat.com>
-
- 24 Şub, 2015 10 kayıt (commit)
-
-
Julien Nabet yazdı
Change-Id: I2362c2c7a1c637b02eeebcae8ee1e3c0fc2b2422
-
Julien Nabet yazdı
Change-Id: Ie1c92ff5f65b019d3f1306917cd924036eea7909
-
Julien Nabet yazdı
Change-Id: I902fcb3fef7100279c34494e95cacfd3e5caf153
-
Julien Nabet yazdı
Change-Id: I5f2577dd1f047331a58d33e05684b673e6dbd11e
-
Julien Nabet yazdı
Change-Id: I4942a9ef4d3805865896c83cd9efa66437857ba1
-
Yousuf Philips yazdı
Change-Id: I0e6c0900d28e7f01ebf88bcabc7dc6d5bbdb1b6a Reviewed-on: https://gerrit.libreoffice.org/14594Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
Eike Rathke yazdı
Change-Id: I88f1d0a134ffa3fbb9a5b5abdabbd4774f457e81
-
Caolán McNamara yazdı
bit/byte thinko I imagine Change-Id: I85ef6de4a4e6cffcd9c593eb15da692a2617736e
-
Caolán McNamara yazdı
so we could create bitmap devices that have the same stride that cairo expects, provide getBitmapDeviceStrideForWidth to get a default value Change-Id: I7ecc6f54a734b3f6bed59c699ac3b482c4ad7c47
-
Caolán McNamara yazdı
doesn't appear to be equivalent, first continue now skips second GetBound assign that original code would have done This reverts commit b56614c6. Change-Id: I113670064fd285795234ae9c9e09be0cc0697cd0
-