* Update helpcontent2 from branch 'master'
  - Update Colibre icon replacement table  in Help
    
    Change-Id: Ie3e2fbca2f74d47a90e43c1707c28df46b7cf1ec
    Reviewed-on: https://gerrit.libreoffice.org/68208
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

A new document uses the default value of ::Environment for the
RES_FRAMEDIR property. On export, of course a default value does
nothing, and for MS formats a nothing means LTR, even though
in Writer the styles setting was determined by the Locale. So RTL
users were finding their new documents switch to LTR style values
when round-tripping to MS formats.

Since this is properly handled when the property is ::SET (as it normally
is when a document is imported), make sure the the default paragraph
style's RES_FRAMEDIR is ::SET, and the export should take care of it.

This works out of the box for DOCX. The export for the other
formats needs a bit of extra tweaking in addition to this
general patch. The tweaking will be done separately.

Change-Id: I5134a636ee3374bb2c1081fd0f3f6d9e79634cd3
Reviewed-on: https://gerrit.libreoffice.org/66964
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ia7e158a4f5a4bc629c4ad4aafc71d7c10d453099
Reviewed-on: https://gerrit.libreoffice.org/68234
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Add 2 new uno command aliases to handle 2 different
  styles of redaction export/sanitization:
    * .uno:RedactedExportBlack & .uno:RedactedExportWhite

* Replace the single export button with the 2 new buttons

* Add a new toolbox names .uno:RedactedExportToolbox which
  consists of the new 2 commands. It will be added to the Redaction
  toolbar after we solve the icon issue.

* Now new redaction shapes are named as RectangleRedactionShape
  or FreeformRedactionShape based on their type.

* While exporting to PDF, a seamless step of "Sanitization"
  takes place, in which, all shapes in the Draw doc are traversed
  and turned into opaq black or white (with black border) shapes,
  then the whole doc is converted into bitmap (page by page).

* After the export operation is completed. All shapes are converted
  back to the usual redaction style (gray and transparent).

* Icon issue:
  * We need 2 new icons for our new commands, one for black redaction
    shapes without border, and one for white redaction shapes with black
    border.
  * I tried adding links to a current icon, but it didn't work, so they
    are iconless for now.

* Next to do: Handle icon issue, and take the redaction implementation
  into a separate helper class because it is growing fast.

Change-Id: I9b2b7716289b800cdbe7bf3ffa4a442fe5afc474
Reviewed-on: https://gerrit.libreoffice.org/68072
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: I428b4c484ba6e18ee2947c9be4688317764769f2
Reviewed-on: https://gerrit.libreoffice.org/68240
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I2ec86617f17cbee25e6de04c5db944b03204996a
Reviewed-on: https://gerrit.libreoffice.org/68235
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I72df89e96ea31c684a5255e19796191481bc8be5
Reviewed-on: https://gerrit.libreoffice.org/68231
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic237f67cb48d8894227805904fbba3b7865b2358
Reviewed-on: https://gerrit.libreoffice.org/68230
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9d23d64f67f3f4490cbcddd1cd07ab267d5e3e95
Reviewed-on: https://gerrit.libreoffice.org/68229
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifd3afbf276100e3cef802bbcc0792b43a9cd84f8
Reviewed-on: https://gerrit.libreoffice.org/68228
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I33d2559cf193489141c9a7047c09d3b5660e7c80
Reviewed-on: https://gerrit.libreoffice.org/68223
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

presProps stream handler is added to do this.
Export is not handled here.

Change-Id: I1979941a09c472c14f96c778ca9960ec14786fbe
Reviewed-on: https://gerrit.libreoffice.org/68237
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I6e4ff4853c3995072b020af54549dc81303a4fde
Reviewed-on: https://gerrit.libreoffice.org/68225
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5e9842970821d0ae61e06e3ad35c9f571b43632c
Reviewed-on: https://gerrit.libreoffice.org/68224
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I152a79b79e75bf87c437dd4dd2976c73198e6b52
Reviewed-on: https://gerrit.libreoffice.org/68185
Tested-by: Jenkins
Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

... so the inheritance and checks introduced with
ParamClass::ReferenceOrRefArray work for those as well.

Change-Id: Ieb87f6a3df5a388f859eae4c5558cf282cd0cde3
Reviewed-on: https://gerrit.libreoffice.org/68236Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: I885acfcdfd9544d7f4eb0e602a7acf0215cb9d92
Reviewed-on: https://gerrit.libreoffice.org/68220
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Either going past the end, or pressing the 'q' key on a hardware
keyboard will exit the slideshow by posting an 'EXITSLIDESHOW' message
to the app. (The app will have to handle that, of course, will commit
in a moment.)

Change-Id: I075e5e3fa86cc632cb3071d6546721b010ff77a2

Change-Id: I5e4774cd9c9a234f644ded61e247187270b536ae
Reviewed-on: https://gerrit.libreoffice.org/68219
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

There were two problems here:

1) We did not import bitmap fill from presentation nodes.

2) Presentation nodes contained properties with reference semantics, so
if you set a bitmap fill for a first and a second shape, then at the end
both shapes contained the second bitmap.

With this, both bitmaps are imported exactly once.

Change-Id: I098a006eb3f58a338400663d57888ca671ed9909
Reviewed-on: https://gerrit.libreoffice.org/68218Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I325faec8594e1c5b8b2c34a135f1604244e4826c
Reviewed-on: https://gerrit.libreoffice.org/68140
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I92b25efa78e156c89a0532aec632a31ec2029e05
Reviewed-on: https://gerrit.libreoffice.org/68202
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I98d599c40e36906022fc5d0b1d992a42c3d784ce
Reviewed-on: https://gerrit.libreoffice.org/68201
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and simplify, the ErrorLink functionality in StgIo is actually unused

Change-Id: I6fb73ebebce2e1b144bd7a75d37323299fd73581
Reviewed-on: https://gerrit.libreoffice.org/68200
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and simplify SvAddressParser

Change-Id: I8333b4442dca69e46ad14c952436b98e40089a8c
Reviewed-on: https://gerrit.libreoffice.org/68199
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

since

    commit 83ee1bcc
    Date:   Fri Jul 22 09:19:52 2011 +0100
    callcatcher: remove unused methods

and even following the history back before that only shows one previous
actual place where the state text was being displayed.

Change-Id: Ib520cb6e999c1e11caf7348821bb274cdd785a44
Reviewed-on: https://gerrit.libreoffice.org/68198
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia5946a77215eba565c3ff8c4dfbc08b95af493c0

Change-Id: Ic196887e963bb96f330e47a7a507c143f95e7a61
Reviewed-on: https://gerrit.libreoffice.org/68204
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - Default Add value for Optimal Column Width is 2 mm, not 0.1 in
    
    See ScCellShell::Execute implementation [1] which passes STD_EXTRA_WIDTH
    (defined as 113 twips = 2 mm) to the dialog as the default value.
    
    The text here (that was 0.1 in) is translated to other languages (incl.
    those using metric units) verbatim (e.g. Russian translation); or if a
    translation team would want to convert to metric, there is no indication
    that the 0.1 in is just an approximation of an exact metric value.
    
    [1] sc/source/ui/view/cellsh3.cxx:693
    
    Change-Id: I1710588ee40840d85eeb89aaeee135a8aa0a942f
    Reviewed-on: https://gerrit.libreoffice.org/67936
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: I5e29ec2863e06d3dfcbad95c55e355805f12e259
Reviewed-on: https://gerrit.libreoffice.org/67895
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I090ceb7d214d0809e86b023a8806b6655627918a
Reviewed-on: https://gerrit.libreoffice.org/67894
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

And with DBG_UTIL validate and dump LOK queue state.

Change-Id: I211ddf89dbcecf17c4f1401e5d96919c4bc966ea
Reviewed-on: https://gerrit.libreoffice.org/67893
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I81f74027363d4b2959c053057851cf01fc94af8b
Reviewed-on: https://gerrit.libreoffice.org/67892
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I3a2d98426729ad1b4e43a8f657b512679be82c26
Reviewed-on: https://gerrit.libreoffice.org/67891
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I48e8de8709e017f2667c0bf2c850004128c840d1
Reviewed-on: https://gerrit.libreoffice.org/67890
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

This is in preparation to cache them.

Change-Id: Ic511caf5a8798750288e9271f6898ab38fe2055f
Reviewed-on: https://gerrit.libreoffice.org/67889
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

...where bad input like "WRONG CELL NAME" (in PythonTest_sw_python's
sw/qa/python/check_xtexttable.py) could wrap around to a valid but wrong nRet.
Instead, return SAL_MAX_UINT16 upon overflow.  At least the call to GetBoxNum in
SwTable::GetTableBox (sw/source/core/table/swtable.cxx) with bFirstPart
potentially true, assigning to nBox, then later checks

  if( nBox >= pBoxes->size() )
      return nullptr;

so returning SAL_MAX_UINT16 upon overflow appears to be the best choice.

(Found with Clang's -fsanitize=implicit-signed-integer-truncation.)

Change-Id: I12822a6bd4f0269adb14c04eefbd1cde4d288728
Reviewed-on: https://gerrit.libreoffice.org/68203
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Idf5984399f2d8bdf4751667e01f170bed15a4443
Reviewed-on: https://gerrit.libreoffice.org/68205
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Also a few hxx files had missing headers and obsolete fw decls

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9a35c566d30678af445da3fec9570af235afb353
Reviewed-on: https://gerrit.libreoffice.org/68131
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: If467a13b03303656e51474b3ebd384db8782ed9b
Reviewed-on: https://gerrit.libreoffice.org/68156
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>