Change-Id: I633047306372ce285bf3531c609f364addf927c8
Reviewed-on: https://gerrit.libreoffice.org/70854Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

and Ctrl-Shift-N should go to the Templates dialog

Actually, since the latter is a global keybinding
this - and the 4 other uno:NewDoc - entry is redundant a bit

Change-Id: I3c36b0b98f04033c8214e9c3c23f8cf5e99451d6
Reviewed-on: https://gerrit.libreoffice.org/70857
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Hyperlink inserted to chart lost after export.

chart_hyperlink.xlsx: Test file from Excel 2016.

Change-Id: Ideca10e544193ba43d7c2ef6e9dd8e393383edc1
Reviewed-on: https://gerrit.libreoffice.org/70648
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I9287d266cd5267e194f2539f95a7efff3824e9b1
Reviewed-on: https://gerrit.libreoffice.org/70715
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

IsPaintTransparent() is preventing to paint the background but
not sure why this is needed. removing this condition doesn't
seem to have any ill effects.

Change-Id: I5ac54e208e4f1c9941beb4012aa44182d21dbed9
Reviewed-on: https://gerrit.libreoffice.org/70855
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

In most cases these were public without a good reason, in other cases
setter / getters are added.

Change-Id: Id6c1032189db1bba211344162e737dabf7ff3f07
Reviewed-on: https://gerrit.libreoffice.org/70842
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I53be5303404cf60609314630b841ebbf2af117de
Reviewed-on: https://gerrit.libreoffice.org/70818
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Iecf88c5720f2407654d85a1a70a04faed43fd690
Reviewed-on: https://gerrit.libreoffice.org/70832
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

When user registers a mouse listener to a window, he expects
to receive mouse events when a user clicks in somewhere in that
window, even if it's technically a widget inside that window

Change-Id: Ie6d3f8b140e4a5b516051014282b43775ecec59e
Reviewed-on: https://gerrit.libreoffice.org/70512Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

... use GetModuleFileNameW() for that.

We call SetDllDirectoryW and SetSearchPathMode to improve security of
the process, and exclude some paths (including current directory) from
search when using API that looks for binaries whose names are not fully
qualified.

So the sequence is this:
1. Program is started using relative executable path like
   "instdir\program\soffice";
2. sal_detail_initialize is called, which calls the two mentioned
   hardening functions;
3. sal_detail_initialize calls osl_setCommandArgs, which in turn calls
   osl_createCommandArgs_Impl;
4. The latter uses SearchPathW with empty path and first program arg
   "instdir\program\soffice" to find fully qualified program path.

That now naturally fails, because current path is not searched.

But to find the process name, we need no search: we can simply use
GetModuleFileNameW() with NULL passed as module handle. Let's use that.

Note that we can't use _wpgmptr/_get_wpgmptr, because we don't use wide
entry point like wmain.

Change-Id: I7a0013a0505f7bdd38164b09b045bfade9686664
Reviewed-on: https://gerrit.libreoffice.org/70844Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Navigate by Control only works in design mode so turn design mode on
when Navigate by Previous or Next Control button is pressed.

Change-Id: I26a565758672c8dd1ec8bf979b199e8b240424e3
Reviewed-on: https://gerrit.libreoffice.org/70644
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

First plan was to move it to bitmapaccess.hxx, but that would add
dependency for the backends, which only need BitmapAccessMode.

Change-Id: Id8ed980207da5b0c7d4de48d82446b33f6b76b13
Reviewed-on: https://gerrit.libreoffice.org/70827
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ibd28b8fa92e98ebeb482a9081fbeae24defe4adb
Reviewed-on: https://gerrit.libreoffice.org/70826
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Move XTextField Java tests to C++ for ScEditFieldObj_Header (formerly
ScHeaderFieldObj).

Change-Id: I36b723945d9306720846b4a4e2d3eaddb1a1c063
Reviewed-on: https://gerrit.libreoffice.org/70841
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

this copy'n'pasta blunder looks innocuous but can slow down loading
of JVM (which reads proxy settings among others) in KDE environment
significantly

Change-Id: I98f0fb107a2ee825bcd47731a5a9d15017ba63bc
Reviewed-on: https://gerrit.libreoffice.org/70806
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I8bb8860d398af2ee9d6dd434c50f914e78b8021b
Reviewed-on: https://gerrit.libreoffice.org/70801
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Users might accidentally move the main shape of
the page being redacted. Let's prevent that.

Change-Id: Ic0f3c2c819d1f974d203fa5fd70d57e5545ba8ef
Reviewed-on: https://gerrit.libreoffice.org/70839
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I3352bf9ade88bd86f7ca3d53238364216547d52b
Reviewed-on: https://gerrit.libreoffice.org/70830
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I374748da8d53045c411db35edbe4ddd65037456c
Reviewed-on: https://gerrit.libreoffice.org/70838
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I80dc602db648c56edb895360188dfd0d43398b8c
Reviewed-on: https://gerrit.libreoffice.org/70837
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Bring White option to the first place,
to save toner on print as users tend to
click on the first option.

Change-Id: Id63c4402f8dc07a83eef69c3dfde3dd086c899b8
Reviewed-on: https://gerrit.libreoffice.org/70831
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Otherwise it's quite annoying to miss e.g. a typo in the shader code
if the code falls back to another way of handling the operation.

Change-Id: I585be85f739929f0f422dc031a36dc83077f6820
Reviewed-on: https://gerrit.libreoffice.org/70771
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Apparently link.exe is a wrapper for either a dynamic linker for .exe
and .dll files, or for an archiver for .lib files, and the latter
doesn't know -debug and complains about it.

eeeec33a made it to be passed to all linking.

Change-Id: Ie4b16536f705987de432fc8e2819467fc5bfb719
Reviewed-on: https://gerrit.libreoffice.org/70817
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Also include/ucbhelper had some false positives not yet on the blacklist

Change-Id: I4500271ea35efd7e140c76255df95ff7bbdf9f27
Reviewed-on: https://gerrit.libreoffice.org/70745
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

...as used as an identifier in sw/inc/swundo.hxx (broke Windows --disable-pch
builds)

Change-Id: I4de0232bcf17c4149cc31ec235f1275648a6d73e
Reviewed-on: https://gerrit.libreoffice.org/70820
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I64662a4020ea402477af33d61d8db0ee062ebe46
Reviewed-on: https://gerrit.libreoffice.org/70819
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

nLen may be larger than the master SwTextFrame, but its follow can't
have negative offset.

(regression from 0acde751)

Change-Id: I6177c748480cdf61e8f15a7032ba52d3ae2ea52c
Reviewed-on: https://gerrit.libreoffice.org/70816
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

By implementing btlr support in
SwTextFrame::SwitchVerticalToHorizontal(SwRect), so not only
invalidation but paint rectangle is also correct, which means actual
text painting happens.

Change-Id: I4215799ff63c93b300e4e8f97c6824f75d7c5401
Reviewed-on: https://gerrit.libreoffice.org/70797
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Greyscale conversion with OpenGL results in RGB values sometimes
having color components one off compared to the normal VCL values,
so be a bit lenient.

Change-Id: I58c279fb90e540cd2ac76d4217c774ff09229051
Reviewed-on: https://gerrit.libreoffice.org/70778
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Related to tdf#105277, check that scaling a bitmap with different
scale methods and different bitmap sizes produces (roughly)
the expected results.

Change-Id: Iea9be675b7cc4b0fbbc634501d32ded82bccbb17
Reviewed-on: https://gerrit.libreoffice.org/70775
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

With a texture atlas the "texture" is just a subtexture of a larger texture,
so texture coordinates are not the full range between 0 and 1, but just
a part of it. Since areaScaleFragmentShader converts between pixel
and texture coordinates, the conversion needs to take this into account.

Change-Id: I9d29ffea52551d19ba681971a2b4f140a35b491c
Reviewed-on: https://gerrit.libreoffice.org/70774
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

The bitmaps have different CRC, because OpenGL uses different algorithm
and data format.

Change-Id: Ic4d2e6215cfc6b971b470367002936f4a81e9fbe
Reviewed-on: https://gerrit.libreoffice.org/70777
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

So that textures do not start with random uninitialized contents.

Change-Id: Ie240f5f71ed77d5c6c22a120e96540a2d0d7c2ed
Reviewed-on: https://gerrit.libreoffice.org/70773
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Windows uses GL_BGRA, but e.g. on Linux OpenGL stores as GL_RGBA.

Change-Id: I00820f7b7a16a54b10c682ba332627ec04648508
Reviewed-on: https://gerrit.libreoffice.org/70772
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

BitmapTest::testScale2() on Linux fails for me without this,
as the two-pass setup higher truncates the size to integers, and
truncating here again sets the final size as 64 instead of the expected 65

Change-Id: I54748e29f0e0ca63539e42009759a93d6a5d6be2
Reviewed-on: https://gerrit.libreoffice.org/70779
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

The two blocks are identical.

Change-Id: I58464160009d1276bd1ca92482cd677c00471251
Reviewed-on: https://gerrit.libreoffice.org/70776
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Without this, building a unittest does not rebuild those if needed.

Change-Id: If15aa2e1d7869d274c8c5f885278e85e0a341c47
Reviewed-on: https://gerrit.libreoffice.org/70770
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I8e08efb549ebd52c37183a1185d6de73f2b00601
Reviewed-on: https://gerrit.libreoffice.org/64630Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b
Reviewed-on: https://gerrit.libreoffice.org/70813
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I57e11d45aad48713b7c6802e2b6976fd916fc6ba
Reviewed-on: https://gerrit.libreoffice.org/70717
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>