* Update helpcontent2 from branch 'master'
  - tdf#119415 Add placeholder text for index filter
    
    Change-Id: If7a0a863eb6b8bb95a5b6236f4f3d490739810a1
    Reviewed-on: https://gerrit.libreoffice.org/63672
    Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: I66b384e57e3e6845bacfad34c5de1b6e5b437311
Reviewed-on: https://gerrit.libreoffice.org/63661Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

and

coverity#1441468 Uninitialized pointer field
coverity#1441470 Uninitialized pointer field
coverity#1441467 Unchecked return value

Change-Id: I485fb0b5a83838a3c4913a74b5ea3ae70b4f6bd1
Reviewed-on: https://gerrit.libreoffice.org/63663
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Has been like this since commit 2d1ef8aa

Change-Id: Idf0e05246f625befb4872e743b490a5594d24f8f
Reviewed-on: https://gerrit.libreoffice.org/63548
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

[MS-OLEDS] 2.2.5 EmbeddedObject actually has a last Presentation field,
and we didn't write it so far.

Luckily all the info can be extracted from the OLE2 container, so we can
roundtrip the OLE1 wrapper around OLE2 nicely.

Change-Id: I8d4922428dd5beeaae8b6cd4da0575db7014e4a2
Reviewed-on: https://gerrit.libreoffice.org/63667Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I5b7f503e32c10b5a844817c040ab0dde27bf48f7
Reviewed-on: https://gerrit.libreoffice.org/63666
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ib1b632690ae8491732d893788c9b09ced8e49933
Reviewed-on: https://gerrit.libreoffice.org/63668
Tested-by: Jenkins
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

in words, for example “az Ipsum”, not “a Ipsum”.

This bug was reported by Gellért Gyuris.

Complete commit 1037e375
(tdf#115319 references with Hungarian articles)

Change-Id: If930feb11a0308246d2512f0093bcacdc8675d0b
Reviewed-on: https://gerrit.libreoffice.org/63637
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I9e3a071b9b5792a627a3c5b478ba16f0de386487
Reviewed-on: https://gerrit.libreoffice.org/63630
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I8493685ceab81a2bd07a3fc75b371a0f679695fb
Reviewed-on: https://gerrit.libreoffice.org/63651
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

For whatever reason this now fails on Windows for multiple
users (including myself). Doesn't look like an easy fix is
possible, so this is reverted until I find some more time
to look into it (or give up on it).

This reverts commit baf0d6d6.

Change-Id: I432637131ba8ac8be614496bd6da0e157372ae94
Reviewed-on: https://gerrit.libreoffice.org/63664Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>

...and not for every target's recipe, once solenv/gbuild/CppunitTest.mk is
included

Change-Id: I710160def23fae5f93c5a67ab25e03fdaa008e00
Reviewed-on: https://gerrit.libreoffice.org/63655
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Icece4e008b653ce334808e3bee968792c4c9e99c
Reviewed-on: https://gerrit.libreoffice.org/63646Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

to make it easier to read.

And fix the last two fall back cases, where it was assigning a different
value to aLocaleStr than it was returning, which means that it would
return a different value on the second invocation.

Change-Id: I6cac1ddd23b0a6a9e4ae8a0b9e7d94c0d877de39
Reviewed-on: https://gerrit.libreoffice.org/63642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifdf46dc79f9b3e2b5ab4c9635619a9d7f598affc
Reviewed-on: https://gerrit.libreoffice.org/63654
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

@Test annotation was missing

Change-Id: I9e58026e5e131b18e35ab81d7927905316b58f11
Reviewed-on: https://gerrit.libreoffice.org/63653
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Fixes the preview on Customize tab page

Change-Id: If918522bda573c0f312b04592b4b7de957c9416b
Reviewed-on: https://gerrit.libreoffice.org/63649Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

add some unit tests, and improve the heuristics

Change-Id: I95aa97a87e178ce8d506bd245710d0ae66ad08a4
Reviewed-on: https://gerrit.libreoffice.org/63647Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

very weird code, no need for hiding this bool inside a method

Change-Id: I75ee67af32ab012fe5ab5ae766abc56212bb08e6
Reviewed-on: https://gerrit.libreoffice.org/63643Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I99f5ce24743a14a78d24da8c64bc6f9adfda6c4c
Reviewed-on: https://gerrit.libreoffice.org/63615Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

which arrived with
   commit bee74696
   Date:   Tue Feb 1 13:42:47 2011 +0100
    dba34d: limit invalidate calls
and looks extremely dodgy, because it means only the very first report
design window will be correctly configured.

Change-Id: I127c733faaddcacd8507fa74aebe3b6da761327f
Reviewed-on: https://gerrit.libreoffice.org/63641
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

(cherry picked from commit 58a04e69)

Change-Id: I3004f9607d9551e9c8bce1bedcfe8426ed392170
Reviewed-on: https://gerrit.libreoffice.org/63609
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I301a27edf47588d11080b91507b79be177a6f99c
Reviewed-on: https://gerrit.libreoffice.org/63608
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3b00ee5c851df368a98c6afa0b4c466fc8970fed
Reviewed-on: https://gerrit.libreoffice.org/63566
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I762eb7766a5cbe788c0a360c8a6f37b9b1106412
Reviewed-on: https://gerrit.libreoffice.org/63639
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

In DOCX, w:pos specifies the position of the current custom tab stop
with respect to the current page margins.
But in ODT, zero position could be page margins or paragraph indent
according to used settings DocumentSettingId::TABS_RELATIVE_TO_INDENT

Added new unit test.

Change-Id: Ic56a8527380b6562f4239df1edce0c9b4649af24
Reviewed-on: https://gerrit.libreoffice.org/63460
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Added checks for filter title, so filter titles are Windows
conform.

Change-Id: I42485c465ea58540a99b8300c5205b902cb86a92
Reviewed-on: https://gerrit.libreoffice.org/63573
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

See https://lists.freedesktop.org/archives/libreoffice/2018-November/081410.html

Change-Id: I258e08894486a925bed50a3a4232b6e805af6784
Reviewed-on: https://gerrit.libreoffice.org/63625
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...(ExprWithCleanups around the CXXConstructExpr in initializers for members of
O[U]String type, with older Clang, as used in
compilerplugins/clang/test/staticconstfield.cxx), and thus revert
e3e8d526 "Temporarily disable
compilerplugins/clang/test/staticconstfield" again.

Change-Id: Ic5fcdd1a26e4a6810369e4f9d909200d25feb12e
Reviewed-on: https://gerrit.libreoffice.org/63628
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I69ee7466d6e13d3b0c51c27a8668d567c0427a35
Reviewed-on: https://gerrit.libreoffice.org/63562
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I031faa67192f21d20938c8cc8056db138326a1ca
Reviewed-on: https://gerrit.libreoffice.org/63143
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I23956b671a24cc8ac85cec4ea6220d1107f99b1e
Reviewed-on: https://gerrit.libreoffice.org/63624
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ibcb56c6c0f1456c472061039ecc0835928846724
Reviewed-on: https://gerrit.libreoffice.org/63458
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Move XEnumeration Java test to C++
for ScIndexEnumeration_SubTotalFieldsEnumeration.

Change-Id: Ibe2b283e99230c5e517eb80858ff31459f2c9844
Reviewed-on: https://gerrit.libreoffice.org/63627
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

additional changes will come

Change-Id: Ia7f8c7d7b3c1471a4c851d1e362f1b67ef8e413c
Reviewed-on: https://gerrit.libreoffice.org/63055
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I442c4bf9acbd85f340371014c20be3292a016beb
Reviewed-on: https://gerrit.libreoffice.org/63613
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

This fixes OSX "make debugrun" by dropping VCL_HIDE_WINDOWS
handling and removing the internal GetPseudoHeadless() API.

While at it moves the DialogCancelMode enum out of Application.

Change-Id: I4876e752ddbfc39dd44faa673fb0e97810089a75
Reviewed-on: https://gerrit.libreoffice.org/61598
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Regression from commit af313fc1
(tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat
option, 2017-01-06), the group shape which covers most of the single
page in the document had a negative left position, while it should have
a small positive one (checking the drawingML markup).

This was a pre-existing problem, but now it's visible since we no longer
force objects to be on the page in Word compat mode.

Seeing the ODT import never positions group shapes (it's just a
container for child shapes), probably the DOCX import shouldn't do that
either. Start moving into this direction, first only for
absolute-positioned toplevel group shapes only, which already fixes the
bug.

Change-Id: I152ba06a81a2bd09195a4c724da4b8878b0457bb
Reviewed-on: https://gerrit.libreoffice.org/63606
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_SpreadsheetViewPanesEnumeration.

Change-Id: I03c05cd894bf84816618ac28deb01ecb2fd8779e
Reviewed-on: https://gerrit.libreoffice.org/63622
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

This is just a minimal solution and obviously not fully parallel.
We still have to walk the tree twice:
1. copy all needed headers to dist (export export_private)
2. the parallel build (libs)

The fixes are:
* Add a few rm and @$(MAKE_OBJDIR) calls to various targets
* Serialize minimal steps in nss_build_all
  => Build libs of nss/lib and nss/cmd/lib before all other
  => drop the minimal all target
* Make $(SHARED_LIBRARY) depend on $(LIBRARY), otherwise dll lib
  creation on Windows builds a static lib, instead of the dll one
* Drop all "export:: private_export" rules. We run this before
  the build and duplicate targets break the header install

Change-Id: I1c35985c90d2d63990e04a0d2bb9d8ae921a2182
Reviewed-on: https://gerrit.libreoffice.org/62011
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>