1. 06 May, 2019 14 kayıt (commit)
  2. 05 May, 2019 17 kayıt (commit)
  3. 04 May, 2019 9 kayıt (commit)
    • Jan-Marek Glogowski's avatar
      Qt5 IM allow committing empty strings · 00221089
      Jan-Marek Glogowski yazdı
      This is a really nasty bug, which is mainly triggered by focus
      change. It happens because Qt tries to delete the surrounding text
      on the first key press after focusing in, sending an empty commit
      string via QInputMethodEvent.
      
      To reproduce:
      * type some dummy word in Writer
      * select a part of the word
      * Alt+Tab to a different window to switch focus
      * Alt+Tab back to Writer
      * Press Alt => deletes the selected text
      
      Instead of Alt+Tab you can also switch the IM via hotkey.
      
      Change-Id: I0ce4c64aebf93a422bd3067f204da1d8f326a327
      Reviewed-on: https://gerrit.libreoffice.org/71796
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      00221089
    • Jan-Marek Glogowski's avatar
      Qt5 IM update input position on keypress · acbab790
      Jan-Marek Glogowski yazdı
      At least my ibus installation doesn't ask for the current input
      position (Qt::ImCursorRectangle), in comparison to fcitx. So just
      as gtk3, we now actively updates the IM position on every
      keypress. Fixes the ibus hint window position for me, which would
      otherwise be displayed in the top-left screen corner.
      
      Change-Id: I9e5f0fb6b134615bc00cdd169ce8592f01239d20
      Reviewed-on: https://gerrit.libreoffice.org/71785
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      acbab790
    • Jan-Marek Glogowski's avatar
      tdf#123957 Qt5 IM generate correct formating · da310336
      Jan-Marek Glogowski yazdı
      Actually really evaluate some of the formating provided by the
      QInputMethodEvent::TextFormat attribute and not blindly underline
      all of the text. This evaluates the same formating that the gtk3
      backend evaluates from pango, so the result should be somehow on
      par. Couldn't find a way to test the red strike-out text.
      
      Don't know how often I typed hyoujunnsutairu to test this bug,
      which - according to Google - translates to "standard style".
      
      Change-Id: I4263df6dc1e0e5ce5d8cb0be681656ccd662a830
      Reviewed-on: https://gerrit.libreoffice.org/71783
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      da310336
    • Jan-Marek Glogowski's avatar
      tdf#123956 Qt5 IM update cursor position · 110fd705
      Jan-Marek Glogowski yazdı
      This sets the cursor position to the one provided by the
      QInputMethodEvent::Cursor attribute.
      
      Change-Id: I4a99f9939b53c69631e45d41102bf9c7f53f0ff5
      Reviewed-on: https://gerrit.libreoffice.org/71782
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      110fd705
    • Michael Meeks's avatar
      unipoll: cleanup runPoll. · 7889e35d
      Michael Meeks yazdı
      Setting a custom thread name is a terrible idea for online unit tests.
      
      Change-Id: I1f5843255ab59072f806587ffcf655958380fe8e
      Reviewed-on: https://gerrit.libreoffice.org/71762Reviewed-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
      Tested-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
      7889e35d
    • Jens Carl's avatar
      tdf#45904 Move XComponent Java tests to C++ · 35608a19
      Jens Carl yazdı
      Move XComponent Java tests to C++ for ScShapeObj.
      
      Change-Id: Ib692827729dbe38eaceb76aa042d76e14d9614f8
      Reviewed-on: https://gerrit.libreoffice.org/71787
      Tested-by: Jenkins
      Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      35608a19
    • Arkadiy Illarionov's avatar
      Use hasElements to check Sequence emptiness in sw · 2ddc66e6
      Arkadiy Illarionov yazdı
      Similar to clang-tidy readability-container-size-empty
      
      Change-Id: If44f20a7aa678915e32d12101e1af71476f4b590
      Reviewed-on: https://gerrit.libreoffice.org/71679
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      2ddc66e6
    • Stephan Bergmann's avatar
      Don't truncate SCROW (aka sal_Int32) to sal_Int16 · dec6bb21
      Stephan Bergmann yazdı
      This looks like it was forgotten when changing other types to sal_[u]Int32 in
      6bda3610 "Fixed binary import/export of
      formulas", and now started to cause a
      -fsanitize=implicit-signed-integer-truncation failure during
      CppunitTest_sc_subsequent_export_test:
      
      > sc/source/filter/excel/xeformula.cxx:1878:32: runtime error: implicit conversion from type 'sal_Int32' (aka 'int') of value 1048575 (32-bit, signed) to type 'sal_Int16' (aka 'short') changed the value to -1 (16-bit, signed)
      >  #0 in XclExpFmlaCompImpl::ConvertRefData(ScSingleRefData&, XclAddress&, bool, bool, bool) const at sc/source/filter/excel/xeformula.cxx:1878:32 (instdir/program/libscfiltlo.so +0x3c936f4)
      >  #1 in XclExpFmlaCompImpl::ConvertRefData(ScComplexRefData&, XclRange&, bool) const at sc/source/filter/excel/xeformula.cxx:1905:5 (instdir/program/libscfiltlo.so +0x3c944ee)
      >  #2 in XclExpFmlaCompImpl::ProcessRangeRef((anonymous namespace)::XclExpScToken const&) at sc/source/filter/excel/xeformula.cxx:1981:5 (instdir/program/libscfiltlo.so +0x3ccba48)
      >  #3 in XclExpFmlaCompImpl::Factor((anonymous namespace)::XclExpScToken) at sc/source/filter/excel/xeformula.cxx:1152:37 (instdir/program/libscfiltlo.so +0x3cc6f6c)
      >  #4 in XclExpFmlaCompImpl::RangeTerm((anonymous namespace)::XclExpScToken, bool&) at sc/source/filter/excel/xeformula.cxx:1130:16 (instdir/program/libscfiltlo.so +0x3cc5d18)
      >  #5 in XclExpFmlaCompImpl::IntersectTerm((anonymous namespace)::XclExpScToken, bool&) at sc/source/filter/excel/xeformula.cxx:1116:16 (instdir/program/libscfiltlo.so +0x3cc453d)
      >  #6 in XclExpFmlaCompImpl::ListTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:1087:16 (instdir/program/libscfiltlo.so +0x3cc2b6f)
      >  #7 in XclExpFmlaCompImpl::UnaryPreTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:1077:20 (instdir/program/libscfiltlo.so +0x3cc23a0)
      >  #8 in XclExpFmlaCompImpl::UnaryPostTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:1056:16 (instdir/program/libscfiltlo.so +0x3cc121d)
      >  #9 in XclExpFmlaCompImpl::PowTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:1043:16 (instdir/program/libscfiltlo.so +0x3cc0498)
      >  #10 in XclExpFmlaCompImpl::MulDivTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:1030:16 (instdir/program/libscfiltlo.so +0x3cbf6e8)
      >  #11 in XclExpFmlaCompImpl::AddSubTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:1017:16 (instdir/program/libscfiltlo.so +0x3cbe968)
      >  #12 in XclExpFmlaCompImpl::ConcatTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:1004:16 (instdir/program/libscfiltlo.so +0x3cbdb98)
      >  #13 in XclExpFmlaCompImpl::CompareTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:991:16 (instdir/program/libscfiltlo.so +0x3cbce58)
      >  #14 in XclExpFmlaCompImpl::AndTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:974:16 (instdir/program/libscfiltlo.so +0x3cbba08)
      >  #15 in XclExpFmlaCompImpl::OrTerm((anonymous namespace)::XclExpScToken, bool) at sc/source/filter/excel/xeformula.cxx:957:16 (instdir/program/libscfiltlo.so +0x3cba5b8)
      >  #16 in XclExpFmlaCompImpl::Expression((anonymous namespace)::XclExpScToken, bool, bool) at sc/source/filter/excel/xeformula.cxx:934:20 (instdir/program/libscfiltlo.so +0x3c83a02)
      >  #17 in XclExpFmlaCompImpl::CreateFormula(XclFormulaType, ScTokenArray const&, ScAddress const*, std::__debug::vector<XclExpRefLogEntry, std::allocator<XclExpRefLogEntry> >*) at sc/source/filter/excel/xeformula.cxx:505:24 (instdir/program/libscfiltlo.so +0x3c7f2f3)
      >  #18 in XclExpFormulaCompiler::CreateFormula(XclFormulaType, ScRangeList const&) at sc/source/filter/excel/xeformula.cxx:2644:20 (instdir/program/libscfiltlo.so +0x3ca3801)
      >  #19 in XclExpNameManager::InsertBuiltInName(char16_t, ScRangeList const&) at sc/source/filter/excel/xename.cxx:790:57 (instdir/program/libscfiltlo.so +0x3ed04ab)
      >  #20 in XclExpNameManagerImpl::CreateBuiltInNames() at sc/source/filter/excel/xename.cxx:704:34 (instdir/program/libscfiltlo.so +0x3ec1794)
      >  #21 in XclExpNameManagerImpl::Initialize() at sc/source/filter/excel/xename.cxx:390:5 (instdir/program/libscfiltlo.so +0x3ebf79e)
      >  #22 in XclExpNameManager::Initialize() at sc/source/filter/excel/xename.cxx:771:13 (instdir/program/libscfiltlo.so +0x3ed1003)
      >  #23 in XclExpRoot::InitializeGlobals() at sc/source/filter/excel/xeroot.cxx:260:22 (instdir/program/libscfiltlo.so +0x416962b)
      >  #24 in ExcTable::FillAsHeaderXml(XclExpRecordList<ExcBundlesheetBase>&) at sc/source/filter/excel/excdoc.cxx:321:5 (instdir/program/libscfiltlo.so +0x3528545)
      >  #25 in ExcDocument::ReadDoc() at sc/source/filter/excel/excdoc.cxx:725:17 (instdir/program/libscfiltlo.so +0x35414f7)
      >  #26 in XclExpXmlStream::exportDocument() at sc/source/filter/excel/xestream.cxx:1106:18 (instdir/program/libscfiltlo.so +0x41ac136)
      >  #27 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at oox/source/core/filterbase.cxx:497:55 (instdir/program/libooxlo.so +0x2b35d6c)
      >  #28 in oox::xls::ExcelFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sc/source/filter/oox/excelfilter.cxx:238:27 (instdir/program/libscfiltlo.so +0x541148b)
      >  #29 in SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2422:25 (instdir/program/libsfxlo.so +0x4b991c3)
      >  #30 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1513:19 (instdir/program/libsfxlo.so +0x4b88f48)
      >  #31 in SfxObjectShell::DoSaveAs(SfxMedium&) at sfx2/source/doc/objstor.cxx:1892:17 (instdir/program/libsfxlo.so +0x4b9b44e)
      >  #32 in ScBootstrapFixture::saveAndReload(ScDocShell*, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags) at sc/qa/unit/helper/qahelper.cxx:671:13 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x916a2)
      >  #33 in ScBootstrapFixture::saveAndReload(ScDocShell*, int) at sc/qa/unit/helper/qahelper.cxx:693:28 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x939bf)
      >  #34 in ScExportTest::testTdf112567() at sc/qa/unit/subsequent_export-test.cxx:4219:28 (workdir/LinkTarget/CppunitTest/libtest_sc_subsequent_export_test.so +0x2c0836)
      
      Change-Id: I37582410068f2730d6f8dd0872b19fdfa8836c5c
      Reviewed-on: https://gerrit.libreoffice.org/71766
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      dec6bb21
    • Julien Nabet's avatar
      Replace list by vector for ConnectedComponentsList · 3ff0c23b
      Julien Nabet yazdı
      Change-Id: I2e64d4b61605267cca7709c1cfe50d35069f4459
      Reviewed-on: https://gerrit.libreoffice.org/71790
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      3ff0c23b