bt here:
https://bug-attachments.documentfoundation.org/attachment.cgi?id=129298

See also https://bugs.documentfoundation.org/show_bug.cgi?id=104227#c13 for more details

Change-Id: Ied497cfff2f71e67161d541b90fe48bb3e2456b9
Reviewed-on: https://gerrit.libreoffice.org/31593Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I45502d73939e99cd3d72c9d8aaa17dc820e78207
Reviewed-on: https://gerrit.libreoffice.org/31590Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

and remove unused implbase*.hxx and compbase*.hxx includes

Change-Id: Iedf6b6dce09b5baf714a1b3394bb7fb3526cca82
Reviewed-on: https://gerrit.libreoffice.org/31594Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ied9f9abcc75f2edcd518ac247907f573aa21f35e
Reviewed-on: https://gerrit.libreoffice.org/31158Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I11b3ca4c55151de7403ff9980ada9958d8ef12dc
Reviewed-on: https://gerrit.libreoffice.org/31592Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>

Change-Id: I7696f28e6b35e79e98614b295c749adebf33878b
Reviewed-on: https://gerrit.libreoffice.org/31439Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I5c0b9007e5a84643ccbe3c5b6b6a913a43667e18
Reviewed-on: https://gerrit.libreoffice.org/31573Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I1ee686ff96615f7b8aa69c0cd4caafaae07318b7
Reviewed-on: https://gerrit.libreoffice.org/31493Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I0c6610308f75a57e517b233db66c66b34eb25189
Reviewed-on: https://gerrit.libreoffice.org/31492Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Ibeb0aff07aec223f274932f2b3a492e58db09a02
Reviewed-on: https://gerrit.libreoffice.org/31488Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Ibcdc6a492abe5e26fb9b5244119be5dacc01b7b4
Reviewed-on: https://gerrit.libreoffice.org/31487Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I55ce4f6a9b033dc064beed8e70d35a5b5097846d
Reviewed-on: https://gerrit.libreoffice.org/31451Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

.. which are not paragraphs.

Note: For some reason in character attributes sequence
we have a wrong Any value for "CharPosture" property.

Change-Id: Ia45526c01cc381d3d6a1b56dbf4f03fdd38a0989
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/31591

Change-Id: Ie94c190f53904372aebfa15749b65c807052fcc7
Reviewed-on: https://gerrit.libreoffice.org/31589Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

and builds as root in that env, at least the default out of the box
experience is that for me, I suppose I could faff around getting it add a
user specifically for the build like I do for my coverity in docker
build, or just drop this.

This effectively reverts

commit 46625769
Author: Tor Lillqvist <tml@collabora.com>
Date:   Thu Apr 14 09:01:48 2016 +0300

    149

    Change-Id: I63f055756ff5f571d5ebe89aa4aee52d8ae2c510

I see your 149 and raise you a 1172

Change-Id: I3e81a725cdab1ff5ead0484dbfee11ac8fe303a9

make ctors with one parameter explicit

Change-Id: I08e753cea9f5ea17d654c889bad37ab7d0f4611e
Reviewed-on: https://gerrit.libreoffice.org/31588Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: I5b2c9455da5f700d0c4da59ee3d48e5aba486a55
Reviewed-on: https://gerrit.libreoffice.org/31583Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ia701f2b0a3c21e19b2de95c8012cc5a37ed88359
Reviewed-on: https://gerrit.libreoffice.org/31580Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Especially in the oox code there are many...

Change-Id: I16915cc207c274e5bcdb5d1f4f8708db5a0479a1
Reviewed-on: https://gerrit.libreoffice.org/31578Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: I6fa81689e14e605cd7449526e44245d4fdebb298
Reviewed-on: https://gerrit.libreoffice.org/31536Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: Ibe08034bcf2a73fb12562c87c2898db1e974376c
Reviewed-on: https://gerrit.libreoffice.org/31577Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I4e6fee65a1416398f6f59feb8734b3b00c0aed3b
Reviewed-on: https://gerrit.libreoffice.org/31570Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Iaca5837e5502ef8eed4cddbca1d00e00c71c53c2
Reviewed-on: https://gerrit.libreoffice.org/31576Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: Ica03ff03aa32d446335b6f6b8e6ec10f3c2c19db
Reviewed-on: https://gerrit.libreoffice.org/31569Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

This is the first version where hb_buffer_set_cluster_level() was
introduced. The layout engine depends on this feature in a few places
and though we can build without it, the result will be wrong in some
cases (i.e. any where we assume combining marks will have their own
cluster number).

Change-Id: I89187f317052e7933b83ad0350cace239333510b
Reviewed-on: https://gerrit.libreoffice.org/31521Reviewed-by: Rene Engelhard <rene@debian.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>

This is to fix a build after 67398a8d
No idea if packages should contain conditions too,
but at least gid_File_Bin_UnpackUpdate did not.

Change-Id: I56e1b23f6eeca9c62cdadd8d93de6ccda89b20c4

Which just lead to confusion as could be seen in two earlier commits..

Change-Id: I172127cf08bcd45c3c53e0cf00cf11a41e0dd3a6

Change-Id: Ifcfc4588d5bd6f713a40bd2300740f7a1c52337c

Assuming that the screenshots directory suffix
* should match the configured UI locale instead of the work locale
* should not be empty if configuration says "Default - ..."
  * actually ScreenshotTest::implSaveScreenshot() explicitly tests
    (maCurrentLanguage == "en-US") and then sets the suffix to empty, so no
    other locale should exhibit the same

Change-Id: Ie4561315b67c3ade20f3947772af45e471d0752f

Testing for GetLocaleConfigString() starting with a language code could never
have worked if configured was "Default - ..." in which case the config string
is an empty string.

Change-Id: I3a68a168a0f8e53c8c389fc243e40053f5d45e1f

And a little cleanup.

Change-Id: Id066b4d37e217b8ab21ea162c23a999566a9e190

Change-Id: I5bd3a5f6168b20c925f5713085fcb0918bcccc8e

Change-Id: Iecf059b974b996fceb57b04197c7dac9b7c8dd47

we're presented with...

CXX="/usr/local/bin/clang++"
CC="/usr/local/bin/clang"
CXXFLAGS="-g -stdlib=libc++"

and out of the box we fail to build, but if we reshuffle to...

CXX="/usr/local/bin/clang++ -stdlib=libc++"
CC="/usr/local/bin/clang -stdlib=libc++"
CXXFLAGS="-g"
LDFLAGS="-lpthread"

then with this distro-config we build to completion

Change-Id: Ib6bee4dd69e0609e3c1238d86837a1680483ffa4

There does not seem to be any need for that atom thing as we are
perfectly happy using plain OUStrings in the same struct, not to mention
that font names are supposed to be unique so I don’t see what we are
saving here.

As this was the only use for unotools/atom, it goes with it.

Change-Id: If9d58d84fff0403f9b2c41fe594b99028b30c2f4
Reviewed-on: https://gerrit.libreoffice.org/31520Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

tables that span multiple pages, and rows greater than one page
caused problems, so just removing the enhancement that tried
to emulate what the original odt looked like.

reverts commit 129f93e4
from bug tdf#91083

Change-Id: Iac31116d731e1e4aa60ee6b8de973f7f9291e47a
Reviewed-on: https://gerrit.libreoffice.org/31551Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

gets vcl built anyway

Change-Id: I521a53019f54d5e42c931043c758143f2f8bdb1d

This was the last unit test that was disabled on Windows due to missing
implementation.

Change-Id: Ia7d84f72bcdf79267c7de17cd8822ed02c378642
Reviewed-on: https://gerrit.libreoffice.org/31552Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I5e6a6debf01886c283f5a2d6b9cacc00a44f7134

Change-Id: Ib553e085337972f74857db0aad9bc885712d5ea3
Reviewed-on: https://gerrit.libreoffice.org/29788Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>