Change-Id: I8c35ddf047751cf06707efbbe11730414767a0af
Reviewed-on: https://gerrit.libreoffice.org/69416
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I2347e66c79e54ad0de33f51470e78e0bdf18cbac
Reviewed-on: https://gerrit.libreoffice.org/69426
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

(lexicographically, by Unicode code point values; to make it easier to add
further entries)

Change-Id: I0ed54cb96a088975c30cb21372acf191ce05731e
Reviewed-on: https://gerrit.libreoffice.org/69425
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Idae750fe2e648d5ae15a691c02a53985d88f90f3
Reviewed-on: https://gerrit.libreoffice.org/69423
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9b08595f5dc7ca0bd3e86891330dd1caa0446e63
Reviewed-on: https://gerrit.libreoffice.org/69417
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If08731217c0839ebd8d51399bb0dd1a3b598dceb
Reviewed-on: https://gerrit.libreoffice.org/69420
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... for easier maintenance. This commit only introduces the
framework. Follow up commits will update the license file.
Advantages:
* single source, multiple outputs (html, txt)
* conditional text, i.e. output will not include license
  terms of components that are not configured in the build

Change-Id: I0ffad41119228a0a26fd1b6ce19930ca6085adb2
Reviewed-on: https://gerrit.libreoffice.org/69396
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

* Update helpcontent2 from branch 'master'
  - remove empty paragraph, fixes a helpex warning
    
    Helpex warning: invalid po attributes extracted from /home/timar/libreoffice-master/helpcontent2/source/text/sbasic/python/python_shell.xhp
    No string specified!
    GroupID: N0120
    
    Change-Id: Ia3fa7d88f4756fd700eebcceb4480e0a553a5482
    

The patch enables a message or notification box which notifies
the user with the message *No dictionary available*
in case there is no dictionary available for any content.

Change-Id: I61fa01ea469acb345637ab86da98a8de8f8a9762
Reviewed-on: https://gerrit.libreoffice.org/69366
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: Ia5880f81aac7df1766ce306d175f80f64920b4d7
Reviewed-on: https://gerrit.libreoffice.org/69409
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Some of the icons embedded multiple fonts in base64 encoded form.

Commands run:
find . -name '*.svg' -exec sed -i '/<style.*/,/<\/style>/d' {} + \;
find . -name '*.svg' -exec sh -c 'svgcleaner "$1" "$1"' x {} \;

Svgcleaner being https://github.com/RazrFalcon/svgcleaner

Change-Id: Iffff65438a6ed34ed956aeff041c6f8925cffdaa
Reviewed-on: https://gerrit.libreoffice.org/69385
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

 #0  0x00007f8dc781e4dc in __lll_lock_wait () from /lib64/libpthread.so.0
 #1  0x00007f8dc781a1b8 in _L_lock_820 () from /lib64/libpthread.so.0
 #2  0x00007f8dc781a088 in pthread_mutex_lock () from /lib64/libpthread.so.0
 #3  0x00007f8dc81d57d1 in lookupThreadId (hThread=140246229497600) at sal/osl/unx/thread.cxx:585
 #4  0x00007f8dc81d5aa4 in osl_getThreadIdentifier (Thread=0x0) at sal/osl/unx/thread.cxx:701
 #5  0x00007f8dc8173fa0 in osl::Thread::getCurrentIdentifier () at include/osl/thread.hxx:138
 #6  0x00007f8dc81736ba in sal_detail_log (level=SAL_DETAIL_LOG_LEVEL_WARN, area=0x7f8dc81f2e53 "sal.osl",
     where=0x7f8dc81f3130 "sal/osl/unx/process.cxx:238: ", message=0x5bd5b90 "Failed to exec: ENOENT", backtraceDepth=0)
     at sal/osl/all/log.cxx:279
 #7  0x00007f8dc816d166 in sal::detail::log (level=SAL_DETAIL_LOG_LEVEL_WARN, area=0x7f8dc81f2e53 "sal.osl",
     where=0x7f8dc81f3130 "sal/osl/unx/process.cxx:238: ", stream=..., backtraceDepth=0)
     at include/sal/log.hxx:50
 #8  0x00007f8dc81c1ddc in ChildStatusProc (pData=0x7f8d9e302a90) at sal/osl/unx/process.cxx:238
 #9  0x00007f8dc81d49a6 in osl_thread_start_Impl (pData=0x6757780) at sal/osl/unx/thread.cxx:235
 #10 0x00007f8dc7817f6b in start_thread () from /lib64/libpthread.so.0
 #11 0x00007f8dc7b227ed in clone () from /lib64/libc.so.6

Change-Id: I611cf907f89c7a1d8cdc3a9c42f449e8daaa2614
Reviewed-on: https://gerrit.libreoffice.org/69363
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ic4919fa3caa2106598ed8da3cec5deffa506eee1
Reviewed-on: https://gerrit.libreoffice.org/69401
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I0a121bbc16c3aabf7873f79ff037b1085d42867b
Reviewed-on: https://gerrit.libreoffice.org/69407
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I42579d4d61be43318f7e2b06b3465890dd624a12
Reviewed-on: https://gerrit.libreoffice.org/69035
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Ic1b6e4e62f4acdeac69b1f1c076bc343cc0b1595
Reviewed-on: https://gerrit.libreoffice.org/69406
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I6c3ae806cbb4a00381e39414ff8c8fede5bf1733
Reviewed-on: https://gerrit.libreoffice.org/69150
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Regression from commit b2c1474c
(SwTxtNode::IsIgnoredCharFmtForNumbering: ignore RES_CHRATR_COLOR,
2014-11-20), where the problem was that unconditionally ignoring or not
ignoring the font color is not correct.

Re-examining the test document from the above commit, it has an explicit
font color set in the numbering, while this bugdoc doesn't have it.

So make applying the paragraph mark font color to the numbering
conditional if the numbering already has a color set, this makes both
cases work correctly.

Change-Id: I43a6dec7d3a77689e2acbdc9d3671e79a9c4cac8
Reviewed-on: https://gerrit.libreoffice.org/69400
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I89570a5758a29e88adfab6114ea93e7805c13699
Reviewed-on: https://gerrit.libreoffice.org/69404
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

- writer test apitest suites are now called like the UNO implementation they
  are testing
- also mark them final for good measure
- move tests to module test and try to match its conventions
  * BaseIndex
  * TextDocumentIndex
  * TextDocumentSettings
  * TextPrinterSettings
  * TextSettings
  * XDocumentIndex
- also remove anonymous namespace in header, as that is a bad idea
- also remove now obsolete ApiBaseTest
- also remove dead code in TextPrinterSettings
- remove writer xtextcontent test as it duplicates the impl in module test

Change-Id: I71aa5f3755d5c90726f4ff4394117fa2391495d7
Reviewed-on: https://gerrit.libreoffice.org/69374
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: I4a949aeba3302fb86f371309a49dfdd53e65cbdf
Reviewed-on: https://gerrit.libreoffice.org/69405
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If44be0f1184d3af18fe4af4f70717afb2d5feb75
Reviewed-on: https://gerrit.libreoffice.org/69403Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I21008bf17641977b61b1735bb27bc54f24beda4a
Reviewed-on: https://gerrit.libreoffice.org/69382
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I5ae3965aa681ea1f5a005fbc8dad4d0ce36af1b3
Reviewed-on: https://gerrit.libreoffice.org/69373
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...or else

  -MF $(CLANGOUTDIR)/sharedvisitor/generator.d

in the command line for building the generator exe could produce a failure
because the dir does not exist yet.  (The dependency of compilerplugins-build on
$(CLANGOUTDIR)/sharedvisitor had been added with
adb08e89 "make (some) clang plugins share the
same RecursiveASTVisitor" for reasons that are not clear to me.)

Change-Id: I124b95be5e8ba36dc5d7502208c61ccf045516f5
Reviewed-on: https://gerrit.libreoffice.org/69307
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...which apparently didn't take into account that inserting into a
std::unordered_map may invalidate iterators, which now started to cause build
failures like

> [PRP] dictionaries/hu_HU/dialog/hu_HU_de
> warn:sal.osl:25175:25175:sal/osl/unx/thread.cxx:1026: RTL_TEXTENCODING_DONTKNOW -> _ASCII_US
> .../gcc/trunk/inst/include/c++/9.0.1/debug/safe_iterator.h:307:
> In function:
>     __gnu_debug::_Safe_iterator<_Iterator, _Sequence, _Category>::pointer
>     __gnu_debug::_Safe_iterator<_Iterator, _Sequence,
>     _Category>::operator->() const [with _Iterator =
>     std::__detail::_Node_iterator<std::pair<const rtl::OString,
>     std::unique_ptr<MergeData> >, false, true>; _Sequence =
>     std::__debug::unordered_map<rtl::OString, std::unique_ptr<MergeData> >;
>     _Category = std::forward_iterator_tag;
>     __gnu_debug::_Safe_iterator<_Iterator, _Sequence, _Category>::pointer =
>     std::pair<const rtl::OString, std::unique_ptr<MergeData> >*]
>
> Error: attempt to dereference a singular iterator.
>
> Objects involved in the operation:
>     iterator "this" @ 0x0x5a8228 {
>       type = std::__detail::_Node_iterator<std::pair<rtl::OString const, std::unique_ptr<MergeData, std::default_delete<MergeData> > >, false, true> (mutable iterator);
>       state = singular;
>       references sequence with type 'std::__debug::unordered_map<rtl::OString, std::unique_ptr<MergeData, std::default_delete<MergeData> >, std::hash<rtl::OString>, std::equal_to<rtl::OString>, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeData, std::default_delete<MergeData> > > > >' @ 0x0x5a81c8
>     }
> /bin/sh: line 1: 25175 Aborted                 (core dumped) LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}"$I/program:$I/program" $W/LinkTarget/Executable/propex -i $S/dictionaries/hu_HU/dialog/hu_HU_en_US.properties -l de -m ${MERGEINPUT} -o $W/PropertiesTranslateTarget/dictionaries/hu_HU/dialog/hu_HU_de.properties
> make[1]: *** [.../solenv/gbuild/Dictionary.mk:88: .../workdir/PropertiesTranslateTarget/dictionaries/hu_HU/dialog/hu_HU_de.properties] Error 134

with trunk libstdc++ in debug mode.

Both classes MergeData and MergeDataHashMap became redundant.

Change-Id: I771548a6155e14037d84acfd74cd13566a26a8d7
Reviewed-on: https://gerrit.libreoffice.org/69395
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: If48e6d75288b42b47c90f3104006b7c52982c9f6
Reviewed-on: https://gerrit.libreoffice.org/69372
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I30a3c35619d0d2d22789303f2f8d3d92d7b9223d
Reviewed-on: https://gerrit.libreoffice.org/69393
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

...where index_type has changed from ptrdiff_t to size_t, see <https://
github.com/cplusplus/draft/commit/7f2493e2e2d34b42a6c12c8806e536d4feb3aee3>
"P1227R2 Signed ssize() functions, unsigned size() functions".  Ideally,
ece27693 "Adapt to C++2a std::span<>::index_type
being unsigned size_t" could be simplified now to use std::size_t, but there may
be build environments that include a C++2a <span> that hasn't been adapted to
P1227R2 yet.

Change-Id: I7bfc0da65d415ef06e94d95b5f62030aeb8b35f6
Reviewed-on: https://gerrit.libreoffice.org/69391
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

As seen while cleaning sd/source/ui/dlg/TemplateScanner.cxx

Change-Id: I31a6892b4419947a411b2c4100281d4cf7c50f09
Reviewed-on: https://gerrit.libreoffice.org/68969
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

of MSO 2007/2010 documents with "automatic" chart area
formatting, setting also the default 0.75 pt border width
and light gray border color.
 
Note: MSO 2007/2010 and MSO 2013/2016 have different
"automatic" border colors. This fix uses the last, light
gray version instead of the dark one.

Change-Id: I579f3745d5fcb2a36e1b4d519320631d20e60fd4
Reviewed-on: https://gerrit.libreoffice.org/69341
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Explanation of the patch: in the Windows version of LibreOffice,
when calling the basic Shell(...) function (located in
basic/source/runtime/methods.cxx), a function is_batch_file()
is called in turn, to check if the program file path to execute
is a batch or an executable.

The function is_batch_file() is located in sal/osl/w32/procimpl.cxx
and simply checks if the file extension is equal to bat (or cmd or
btm).

This works as expected, except when the file path contains space
characters. In that case, the file path is *quoted* before the
call to is_batch_file() and for a batch file the file extension
becomes bat" (note the quote) instead of bat, and thus the call
to is_batch_file() wrongly returns false in that case.

In this patch, the issue is fixed by changing the function
get_file_extension() to make it return the correct extension
(i.e. without the '"' character) when the file name is quoted.

Change-Id: Ib6e74da87b23d64db925c17f8a26617f1a86a83d
Reviewed-on: https://gerrit.libreoffice.org/69230
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I3f28ad64c13dd4bc1b2862e86d2190e46a0ced46
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/67779
Tested-by: Jenkins

Change-Id: Ia0cc331998d735002dda5eedff8dad3bfbd53979
Reviewed-on: https://gerrit.libreoffice.org/69235
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I95978d4e32268c66cde5fb0d9e0360000fe2a560
Reviewed-on: https://gerrit.libreoffice.org/69379
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

... SwFormatFootnoteEndAtTextEnd

Change-Id: I2b092c8a6d713e2741e99f334b2e9d2247cde6c2
Reviewed-on: https://gerrit.libreoffice.org/69380Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Use pylint to identify style and convention errors in
xscriptprovider.py. Also make use of setUp and tearDown
methods to streamline the class and reduce code
duplication.

Change-Id: Iee4addb6577c304c5ced4e2d246c4bb557d2b6f4
Reviewed-on: https://gerrit.libreoffice.org/66197
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I1dcb41b404d69e7437a2cc6f22d3391bb91f3acc
Reviewed-on: https://gerrit.libreoffice.org/69216
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ied6cc17887df0baabcc51ad85041a7a4fe966e72
Reviewed-on: https://gerrit.libreoffice.org/69377
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ieaf341dd13e06046044f3523c3aad74476160402
Reviewed-on: https://gerrit.libreoffice.org/69328
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>