Project: help  864de3b4e95b4550d7cfdb99ff2188e63f140cd0

Fix typo in AGGREGATE function help page

Change-Id: I0701328d135968735bec3b30adeba64fc6138f04
Reviewed-on: https://gerrit.libreoffice.org/21051Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>

Change-Id: I253f71f851621d8a3d1244468b9da63ba2d10b09

Change-Id: Ic6407a57440fbd887f9ec9d5963e5748aa89a29e

Change-Id: Ia35f2ec1b27373243736172f1d91c03bb2622c64

Change-Id: Ib2520679c3d62991f4ae6c5a325a44ab3cce1d89

Also significantly simplify, and remove paranoid ramblings
from the flushing code.

Change-Id: Ie7cc742caac290d77ac931c54cc4fe777a7872de

Change-Id: I959c0874c670027e79163ded6a1d8c8b55d66376
Reviewed-on: https://gerrit.libreoffice.org/21045Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I3085e2d2848e2041c2faadbfce099ce75c62b712
Reviewed-on: https://gerrit.libreoffice.org/21043Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I5b09d1777c994acaf25457e786222886b2435af8
Reviewed-on: https://gerrit.libreoffice.org/21042Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Project: help  efa3b7d1e3eb003e6babb49c9b83c47979da0a89

Fix tdf#86428 Wrap text help page duplicated

Fix for tdf#86428  Help Page “Wrap” Exists Two Times in Local Help

Wrap text help page 05180000.xhp was replaced by 05060200.xhp but
left there because of a link from the main format help page.

The 05060200.xhp page now carries the recent changes in Writer UI
and context menus.

Wrap page from guide (main0105.xhp) also updated.

Change-Id: Icd0c015ceca89dc1e3f8f7200ffe491ddb03ff7b
Reviewed-on: https://gerrit.libreoffice.org/21023Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Project: help  dd8cc9d27b6891661185f02bf7478b5934deff08

COUNTIFS: add missing argument name

Change-Id: Ic099ea1272f1c8c0ea6804cd77b15c75159d084b
Reviewed-on: https://gerrit.libreoffice.org/21014Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Use Qt submodule notation for Qt includes and also "correct"
some KDE headers AKA use <> notation for external headers.

Change-Id: I9457f75baae56514989800b016a11348a72a242b

Generalize the UnoMark pretty printer to actually print many
objects inheriting from sw::mark::MarkBase.

Also adds the mark name to the output.

Change-Id: Idaec06ba448702ee3a47b474736df954646c0300

Adds the missing unit test to the bugfix.

Actually the original bug was a crash, so this just
does some test on the resulting MM document.

Change-Id: I4c9f031e57157fe5744aa8290b7503b7e1990fc7

... when inserting text into a text node.

Seems SwTextNode::InsertText doesn't handle bookmark end
positions correctly. This is just handled correctly, if it
also contains the bookmark start.

This workaround simply concats the three strings to be
inserted in advance, so we just have to call
SwTextNode::InsertText once for the whole string.

Change-Id: Iab7708b4cc4df406bdbc3a685c7410e0e797fdc4

(likely a bad sign that this compilation unit, defines lots of UNO
interfaces without ever using a SolarMutexGuard)

Change-Id: I2cca810f8e4e1684c75d9185d701024f692403a4

Change-Id: I79623024b008b60a33935942986e8a98fccc3d8d

Change-Id: I8a02be2772b8f7c0d1b13556d0c49f1b00bcc1aa

- mpItemSet is assumed to be owned by SwStyleBase_Impl
- yet it can be external set to any naked pointer
- ... and is (temporary, at least that is the hope) set to ItemSets
  owned by others

Change-Id: I0cd56f5bb9f58a2e5ab09f49f66faf8a63c69f37

... also kill some plenking

Change-Id: I03c0669239bba5f63a7dc5a078f5b4c4f2a51386

- reduce scope of getConstArray variables
- use m_nPropMapType directly
- remove some plenking

Change-Id: Id507cffe2563bf078fe5e3e2a8267f352533844e

Change-Id: Ifc81677eb3331a786a964f89aa425916df6364b4

Change-Id: I3b8b85d91c2b19dc3cf6cba95d258ea639dd9862

The *only* things relying on the in-built magic number are PDFFontCache
and PDFWriterImpl. PDFWriterImpl::emitBuiltinFont has as its first
parameter a const PhysicalFontFace*, but this is only called upon by
PDFWriterImpl::emitFonts, which instantiates an ImplPdfBuiltinFontData
object from a built-in font map... so basically it is always guaranteed
to get a ImplPdfBuiltinFontData object. ImplPdfBuiltinFontData derives
from PhysicalFontFace, so to prevent the need to check the class being
used is a ImplPdfBuiltinFontData, just make emitBuiltinFont require as
it's first parameter ImplPdfBuiltinFontData!

Unfortunately, we can't get around RTTI completely, because
PDFFontCache::FontIdentifier requires a way of distinguishing between
two different PhysicalFontFaces...

Change-Id: I74c8cd294580bbecd12dd2427ac405f97a7e7f7e
Reviewed-on: https://gerrit.libreoffice.org/21030Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I5d15ab7f8d9b7cb3ff0124f20c840dd2a285b400

Change-Id: If8da668cba96364189de3b0aa89b43110cc41f9b
Reviewed-on: https://gerrit.libreoffice.org/21034Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I09c1ccb850f0cb2365e52ee6ffd293ccf34ad00e

This reverts commit 60676b3b.

The FontMapStatus structure is passed as a reference to save the
search state outside of the search loop in
PhysicalFontFamily::FindBestFontFace.

This *looked* like it would be an easy win, evidently not! Back to
the drawing board.

Change-Id: Icc7078543e50bc34221127d8df055f056e249cdb

Change-Id: Ie4d03a01c557e93a3ba3b5925896e38ed07f9a27

Change-Id: Ic94f94148397d46d4442f2290d331438c0799f75
Reviewed-on: https://gerrit.libreoffice.org/21029Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I097f1c1fb7fb505b6859289997bff3562fc06ba6
Reviewed-on: https://gerrit.libreoffice.org/21027Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Very silly mistake - I put in an else, where it should have been an
entirely new if statement... this will have broken font mapping :(

Change-Id: I026b1f3808cb3a3793467fa3b2670bf9b56e3c5c

Always wanted to write a commit that said this.

Change-Id: I52f6a188e2d115eef9a1e3f702ed127fea3ebb4c

It's used exactly once, as a parameter of PhysicalFontFace::IsBetterMatch()'s
function signature. That parameter only acts as input, so I think this is a
case of YAGNI creeping into the code, thus I'm getting rid of it.

Change-Id: Ic5e24f484d652ba2196e512795d0d27f4239df30

Change-Id: Ic56ed5b33f2a00bda27779b7b7450b95a1dfb14b

ImplFontAttributes handles device independent data, whilst
ImplDevFontAttributes handles device dependent data. However, there
is no real reason for the divide in classes, and in fact I'm not at
all a fan of using a pImpl directly - sort of defeats the purpose of
having one!

Change-Id: I2db22727e3479b14e3bc37dfad9136703bbdeb13
Reviewed-on: https://gerrit.libreoffice.org/21018Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I8488cb8e8074831a6f81e6c8c122462c9819d25d
Reviewed-on: https://gerrit.libreoffice.org/21025Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Id9c67638e5c2e535cc06e9566c9a169471f55da8
Reviewed-on: https://gerrit.libreoffice.org/20856Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

These were missed during the removal of NPAPI.

Change-Id: Ie6233a755cd8f2995692fb8790bd65055d100251
Reviewed-on: https://gerrit.libreoffice.org/21015Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iecff49f04e4b68f071d63217943891a31a610aeb