Reviewed-on: https://gerrit.libreoffice.org/19375Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit f34ac236)

Conflicts:
	sc/source/ui/cctrl/checklistmenu.cxx

Change-Id: I0a1ad60cb6eea26899604641f981642943b06347
Reviewed-on: https://gerrit.libreoffice.org/19452Reviewed-by: Dennis Francis <dennisfrancis.in@gmail.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 01af5056)

Seems that people prefer this to be CPPUNIT_ASSERT() instead of
assert().

My first thinking was that there is a slight difference in meaning;
that assert() checks that the code (or, in this case, data) in the
test *itself* is as expected while CPPUNIT_ASSERT() checks that the
functionality *somewhere else* works as expected. But whatever.

Change-Id: I93f7f8cf2b3aac9e8fc35baf2dcbad1a4003773f
(cherry picked from commit 2438f18b)

Gtk 3.18 has the filename entry in the header too.

Change-Id: Id1abf5baf0e82c03e27ede2bfc67ec1983a2c4fb
(cherry picked from commit c1b97d27)
Reviewed-on: https://gerrit.libreoffice.org/19427Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit b9996778)

bool ScDocShell::isTiledRendering() const crashed without this check

Change-Id: Idb7ace05eb1aa37cbc3d956503c046b0e9b9d0e5
Reviewed-on: https://gerrit.libreoffice.org/19570Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I1b44c9fa4edfdc79e48f52ba95493f83f0421669
(cherry picked from commit 075c4db2)

Change-Id: I41d25d288253f1b35c268ba70b8384812fa567e5
(cherry picked from commit c8dcec92)

Change-Id: Icf3973d20455fd9ccde3a448b9596457ef5308a3
(cherry picked from commit 03089170)

Change-Id: I36f88d7e1114096d1e7a7a1d29077c387c21a10a
(cherry picked from commit 3c9da1fb)

So that we don't render the entire document in the thumbnail ;-)

Change-Id: Ic19f403b68bd2e2e748138a861d55e41742250e0

It turns out that Base already has a similar property called "PickListEntry".
Let's make it consistent then, and rename "AvoidRecentDocs", so that it works
in all the apps the same way.

So instead of setting "AvoidRecentDocs" to true, set "PickListEntry" to false.

Change-Id: Idf0dd8e8892218f387944f0ad43b292c4b052be6

Change-Id: I292281e300e8976bf5ae286262a6a3e20de41858

When "AvoidRecentDocs" is set to true, the loaded document is not added to the
recent documents list, avoiding the (a bit expensive) thumbnail creation.

Useful when loadComponentFromURL() is called from macros, or when LibreOffice
is controlled via UNO.  See the bug for an example.

Conflicts:
	sfx2/source/doc/objxtor.cxx

Change-Id: I99d516cae8b278199a01276686465f716b9b4cec

Change-Id: Iae0e89646eab794879529274f09839ad34aa4696
(cherry picked from commit 03bb5d52)

Change-Id: I7530281302b9787a9cb9f98f0dee9d98d39cfb05
(cherry picked from commit d42c3e0d)

Change-Id: I5a80fe3eb55caa6e57c7842e5ac74cd1abb93f0b
Reviewed-on: https://gerrit.libreoffice.org/19471Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I8fc36ac3aaf31abff84f53b1ba832e02145f6b99

This commit fixes the writer image export (jpeg, png) that didn't
work because the export pixel size was set to 0 by default. Now
the default is set to document size (which depends on system DPI).

When exporting to a PNG the background was transparent, which may
not  be desired. The background color is now by default white and
can be changed for DocumentToGraphicRenderer, but the dialog or
command line don't support such an option - for now.

Change-Id: I16ffd3cd60c47b52768f43ae4c4c170fc821033b

Change-Id: I21f4bc6fe6cb10e57c45880a4b6d1be2e4fb88d2
(cherry picked from commit 7df1b63b)

Change-Id: I987262e4e9ae99c889285658fc9f840655d29191
(cherry picked from commit 2ca4748a)

Reviewed-on: https://gerrit.libreoffice.org/17476Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
(cherry picked from commit 525b1c2c)

Conflicts:
	sc/uiconfig/scalc/toolbar/standardbar.xml
	sd/uiconfig/sdraw/toolbar/standardbar.xml
	sd/uiconfig/simpress/toolbar/standardbar.xml
	sw/uiconfig/swriter/toolbar/standardbar.xml

Change-Id: I175d27311fa166d3d33f2d88184b1fcd01f5df6a

Reviewed-on: https://gerrit.libreoffice.org/19178Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
(cherry picked from commit e495bf39)

Conflicts:
	sfx2/uiconfig/ui/startcenter.ui

Change-Id: I7bede0cb520f446582d01bc0e5f583ddf4655ce0

Change-Id: I00b64e2e60596094f74beb729b37eff36e544fd2
(cherry picked from commit 419549b0)

Change-Id: Ia368eb83202b65d77777874b7e7948f9f3169c58
(cherry picked from commit 2052a854)

Reviewed-on: https://gerrit.libreoffice.org/17755Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
(cherry picked from commit cd3ca5b2)

Conflicts:
	svx/source/dialog/imapdlg.cxx

Change-Id: Id69a03b0379becc4c267a85eb7567bbbd41ccf82

Edit control needed a disposeAndClear instead of a clear

Change-Id: I24f4ec8c391080cb83574949cc141c883b43cfb9
Reviewed-on: https://gerrit.libreoffice.org/19185Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
(cherry picked from commit f9157d1a)

Change-Id: I296ce6233287dac5447462faa4b7404c25297f8b
(cherry picked from commit 87297284)

Avoid the horrible convention of hard-coding in a C++ unit test code
addresses of data in the spreadsheet document being tested. Instead,
mark the expected (= as calculated by Excel) and calculated (by
LibreOffice) formula results, rectangular blocks of data, so that the
C++ code can easily find it, and then compare. This is much more
flexible. No need to edit hardoded row and column numbers in the C++
code when adding more test data.

The systematic.xls file has documentation on how to maintain it.

Change-Id: I4fb088fe21831dd3b3213d21916460a708aa0842
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 9db43e72)

Used the same style as existing code, added a new virtual isMinOrMax()
and add some special casing in Reduction::GenSlidingWindowFunction(),
and fsim_count() and fmax_count() functions that count how many
non-NaN numbers we actually see. As such, I am not sure at all that
this is an ideal way to do this, but will have to do for now.

Change-Id: I846a8d24f4563f8fae1a45971a4ce202ed918487
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 127c2683)

Change-Id: If7326fd1242d90ff92e62d141714960476198605
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit a6fa35ab)

Not sure why the code from f5e72070
did not produce correct results any longer. Anyway, now OpenCL
division works right in case of empty or zero cells.

Clearly I need to add unit tests to make sure this stuff keeps
working. In later commits.

Change-Id: I93b787ad5da453af1601768308fb614a332ed142
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 958ef1a5)

We get correct result by simplifying the code;)

No need to have the outer "if (gid0 < X)" test around the calculation
code generated by Reduction::GenSlidingWindowFunction(). The lhs and
rhs check the gid0 range themselves and that leads to the desired
result for subtraction.

While fixing this I noticed that the handling of empty cells in
division is also wrong. Will fix in another commit.

Change-Id: Ia45bd81e692a17b0453cc79cd4673a00e119562a
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit b76c450e)

Added a Windows API missing error.

The error added:

ERROR_CANT_ACCESS_FILE
returned when a file cannot be accessed by the system.

Mapped to existent osl_File_E_.... for compatibility.

Change-Id: Ia68cdf761a62db8960b143a69ccfa3e12fc6eac5
Reviewed-on: https://gerrit.libreoffice.org/19270Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit b49a2f73)
Reviewed-on: https://gerrit.libreoffice.org/19374Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 9a75c724)

Change-Id: Ia7748eae16c35a1d197b9f4aa5f391f496e7f2f2
Reviewed-on: https://gerrit.libreoffice.org/18122Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 861a9369)

was... fixes memleak : clear self referring VclPtr in MetricBox

Clears self referring VclPtr called mpField in MetricBox (inherited from FormatterBase class)
via dispose() method of MetricBox.

Reviewed-on: https://gerrit.libreoffice.org/18674Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 36c11cb7)

Change-Id: I375e03e814de3c6e47c36b1fc6f625b04521a5e2

memleak:clear self referring VclPtr in *Field and *Box classes

Clears self referring VclPtr called mpField via FormatterBase in :

1. MetricField, PatternField, NumericField, CurrencyField, DateField,
   TimeField
2. PatternBox, NumericBox, CurrencyBox, DateBox, TimeBox

via respective dispose() methods.

Change-Id: I7f92fefd49756cabe7db7d240781260a2d4cd298
Reviewed-on: https://gerrit.libreoffice.org/18701Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit a44e03b5)
Reviewed-on: https://gerrit.libreoffice.org/19397Reviewed-by: Dennis Francis <dennisfrancis.in@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 1995ad7d)

Change-Id: I3c9a5f89df721618bb60b8932b69a371bb6f3ff1
(cherry picked from commit 0d79e4c0)
Reviewed-on: https://gerrit.libreoffice.org/19366Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 4bfde740)

Change-Id: I2e4d1c79f57ec048d66111ed393491b7803ee3b9
Reviewed-on: https://gerrit.libreoffice.org/19387Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 87f3db9b)

Seems that first/last button are still useful when there are a lot
of tabs. Using ctrl+click is not discoverable enough for the users
so for now bring the buttons back.
Also turn on enabling/disabling buttons when they have some
effect (this was turned off for Calc for unknown reasons).

Change-Id: I6bbb04d44066ebc6b89fe3d941ecafdbb378284a
(cherry picked from commit b6fe593c)
Reviewed-on: https://gerrit.libreoffice.org/19380Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 6894ebff)

Change-Id: Ic3d26f45251ff27bacd572f0cb7a7aadf091e808
Reviewed-on: https://gerrit.libreoffice.org/19386Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit db704b40)

Change-Id: Iac825646e33cb40f7d8a1c1aa6a3e67f3aac5980
(cherry picked from commit aa2886cf)
(cherry picked from commit b16be656)

SwTextInputFieldPortion::Format has previously tried to erase the
input field special chars, which caused the words not breaking as
expected or in the same way as normal text. It appears that it is
actually not necessary to do this at all so just calling the super
class method SwTextPortion::Format does the job and fixes the
problem. After testing I could not find anything that is obviously
wrong.

Change-Id: Ie763f55ad55863dd224425dc481b7100deb639fa
(cherry picked from commit 5e1714fd)
Reviewed-on: https://gerrit.libreoffice.org/19349Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 9c9e9e15)