Remove and fix stray Hicontrast (HC) icons.
- Remove old HC icons from Human, Oxygen & Tango themes. (They should only exist in specific HC theme).
- Move few icons misplaced in Galaxy to correct HC theme.
- Fix HC filename: lch_autopilotmenu > lc_autopilotmenu.

Change-Id: I12b9729888ff7927f9c8f31d1d66d178ef39150b
Signed-off-by: Andrew <dent.ace@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/14352Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I39cbff3fbd21c6d0640a0fa1298c5df720525405

Change-Id: I273af8b570adfcb7bfb784495bc31d2f4f1ee00b
Reviewed-on: https://gerrit.libreoffice.org/14333Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

...don't dare make it non-explicit, yet.

Along the way, introduce SAL_CONSTEXPR.

Change-Id: Ia3179d0d5e001fd7aa92237c97437e9b74366ee1

Change-Id: I62a038d99107b30da302acee7b68e802fe5d9622

Change-Id: Ic98ada6d0bca124194cea24a1ed30d30a1c0a85e

Change-Id: If2f26bd6414622889fc15d3806851e497882558c

Change-Id: I3bd06dee1a5536552f79d9eddf5c7059723cba2e

Change-Id: Ida19552cd9163507bea36a189811fdf8c152cae6

reviewed the 120+ callers and confirmed it is never NULL

Change-Id: I5c029dc35b265d9e11a0a222170dad4d6a55ed2f

and boost:make_shared->std::make_shared

Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d

Change-Id: I55f0a5bd01a3e250764e1eb34d674b535b85b56f

...removed in 2c03d6fb.

Change-Id: I09194c55ac574bbc0f3065360b329fab8f0ba10c

Change-Id: I24ac6405f03e2d55f832d1ffe0c71e575883c5c8

Change-Id: Iaa880528cf3c899ce66e4349c6d989dfbe5cbeb6
Reviewed-on: https://gerrit.libreoffice.org/14346Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

...regression introduced with b0ef5cf2 "sal: add
some argument checking assertions for strings and buffers" not being aware of
18699039 "Clean up Mac _imp_getProcessLocale:
Introduces OUStringBuffer::appendUninitialized."

Change-Id: I828d98eb52f57f4e39e71ded39ef034e1788f4d1

improves import of attachment https://bugs.documentfoundation.org/attachment.cgi?id=110836 from issue 62284

Change-Id: Icb056774746ce270138a54e9dfe9ca6987a64769
Reviewed-on: https://gerrit.libreoffice.org/14242Reviewed-by: Katarina Behrens <bubli@bubli.org>
Tested-by: Katarina Behrens <bubli@bubli.org>

Change-Id: Id30afe5bf954e26515bf8cca6f1ee8bc018fb835

Most likely 64c479e9 accidentally made the
code unmap the host buffer before it is accessed, but the code continued to
work by accident in many (most?) cases. Either because in the case of OpenCL
devices that share memory with the CPU, the host buffer *is* the OpenCL
buffer, so even if the host buffer is "unmapped", it still exists. In the
case of GPU device with separate memory, using the host buffer after unmapping
corresponds simply to a case of use after free of a heap-allocated buffer,
which often happens to work.

Found by code reading.

Change-Id: I9e2b4574077a267938702c0f81c4b1cba9c9a183

Add the name of the function that failed to the OpenCLError class. Log OpenCL
failure in a couple of more places (where OpenCLError is not thrown). Print
OpenCL errors symbolically instead of numerically where applicable.

Change-Id: I60f910e9ea7b75af7ec506553d7a73ad99ba4366

There is nothing Calc-specific in this function, and surely it will be good to
output OpenCL errors symbolically also in the opencl module.

Change-Id: Ibe7d0d036f24dd87e06b8290224e1033dda0f3d1

ISNAN was defined unconditionally since long, and even the original authors of
this stuff started removing those conditionals last summer.

for F in `git grep -l ISNAN sc`; do unifdef -DISNAN -B -o $F $F; done

Change-Id: I61df4066d0ecc23b6ce26bac8f3fbdfaf4aceac4

Change-Id: I6c9d8ff064f059e4a756593ff5c45b9670cacb29

Change-Id: I6144d7d6527dc401b7f1b577d1a227361e39e7bb

Also remove some now redundant asserts from headers.

Some of these actually trigger on unit tests so are commented out.

Change-Id: I07c6b2b2bd175361691a141f22eec584e3ab8f0b

Returns early if comparison matches so you can reduce iterator scope and avoid last test for logging.

/usr/include/c++/4.9/debug/safe_iterator.h:168:error: attempt to copy-
    construct an iterator from a singular iterator.

Objects involved in the operation:
iterator "this" @ 0x0x7fffffff3a30 {
type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator);
  state = past-the-end;
  references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088
}
iterator "other" @ 0x0x7fffffff3a90 {
type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator);
  state = singular;
  references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088
}

4  0x00002aaab193d6e9 in boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem>::base (this=0x7fffffff3a90)
    at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:121
5  0x00002aaab193d269 in boost::operator==<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem> (l=..., r=...)
    at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:179
6  0x00002aaab193c2ca in ButtonDialog::RemoveButton (this=0x7fffffff3d90, nId=1) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/btndlg.cxx:340
7  0x00002aaad8ed109b in dbaui::ORelationTableView::lookForUiActivities (this=0x317ef30)
    at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:342

Change-Id: Ied45c222c94d2a362075a3b1550b6092aad77c62
Reviewed-on: https://gerrit.libreoffice.org/14325Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

and we can include a few less headers

Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8

Strange, I somehow believed this already works not only for ODF
but also for OOXML. Wasn't the case

Change-Id: I5e06fd7bccbe2e59b13f9f56188374193b10a009

This reverts commit 2d4b87f0.

The reverted commit leads to the following regressions:

 - Basic dialogs
   (which were not targeted, but impacted, by the reverted commit)
   with several RadioButtons sharing a group-name (as they will have a
   tendency to do) cannot be loaded anymore, since the implementation
   assumes (and checks) that names are unique.

 - Even in forms, where a RadioButton had both a form:name and a
   form:group-name attribute, the form:name attribute wins and thus
   RadioButtons that has the same group-name but different form:name
   (as they will tend to do) will not anymore be mutually exclusive,
   which defeats their point.

Additionally, since it did not change the UI parts (property editor
window), the user was still presented with two different editable
properties "Name" and "Group Name", where "Group Name" was empty...

Change-Id: I1bff532a5a7336cf2eb0579bcd4e2d16be6480fe

This reverts commit 29e1b2f1
in preparation for reverting 2d4b87f0

Change-Id: Id319c001b399a3105d6c9f87a58168f956ad46c3

Change-Id: Ifc7577f46625562183ed3ee2273f28b9dcfc13df

so move potentially throwing call to a manually called finish()
additionally don't make it leak something that is not a RuntimeException,
the caller does not expect it.

Change-Id: I8b19585ae197f5ac8625dc85d4c4860a1c11b262

regression from .ui conversion:

commit 5c72a213
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Jan 21 14:41:16 2014 +0000

    convert table filter page to .ui

    Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52

Change-Id: Ic7d41d64d4c15eabf7b7f83a17482c473154434a

Change-Id: I74955a05bf13f7b33650d11c5cf4b1388382da2a

Change-Id: Id22ba872865bd8136c65c73152097805e696a695

Change-Id: If96b66d5bbfcf4426bb602909599cd36e1f3c994

Change-Id: Ic6b813b3f826300d3b59b7105690ab611bb4bd44

Change-Id: I910c37a19c1f627ec0c92dcb044db92e9e24c25e

Change-Id: I99281928665f6738a7f8d5fd04104445c06b17e8