We don't want a potentially outdated copy to be used.

Besides, when it was in the user profile, it did not exist the first
time after an installation, or a user profile removal, when we
attempted to read it.

Change-Id: I21290090a3bbb44864730dff84c81e80add89fb3

This e.g. reduces the LSan-reported leakage during CppunitTest_sd_filters_test
from

  SUMMARY: AddressSanitizer: 115048 byte(s) leaked in 4639 allocation(s).

to

  SUMMARY: AddressSanitizer: 6544 byte(s) leaked in 118 allocation(s).

The history is that this happened to (presumably accidentally) get fixed when
switching from an SV_DECL_PTRARR to a boost::ptr_vector in
b35980d9 "Move away from SV_DECL_PTRARR in
CharAttribList" but then got "fixed" again with
46da0b68 "further sc/editeng unbreaking."  That
latter commit doesn't give any more detail than "this boost::ptr_vector idea is
seriously broken," but I assume it did that change only via code inspection, to
return to the previous (assumed good) status quo, rather than because that
recently introduced deletion actually caused any problems there.

I now see that this has also independently been found and fixed in AOO with
<https://bz.apache.org/ooo/show_bug.cgi?id=120865> "Part of EditAttrib objects
are not released after removing from Character attributes list" (the fix for
which apparently got mis-classified for LO as
"dd127fae prefer:
e4e4b3d6," i.e., "Another SV_DECL_PTRARR now
gone" about some unrelated XBaseParaPortionList).

Change-Id: Iecee5a4c85bc0c0c36a6690d70f0a4a59dab964a

This e.g. reduces the LSan-reported leakage during CppunitTest_sd_filters_test
from

  SUMMARY: AddressSanitizer: 504104 byte(s) leaked in 4654 allocation(s).

to

  SUMMARY: AddressSanitizer: 115048 byte(s) leaked in 4639 allocation(s).

Change-Id: If922e872d9f696847face198e082144ccd5f12de

Change-Id: I251d079d6362cf09d014623663cf9355a9c79a2e

TODO: now table are skipped because current implementation is not
able to iterate through table cells and when a match occurs on the first
cell the text object iterator stops working;

Change-Id: I36ca4dabe88b0eb8fd89d3fe3dcc6951e5c03d0e
Reviewed-on: https://gerrit.libreoffice.org/21166Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I1318acdcd9fbf1d0b363248266e913954cc97e9b

Change-Id: I94db78ca12e0f3389f00ea5c557f0b64d452f613
Reviewed-on: https://gerrit.libreoffice.org/21150Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The width was decent, except that on small paper (A6) it was
wider than the paper size.

The height was terrible - the minimum size possible. It was too small
for even a single line of text. That made it hard to grab the table edge
(instead grabbing a row edge) when trying to resize.

Now the height and width are limited to the page/view size,
and based on the number of rows created.  One possible enhancement
would be to use the border width instead of the page width.

Change-Id: I4e106a7bc34f65886e3c80d308499242c0fdd7d8
Reviewed-on: https://gerrit.libreoffice.org/21171Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Project: dictionaries  3f7bdd798006d506d83d58e699d52878326bbd62

Update the Swedish spelling dictionaries

Update to the latest dictionaries version 2.39.

Change-Id: I464aa0bbc9d58b0ec2f3b82906dabe60a49c020e
Reviewed-on: https://gerrit.libreoffice.org/21151Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I41361d8dd4619a27bba5cc9ad2c627b37f1b2013
Reviewed-on: https://gerrit.libreoffice.org/21190Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

... to avoid calling C:/Windows/system32/{sort,find}.exe, if those
happen to be first in PATH.

On a Windows 7 system, the other conflicts appear to be harmless,
we don't use "more", "expand", "timeout", "whoami".

Change-Id: Iceefeb7ee6725291b04c0eba465991bb1df96b57
Reviewed-on: https://gerrit.libreoffice.org/21175Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I174a7a87d68958d0a5dd7c3e0f35294f0d020eb1
Reviewed-on: https://gerrit.libreoffice.org/21189Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

We used to optimize the creation of these styles, so in case two list
label had the same character properties, then we could avoid creating
two styles for those.

This isn't correct though: it means if the style is changed later by the
user, then unexpected other places in the document will change as well.
Do what the binary DOC filter does: create one character style for each
level of a numbering separately.

Change-Id: I967b30fc078b1be30f7ef81b2706df2962fc3fb0
Reviewed-on: https://gerrit.libreoffice.org/21191Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ia64d33a6a755f6a0c1418c7230f4734a06febed4
Reviewed-on: https://gerrit.libreoffice.org/21187Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

pActiveAccessibleCell is only needed when the "FOCUSED" state
is being set. Many other states are also set with the SetState function.
Avoid the GetActiveAccessibleCell function call when processing
these states.

Change-Id: Ib317f0f4b290cc8d33f7af7f450e35c8b1f7f924
Reviewed-on: https://gerrit.libreoffice.org/21120Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I91621a177f27200c9d3413dd4953d5292a2ac15b

Change-Id: Ib3cb2d905242d2a15935c074cb6d0634102de4e5

Change-Id: Ifa10c3b954dd245ff8357b790b59316b3fb111a9

Change-Id: Idb18436c578ae6d745bb2177688cb3f5435df7a2
Reviewed-on: https://gerrit.libreoffice.org/21177Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I9e3759d1d5ae850a2bead62fb3b2fef02f43ec4a
Reviewed-on: https://gerrit.libreoffice.org/21176Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Ie11281285de012dfd61f4b3b04b4144cd90d382a
Reviewed-on: https://gerrit.libreoffice.org/20989Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I3355d25f04a3c57063fd3d03e72a75da32e16efc
Reviewed-on: https://gerrit.libreoffice.org/21109Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I3e40a8006278b094d494820e6f47628c6579e78a
Reviewed-on: https://gerrit.libreoffice.org/20883Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: If43ca99631fab5a3a04e7dead9b694cf52944666
Reviewed-on: https://gerrit.libreoffice.org/20882Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ib19a5651f7e30108e8fbcdc6f7924c47cbeb4434

Using both GTK2 and GTK3 sounds like a recipe for disaster, so use gtk2
for now (since we get numerous deprecation warnings with gtk3).

Change-Id: I32a27c3620503b6c5d7d81510137bfddc5abb05c

Regression of 7dd77a12

Change-Id: I7f4bb251b831c9f5ee9e3c6ae2f9b1b8f7c34686

Change-Id: Ie0578dcca6cbf4edb62544109d616a081888f369
Reviewed-on: https://gerrit.libreoffice.org/21140Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

That's what the code originally did, when the versions were hardcoded
in the C++ code. The 15.40.4.64.4256 is the "marketing" number for the
version that was suggested to use instead. The code can not handle
five-number versions anyway, and this blacklist entry was ignored. An
actual version as reported by the system always has four numbers, to
the best of my knowledge.

Change-Id: If7e2e91bbd81fc75d03eacb38580df16c6e09d78

Usage of NUM_TBX_CATEGORIES was gone at 3dfe2fc3.

Change-Id: Ic0fea85ad143de02102e3745f310966a8b94192e
Reviewed-on: https://gerrit.libreoffice.org/21153Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Quite unnecessary, just remove the implementation details from the
header.

Change-Id: I5712ff32756bb1d31ff7701424b85a323438cced

I had it locally enabled for like a month now, and it did not produce any more
noise than any of the other plugins.

Change-Id: I94dab702c537969cf32922f6e88b4f5b503cd3f5

I had it locally enabled for like a month now, and it did not produce any more
noise than any of the other plugins, but quite some amount of malformed area
designators had been introduced over time.

Change-Id: I642591496bb9338246ba43a3d988481930c087fb

FixedTextureAtlasManager should use ref-counted textures properly.
Also - dispose embedded textures early in VCL shutdown while we have
a valid OpenGLContext.
Also - dispose the native widget control cache earlier too.

Change-Id: Id3f7a1c3b331496616f36cbf02f83737505278a5
Reviewed-on: https://gerrit.libreoffice.org/21148Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

...given the oldest incarnation of the code still available is

  HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" )
  if ( ppStaticDefaults )

and

  HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" )
  if ( ppStaticDefaults )

from cf7e1f9c "INTEGRATION:
CWS visibility03: #i45006# Moved from svtools/source/items/ (for
svl/items1.lib)"...

...is that ppStaticDefaults should really be non-null, but "Image" (Draw?
Impress?) needed a temporary (?) hack there.

Test that assumption by asserting that ppStaticDefaults is non-null.

Change-Id: I2a75547618da1d211c44176e4593f6951a0e0298

...entire column or row is selected using row/col
header and keyboard shortcuts are used to amend
the ref selection.

Change-Id: I97f05ae2192aff65933fec53e6e79024420d8d5b
Reviewed-on: https://gerrit.libreoffice.org/20837Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

This avoids finding emboleobj's component in such case.

Change-Id: Ie1bdef629a55b4ddb6be2538939867c182c184b3
Reviewed-on: https://gerrit.libreoffice.org/21075Reviewed-by: Matúš Kukan <matus@libreoffice.org>
Tested-by: Matúš Kukan <matus@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I5344af095e52efb1f1569d2b67ee3cc6b449dd22
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Also changed the bool member bDoneInitRef to bInRefMode which
better indicate what it does.

Change-Id: I1698202add7876b89c95f737d4b5ad2243af31ab
Reviewed-on: https://gerrit.libreoffice.org/20836Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

RID_PRINTUIOPTIONS has 9 items.

Change-Id: Ie7aee00e0219151b1573217ca670a93925de67cc
Reviewed-on: https://gerrit.libreoffice.org/21154Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>