Follow-up to https://gerrit.libreoffice.org/#/c/1803/ .

Change-Id: I9131854a579ef57e38dfef7faa539bec98fc305b

This has the disadvantage that it makes comparisons involving fast
OUString concatenation via operator+ ambiguous, as can be seen in
scriptdlg.cxx, but it allows comparing String and OUString wihout
explicit conversion, which is nice for incrementally converting code.

Change-Id: Ibfc728bdb161a01e0f8311915c97bcbba8b58c0b
Reviewed-on: https://gerrit.libreoffice.org/1803Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>

Project: dictionaries  7d469f332804f6ed3efcdfd5f7217703aded1e35

...a regression introduced with 2fe85238
"fdo#46808, Adapt SystemClipboard UNO service to new style."

Change-Id: Ia98eadc0fc80762455c1e8cc33797b322b83e458

Change-Id: Ieb8e782eab9c9bde1d2099d8cc32eceef9f00002

...00134920 "New option for INDIRECT reference
syntax" and e6ef9f12 "Rename this option to make
it sound more generic" had marked
/org.openoffice.Office.Calc/Formula/Syntax/StringRefAddressSyntax (formerly
IndirectFuncGrammar) as oor:nillable="false", even though it is given no value
in officecfg, and the sole code reading it (SCFORMULAOPT_STRING_REF_SYNTAX case
in ScFormulaCfg ctor, sc/source/core/tool/formulaopt.cxx) is prepared to read a
nil value.

Change-Id: Icab871c821f437cd095280e9af8b0c0c11bbef8f

Change-Id: I5706fc9201359c05c00d0a97009994d7d188d5bf

Change-Id: Ie46a2627d247fb293606c6deab3254113b741336

Change-Id: Ie830fe9f7276fbc8f20e7d37424116d6653a6931

Change-Id: I0b204e9a81aad3e4f5fafc17bbd0c3935eb5cdb5

Change-Id: Ib4ca01df58da4129d5262c344c7c092925e19caa

Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
Reviewed-on: https://gerrit.libreoffice.org/1773Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

Also, remove some chained appends, and sanitize some functions call.

Change-Id: I5bfed073bd84e4dee4bc7e7b4715e413859beb50
Reviewed-on: https://gerrit.libreoffice.org/1772Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

Change-Id: I5a5af27d7c980f6b71011c33531a49a82d79fbc8
Reviewed-on: https://gerrit.libreoffice.org/1771Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

... remove some RTL* macros.

Change-Id: I919d17e14334c9220b47775355512df8dfa00bca
Reviewed-on: https://gerrit.libreoffice.org/1768Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

Change-Id: I554bb631a9b8d7b334483eeaed9b096451660a75

- unconverted assertion in dinfdlg.cxx
- wrong replaceAt in SidebarWin.cxx
- obsolete cast in SpellDialog.cxx

Change-Id: I18450c0c6fdd275b7f81a7fce58cdf98bb806e27

replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

See http://nabble.documentfoundation.org/Cppcheck-Variable-nMode-is-reassigned-in-fstat-cxx-td4030405.html
Thank you Stephan!

Change-Id: I780d422fe03c4c125cc89fee778d820a20553c1c

See http://nabble.documentfoundation.org/About-parenthesis-problem-in-testintrosp-cxx-td4030420.html
Thank you Lubos!

Change-Id: If46b3d3aa304f2c16d66813ff337a70b3a520e76

Number of repeated column styles were limited to MAXCOL effectively
being MAXCOLCOUNT-1 and in an --enable-dbgutil build yielded lots of
warnings when importing a document that has a style applied to all
including the last column.

For example see attachment of fdo#59583
https://bugs.freedesktop.org/attachment.cgi?id=73282
or fdo#59325 https://bugs.freedesktop.org/attachment.cgi?id=73014

Change-Id: I74dbbe3065a46015b0b7c8f61d58690a1c08c855

Change-Id: Ieb8e782eab9c9bde1d2099d8cc32eceef9f00002

If followed by '(' (with or without space inbetween) an identifier can
not be a column/row label. Prevent arbitrary content detection in case a
macro function of the same name is meant (fdo#59583) or if it wouldn't
resolve to a known function name at all, that earlier resulted in #REF!
instead of #NAME? in the case of unknown function but label found.

Change-Id: Id36a0c9ebad2d62867b4f9fe00ae78d464e77109

Change-Id: Ifbd7dcc3fa8d18192d2ac2fc5faca1b0637c93c2

(...whatever it is that causes them to be raised at least in my build).

Change-Id: I52889de876e448ae8e90ec328e65cda2025968e2

Change-Id: Ib0d64c9d93f7ae73a160ad242a6731b781edaf0f

This reverts commit 1efe9a15, which is obsoleted
by 488823a1 "Remove -Wsign-promo."

Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6
Reviewed-on: https://gerrit.libreoffice.org/1782Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>

...to avoid unhelpful "passing [enum] chooses 'int' over 'unsigned int'"
warnings from those new calls to rtl::OUString::number as introduced with
63bcb139 "Replaced O[U]String::valueOf(
static_cast<> ) with O[U]String::number()."

Change-Id: I2adb16e83865bd4cba4a1650eb54bb7f5cee31e0

Change-Id: I6123f8924d7502d3b97b3254ce4e5df724e4370d
Reviewed-on: https://gerrit.libreoffice.org/1769Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>

Asturian by Xuacu <xuacusk8 at gmail dot com>
Spanish by Adolfo Jayme Barrientos <fitoschido at ubuntu dot com>
Slovenian by Martin Srebotnjak <miles at filmsi dot net>

Change-Id: I29387f5908ea456abc5c464a03cc74c718ae6b74

Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>

Change-Id: I46605f6c8dfacab0feb5a446db458eed8e5756ee

Change-Id: Ie5d3564cf00c27c11597dd3ff1ba8dc82e250c0b

Seems to me there's no point to that since GVFS itself is deprecated
anyway.

Change-Id: Ibceba3bbe33a3a37dd088d0f24bfdd4211095589

Change-Id: Ia11d30816b920b60367b8a0b7bd70d4bb4614ded

Change-Id: I42a80b12d843b95e2ddc0872ee793ebbda050066

if odk is not explicitly requested by --enable-odk
and --with-doxygen is "yes" , i.e not a specific location
and doxygen could not be found in the PATH
then enable_odk is set to "no" as a default value
rather than an implicit 'yes'

Change-Id: I4f04ecc8dbe959001f6dfdccf0c97b61f79faff6
Reviewed-on: https://gerrit.libreoffice.org/1789Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>

Updated the distro-configs so that the default change
does not impact build based on distro profile

The intent is that with this change of defaults
the build does only rely on core and does not need
any submodules. Making a initial build simpler
for new dev, since they won't be exposed to submodules
unless they really need them.

Change-Id: I446e912d607ce7358fd11f54a3de025dc3f25144
Reviewed-on: https://gerrit.libreoffice.org/1791Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>