Change-Id: I7967f0ee333eda4db320dc50bd91f2229792f0a8

Change-Id: I21719d513aa4af7a7f9621e19d529fd0c4425f58

...in code introduced with be1b03a4 "dock icon's
menu doesn't begin with separator anymore," causing CppunitTest_vcl_lifecycle to
fail

Change-Id: If6eb1f3a0f52d05284ac01f448888aaaa7523a98

Chose not to use lambdas instead because the number of arguments in these calls
would have made it way too verbose, hurting readability.

Change-Id: I8662a937ec10ca0fac6cd7e0d78b6268e8023ada
Reviewed-on: https://gerrit.libreoffice.org/19707Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

... just ... why ... was ... that ... ? ...

Change-Id: I1bc1ea12600859872c6d238b1ef6fc55f6ff2e04

... that only results in a performance penalty.

Change-Id: Ia161ab7fb03f2d32cf966ce9da9d0319d919fc4c

... to just assign a new value, which takes a significant amount of time
(~13% of ScTable::ValidQuery()) in ScRefCellValue::operator=() due to
its implementation using a temporary and swap.

Change-Id: Ia205850e10c5fa9083eec5fb7563d98561b52462

corrupted with 7408498d
"loplugin:stringconstant"

Change-Id: Ia7af4b7276fb30485f39e24c9afcdc82f7cef447

Change-Id: I077a17eada47b9c1509c21c18a6e4cd06172de3b

Change-Id: I1085b655a9a589f2e92edfdacfea6621d2f67d9c

Change-Id: Iddb96f51ed2fd2d7861e9448a7aa221d998ad2a5

Change-Id: Ia5aba89f02ee4d99dd573599a3888731efb131b9

...at least recent Clang trunk ASan+UBSan build apparently adds instrumentation
code that made that (arguably optimistic) setup fail

Change-Id: I186a7abdfe5cc69e624583b1281d3989cefd7d53

Change-Id: I7ed9e19df071b6baf1e941faee24c332c7b5e804

(i.e., if any of --enable-dbgutil, --enable-debug, or --enable-symbols);
introduce gb_DEBUGINFO_FLAGS for the platform-specific flags

Change-Id: I4306fa30ced57d40d5b1206a0b26a886411118ef

(i.e., starting with an authority component); treating input starting with a
single slash (i.e., starting with an absolute path component) as a relative URL
instead of as an absolute pathname would cause e.g. CppunitTest_sal_osl_file to
fail

Change-Id: Ie340881974c5e9451ab7e0a9bfb21176b8f5666d

VCL Image/Bitmap/BitmapEx instances must not have static life-time
because then they will be destructed after DeInitVCL() and that
likely segfaults.

Change-Id: I3ff8d32de729c971b190028094cb4efe206395e2

Change-Id: Ideb7bdabd86e95cf10c7f19f0900110b816970c2

Change-Id: I0f899fbab73ae43e09ca2afc18d956f42ec8b0a7
Reviewed-on: https://gerrit.libreoffice.org/19537Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

There were two problems here:

1) ScTabView::getRowColumnHeaders() did not expose twip values directly,
but used ScRow/ColBar::GetEntrySize(), which does a twip -> pixel
conversion, and then converted it back to twip. Avoid this unnecessary
roundtrip.

2) ScViewData::ToPixel() trunaces the resulting float to an integer, so
if the result is e.g. 67.7 pixels, then Calc handled that as 67, but
gtktiledviewer rounded that up to 68, resulting in non-matching headers
for the rendered tiles.

Change-Id: Ie6ed1ea923a423d1526eeb235b7b87106fd2f20b

Change-Id: I4ab00a269b0a8435a278f93e1d92d102a80c8506

after my commit 7408498d
 "loplugin:stringconstant"

Change-Id: I1354207e1ecb6ebc76fcda3ed8eb8f369180eae8

Change-Id: I8955bee3ac2bb7a757c1f70dd46141833a068517

Change-Id: I736e0d63ed891aee1582844aff25b9bdacab8db9

Change-Id: I865efc1884b82d430fe7df2e432d43f5425a83d4

There was a subtle change in semantics, the earlier loop was only
iterating until aEnd, covering only unique elements of the vector.

This partially reverts commit c04fd824

Change-Id: I75c5f1b343c3fa8855f6d7f8f706b9259bc9f6df

Change-Id: I96f75b51000811044b4407f8411d4e8cdba797c6

Change-Id: I81880456d398e8bffd363626bac17ff9d54e7796
Reviewed-on: https://gerrit.libreoffice.org/19697Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

... even when there's no open windows

Change-Id: I8c1d8f254e621d1867a100ad984f8b77ed8cfc5a
Reviewed-on: https://gerrit.libreoffice.org/19677Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

Its lifetime is bounded by the currently processed event.

(regression from 76e75d2d)

Change-Id: I4896b161295eeab3bbf08e59c5a82afac4338f08

Change-Id: Ic1bb54d1e6d2c3f8c4215d8ececeb6353ad8ca45
Reviewed-on: https://gerrit.libreoffice.org/19717Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

Change-Id: Ib256e4a4921e11defe7018f82273739c9ecc3105
Reviewed-on: https://gerrit.libreoffice.org/19735Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

...and use something more direct than rtl::Uri::decode for the UTF8 case

Change-Id: I2f37d371c425dff6b068e3120be485e71b8e9e12

...expecified in File - Open too.

Change-Id: I616e66a296d7c44e5a8784b3a5f32f14ce7a668d
Note: Chrome and Firefox use back as well so IMHO it makes sense to do it this way.
Reviewed-on: https://gerrit.libreoffice.org/19567Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

Change-Id: I2614e6c9f6d0a31866cb9821910da7f3e31377c6

Change-Id: I6aacf764513b8f789d925db2943f4bf6f0039674

Change-Id: Id7c1a28370f35fce7d885041a18e81a89defb69c

Change-Id: Icb51f02ca761d683d926135fcaedc1164cd1ae8d

Change-Id: I3270237a8691a5f5f4495be8cf2e290cac0b2fcd

Change-Id: Id051dd984c24fb34dcc89060ed11955fed61fd48