1. 28 Haz, 2018 18 kayıt (commit)
  2. 27 Haz, 2018 22 kayıt (commit)
    • Luboš Luňák's avatar
      blacklist ocGetPivotData for calc's threading · 7e1cabd9
      Luboš Luňák yazdı
      There appears to be a lot of caching involved in the code invoked
      by ScGetPivotData(). Testcase is e.g. tdf#89186-1 (with minimal
      formula size disabled again).
      
      Change-Id: If7e2a972898c358dc8f80cf238f8d5ccf541f16d
      Reviewed-on: https://gerrit.libreoffice.org/56525
      Tested-by: Jenkins
      Reviewed-by: 's avatarLuboš Luňák <l.lunak@collabora.com>
      7e1cabd9
    • Stephan Bergmann's avatar
      Suspiciously, copy ops of Bundle-derived classes didn't copy Bundle::mnColor · dc952845
      Stephan Bergmann yazdı
      Lets assume that that was an oversight, and change all those user-provided
      copy assignment ops into implicitly-defined ones (that will now also copy
      Bundle::mnColor).  Avoids -Wdeprecated-copy with GCC trunk towards GCC 9, as the
      copy ctors were already left implicitly-defined (and so already copied
      Bundle::mnColor).
      
      Change-Id: I43e323b55d059c7afecaddab0d777b6df47182c8
      Reviewed-on: https://gerrit.libreoffice.org/56539
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      dc952845
    • Arkadiy Illarionov's avatar
      tdf#96099 Remove *HandlerPtr typedefs in writerfilter · f17eb4c8
      Arkadiy Illarionov yazdı
      See https://bugs.documentfoundation.org/show_bug.cgi?id=96099#c44
      
      Change-Id: Ib2d828a66bc14faa4f341eec9210e1effdebd7c1
      Reviewed-on: https://gerrit.libreoffice.org/56541
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      f17eb4c8
    • Tor Lillqvist's avatar
      This assert() seems superfluous · 33af2a8e
      Tor Lillqvist yazdı
      The assertion fails when one reproduces tdf#69460 but removing the
      assert() does not cause any problems.
      
      Change-Id: Idaa5d41a0cf76073e406d7152fc3b4e9ebd3e876
      Reviewed-on: https://gerrit.libreoffice.org/56538Reviewed-by: 's avatarTor Lillqvist <tml@collabora.com>
      Tested-by: 's avatarTor Lillqvist <tml@collabora.com>
      33af2a8e
    • Eike Rathke's avatar
      Check string length before copying, tdf#115007 follow-up · d9388ab0
      Eike Rathke yazdı
      Change-Id: I50b842afc505ce603225fb2d25281cc8e9240200
      Reviewed-on: https://gerrit.libreoffice.org/56537Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
      Tested-by: 's avatarEike Rathke <erack@redhat.com>
      d9388ab0
    • Stephan Bergmann's avatar
      Break HashedStyle::RefCount out into new RefCountedHashdStyle · 40e5ad11
      Stephan Bergmann yazdı
      ...as that member is only used in m_aIdToStyle, and it was confusing how the
      user-provided HashedStyle copy ctor initializes it to zero while the implicitly
      defined copy assignment op copies it.  (And existence of only one of those
      copy functions also triggered -Wdeprecated-copy with GCC trunk towards GCC 9.)
      
      Change-Id: I176ef95af8780fefe21e53f61fd66f5e2d9156ab
      Reviewed-on: https://gerrit.libreoffice.org/56528
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      40e5ad11
    • Miklos Vajna's avatar
      tdf#102960 vcl opengl: fix missing support for polygon track frames · 1e533f69
      Miklos Vajna yazdı
      Which is used in e.g. the Calc cell border dialog. The approach is
      similar to commit 60790935 (tdf#96657 -
      vcl opengl: implement invert: Track Frame., 2016-01-09) but that one was
      for rectangles, this one is for polygons.
      
      Change-Id: Ib1feebab2d14f4450fee0afe96afcea906965fdb
      Reviewed-on: https://gerrit.libreoffice.org/56534Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      Tested-by: Jenkins
      1e533f69
    • Tor Lillqvist's avatar
      This should be a const NSString* so that we can pass such variables to it · fa7ebc82
      Tor Lillqvist yazdı
      Change-Id: I017c100f83faac64ad3a8430010c226b438e6a07
      Reviewed-on: https://gerrit.libreoffice.org/56529
      Tested-by: Jenkins
      Reviewed-by: 's avatarTor Lillqvist <tml@collabora.com>
      fa7ebc82
    • andreas kainz's avatar
      tdf#114425 add Page Settings to writer and calc NB · a29b1018
      andreas kainz yazdı
      add to NB grouped (full and compact) in Edit group
      cause Format is only Format selected text but not Format page.
      Edit group is most generic group that fit's for page selection
      
      Change-Id: I49af8ff5b560655d43c55818da391a768d26ef04
      Reviewed-on: https://gerrit.libreoffice.org/56430
      Tested-by: Jenkins
      Reviewed-by: 's avatarandreas_kainz <kainz.a@gmail.com>
      a29b1018
    • Tomaž Vajngerl's avatar
      vcl: prefer OpenType font feature description over Graphite · 1a651c3f
      Tomaž Vajngerl yazdı
      If the fon supports Graphite features we can get the feature
      descriptions from the font, but this descriptions are mostly
      limited (available in a limited number of languages), so it is
      better to only use this descriptions only if the feature does not
      have an OpenType description available.
      
      Change-Id: Ic0b81cb8cc22e1e73f30e6a960167cfa982fbfc7
      Reviewed-on: https://gerrit.libreoffice.org/56318
      Tested-by: Jenkins
      Reviewed-by: 's avatarTomaž Vajngerl <quikee@gmail.com>
      1a651c3f
    • Tor Lillqvist's avatar
      tdf#53282: Leave (our own) full-screen mode when the AquaSalFrame is dying · 387f0031
      Tor Lillqvist yazdı
      Change-Id: I85243dff96b9090de0fd55564b44abb6142d9ac2
      Reviewed-on: https://gerrit.libreoffice.org/56524
      Tested-by: Jenkins
      Reviewed-by: 's avatarTor Lillqvist <tml@collabora.com>
      387f0031
    • Noel Grandin's avatar
      loplugin:useuniqueptr in ScUnoAddInCollection · e5c8f2ba
      Noel Grandin yazdı
      Change-Id: Ic38eab88f68952549af3417c3e85020877c95446
      Reviewed-on: https://gerrit.libreoffice.org/56498
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      e5c8f2ba
    • Henry Castro's avatar
      tdf#118308: Incorrect Paste Special dialog when ... · b9652803
      Henry Castro yazdı
      pasting content from another cell
      
      In tiled rendering case (headless) each window has its own clipboard,
      otherwise exists a unique clipboard (UNO service).
      
      Change-Id: I7d5d0b085faeaffa3fc0a80914fbe9349f4aa402
      Reviewed-on: https://gerrit.libreoffice.org/56508
      Tested-by: Jenkins
      Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
      b9652803
    • Tomaž Vajngerl's avatar
      xmloff: prevent embedding same font files with checksumming · b262e6e5
      Tomaž Vajngerl yazdı
      When embedding fonts to ODF documents we can get into a situation
      where the same font is embedded multiple times and this wastes
      space. To prevent this we calculate the checksum of the font first
      and track the fonts that are embedded. When the font has the same
      checksum, the path to already embedded font is returned.
      
      Change-Id: I087c42d9a63b1697b9b4ea985dbce2fda760a996
      Reviewed-on: https://gerrit.libreoffice.org/56507
      Tested-by: Jenkins
      Reviewed-by: 's avatarTomaž Vajngerl <quikee@gmail.com>
      b262e6e5
    • Tomaž Vajngerl's avatar
      xmloff: cleanup XMLFontAutoStylePool, use range for, std::pair · eeef4ab2
      Tomaž Vajngerl yazdı
      Change-Id: I5c775b8bc5cef3e14404f119e1ffb06334022003
      Reviewed-on: https://gerrit.libreoffice.org/56506
      Tested-by: Jenkins
      Reviewed-by: 's avatarTomaž Vajngerl <quikee@gmail.com>
      eeef4ab2
    • Noel Grandin's avatar
      loplugin:useuniqueptr in ScConsData · a9803051
      Noel Grandin yazdı
      Change-Id: I0f9392d95ec2887ee62d1486f63600693a8b4dca
      Reviewed-on: https://gerrit.libreoffice.org/56497
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      a9803051
    • László Németh's avatar
      locale hu_HU.xml: add date formats with suffixes, articles · 4fc072bf
      László Németh yazdı
      and spelling out using the new NatNum12 modifier
      to support common "in", "on", "from", "to", etc. date
      suffix variants, "dash-free" spell out format of years
      of the new Hungarian orthographical reform, and months
      with articles.
      
      For example, "in 2018" is "2018-ban", "in 2019" is "2019-ben"
      in Hungarian because of "vowel harmony", the word stem
      dependent fluctuation of the suffix variants, a frequent
      linguistic feature of other agglutinative languages, too,
      including Estonian, Finnish and Turkish.
      
      Note: some of the new date formats will work correctly only
      with the upcoming update of the external libnumbertext.
      
      Note 2: add also alternative (real) abbreviated month names,
      because the default abbreviated month names are Roman
      numbers.
      
      Change-Id: Ibb33ff6a627b8e27fd02388653e3b33ebd446a10
      Reviewed-on: https://gerrit.libreoffice.org/55637
      Tested-by: Jenkins
      Reviewed-by: 's avatarLászló Németh <nemeth@numbertext.org>
      4fc072bf
    • Noel Grandin's avatar
      loplugin:useuniqueptr in OutlineBulletDlg and SdPresLayoutTemplateDlg · add88797
      Noel Grandin yazdı
      Change-Id: I4bd0a9dd7be5b6ad7c1307f73c89ab0ee915ce9f
      Reviewed-on: https://gerrit.libreoffice.org/56495
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      add88797
    • Stephan Bergmann's avatar
      Null deref in ScDocument::IsClipboardSource · 47e334ed
      Stephan Bergmann yazdı
      Appears to be a regression introduced with
      b6b1ded0 "sc: replace ScCaptionPtr with
      std::shared_ptr, tdf#117997, tdf#117228".  Reported e.g. as
      <https://ci.libreoffice.org//job/lo_ubsan/954/console> during
      CppunitTest_sc_subsequent_export_test and CppunitTest_sc_ucalc:
      
      > /sc/source/core/data/document.cxx:2574:28: runtime error: member call on null pointer of type 'ScDocShell'
      >     #0 0x2b9971542d76 in ScDocument::IsClipboardSource() const /sc/source/core/data/document.cxx:2574:28
      >     #1 0x2b99722b7762 in ScFormulaCell::ScFormulaCell(ScFormulaCell const&, ScDocument&, ScAddress const&, ScCloneFlags) /sc/source/core/data/formulacell.cxx:844:14
      >     #2 0x2b996fee35b0 in ScCellValue::assign(ScCellValue const&, ScDocument&, ScCloneFlags) /sc/source/core/data/cellvalue.cxx:395:29
      >     #3 0x2b997312db22 in ScChangeTrack::Clone(ScDocument*) const /sc/source/core/tool/chgtrack.cxx:4565:25
      >     #4 0x2b99cd1728be in XclExpChangeTrack::CreateTempChangeTrack() /sc/source/filter/xcl97/XclExpChangeTrack.cxx:1561:12
      >     #5 0x2b99cd169a74 in XclExpChangeTrack::XclExpChangeTrack(XclExpRoot const&) /sc/source/filter/xcl97/XclExpChangeTrack.cxx:1418:39
      >     #6 0x2b99cab087c0 in ExcDocument::ReadDoc() /sc/source/filter/excel/excdoc.cxx:788:41
      >     #7 0x2b99cadddc2e in ExportBiff5::Write() /sc/source/filter/excel/expop2.cxx:112:5
      >     #8 0x2b99cab8ee83 in lcl_ExportExcelBiff(SfxMedium&, ScDocument*, SvStream*, bool, unsigned short) /sc/source/filter/excel/excel.cxx:181:16
      >     #9 0x2b99cab8d342 in ScFormatFilterPluginImpl::ScExportExcel5(SfxMedium&, ScDocument*, ExportFormatExcel, unsigned short) /sc/source/filter/excel/excel.cxx:219:16
      >     #10 0x2b99768df9d2 in ScDocShell::ConvertTo(SfxMedium&) /sc/source/ui/docshell/docsh.cxx:2419:30
      >     #11 0x2b998a7e2550 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1513:19
      >     #12 0x2b998a7fe5e2 in SfxObjectShell::DoSaveAs(SfxMedium&) /sfx2/source/doc/objstor.cxx:1900:17
      >     #13 0x2b9985a31bb6 in ScBootstrapFixture::saveAndReload(ScDocShell*, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags) /sc/qa/unit/helper/qahelper.cxx:664:5
      >     #14 0x2b9985a34593 in ScBootstrapFixture::saveAndReload(ScDocShell*, int) /sc/qa/unit/helper/qahelper.cxx:686:28
      >     #15 0x2b9956fca835 in ScExportTest::testTrackChangesSimpleXLSX() /sc/qa/unit/subsequent_export-test.cxx:2618:29
      >     #16 0x2b9957203058 in void std::_Mem_fn_base<void (ScExportTest::*)(), true>::operator()<, void>(ScExportTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11
      >     #17 0x2b9957202d63 in void std::_Bind<std::_Mem_fn<void (ScExportTest::*)()> (ScExportTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11
      >     #18 0x2b9957202771 in void std::_Bind<std::_Mem_fn<void (ScExportTest::*)()> (ScExportTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11
      >     #19 0x2b9957201149 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (ScExportTest::*)()> (ScExportTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2
      >     #20 0x2b9957203ad0 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14
      >     #21 0x2b99571ff885 in CppUnit::TestCaller<ScExportTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
      >     #22 0x2b990c338e7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
      >     #23 0x2b99294cb4d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14
      >     #24 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
      >     #25 0x2b991bcad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
      >     #26 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
      >     #27 0x2b9917d39e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
      >     #28 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
      >     #29 0x2b990c2732df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
      >     #30 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
      >     #31 0x2b990c2edb70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
      >     #32 0x2b990c3c2ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10
      >     #33 0x2b990c335efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5
      >     #34 0x2b990c33c0b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
      >     #35 0x2b990c33b01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
      >     #36 0x2b990c33c0b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
      >     #37 0x2b990c33b01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
      >     #38 0x2b990c402686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5
      >     #39 0x2b990c3c0e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3
      >     #40 0x2b990c403b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3
      >     #41 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13
      >     #42 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14
      >     #43 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1
      >     #44 0x2b990e038444 in __libc_start_main (/lib64/libc.so.6+0x22444)
      >     #45 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494)
      
      Change-Id: Id6cbc92844c89d48daecf8fad0b8899fcd087eaa
      Reviewed-on: https://gerrit.libreoffice.org/56513
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      47e334ed
    • Stephan Bergmann's avatar
      salhelper::SingletonRef copy ctor is broken, mark as deleted · 6ebc026e
      Stephan Bergmann yazdı
      If that (implicitly defined) ctor had ever been used, it would have failed to
      increment m_nRef, so could have caused m_pInstance to be deleted too early.  So
      better mark it as deleted.  (LO itself apparently didn't call it.  If 3rd party
      code would want to call it after all, it could be changed from deleted to
      properly user-provided, incrementing m_nRef, in the future.)
      
      The implicitly defined copy assignment op happens to already do the right thing,
      and /is/ used, e.g., during
      
      >         m_aNode = _rhs.m_aNode;
      
      in DriversConfig::operator= (connectivity/source/commontools/DriversConfig.cxx).
      Mark it as defaulted to avoid -Wdeprecated-copy with GCC trunk towards GCC 9.
      
      Change-Id: I527123d9de837c311d30a270feb09dc173d9f411
      Reviewed-on: https://gerrit.libreoffice.org/56512
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      6ebc026e
    • Justin Luth's avatar
      tdf#114845 sd: only shift rotated group items · ee45d881
      Justin Luth yazdı
      fixes 6.0 commit  9ae1e094
      > PPTX export: correct position of rotated groups
      
      However, there was nothing excluding the re-positioning
      to only group items.
      
      Change-Id: I62e36b46c0d2ac3e41f8d7d4ed82df11e6eb1ee5
      Reviewed-on: https://gerrit.libreoffice.org/56386
      Tested-by: Jenkins
      Reviewed-by: 's avatarSzymon Kłos <szymon.klos@collabora.com>
      ee45d881
    • Stephan Bergmann's avatar
      Clarify name and location of external/gpgmepp's upstream · 82e5b2ba
      Stephan Bergmann yazdı
      Change-Id: I8f91e5d00e716bbd0e6aa25697e0b30908ffb8bb
      82e5b2ba