regression from

commit 3cbfcee3
Date:   Sun Feb 2 22:16:48 2014 -0600
    xub_StrLen and tools/string.hxx final straw

    There is still some 0xffff limit left and possibly some
    less than gracefully handled overflow/error cases

Change-Id: I82bdcb6951c42fdcaa68808a251f9b2f76f8ed0b

Change-Id: I7a43d0802f41230f8b8ab135021187962cde542e

Also, improve exchange between Calc and Excel2013.

Change-Id: I491f9e2100a9a2c38e23cf55dd1eda4b5e96db96
Reviewed-on: https://gerrit.libreoffice.org/13101Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I3b375c67ed84f29360cbc9933f4a1e5c7cbe3277

when you want to find the uses of it

Change-Id: I580c194f0fd200505d3df99089afc0872921a67b

Change-Id: I4cbb303b395ad60d4935bff55fbaea08f13334a0
Reviewed-on: https://gerrit.libreoffice.org/13867Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5c9da630fe800df8da8ff32d7bb3e6b19fc37a8d

Change-Id: I923221f502c4efd200f77d5c73f03d124490ee39

Change-Id: Ie22c9b2997031146ee3a25ad55b2198ed50ee028

Change-Id: I7d5b3daf4ae4da05bb7f09e80e790edae24e0eaf

Change-Id: I0201d87d631413fc75230535e25c8eac189ede10

Change-Id: I2479b8df69da3c05021a82d269925a6374709c72

Change-Id: I4e11cd8f02c41f73b2dda05effbcc17db036f3fc

Change-Id: I50f16a6c2ec3dcbb12881ab42d0a2f9556cf7ec8

Change-Id: Iadaba3d9c16bdde3715d4836fa0d5661b90ccab4

Change-Id: Id0d9be65aff504ff6092fa64e8207ddb1b7aeea5

Change-Id: I4044722f59aec3ed06cc77f9a29b01f5f1ab7d68

...avoid setting bad values from generic qadevOOo property set tests, and throw
an IllegalArgumentException if bad values do get set.  Found via
-fsanitize=enum.  The TODO about ScLkUpdMode vs. LinkUpdateModes mismatch looks
worrying.

Change-Id: Ibc01845e7e3179dc693fe8c59c1f1ffad5282420

Hijacked ImplNumericGetValue() to parse fractional strings. It now searches for
'/' and build 3 string segments for mixed fractions: whole number, numerator
and denominator. It then follows the previous conversions and checks for
decimal formats. The output string remains as a decimal formatted string for
simplicity and standardization.

Change-Id: Iad842e0ef2b1f637025b09401b10fe93f90e0fba
Reviewed-on: https://gerrit.libreoffice.org/13225Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

It seems that most comments starting with '//!' were intended as FIXMEs.
This replaces gerrit 12241.

Conflicts:
	sc/source/core/tool/token.cxx
	sc/source/filter/excel/xlpivot.cxx

Change-Id: I6ed06b32c70cc854a896dbbc386565e6fbfa9b28
Reviewed-on: https://gerrit.libreoffice.org/12361Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I81607ea1951c4a71c003e639b3ebe871a6943374

Change-Id: I2568d665e6080c7282a6e9f97aac6224c6a4985e

Change-Id: Ia5cd68b7a6bf59d29af8188bd4477c00194fb850

Change-Id: I0b0f5a7fca8c5cb4aefd355f79b5141ce9803a55

This reverts commit 1cc29a04, as it caused
JunitTest_forms_unoapi trigger the

  assert( m_nConvertedBoundValuesType == getValueType())

at forms/source/component/ListBox.cxx:1189.

Change-Id: I6835387cab5c093ad6645d75966786330bd0602a

Change-Id: I2cd795b0b5a266332b167b263f85d2da891e6dee

Change-Id: Ifd0905ed0e68b495d96e429df6193503f53ea908

i.e. there was a reason to the inheritence I removed in

commit bdca5a7e
Date:   Tue Jan 13 13:55:58 2015 +0000
    merge CompareData and SwCompareData

    the inheritence doesn't help us here at all and we can remove
    the virtuals and the casting becomes unnecessary

so restore the different modality

Change-Id: I8f20b8652b7949b04b442b89bed5df3093ad24d8

if two documents have the same number of frames then have an additional stab at
comparing the contents of those frames

Change-Id: Ie7f1a8906d49d720a74620ad8d69fd97c76304e3

Change-Id: I8a772d6e5fdaa1223ed15f8221c64010eddbe75a

Change-Id: I7a64027eb58c86ccf9d1b4968c287f0f861f2ec2

Change-Id: I0dceccbe1275298b43f50296da075ae95694d39a

Change-Id: I82cccaabbcf481367e55c52682d0ff765b4a8671

Change-Id: If22f2d90644f2c03f1b027c73574a857cea890c1

currently disabled as we have a crash on exit in the test related to the
star basic code

Change-Id: If321561a117ea2c55107916c9cb5e99a2c07bdc6

Change-Id: I92c48f71baa24cef3b061b9bb6853b99ea1546d4

add constructors to Date/DateTime/Time,
that take the css::util counterparts,
to simplify code converting between these type

Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7
Reviewed-on: https://gerrit.libreoffice.org/13855Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Are we having fun yet?

This reverts commit 0694e831.

Change-Id: I378a1695a7b3bd8a1b6bb3d5aa1fff53ab8c7bb5

Also change the default to what it actually is now.

Change-Id: Iac5737f9328587c9f0757acecce4f2e77e715d8b