Low level functions will not be tested

Change-Id: I72fa44ea713639db97e39801a3975d6731a684c2

Change-Id: Ie1b5cd0a1f64198f8e6362a02484055c5ae6b26e
Reviewed-on: https://gerrit.libreoffice.org/39077Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ic97e75c81a0c00853d2f10aaf182ab476c466c86
Reviewed-on: https://gerrit.libreoffice.org/39281Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I20e3796407c7e429a88d2811673929ac1141a41c
Reviewed-on: https://gerrit.libreoffice.org/39280Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

extending it to find places we can use std::unique_ptr on arrays

Change-Id: I9feb1d12d738d6931e752ecb6dd51cbc1540c81b
Reviewed-on: https://gerrit.libreoffice.org/39255Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie2b36175a52c897bcf39da0ac2daa35979aac923
Reviewed-on: https://gerrit.libreoffice.org/39285Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ifbed15c881e4c0b987cd2fdbb903709a0b8b0e36
Reviewed-on: https://gerrit.libreoffice.org/39269Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I97fd74c664e125f6c04f585e20c84ce702927e50
Reviewed-on: https://gerrit.libreoffice.org/39277Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I218675bcb832c158171f87bb7c52a658ceaa7a67
Reviewed-on: https://gerrit.libreoffice.org/39278Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Project: help  bb320c4e73967aff4b1b92c46c82a5dc5bdd8d3f

Expand some useless “MS” abbreviations to “Microsoft”

Abbreviations should be used only when we lack space
(e.g., in UI), but there’s plenty of it here

Change-Id: Ib0ac97b2003ca96e4bc286a1a1436bda0f81bd8a

Change-Id: I3c0f8cea0adca843ec88f4742243c6cdada6bc5f
Reviewed-on: https://gerrit.libreoffice.org/39260Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I647253f32bfac0460c263f662ab95ec0151bf38c

...after 272d5a02 "Revert 'tdf#108524 sw:
attempt to split section frames inside table cells'"

Change-Id: Ic1ec8cd3284e2ba98630552c80d99b5d67fc7efd

Change-Id: Ibe51eb81ea1b0874fc1a9018871f07c9af38e8d2
Reviewed-on: https://gerrit.libreoffice.org/39268Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ic94338662009a4e0ddbc28e21ac1f5028ddd9126
Reviewed-on: https://gerrit.libreoffice.org/39219Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Found when trying to temporarily add a SAL_DEBUG to (otherwise empty)
~NotebookbarTabControl (sfx2/source/notebookbar/NotebookbarTabControl).

This reverts commit f991b842.

It doesn't really work and crashes on ooo61225-1.sxw in

1 in SwFrame::FindTabFrame() (this=0x0) at sw/source/core/inc/frame.hxx:913
2 in SwFrame::GetNextSctLeaf(MakePageType) (this=0x3137130, eMakePage=MAKEPAGE_INSERT) at sw/source/core/layout/sectfrm.cxx:1529
3 in SwFrame::GetLeaf(MakePageType, bool) (this=0x3137130, eMakePage=MAKEPAGE_INSERT, bFwd=true) at sw/source/core/layout/flowfrm.cxx:805
4 in SwFlowFrame::MoveFwd(bool, bool, bool) (this=0x31371d8, bMakePage=true, bPageBreak=false, bMoveAlways=false) at sw/source/core/layout/flowfrm.cxx:1861

The code added in GetNextSctLeaf() looks unfinished to me: it assumes that
something else has added a follow-frame for the SwCellFrame containing
the SwSectionFrame already, but AFAICT the GetNextSctLeaf() function
is responsible for creating that SwCellFrame follow.

The caller (in GetLeaf()) specifically checks for this condition and
avoids calling GetNextCellLeaf().

Change-Id: I51875830771f07f5d2fec293f6063c73fc68d468

This reverts commit 55d4cc34.

It's obviously bogus to have mbInfTab set but ImplFindTabFrame return
null.  Also, just loading the document still crashes with the same
problem in a different place.

Change-Id: Ief5b2e37f289d6bfa92a909701c331d50509b0a3

Change-Id: Ifbcfa5b612cb0a8670bf3dd0be6e74708cc969c1

Change-Id: I1d69d592a05908e4e2a2e832a5b6ef9d13fc2e2c

Change-Id: I0830f00bce19bc4b77d8e9e0cb5684338a4c9e5d
Signed-off-by: Christian Barth <Christian.Barth@zoho.com>

Change-Id: I657a131374b9f1153135e00ed429889518b91427
Reviewed-on: https://gerrit.libreoffice.org/39258Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

This translates "Neu..." to "New..." in names of some variables.

No functional change is intended.

Change-Id: I29859ecdd44e15820414746cd2b39f62cdfc0ae3
Reviewed-on: https://gerrit.libreoffice.org/39213Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

regression introduced with ac2d415a
"loplugin:oncevar in sc"

Change-Id: I521053a59bb16c78d97129e4de5ebbf4820d6640

Change-Id: I6ffd9832ff1085c84fde8763045f3d1cb02137e2
Reviewed-on: https://gerrit.libreoffice.org/38974Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

regression introduced with ac2d415a
"loplugin:oncevar in sc"

Change-Id: I1073e7e8b67ddf1dd633f004322c6bc46b9a8052

Change-Id: I32afd77a851da180d91011fa424a88be5871e8f7

Change-Id: I56649b4df8c517f152ed4e9132985bbef22f8634
Reviewed-on: https://gerrit.libreoffice.org/39241Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

didn't find anything useful, so just updating the exclusion lists

Change-Id: I66d37aee185290f454e5ac0baeafd1f67bfaf106
Reviewed-on: https://gerrit.libreoffice.org/39254Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ice59e286debb6bd0eb692f2b2b0c2c5087c069c0
Reviewed-on: https://gerrit.libreoffice.org/39239Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

... to avoid "corrupted" warning from Excel.
In case of string fields, Excel expects the item list to be present,
and containsXXX attributes of sharedItems to be absent, otherwise
it shows a warning about file corruption.
For numeric fields, it doesn't expect item list, othervise it also
warns about file corruption.

Change-Id: I5ded5b836587bed3177eb0a6b6c418e459e6be8b
Reviewed-on: https://gerrit.libreoffice.org/39114Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I854703ea3cb09ace2d0b01a47d9f07bb7a98b70e
Reviewed-on: https://gerrit.libreoffice.org/39172Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

I guess Coverity complained that there was a copy assignment operator
but no copy ctor, move assignment and move ctor defined.

Change-Id: I10641c9f403e609406b2a1420b22abbfc9dbc6fc
Reviewed-on: https://gerrit.libreoffice.org/39240Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fixes c0ce1ec3 "loplugin:unusedfields in sfx2
part1" part on "fix a memory leak in NotebookbarTabControl where it was not
freeing it's m_pListener field", which now caused ASan to report heap-use-after-
free during CppunitTest_sw_dialogs_test.

Change-Id: Ic0209650692a34abd1ee451713615a03ed9c746f

Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5
Reviewed-on: https://gerrit.libreoffice.org/39232Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I9aadcb9a12ef9b0c3f93ea255f2542e51d31fbf7
Reviewed-on: https://gerrit.libreoffice.org/39242Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Translates all (leftovers) found using a custom regex, in directories not
shown by /bin/find-german-comments and beginning with "r".

Additionally:
- Translates test strings in /registry/test/testregcpp.cxx

Change-Id: I9fda72a3d1830268c4eb83d67ee7a95e38c31c0d
Reviewed-on: https://gerrit.libreoffice.org/39210Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

COMPMOD_RESPREFIX=abp was unused ever since initial commit in 2001.

COMPMOD_NAMESPACE was used to set the namespace name qualifier of
the helper in componentmodule.hxx to the extension's namespace name.

I don't see why this is necessary as the helper is always compiled in
a separate extension library.

Change-Id: I287607008db3dc0ebc32731536747a921c91807d
Reviewed-on: https://gerrit.libreoffice.org/39184Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Those will be implicitly-defined by compiler and a move assignment
operator should be implicitly-defined now too.

Change-Id: I03c4bb3b95e76c706b606a170ed02c2a39862b36
Reviewed-on: https://gerrit.libreoffice.org/39246Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>