Change-Id: Iaafaf0117a339dbb435cec2bbf4dca55629ab8a2
Reviewed-on: https://gerrit.libreoffice.org/33154Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  f877da8362728007c4771e731487149c084fc2da

typo: add missing space

via translator feedback

Change-Id: I932dde4cc9d728830f8eeb35453853b9d63bfe9c

Change-Id: Iafbaff60d10c9de7b57421e0c24809b08d813987
Reviewed-on: https://gerrit.libreoffice.org/33146Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie5cee5d7dd067df121397b60a7adc85c62906e54
Reviewed-on: https://gerrit.libreoffice.org/33155Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5b4523929f971d0345f112ba4f5faff1181cee2b

Change-Id: I3570b465d406921cbbb225825f9ba410161c9635

Change-Id: I9f0f98c989cb7ecf6227154e1d81d49abade66c2

Change-Id: I546629656ada6c7a8a15b4dc77a042e1f1106924
Reviewed-on: https://gerrit.libreoffice.org/33059Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

Handle corner cases better and eliminate
invalid rects and out-of-bounds coordinates.

Change-Id: Ib9247ae4f0306cf68937cd2678f6386fe7710eec
Reviewed-on: https://gerrit.libreoffice.org/31665Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I2421cd032066c41f80e8b6560c8c4a73f26edeb2
Reviewed-on: https://gerrit.libreoffice.org/33151Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9a72b0d3ca999e2f84c615515fafa90bc7f8f2b6
Reviewed-on: https://gerrit.libreoffice.org/33150Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

It was coded pretty badly, so I cleaned it up. Most notably, it used
a static instance of the Activity, which is a huge no-no which
creates memory leaks. The irony is, it already had a reference to the
Activity used correctly in the constructor. One memory-leak fixed,
29 more to go (LibreOfficeMainActivity holds that static Activity
object which needs fixing). Also, simplified the "bottom toolbar"
in preparation for the CoordinatorLayout implementation which will
allow the activity to have fancy animations and smart interactions.

Change-Id: I31aa117f6179910db73a5256b0a287357e1dec83
Reviewed-on: https://gerrit.libreoffice.org/33010Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Fixed typo in SearchController (SearchDriection -> SearchDirection)
Also tightened up the code.

Change-Id: Iedb6f95c9d8ed04cc166638250c2d565e92d79ff
Reviewed-on: https://gerrit.libreoffice.org/33011Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Because RecyclerView is more optimized, especially if there are lot
of items. This way, we don't have to recreate ListView and GridView
each time we switch view modes. Changed list adapter to appropriate
RecyclerView adapter, and created new grid adapter inline, next to
the list adapter, while deleting the older grid adapter file. Since
these adapters are almost identical in content, maybe we could:
a) Make them extend the same "base" adapter, to avoid duplicate code
b) Unite them into one adapter which would display appropriate views
at appropriate times.

Change-Id: I1545c2c245ca642a689dee584bffb15f90aac4a6
Reviewed-on: https://gerrit.libreoffice.org/32976Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Replaced the custom implementation of the drawer with the support library one.
This one inherently follows Material Design guidelines, and is much easier to
maintain. This implementation also allows for header in the drawer, and so
we could put something useful there to make the drawer even better. Also kept
the original way of programatically adding the menu items, although I find this
practice somewhat unelegant. Maybe we could have static list of items, and then
grey-out the ones that aren't currently available? Also added appropriate icons
to the menu items (which are vector drawables, of course), but I only covered
the providers that appeared on my device (I can't confirm that there are no
other providers), so if the provider is covered, it will have an icon, but if
I didn't cover it, it will appear just fine, but without an icon. Maybe we
could move the settings and sorting to the navigation drawer, also? It would
be cleaner and more elegant, IMO.

Change-Id: I02a051f0b75c6d4e16f518aa19fb9c6eef00f5e4
Reviewed-on: https://gerrit.libreoffice.org/32881Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Change-Id: I5a9806e8dd79431f14d6861c8f4d65f828398f07
Reviewed-on: https://gerrit.libreoffice.org/33145Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  6d47ddb5ee88c192a4fa3343b1cccf4044c54e2c

Fix Macro assignment page of frames, images and OLE objects

Fixes bookmarks, ahelps and UI element names

Change-Id: I8441005c2bf181af314d3e80b4d926fa9caf923e
Reviewed-on: https://gerrit.libreoffice.org/33109Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  e8625126b630646ca0f490e1f21ef97015bce2a3

tdf#105354 Do not link Macro Selector window to wrong page

With this part dropped (it doesn't make any sense)
the Macro Selector windows Help button does not display
the Customize - Menu tabs help page anymore

Change-Id: I2b74d4e920ee0e6b2172842406e29bbbecc329e5
Reviewed-on: https://gerrit.libreoffice.org/33106Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  c5f15a5212c3b3da85229045ba24354c1f42726b

Typo: 'theList Box Wizard'

Change-Id: I664271ec7cf1de150c13bf32e1c37b91f2f297a9
Reviewed-on: https://gerrit.libreoffice.org/33105Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0994bfcae23a2714c78e16c9baa7e0a018d46513
Reviewed-on: https://gerrit.libreoffice.org/33144Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  d384c401e5630c617ac55e4f4b6e7142cc225e1c

Typofixes: spaces missing after </item>

Change-Id: I2344e3f845f83aac65eb0ebe53b1c1f2064f4022
Reviewed-on: https://gerrit.libreoffice.org/33108Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  ba55e4f84d78748ea2f532515220e3860374a2b7

Typofixes: missing spaces around <emph> and </emph>

Change-Id: I20d9bed521fcf8c8fcba642c55821978cd3c78c3
Reviewed-on: https://gerrit.libreoffice.org/33107Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  26f13088c51486cbf9300e6453458f655f61d702

tdf#105089 (partial) Typo: 'if he status' -> 'if the status'

Change-Id: I78c9f36335ee1f79860237b92fa90b4731a589fd
Reviewed-on: https://gerrit.libreoffice.org/33104Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0eb3d43d7bcfc491df16a72997a0720a6aec2c5c
Reviewed-on: https://gerrit.libreoffice.org/32959Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic029ed28fd6de8cf4ee204585c1c6e0c8a4b67ff
Reviewed-on: https://gerrit.libreoffice.org/32960Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This patch allows processing a number even if a comment is the
first item in the string. Previously the result was formula
cells displaying an error message.

Only fields were handled for annotation anchors. Allow other
non-word-breaking markers to be checked for number validity.

Change-Id: I13b3566bf93f0029a28bada470cdd4196271bccd
Reviewed-on: https://gerrit.libreoffice.org/32949Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: I8eb53c06892934c21d55b69d12e3c8ff09696295

Change-Id: Ie44a5b8433e2dc2c253d6c439f9308f936a4508f
Reviewed-on: https://gerrit.libreoffice.org/33094Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: I9cb4b14c0b4642c6e630c449dc979521ba0f8ee6
Reviewed-on: https://gerrit.libreoffice.org/33093Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: I3e609c54f7b21c300944362d27248d92ab69b886
Reviewed-on: https://gerrit.libreoffice.org/33092Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: I61c2890db1190f2552e16bc26968bec31c5dc6d3
Reviewed-on: https://gerrit.libreoffice.org/33091Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I31d10a481063f42f1504d0066d8364102d17a1fb
Reviewed-on: https://gerrit.libreoffice.org/33090Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

The UNO command of default formatting in Draw is .uno:SetDefault
instead of .uno:ResetAttributes.

Change-Id: I9fea2cb6b89f7869cfcd40fa6e1768952563a4f6
Reviewed-on: https://gerrit.libreoffice.org/33085Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: Icc9d7d84b44ecbd0531f538ec227b37998b1f5e2
Reviewed-on: https://gerrit.libreoffice.org/33097Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Submitted by:	Curtis Hamilton

(cherry picked from commit 55ffac65)

Change-Id: I160ff9369a563d58469682ed96e25c792184708c

e.g. fdo80788-1.odt

 Invalid read of size 2
    at 0x3C031438: SwLinePortion::IsParaPortion() const (porlin.hxx:132)
    by 0x3C05EC56: SwTextFormatter::BuildPortions(SwTextFormatInfo&) (itrform2.cxx:679)
    by 0x3C05F2A2: SwTextFormatter::FormatLine(int) (itrform2.cxx:1550)

  Address 0x3576189e is 30 bytes inside a block of size 40 free'd
    at 0x4C2ED4A: free (vg_replace_malloc.c:530)
    by 0x4E56939: rtl_freeMemory_SYSTEM(void*) (alloc_global.cxx:279)
    by 0x4E56978: rtl_freeMemory (alloc_global.cxx:349)
    by 0x4E5501B: rtl_cache_free (alloc_cache.cxx:1230)
    by 0xDACE741: FixedMemPool::Free(void*) (mempool.cxx:49)
    by 0x3C043AB8: SwTextPortion::operator delete(void*, unsigned long) (portxt.hxx:55)
    by 0x3C043B05: SwHangingPortion::~SwHangingPortion() (porrst.hxx:98)
    by 0x3C043F47: std::default_delete<SwHangingPortion>::operator()(SwHangingPortion*) const (unique_ptr.h:76)
    by 0x3C044070: std::unique_ptr<SwHangingPortion, std::default_delete<SwHangingPortion> >::reset(SwHangingPortion*) (unique_ptr.h:344)
    by 0x3C0888C3: std::unique_ptr<SwHangingPortion, std::default_delete<SwHangingPortion> >::operator=(decltype(nullptr)) (unique_ptr.h:280)
    by 0x3C0888DB: SwTextGuess::ClearHangingPortion() (guess.hxx:51)

since...

commit a706bb06
Date:   Wed Jan 11 14:26:47 2017 +0200

    new loplugin: useuniqueptr: sw part 1

Change-Id: I614029474d684ddcccd4f4a5e9787fe6c19d8fd2

Change-Id: I65cdb5a5ba3e5d1ebb852b7e0d3d58b2b2fbbbcd

Change-Id: Ib41b474c6ae573ca68614aeff8ca2cda5fd52dbc
Reviewed-on: https://gerrit.libreoffice.org/33061Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I9b07b185fd1c3f43c06713d4e5fde8d97b2991ef
Reviewed-on: https://gerrit.libreoffice.org/33099Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Change-Id: Ieeebda1fdd1db7dd9a08c7393788bac2509ab637
Reviewed-on: https://gerrit.libreoffice.org/33020Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>