- 31 Agu, 2015 40 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I51a0596049a43cbc80f914f3d8491c2125c8109e Signed-off-by:
Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/18158Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Michael Meeks yazdı
Change-Id: Idd7ec17eed51f79ead56349bb644945826d0a695
-
Caolán McNamara yazdı
Change-Id: I9375f84affdaef30d9b1ded31525e6b7b8709cbc (cherry picked from commit 7d4c77e3) Reviewed-on: https://gerrit.libreoffice.org/18149Tested-by:
Norbert Thiebaud <nthiebaud@gmail.com>
-
Michael Meeks yazdı
Change-Id: I677f47f6b60271dc56c9d3d123cf982c00866eb9 Reviewed-on: https://gerrit.libreoffice.org/18136Reviewed-by:
Maxim Monastirsky <momonasmon@gmail.com> Tested-by:
-
Tor Lillqvist yazdı
SAL_DETAIL_ENABLE_LOG_INFO is always defined, as "true" or "false". It is SAL_LOG_INFO that is defined or not, and can be used to avoid unnecessary non-trivial code that the compiler might not be able to optimise away. Change-Id: I9903faab64b39fee86bff3b085cdce3614b0d921 (cherry picked from commit d23a1f4d)
-
Michael Stahl yazdı
Since the gradient frame backgrounds were added in LO 4.1, we export this: fo:background-color="transparent" draw:fill="solid" Which doesn't make a whole lot of sense as this is really a "none" fill, and now with the backward compatibility stuff in the style import code we get the pool default color added when setting the BackTransparent property, and with the draw:fill="solid" it becomes visible and the background color is now Sky Blue 1. So try to detect draw:fill="solid" without draw:fill-color attribute and contradicting transparent legacy attribute and nerf it. This way we also export draw:fill="none" again, although still with a bogus draw:fill-color but that shouldn't cause any harm. Change-Id: I1c2bea46ba7d9a3f042b875df0ca12c7f6037909 (cherry picked from commit 68efa6f5) Reviewed-on: https://gerrit.libreoffice.org/18040Tested-by:
-
Michael Stahl yazdı
... frame/paragraph backgrounds. If a style is set to have draw:fill="solid" and a derived style to draw:fill="none" then the derived one must have fo:background-color="transparent" to override the parent for old consumers like LO <= 4.3/AOO <= 4.1 that don't understand draw:fill. Change-Id: I5b56c7ace927338239195c6bfcfef1950544c8d2 (cherry picked from commit 25c50a71) Reviewed-on: https://gerrit.libreoffice.org/18039Reviewed-by:
-
Michael Stahl yazdı
The problem is that if the FillStyle is NONE, setting only ParaBackTransparent but not ParaBackColor does absolutely nothing. This means that if a parent style sets a background color, then a derived style cannot override it to be transparent. Cause is that getSvxBrushItemFromSourceSet() defaults to setting a 0xFF transparency on the SvxBrushItem. There is still a problem that getSvxBrushItemFromSourceSet() sets the pool default item's color and that is also exported to ODF again as draw:fill-color, but together with draw:fill="none" it should not cause harm, at least for consumers that prefer draw:fill attributes like LO >= 4.4. (regression from 7d9bb549) Change-Id: I5312901166a0e6f0cf02369b173dc8498e4113ed (cherry picked from commit f38f0180) Reviewed-on: https://gerrit.libreoffice.org/18038Reviewed-by:
-
Michael Stahl yazdı
getSvxBrushItemFromSourceSet() is called once for each property of a frame style that is set, and the "solid" fill-style is set by first applying the BackColorRGB and then BackTransparency property. So there is an intermediate state that has fill-style NONE but a XFillColorItem set - don't reset the color to white in that case! Apparently writerfilter generally relies on the current reset-to-AUTO implementation (loads of test failures), so for now limit the fix for when we know that a frame style is imported from ODF. (regression from 3d399b0e) (cherry picked from commit 79fb61ef) tdf#92379: sw: unit test for frame style background color (cherry picked from commit 982537d7) Change-Id: Ia987fe586ec819a1f3cd85acdbfb03c74ca0ec2c Reviewed-on: https://gerrit.libreoffice.org/18037Tested-by:
-
Michael Stahl yazdı
Flat ODF Import does not use SwReader but uses SwXMLImport::startDocument() and SwXMLImport::endDocument() to set up the document, so make sure those set the import relevant SwDoc flags. Change-Id: Ife3e58eeebd73ad895fe328662822b847cf9bfec (cherry picked from commit 27a02d17) Reviewed-on: https://gerrit.libreoffice.org/18036Reviewed-by:
-
Michael Stahl yazdı
Since commit 65a66d41 the sd_exports_test crashes on Windows in UniscribeLayout because it uses a ImplFontEntry that has been removed from the font cache. Tweak the refcount in WinLayout so it will be valid. Change-Id: Ic4bf984ea9fd70de9fa95ca964ae12d95d47d5bf (cherry picked from commit 34700400) Reviewed-on: https://gerrit.libreoffice.org/18121Reviewed-by:
-
Michael Stahl yazdı
It says there's access to uninitialized variable on that line, so propbably the loop is running over. Change-Id: I0226f82b20a6fbbc79af5bbb46af09830c3bc25a (cherry picked from commit eba9a6c4) Reviewed-on: https://gerrit.libreoffice.org/18107Tested-by:
-
Caolán McNamara yazdı
Change-Id: I609c8c4f4e843601361b61f55e0325ad99db3c23 (cherry picked from commit dc1be62d) Reviewed-on: https://gerrit.libreoffice.org/18115Tested-by:
David Tardon <dtardon@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ie1df87c7eb9d391d0fa4a579f744051a1f1b2ae1 (cherry picked from commit 07823502) Reviewed-on: https://gerrit.libreoffice.org/18114Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I9c4c2f0fe2d892615b3c70e08da0cab6da13338a (cherry picked from commit 2aadad1e) Reviewed-on: https://gerrit.libreoffice.org/18113Tested-by:
-
Caolán McNamara yazdı
Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562 (cherry picked from commit 1847753a) Reviewed-on: https://gerrit.libreoffice.org/18112Tested-by:
-
Tor Lillqvist yazdı
Can't call a function that as a side effect prints to std::cerr in SAL_INFO. It will be called even if the log area doesn't match $SAL_LOG. Just use only SAL_INFO and no plain std::cerr output. It's fine to output a string with embedded newlines in SAL_INFO. Also drop the debug output line with the glyph start positions, it was less than useful. Change-Id: I9fb5ed068aae1b835e20cf1ec1097bcd55deb05d (cherry picked from commit 15943416)
-
Tor Lillqvist yazdı
Change-Id: I67d2430aec782efa7916856584028f469d39355c
-
Bjoern Michaelsen yazdı
- prevents flys in inlcuded docs in a master doc from disappearing - fixes a regression from 3fcb0c3a Change-Id: If211d8dbf423e2a33a258b43ab7092e1a010206f Reviewed-on: https://gerrit.libreoffice.org/18106Tested-by:
Michael Stahl <mstahl@redhat.com>
-
Tomaž Vajngerl yazdı
Currently we draw the polyline from the input polygon, but we should first create a trapezoid and draw its polygons when drawing the hairline. Change-Id: Idd850d18d05410c75a8a2c922338caf46158bfd4 (cherry picked from commit c9d39c37) Reviewed-on: https://gerrit.libreoffice.org/18105Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ie3836f2e95acab963634181a07565343501f00f8 (cherry picked from commit 9a695e07) Reviewed-on: https://gerrit.libreoffice.org/18092Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716 (cherry picked from commit eea399dd) Reviewed-on: https://gerrit.libreoffice.org/18088Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I02420ffb3af009d08ce54a0932e2c7a287703a72 (cherry picked from commit 1830b4f2) Reviewed-on: https://gerrit.libreoffice.org/18091Tested-by:
-
Caolán McNamara yazdı
(cherry picked from commit 932f6de9) Change-Id: Ia2bb397c3fdd783cab77a6b0dbc31c9e3d19326b Reviewed-on: https://gerrit.libreoffice.org/18094Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I7413a4e9e491b65122eaadb38ad574161f1aa943 (cherry picked from commit d417ffb7) Reviewed-on: https://gerrit.libreoffice.org/18090Reviewed-by:
-
Michael Meeks yazdı
Change-Id: I56629a721202d7a04bd493d4604278dea85b4212 Reviewed-on: https://gerrit.libreoffice.org/18104Reviewed-by:
Tor Lillqvist <tml@collabora.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: Icc1378c9c27b9b6d229bcffc6a63017f82be70d4 (cherry picked from commit 580d3837) Reviewed-on: https://gerrit.libreoffice.org/18100Reviewed-by:
-
Michael Meeks yazdı
Change-Id: Icf75e0e477be1b2bbbe5095aee33e681d212be0b Reviewed-on: https://gerrit.libreoffice.org/18103Reviewed-by:
-
Caolán McNamara yazdı
(cherry picked from commit de71eae5) Change-Id: Icc40c0ee6c7d8d305cf7cc60cbf3e511c763aedd Reviewed-on: https://gerrit.libreoffice.org/18093Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Iedba71b72fc815b274ca5e0da0903a558947cb06 (cherry picked from commit 90dc4e38) Reviewed-on: https://gerrit.libreoffice.org/18089Reviewed-by:
-
Caolán McNamara yazdı
SvxBackgroundColorItem inherits from SvxColorItem and for backwards compatibility with the StarOffice 5 binary file format (yes, really) writes/reads only rgb and not the transparency value, so copying and pasting text from a sidebar comment in writer to itself or another one results in a black character background as the default COL_AUTO turns into black Change-Id: I18b5105dd8e060b9e49dda6026e26d3a0f00d8f5 (cherry picked from commit 3bc69b1d) this farcical staroffice 5.0 related junk can at least be const Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6 (cherry picked from commit 1e8b7cdb) Reviewed-on: https://gerrit.libreoffice.org/18087Reviewed-by:
-
Tor Lillqvist yazdı
That is a too complex and rare case to bother with, I think. Change-Id: Ica6ef7fa05314d2367dcff32627c1aec6ba8f8df Signed-off-by: -
Tor Lillqvist yazdı
Change-Id: I46e5463aaa5cab41cd69c13314ee98a0c73e7ba2 Signed-off-by: -
Tor Lillqvist yazdı
Change-Id: I6b19873eef48b625dc3d4f7b3a9afdb348189b38 Signed-off-by: -
Tor Lillqvist yazdı
Change-Id: Icab5608900108c89e649e78a2e35d02e941d0ac0 Signed-off-by: -
Tor Lillqvist yazdı
The text alignment of DCs is set to TA_BASELINE in WinSalGraphics::InitGraphics(). In the ScriptTextOut-using old code path this affects where glyphs are put, so we need to take it into consideration also in the new code path that uses cached glyph textures. Adjusting the position up by the ascent plus internal leading of the font seems to work at least for horizontal scripts. (We used to bluntly adjust the position up by the height of the glyph cache texture, which was too much. The glyphs got positioned too high and the top of tall ones was clipped.) Change-Id: I86aecd6f3016e14b2f0328555ddfd3129e394c4c Signed-off-by: -
Tor Lillqvist yazdı
Change-Id: Id023b43e901b0e41ebf3b208c6e80fd023bf7f9a Signed-off-by: -
Tor Lillqvist yazdı
Show the whole height of the cache bitmap after all (when SAL_LOG contains vcl.gdi.opengl). The interesting pieces are often at the bottom, like the tip of the hook of the "j" glyphs that used to bleed over into the preceding glyphs, usually "i", when they were rendered into the same chunk. Add more space between glyphs and at top and bottom of the bitmap, for anti-aliasing. The glyph ABC widths don't take expansions caused by anti-aliasing into consideration and are misleading. Hopefully anti-aliasing can expand the (partially) painted pixels of a glyph just one column/row in each direction, but for safety use a two-pixel border. (Defensive programming, eek?) Some getWidth() instead of GetWidth() etc craziness. Using <tools/gen.hxx> types truly is programming-by-coincidence as Thorsten says. In a dbgutil build, setting the environment variable VCL_GLYPH_CACHING_HACK_NO_ANTIALIAS causes the code to turn off anti-aliasing for the fonts used. I used this to verify that it indeed was anti-aliasing that made the ABC widths inconsistent with reality. Not sure if it makes sense to keep this code in? Anyway, now I don't see any leaked pixels in "i" glyphs any more, touch wood. Change-Id: If527343ff1dcdb1fa208cd5e7fa4d08f812d0d7b Signed-off-by: -
Tor Lillqvist yazdı
Change-Id: I29cb771eb059f560b7cbd449257ffda581b40f11 Signed-off-by: -
Tor Lillqvist yazdı
Change-Id: I59dbfea2230012447732d12f732ad160a30908e7 Signed-off-by:
-
