LO's own font handling backend has some additional font styles,
which are unknown to Qt, probably because it uses some stricter
handling to decide which fonts are "usable", and because Qt seems
to not know about some style types AFAIK.

The main problem is QFontDatabase::addApplicationFont, as this
seems to parse the whole font instead of a kind of registration,
which takes ages for something like the Noto CJK style variants.

As a workaround this drops the registration of all the additional
PSP fonts. Both Qt5 and PSP use fontconfig but there is definitly
some difference here, which needs to be resolved in some other
way at some point.

Change-Id: Id63cd0258ff56ee988323551820500b2c72a12be
Reviewed-on: https://gerrit.libreoffice.org/69576
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: If4c8de085701af503a43a143c7eec5263e36d59b
Reviewed-on: https://gerrit.libreoffice.org/69580
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

Change-Id: Ie8ceead5cba72abf32e57e214e677dbf478941d4

... and I was wondering why Qt5 didn't start anymore. Looks like
it was already broken in my initial commit :-(
Now there is also no more need for the KDE5SalInstance "variant".

Change-Id: I035d31eaf191b3f2a4255869cea25394470d0dd0
Reviewed-on: https://gerrit.libreoffice.org/69577
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Move the "help" and "close" buttons to the bottom of the dialog.
The "help" button will be at the bottom left.
The "close" button will be at the bottom right.

Change-Id: I496a3c95dd4761d8a360ad85fc5af03d0c53f131
Reviewed-on: https://gerrit.libreoffice.org/69468
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Reportedly under some circumstances execution of wusa.exe may hang
for very long time (available logs show more than 90 min). LO MSI
installer waits for wusa.exe indefinitely in its deferred inst_msu
custom action; during this wait, one can't abort the installation.

There is an evidence [1] that stopping WU service prior to wusa
launch might prevent this hang.

The patch does two things:
1. It stops running WU service prior to wusa launch.
2. It adds a check for user input by executing MsiProcessMessage
twice a second, and checking its return value, to allow early
return in case user cancels the installation.

This is a blind shot, since I cannot reproduce the problem myself.

[1] https://superuser.com/questions/1044528/

Change-Id: I8bf4ce52b3e9d98a4f90af3abcc49ac63b6a0e40
Reviewed-on: https://gerrit.libreoffice.org/69487Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

They now unnecessarily duplicated the start listening with the
changes that introduced ScColumn::StartListeningUnshared().
Also the ScColumn::BroadcastNewCell() now is sufficient as it is
called after StartListeningUnshared().

Change-Id: I0495ce5fe47daa068974c7b70ec28e0530c080f1
Reviewed-on: https://gerrit.libreoffice.org/69570Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: Ice7e1e42dba7bfbc2db6a60e4457c3610430b87e
Reviewed-on: https://gerrit.libreoffice.org/69568
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

The RegexMatcher.find(status) is new since icu 55 and this works even
on the old releases thus revert there to the available albeit slower
call.

Change-Id: I964c10efd15515b04ac9037cda3b5b309910baf5
Reviewed-on: https://gerrit.libreoffice.org/69311
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

User can find it easier in this position.

Change-Id: I38fd782485a180e0d5223b52cc2c6ee061661600
Reviewed-on: https://gerrit.libreoffice.org/69562
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

This was broken because GenericSalLayout::LayoutText() sets the
SalLayoutFlags::KashidaJustification flag as a side-effect of building
the glyph list. So in case we cache the list and not build it, the flag
will be missing. This means that later in
GenericSalLayout::ApplyDXArray() kashida glyphs won't be inserted.

With this, the workaround in sw can be removed.

Change-Id: Ic18211bf50ca673daa238e8950a381915e4b3096
Reviewed-on: https://gerrit.libreoffice.org/69566Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Id97a35cdef93f4e1b21e4c3d22918f1bae42aea9
Reviewed-on: https://gerrit.libreoffice.org/69563
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

If the bitmap to be drawn will need to be scale for drawing, OpenGL
handles this by scaling, but the scaling is of poor quality. Other
backends scale in such a case with a good quality, and e.g. opengl's
drawAlphaBitmap() also does the same check, so copy that check
to drawBitmap() as well.

Change-Id: If6a457c69c6676d03fa4046b9910683f51479d21
Reviewed-on: https://gerrit.libreoffice.org/69556
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Idf3cac2c8a37850ac254553164b57c777c2fd850
Reviewed-on: https://gerrit.libreoffice.org/69560
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Until now we exported the original x/y position values of the table
from the grabbag. Ignoring users actions like moving the table around.

Now, we compute the position from the parent frame and write the actual position
in the docx file.

Change-Id: I25a09f9c7c8fbe49acbd19e2b1440c7fa90b8aff
Reviewed-on: https://gerrit.libreoffice.org/67969
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Make SfxInfoBarWindow text wrap (WB_WORDBREAK) by default.
Make SfxInfoBarContainerWindow stretch to fit its content (the wrapped text)

Change-Id: Ib6f68011b4f2a4813dc5e0316281583b9ac641ee
Reviewed-on: https://gerrit.libreoffice.org/69482
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Commit 436b829f (sw: save one vcl layout
call in SwFntObj::DrawText(), 2018-08-16) did this unconditionally,
which broke kashida justification. Re-introduce the same mechanism, but
this time opt out in the kashida case to keep that working.

This means that for Latin scripts we are back to 2 layout calls (instead
of 3) for each keypress in Writer.

Change-Id: I890f0ab04d1f5dce561f1536d7c8a6d67a639813
Reviewed-on: https://gerrit.libreoffice.org/69557Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - Resolves: tdf#122479 no extended tooltips for Reset and Standard buttons
    
    a) in the ahelp HID_TABDLG_STANDARD_BTN hid is used instead of SFX2_HID_TABDLG_STANDARD_BTN
    
    b) there are multiple entries for HID_TABDLG_STANDARD_BTN, the second one
    describes some wizard previous buttons and the third one is definitely
    describing an expander button, not standard buttons
    
    c) HID_TABDLG_RESET_BTN likewise is unsed instead of SFX2_HID_TABDLG_RESET_BTN
    and appears in two places, the second of which is tagged with "what's this" and
    "A confirmation query does not appear. If you confirm the dialog with OK all
    settings in this dialog are reset."
    
    so:
    use a hid of "." which means to apply to all the previously seen bookmarks
    hids since the last ahelp current bookmarks are those within the current
    section
    
    add another bookmark for the "options/more" expander, which isn't currently
    linked to by anything but could be if desirable in the future
    
    drop the second text describing Reset button which has no bookmark in
    its section
    
    Change-Id: I8c89ea7a5588dc22c29ccdd78118b9288a609563
    Reviewed-on: https://gerrit.libreoffice.org/69559
    Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
    

even if it's larger than max sidebar width (increase max sidebar width in that case).

Change-Id: I2efbd546596f756df205196fae3e545beddd2f7c
Reviewed-on: https://gerrit.libreoffice.org/69551
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Otherwise the core likes to crash due to the keyboard accellerators
being read, but the configuration is missing.

Change-Id: I94193f47462227b5975a49ce11709d7bf415a519
Reviewed-on: https://gerrit.libreoffice.org/69508
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I324a581721e01c907113bb3ab1cc91a290bd71a7
Reviewed-on: https://gerrit.libreoffice.org/69475
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5eb1f2b6b7b2dbc3bc675845730cb3aef1cab5f0
Reviewed-on: https://gerrit.libreoffice.org/69528
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I03a800cc5e1c81e167ad91e68e80ac7a08e940a4
Reviewed-on: https://gerrit.libreoffice.org/69548
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

When the sheet name/cell address separator was an exclamation mark,
bad conversion of the optional dot separator replaced the last dot
of the exported sheet name, resulting broken links:

'sheet.name.with!dot'!A1

Change-Id: I84fb6c8da345c144b04657ea350f1f96614071b7
Reviewed-on: https://gerrit.libreoffice.org/69272
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

always within welded dialogs now

Change-Id: If3d7adc54e8c65e164c9edce0a2f1dddd3d63e8f
Reviewed-on: https://gerrit.libreoffice.org/69550
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I0f7d9d3d4cdddd105eb2a31ecce035ef7858fa19
Reviewed-on: https://gerrit.libreoffice.org/69534
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I703cefb4a73c5f3e002c142eec01d19ec8c9fcd3
Reviewed-on: https://gerrit.libreoffice.org/69533
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ifbdbf7f2d44d569c491b1822d9d842433a9978a1
Reviewed-on: https://gerrit.libreoffice.org/69462
Tested-by: Jenkins
Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>

Also change the default max width to 500px (instead of 400px).

Change-Id: Idece5aadaf4c4165cc873b4605d2c0f026c89c6e
Reviewed-on: https://gerrit.libreoffice.org/69545
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

In my macOS build, that clang::tooling::runToolOnCodeWithArgs invocation failed
to find headers like cassert and assert.h, which works now with

  COMPILER_PLUGINS_TOOLING_ARGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -isystem /Users/stephan/Software/llvm/inst/include/c++/v1

added to my autogen.input (I build against my Clang trunk libc++ whose headers
are at /Users/stephan/Software/llvm/inst/include/c++/v1).

Change-Id: Idbffa39c9fd4a88743fd498b8f7b6c9c56d7630d
Reviewed-on: https://gerrit.libreoffice.org/69538
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

on the fontconfig/harfbuzz/cairo drawing path for preset variations

Change-Id: I95ef68aecfd59687ae9aae58e01e394c83c6ea9e
Reviewed-on: https://gerrit.libreoffice.org/69505
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

As seen in include/sfx2/dispatch.hxx IWYU proposes to replace
o3tl/span.hxx with fw declaration, but that won't compile

Change-Id: If5739075bd91511cf22a39f3382c424c21829053
Reviewed-on: https://gerrit.libreoffice.org/69397
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I4f3731e2236f1b8be97a6f5d21e32e678610fecb
Reviewed-on: https://gerrit.libreoffice.org/69532Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

since...

commit 57ca02a7
Date:   Wed Apr 18 00:04:09 2018 +0200

    NB Impress tabbed toolbar big update

Change-Id: I357a65b5f71ff9960f36d2e4ae64117509b41a48
Reviewed-on: https://gerrit.libreoffice.org/69536
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

since...

commit 57ca02a7
Date:   Wed Apr 18 00:04:09 2018 +0200

    NB Impress tabbed toolbar big update

    Reviewed-on: https://gerrit.libreoffice.org/53072

Change-Id: I45f099d2521db576089e8d555f7ccc8fef6d49bc
Reviewed-on: https://gerrit.libreoffice.org/69535
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

since...

commit 57ca02a7
Date:   Wed Apr 18 00:04:09 2018 +0200

    NB Impress tabbed toolbar big update

Change-Id: I7c59d5388138166851c24d1494dc3293a32f8330
Reviewed-on: https://gerrit.libreoffice.org/69537
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4883d3f79250edeafb78fa58f993955b5839f041
Reviewed-on: https://gerrit.libreoffice.org/69531
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This partially reverts:

commit 436b829f
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date:   Thu Aug 16 17:35:17 2018 +0200

    sw: save one vcl layout call in SwFntObj::DrawText()

    Pressing a key in Writer used to lay out the relevant string 4 times
    (counting GenericSalLayout::LayoutText() invocations), save one of them
    by pre-calculating the layout and sharing it between GetTextArray() and
    DrawTextArray().

The reverted part was causing inserted Kashida to be missing, leaving gaps
inside the words. See attachment in the bug report.

Change-Id: Iaafbc793ed5906e6fdf3dcb03c54d5a440e15da4
Reviewed-on: https://gerrit.libreoffice.org/69530
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

The text frame is swapped in this case, so handle BTLR similar to the
normal vert (TBRL) case and the background will be positioned correctly
behind the text portion.

Change-Id: I2399131ef74ea8849577a467ad9bb02d980d8609
Reviewed-on: https://gerrit.libreoffice.org/69539
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8f6a170e4bbb5d0a0bf06d26560189e4ca7ecfb0

Change-Id: I2b574cc7ddaf55e770bc5b746e615834f413b6b4
Reviewed-on: https://gerrit.libreoffice.org/69540Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>