... when either the start or the end position of the new hint is equal
to an existing hint.  There is not just 1 case here but 3 different
ones; don't attempt to insert hints with start > end.

Change-Id: I39cf8a352f67d77b56b0d01de5872f4d341f6bdd

Change-Id: I875bdf1eb6df37b07dd19c6a7ff5ba5eb3b8a096

Change-Id: I453084b3b034a04305058da404b334c7016559ce

And unindent to make it look more like C++ than Java.

Change-Id: I67562cf17c32c40c321b492e9b05c2321a51e126

Change-Id: Ieb34db019c03e7f20f06d3a690b3717b41645e90

Change-Id: Iaf5a3bf28879f229a223a8760fd878f96958a53c

The timer could run after the ToolBarManager is deleted because the
dispose() method can accidentally restart the timer somehow.

Change-Id: I86868f08f436976761e814d4cea1cd5a0e348935

This is similar to fdo#72695, just with SfxBroadcaster in Calc.
Solve it in a similar way, by putting a WeakReference to "this" into the
UNO object so its Notify() can return if another thread is already in
the dtor waiting for the SolarMutex.

==11581==ERROR: AddressSanitizer: heap-use-after-free on address 0x6170006fdb08 at pc 0x2b2c4f5b8e3e bp 0x2b2c0b2ad9f0 sp 0x2b2c0b2ad9e8
READ of size 8 at 0x6170006fdb08 thread T262 (cppu_threadpool)
    #0 0x2b2c4f5b8e3d in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1448
    #1 0x2b2c4f643914 in ScCellRangeObj::~ScCellRangeObj() /sc/source/ui/unoobj/cellsuno.cxx:4751
    #2 0x2b2c4f697624 in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053
    #3 0x2b2c4f69648d in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6052
    #4 0x2b2c4f69661f in non-virtual thunk to ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053
    #5 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204
    #6 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752
    #7 0x2b2c4f64de58 in ScCellRangeObj::release() /sc/source/ui/unoobj/cellsuno.cxx:4800
    #8 0x2b2c4f6a2c08 in ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6093
    #9 0x2b2c4f6a5f0f in non-virtual thunk to ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6094
    #10 0x2b2c053b96fb in bridges::cpp_uno::shared::freeUnoInterfaceProxy(_uno_ExtEnvironment*, void*) /bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:43
    #11 0x2b2b2bae80fb in (anonymous namespace)::s_stub_defenv_revokeInterface(__va_list_tag (*) [1]) /cppu/source/uno/lbenv.cxx:383

0x6170006fdb08 is located 264 bytes inside of 728-byte region [0x6170006fda00,0x6170006fdcd8)
freed by thread T264 (cppu_threadpool) here:
    #3 0x2b2c49c980f5 in cppu::OWeakObject::operator delete(void*) /include/cppuhelper/weak.hxx:87
    #4 0x2b2c4f5b840a in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1442
    #5 0x2b2c4f5b858f in non-virtual thunk to ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1458
    #6 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204
    #7 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752
    #8 0x2b2c4f5c65ff in non-virtual thunk to ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1753
    #9 0x2b2c4af84583 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() /include/com/sun/star/uno/Reference.hxx:104
    #10 0x2b2c4f5bc66f in ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1570
    #11 0x2b2c4f5bdf0d in non-virtual thunk to ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1645
    #12 0x2b2b31dda705 in SfxBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/SfxBroadcaster.cxx:41
    #13 0x2b2c4b03f2e4 in ScDocument::InsertTab(short, rtl::OUString const&, bool, bool) /sc/source/core/data/document.cxx:510
    #14 0x2b2c4e7ed861 in ScDocFunc::InsertTable(short, rtl::OUString const&, bool, bool) /sc/source/ui/docshell/docfunc.cxx:3007
    #15 0x2b2c50b1f415 in ScViewFunc::InsertTable(rtl::OUString const&, short, bool) /sc/source/ui/view/viewfun2.cxx:1855
    #16 0x2b2c502e075f in ScDBFunc::ShowDataPilotSourceData(ScDPObject&, com::sun::star::uno::Sequence<com::sun::star::sheet::DataPilotFieldFilter> const&) /sc/source/ui/view/dbfunc3.cxx:2056
    #17 0x2b2c4fa8924d in ScDataPilotTableObj::insertDrillDownSheet(com::sun::star::table::CellAddress const&) /sc/source/ui/unoobj/dapiuno.cxx:1286

Change-Id: I4cd0fca46b9b81311bddfab2229ab9abf4c06c4e

... by disallowing usage of gb_Helper_register_* without _for_install
for layers that imply installation.

Change-Id: I5734b2d6fbc57196633a562dd5df0236cc290ca6

Change-Id: Iae0c3fc429c74713662f1a75ef0a2150700274c7

Change-Id: I494349840e5b95a7c9f477a4b3133d1a2318ab7e

Change-Id: Ide3361fd5eba6462095cc45c0c99b1ab27a16262

Change-Id: I3e541053faf956dc0cd2a3f068cd93b73fcaab6d

Change-Id: I0e0c3b5e3f130093f430f47c1730580105718c1e

Change-Id: I7d8e2606f0518d489473a9824cb25b6bcd6a9bb2

Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Instead, generate it once and then pass around that list. Again, this
helps ODF export.

For a test document of 2000 mail merge records and 16 frames, the times
for css::text::MailMerge::execute() are 7m53.575s -> 7m30.261s.

Change-Id: Iec993ec34392350b1e26857f7d5434a0a9c494a3

RowInfo.pCellInfo is already initialized by ctor.
Found while investigating coverity#707985 Uninitialized scalar field

Change-Id: Ibb41032674ce5f07ed855a62d76648526d09a1ad

This method is called by the ODF export for each paragraph, so limiting
the result for TextBoxes anchored to a single paragraph helps to avoid
iterating over all the frames for each paragraph.

For a test document of 2000 mail merge records and 16 frames, the times for
css::text::MailMerge::execute() are 8m18.811s -> 7m53.575s.

Change-Id: I7a9cd7b23a3e903059ec0ae3a6a8f8309681bb2e

comment it's unnecessary

Change-Id: Iebf2d1dbed1f9c1e2e09144f47e73d9628355f2e

Change-Id: Ic341502383de8a5b0843d2c4c15e7388818a6027

Change-Id: I84cd8b6542d2b52df620d56eb6492139a1d60c10

assert if fouled

Change-Id: Id3a160ff08907cc7792e93eea9f91997bcc0e2c3

assert if fouled

Change-Id: I1bc38690c755b8bc6eab16c8aa33c8f568e0c854

We always have a DB collection.

Change-Id: I8933be3a01b4c2e63b852361d5d2438e6fca4d05

...so (highbit(ave) - 1) will never be negative and never cause undefined shift by negative
value.

Change-Id: I86703f03d30d48c74d2e814c182b9edb85d18186

Change-Id: I23e03e45ba4f6d259128bc5e4c2fd5952be05c2f

...so arena->m_hash_shfit will never be negative and never cause undefined shift by negative
value.

Change-Id: Ifc3d28d53bae38bc8deea72473c81f1d043dc18e

this is the image map window, I see that indeed toggling a shape
active/inactive in the image mapwindow makes it change layer
to the front for no good reason

Change-Id: If6556e8f21dee2b0f7c750d460490d4e03fc0c02

Enable Math to use 16 basic HTML colors
Patch by: Regina Henschel <rb.henschel@t-online.de>
Found by: <lapsap7+ooo@gmail.com
(cherry picked from commit 529e59d9)

Conflicts:
	starmath/inc/parse.hxx
	starmath/source/mathmlimport.cxx
	starmath/source/parse.cxx

Change-Id: I08de0ce33928ead3635a3a87c81671b4cc4112ac

Change-Id: I38517bb7fbf4ab1e9314a28973b707223d7120e7

Change-Id: Ia914c4842e69b3ea57692f1f8ac52c321240b7c4

and

coverity#1158394 Uncaught exception

Change-Id: I73430678c658202475e0073c3c9bde0a072c1ee9

Change-Id: Ic9aab232667a9b0a3a995d7b033b7ba508fd42dc

and

coverity#707301 Uncaught exception

Change-Id: I6b7b2a9910b8a7d563a08ce84ddf16f550d8818e

and

coverity#707419 Uncaught exception
coverity#707420 Uncaught exception

Change-Id: I98d752c14be5f7b1fccb4bdf2eeefb6bbfe12e0e

Change-Id: I91bf3bce86d6b7fb01a26a6785d5bcfd7677878c

...which must be true for pDestTypeDescr == pSourceTypeDescr.

Change-Id: I98b4d654eb0e705ff0b577e7c87971b418ed13fc

Makes __LINE__ numbers you have inserted in temporary printf() calls in the
(generated) OpenCL code more useful.

Change-Id: I6da5a6937b924c1378f7f0c25ab7e156b23e1b61

Change-Id: Ifa9e77b955cea26da6602d409a1c111f45f72587