- 11 Eki, 2018 5 kayıt (commit)
-
-
Aron Budea yazdı
Try to find >= 4.6 .NET SDK first. +allow .NET SDK 4.7.2. Change-Id: I64084e894ee829ecff091fe16a45f309a51eb4d5 Reviewed-on: https://gerrit.libreoffice.org/57550 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 9b8c8c70) Reviewed-on: https://gerrit.libreoffice.org/59205Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Justin Luth yazdı
Change-Id: I20664f8c2dc2c49feec17ee6a1df72776d43cc40 Reviewed-on: https://gerrit.libreoffice.org/61635 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit 9943f37e)
-
Justin Luth yazdı
A bookmark cross-reference was trying to access the textform field by name, but an autogenerated __Fieldmark__ name obviously wasn't matching. Change-Id: I1018fecf44fda5d947b214c599f1a405f311e2ee Reviewed-on: https://gerrit.libreoffice.org/61565Reviewed-by:
Justin Luth <justin_luth@sil.org> Tested-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit 4af4a473)
-
Justin Luth yazdı
The area of a GroupBox indicates which radio buttons are considered to be part of the same group. The button needs to be fully inside of the groupbox in order to participate. This patch resolves the last worry of commit 9f969799 Reviewed-on: https://gerrit.libreoffice.org/61131 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 048b8e45) Change-Id: Ie6057337c63bf9eb173a0615e30c8d4e4d0c7a19
-
Justin Luth yazdı
This patch only affects calc. (Perhaps .xls* is the only format that supports non-activeX radio buttons?) Commit 9f969799 worried about form and activeX buttons sharing the autoGroup_. This patch prevents that. Change-Id: Ia57a14f1cdd6363aa5d6d991469668fcc56016ca Reviewed-on: https://gerrit.libreoffice.org/61095 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit a7756236)
-
- 08 Eki, 2018 1 kayıt (commit)
-
-
Justin Luth yazdı
Reviewed-on: https://gerrit.libreoffice.org/61388 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit 2cae2ecf) Change-Id: I72c79c1fed4d9a91bf02024eef23cd3b1a58632e
-
- 03 Eki, 2018 1 kayıt (commit)
-
-
Miklos Vajna yazdı
This is a combination of 3 commits. 1st commit: Longer term the core Impress shape has to be improved so that it can have text in multiple columns. Shorter term, map text with multiple columns to table shapes, that gives correct layout in many cases and requires changes to the import filter only. (cherry picked from commit aef569ed) Commit #2: Related: tdf#120028 PPTX import: fix font size of multi-col shape text Normal shapes have a TextFitToSize property for this, but table cell content has to be scaled manually, as the rendering has no automatic support for them. Luckily the file format has the info we need to scale at import time. (cherry picked from commit c8b2849d) Commit #3: Related: tdf#120028 PPTX import: fix font color of multi-col shape text Not just font color, anything defined via list styles were not imported. (cherry picked from commit 800bf107) Conflicts: oox/inc/drawingml/textbodyproperties.hxx Reviewed-on: https://gerrit.libreoffice.org/61244 Tested-by: Jenkins Reviewed-by:
Andras Timar <andras.timar@collabora.com> (cherry picked from commit 6f1fb474) Change-Id: Id7942b16882ab1f083ded2f0e577e8c9e128697c
-
- 30 Eyl, 2018 1 kayıt (commit)
-
-
Andras Timar yazdı
Change-Id: Ibe331066cb584d45391bdaad971e51ed958463c9
-
- 28 Eyl, 2018 4 kayıt (commit)
-
-
Tamas Bunth yazdı
For MYSQL connections there is an extra window which determines how to connect to a mysql/mariadb database. This functionality is handled in OGeneralPageWizard::approveDatasourceType. Change-Id: Ia3c548103b694731cba47ff5390c34b072a938a0 Reviewed-on: https://gerrit.libreoffice.org/60893Reviewed-by:
Tamás Bunth <btomi96@gmail.com> Tested-by:
Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 37dba4f2)
-
Caolán McNamara yazdı
Change-Id: I8ef476e06f54ddd57be907488a8a65314abda3ee Reviewed-on: https://gerrit.libreoffice.org/60828 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit c5d9823a)
-
Justin Luth yazdı
affects doc, docx, xls, xlsx (at least). Handling optionbutton groups is new since 2017, so incremental enhancements are OK. In LO, if an option button with an empty groupName (like any form control which has no groupName option), then it stands alone, which is a ridiculous position to be in for a radio button. So, lets put them all together into an automatic group. In MSO, buttons without any explicit group stick together, so the effective group is the entire document, or entire sheet. One complication is that ActiveX radio buttons don't interact with Form radio buttons, even if all of them have no group name. That situation is not handled by this patch (and not very likely to happen since ActiveX defaults the group name to the sheet name). (A Group Box can also be used, which automatically groups all buttons fully within its area. That will be much harder to implement since every object will need to first be categorized as groupbox or optionControl - meaning that everything must first be imported. That implies a function call from every application doing the import.) Change-Id: I204adaea75ce99999a16c0cc4e9c3b8b08da9433 Reviewed-on: https://gerrit.libreoffice.org/61064 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 9f969799) Reviewed-on: https://gerrit.libreoffice.org/61072Tested-by:
Michael Meeks <michael.meeks@collabora.com>
-
Aron Budea yazdı
This reverts commit 3d92276f.
-
- 21 Eyl, 2018 5 kayıt (commit)
-
-
Samuel Mehrbrodt yazdı
Change-Id: Iaf9c8e2ed72115e1f82d2541ae2a1d4803795a46 Reviewed-on: https://gerrit.libreoffice.org/60752 Tested-by: Jenkins Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 088af440) Reviewed-on: https://gerrit.libreoffice.org/60768Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 005be0cd)
-
Caolán McNamara yazdı
Change-Id: Ifbe81b851b17858a915105c102af6f4d8f2c81fa Reviewed-on: https://gerrit.libreoffice.org/60800Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4a63deae)
-
Christian Lohmaier yazdı
Change-Id: I1a8c8bc20ee7e97b47f0602dcfaa3cb1b771de8f (cherry picked from commit bb26bd61) (cherry picked from commit 606c2208)
-
Xisco Fauli yazdı
Change-Id: Ie29c2213d8efccd7750396325ce05b4909c09d02 Reviewed-on: https://gerrit.libreoffice.org/60592Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 79093cce) Reviewed-on: https://gerrit.libreoffice.org/60678Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 0ed572e4)
-
Miklos Vajna yazdı
The interesting part of the layout of page 2 is: - frame #40 is a section frame with a text frame which is in a list ("A") - frame #48 is a section frame after that, with the same top=19213 Given that frame #40 has height > 0, they overlap when the page is rendered. What happens is: - frame #40 grows - there are other section frames between #40 and #48 in-between, but they don't have an SwSection - these frames are skipped - then the position of #48 is invalidated So the next time we calculate the position of #48, we look the last skipped (previous) section frame (which still has top=19213, since its position was not invalidated above), and since its height is 0, we conclude that our current top=19213 is valid after all. This is like this since commit 84a3db80 (initial import, 2000-09-18), so leave the code there that invalidates not only the next frame, but all the way down to the first non-SwSection-less-SwSectionFrame. But instead of just invalidating the last frame, invalidate the in-between SwSection-less-SwSectionFrames as well. In practice this did not cause a problem in case the document has no layout cache. If it does, then the frames are created on pages hinted by the cache, then later moved to their final place. In practice this bug was visible only in this later case. (I.e. such a layout cache can be only created if the machine that saved the document last time does not have the fonts needed by the document installed; and then the document is opened on an other machine which has those fonts.) (cherry picked from commit b5937112) Conflicts: sw/qa/extras/layout/layout.cxx Reviewed-on: https://gerrit.libreoffice.org/60658 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit e850b5a1) Change-Id: I02ae9f63d0b4b5e9d014df53ed2cf21a04b15090
-
- 17 Eyl, 2018 4 kayıt (commit)
-
-
László Németh yazdı
of cells of blank rows. This workaround is probably a fix for problems of most users, but for a full solution it needs to extend the workaround for all rows with not default settings, also avoiding of the possible performance problems. Note: the number 1000 of the extra rows came from a similar workaround used in XLSX export of Google Spreadsheets, but instead of listing extra empty 1000 rows in OOXML, this fix writes only the cells with not default settings from the extra 1000 blank rows. Reviewed-on: https://gerrit.libreoffice.org/58575 Tested-by: Jenkins Reviewed-by:
László Németh <nemeth@numbertext.org> (cherry picked from commit 99b9ea63) Reviewed-on: https://gerrit.libreoffice.org/58812Reviewed-by:
Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit d7cbaac6) Change-Id: Icac9441b7eb1520dcd20fc04337e070d070591c7
-
Michael Meeks yazdı
Change-Id: Idee779cea587e11f6d0f7902182c9394e73d46eb Reviewed-on: https://gerrit.libreoffice.org/60488 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/60544Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Michael Meeks yazdı
Change-Id: Ie0fb21776514a9a67e9fdff2ae856392cd711adb Reviewed-on: https://gerrit.libreoffice.org/60542Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Michael Meeks yazdı
Change-Id: I22d2d545a6201cbb89d430c65f66e0fea8794d83 Reviewed-on: https://gerrit.libreoffice.org/60543Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
- 14 Eyl, 2018 6 kayıt (commit)
-
-
Andras Timar yazdı
Change-Id: If2673b0bdd1489e8bd0bc60b8372756da8cf1533
-
Muhammet Kara yazdı
This is just a band-aid to make personas feature work again. Change-Id: I80b54fe9a8ddc93d93744fcf2c7f739d81f6face Reviewed-on: https://gerrit.libreoffice.org/60432 Tested-by: Jenkins Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com> Tested-by:
Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by:
Muhammet Kara <muhammet.kara@pardus.org.tr> (cherry picked from commit e98ac43e) Reviewed-on: https://gerrit.libreoffice.org/60468Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 2f52a8e0) Reviewed-on: https://gerrit.libreoffice.org/60481 (cherry picked from commit 6a113caf)
-
Tamas Bunth yazdı
Change-Id: Ia0d0290517fdebd9a7700d52fa0e86de0e958b2d Reviewed-on: https://gerrit.libreoffice.org/60406 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/60462Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Tamas Bunth yazdı
Change-Id: I81307c6e45220081c39ddd7d1672457202bbc517 Reviewed-on: https://gerrit.libreoffice.org/60404 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/60461Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Tamas Bunth yazdı
it should throw an exception. Change-Id: I55fd8ed5d92a28096b9bde6b0161e16d7543203b Reviewed-on: https://gerrit.libreoffice.org/60460Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Jan Holesovsky yazdı
Steps to reproduce: * turn on changetracking * write few characters * insert table * move the cursor behind the table and type * crash Change-Id: Icd7b64d2fe594c2b87c9d3d7fa48a957755cbc3b Reviewed-on: https://gerrit.libreoffice.org/60390Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com> (cherry picked from commit 43197a30) Reviewed-on: https://gerrit.libreoffice.org/60402
-
- 13 Eyl, 2018 2 kayıt (commit)
-
-
Justin Luth yazdı
This commit reverts the first (LO 4.3ish) regression commit 60635557 and most of the two commits that tried to fix that: commit 9ae1e094 and commit ee45d881 in LO6.0/6.2. The ooxmlexport6 unit test shows that there is nothing special about 180degrees. So, all transformations need to be avoided in docx format - not just 180 degree ones. I removed IsInGroupShape() since it is no longer being used - as per standard procedures. Reviewed-on: https://gerrit.libreoffice.org/58434 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit ab296726) Change-Id: Id2bba5bc542875a10ac21fbb67f29b2d59705493
-
Justin Luth yazdı
Introduced in LO 4.0 in a mass copy of compat settings in commit 355d25ea Reviewed-on: https://gerrit.libreoffice.org/57991 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 49ddaad2) Change-Id: I0d95941ff2815a43e571be1a6a0dbab1d12185d6
-
- 12 Eyl, 2018 11 kayıt (commit)
-
-
Ashod Nakashian yazdı
Change-Id: Idde3cd22ecc1f1bd34f7519acedc85584ed2deaf Reviewed-on: https://gerrit.libreoffice.org/58160Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
Jan Holesovsky <kendy@collabora.com>
-
Ashod Nakashian yazdı
When loading document, LOK needs to setup the client view, register callbacks, get document size and type, etc. All of these need to take SolarMutex, which is taken by the idle jobs immediately after loading, blocking LOK from finishing initialization and rendering the first tiles for the user. This gives the user the impression that the document is loading for far longer than it actually is, due to lack of interactivity (or indeed any activity on the screen besides the spinning wheel). By delaying the idle jobs, we allow time for LOK to finish initialization and render the first tiles before the idle jobs kick in and hog SolarMutex. Reviewed-on: https://gerrit.libreoffice.org/56572Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 1056640a) Change-Id: Ic6f437bfd6f43dfed2aaa1a9d3510d43f5ec30ae Reviewed-on: https://gerrit.libreoffice.org/58157Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
Jan Holesovsky <kendy@collabora.com>
-
Ashod Nakashian yazdı
Reviewed-on: https://gerrit.libreoffice.org/57160Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
Jan Holesovsky <kendy@collabora.com> (cherry picked from commit bbba0902) Change-Id: I66840512b45e987cc7b08b07b65bdb24f2023a41
-
Aron Budea yazdı
spell-checker is initialized during font init since e7f65920 Change-Id: Ia5b5223aa8cc00d0e80451142ae18a7046ad00d4 Reviewed-on: https://gerrit.libreoffice.org/57064Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
Reviewed-on: https://gerrit.libreoffice.org/56573Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
Jan Holesovsky <kendy@collabora.com> (cherry picked from commit e7f65920) Change-Id: I5a3acc41196c7e0672514fa2dae00e5fc0f76a1f
-
Justin Luth yazdı
better fix than cecf71c1 since: 17.4.25 insideV (Table Cell Inside Vertical Edges Border) This element specifies the border which shall be displayed on all interior vertical edges of the current group of table cells. [Note: Although individual table cells have no concept of an internal edge, which would render this property useless in most cases, it is used to determine the cell borders to apply to a specific group of cells as part of table conditional formatting in a table style, for example, the inside vertical edges on the set of cells in the header row. end note] So, I interpret this as insideV/H having meaning only within table styles, and not when directly applied to a cell. The only documents I've seen with insideV/H directly applied to a cell seem to have been created by LO - which dumps them everywhere, redundantly. Tablestyle cell groupings are handled elsewhere via grabbag dumps, so insideV/H borders can be eliminated from TableCellProperties. Change-Id: I128417f0a0b485c85ede463daacb8feabc457302 Reviewed-on: https://gerrit.libreoffice.org/60187 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d934fe80)
-
Justin Luth yazdı
Previously, if an earlier column wished for the entire table width, then none of the other columns could adjust their size, even if they only wanted one more character. This slight change gives every column a chance to "wish" for an equal portion, and still gives the earlier columns a chance to maximize. So, this should implement very similarly to before, thus workflow should not be impacted. Change-Id: I11e8b94ce333735aa92b5388af6319f8eb0ccc51 Reviewed-on: https://gerrit.libreoffice.org/60027 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit 62159ea8)
-
Justin Luth yazdı
Since the internal SW defaults (0) don't match the import defaults, always write the top/bottom, left/right margins into the document definition. It is very rare indeed to have a zero margin anyway, since the page margin being zero is highly discouraged because of printing. The bug report is for DOCX, but it also affects DOC. I don't have an example where LRSpace is skipped, but it only makes sense to treat these two the same just in case. Change-Id: Ie9a08ad0dd4f73bc976756fe244fc33e2dc804f3 Reviewed-on: https://gerrit.libreoffice.org/59967 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit efd316b6)
-
Justin Luth yazdı
Well, not on the bottom or right outside cells. Obviously the presence of a bottom or a right in those cases doesn't indicate an inside line. Reviewed-on: https://gerrit.libreoffice.org/59600 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit cecf71c1) Change-Id: I5d0661fd60f478a392b12fe9093c2e47e130631b
-
Justin Luth yazdı
The absence of "on=" is treated in Word (tested 2003) as off. Change-Id: Ibc6b0e5ca0f25a9c3ca1b9505fa24c4d821bfd0 Reviewed-on: https://gerrit.libreoffice.org/59457 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit b914c4c9)
-
Justin Luth yazdı
I didn't see this mentioned in the sprm documentation, but that is how MS Word seems to implement it. Change-Id: I5b86ecf99a884e768877cdb0e71f43cdb9f2ad76 Reviewed-on: https://gerrit.libreoffice.org/59221Reviewed-by:
Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 21275817)
-