* Update helpcontent2 from branch 'master'
  - More CSS tweaks…
    
    • Ever-so-slightly brightened link color
    • Made most tables centered; I think they look much better
    • Removed some pointless spacing
    • Made all dropdown options consistently align to the left
    • Finally found out why pagination had extra 40px to its left
      and it’s a shame the normalizer doesn’t account for it
    • Correctly made disabled pagination links unsensitive
    • Gave styling to the search bar for consistent appearance
      in Gecko- and Blink-based browsers
    
    Change-Id: Idcb488160aa97ec0c4adb5202aed7f194dfac7c9
    

warn:sw.core:31398:31398:sw/source/core/bastyp/index.cxx:322: SwIndex::operator--() wraps around

Change-Id: I5c37a6b5e1fe24bc3b6b84e762bad6577583f3d8
Reviewed-on: https://gerrit.libreoffice.org/68127
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Ia41f1a03581a0a48d59706ac5b3c569fc39c7f4d
Reviewed-on: https://gerrit.libreoffice.org/68099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-6.2.0.3/instdir/program/types.rdb \
 >.../master/udkapi/type_reference/udkapi.idl

* no changes

LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-6.2.0.3/instdir/program/types.rdb \
 .../libreoffice-6.2.0.3/instdir/program/types/offapi.rdb \
 >.../master/offapi/type_reference/offapi.idl

Change-Id: I16c8cc9edafa81570f43197a1f1e78ff1eaee1ee
Reviewed-on: https://gerrit.libreoffice.org/68141
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

* Update helpcontent2 from branch 'master'
  - Copying/Pasting sample code results in compiler error.
    Embed tags in place of link within relatedtopics
    
    Change-Id: I05d899e77a51c15d69e066bc94bd5bbb9ed69c8f
    Reviewed-on: https://gerrit.libreoffice.org/68142
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Id3858365a54e6ae96bf9e6c3e27a777441ab56ae
Reviewed-on: https://gerrit.libreoffice.org/68133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3a060d94de7c3d77a54e7f7f87bef88458ab5161
Reviewed-on: https://gerrit.libreoffice.org/68132
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I5e810ed15cc33900d106b64353584d21f081517f
Reviewed-on: https://gerrit.libreoffice.org/67992
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Id2782a16d6118676b0638727b368e4628335e055
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/68128
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Revert "tdf#122424 RTF import: ignore table row text outside the cells"

This reverts commit dc8fa612.

Change-Id: Id68dc7ae55df013de64fb2d4955a412e4c046781
Reviewed-on: https://gerrit.libreoffice.org/68086Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Change-Id: I853a4471723c39bbdb8cf71409f518640b54cb83
Reviewed-on: https://gerrit.libreoffice.org/68110
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I031f7ce7e63c9bf7ebda55c2742004f642ba8e5a
Reviewed-on: https://gerrit.libreoffice.org/68129
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I9e36cb78e3e945f6531a31e0ddf73d9c8d655f7d

* Some .m/.mm files that still contained tabs instead of spaces have been
  cleaned up with Emacs' untabify (and
  apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions):

  apple_remote/source/GlobalKeyboardDevice.m
  apple_remote/source/HIDRemoteControlDevice.m
  apple_remote/source/KeyspanFrontRowControl.m
  apple_remote/source/RemoteControl.m
  vcl/osx/a11yrolehelper.mm

* Some of the changes predate 0626e66d "Avoid
  loplugin:indentation after preproc conditional inclusion lines" and would
  likely have no longer been flagged since.

Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f
Reviewed-on: https://gerrit.libreoffice.org/68090
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I0af7233d13223c4d1114d4f92a24e381ef81b5d5
Reviewed-on: https://gerrit.libreoffice.org/68126
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: If477845972ce4c8e7bf09ea8718c58851a5b9740
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/68102
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ibd7c52137674eb07c35c951260a8102d06a436cc
Reviewed-on: https://gerrit.libreoffice.org/68130
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: Ie22398eb42f61e50177f88672a1407d9dda58f8a
Reviewed-on: https://gerrit.libreoffice.org/68106Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iaef35328c0657a4538d4b4a44734146baee0346b
Reviewed-on: https://gerrit.libreoffice.org/61153
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iad1786962dedb6cae0cf8720022498bfd793feb1
Reviewed-on: https://gerrit.libreoffice.org/68105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(not an image used as the indicator, which is already covered,
but if an image follows the indicator

Change-Id: I9e3f9c466d997f91f54912660f8c54eea6deb721
Reviewed-on: https://gerrit.libreoffice.org/68097Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If383e2f1542ffb57415f8138077013dbafa0fc69
Reviewed-on: https://gerrit.libreoffice.org/68095
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5d229a0afb822c9e7b81d3d8f27962c52d27d815
Reviewed-on: https://gerrit.libreoffice.org/68094
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4b86636cc4e4884459d59d1df9949505274bde9e
Reviewed-on: https://gerrit.libreoffice.org/68069
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The topmost shape may not have 0 depth, but something larger.

In that case at least it's safe to still use fill & line properties. The
B1 quadrant of the test file now has the proper orange background, and
B2's border is also properly orange.

Change-Id: Iccc5f6993693a0f1cf8f50d163003c24d3ad690e
Reviewed-on: https://gerrit.libreoffice.org/68104Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Apple can't afford the costly GPG licenses to sign releases apparently,
but the sha256 matches some OpenWRT and FreshPorts repos...

Fixes CVE-2015-7988.

Removing windows build patches, fixed upstream (except for the last hunk
of the SOCKET patch, but that is in code that is only used on MacOSX).

Change-Id: I9fdba5929badb75f995c66da0850d188780e7beb
Reviewed-on: https://gerrit.libreoffice.org/68092
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Eike says that no LO code should use ICU number parser/formatter, but
meanwhile ICU is also used in the externals firebird, harfbuzz,
hunspell, libcdr, libebook, libfreehand, libmspub, libqxp, libivsio,
libxml2, libzmf, pdfium, xmlsec, so let's just patch it to be sure.

Change-Id: I3e1a76d7ceefadbe3c514ad7f1384a4daa196f36
Reviewed-on: https://gerrit.libreoffice.org/68098Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Fixes CVE-2017-15232, which looks rather minor.

Change-Id: Icffb0c5160bef79577431a02eb10ed9492e01d11
Reviewed-on: https://gerrit.libreoffice.org/68091
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

* Update helpcontent2 from branch 'master'
  - Fix call of main Help page from app Help menu
    
    The Application Help menu sends /<module>/.uno:HelpIndex in the Help
    URL.
    
    This translates to '.uno:HelpIndex' and module name is lost, opening the
    New Help default page instead of the module Help entry page.
    
    The patch picks the right module Help entry page in this particular
    case.
    
    Change-Id: Ifbb5ba4f817b195210fbb19bcb5c2011d2cb416d
    Reviewed-on: https://gerrit.libreoffice.org/68093
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Spelling offence made to BeanShell requires correction
    
    + link cleanup
    
    Change-Id: If186f97bfd4ae8c4ccc2220ea8af9f1a6d1d8a2d
    Reviewed-on: https://gerrit.libreoffice.org/68064
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

...found with (trunk) libc++ on macOS, where the standard library iterator
implementations are apparently sufficiently different to libstdc++ to find more
cases of !(... == ...) vs. ... != ...

Change-Id: Ia3861406aa584c7b1d33f47448190b5cf2e770f7
Reviewed-on: https://gerrit.libreoffice.org/68089
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This fixes some minor CVEs.

Not including the fix for CVE-2018-18064, which does not affect LO
because we use the default implementation of FT_Memory which uses
free/malloc.

Change-Id: Ic047ed52cff3fdeba068f1b8d303c6c96c69addd
Reviewed-on: https://gerrit.libreoffice.org/68088
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Fixes CVE-2018-6942.

Remove freetype-msvc-disable-sse2.patch.1 (doesn't apply and freetype is
only used on Android).

Change-Id: Ia89329f758a077c1493cdea45f99e5f58d1ef265
Reviewed-on: https://gerrit.libreoffice.org/68087Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Take over missing case from 'KDE5FilePicker::initialize' to
'Qt5FilePicker::initialize' and make
'Qt5FilePicker::addCustomControl' virtual, so that the
subclass's implementation is called in the 'initialize()'
method (in particular to avoid adding another autoextension
checkbox).

Drop the 'KDE5FilePicker::initialize' so that the
base class implementation is used, which now does the
same thing.

Add 'override' keyword in KDE5Filepicker.hxx.

Change-Id: Id151a4d4862af4275f6c21c6537a79c52e3ed513
Reviewed-on: https://gerrit.libreoffice.org/68059
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

* Update helpcontent2 from branch 'master'
  - each CUI_HID_HANGULDLG_SUGGESTIONS child has an help id already
    
    Change-Id: I5b565843c2ae6a53974588abdeac795b5b5f0890
    

Add an option to Qt5FilePicker constructor to
say whether the QFileDialog should be a native one or not,
since 'QFileDialog::selectFile' does not preselect the correct
name in the native dialog any more if the
'QFileDialog::DontUseNativeDialog' option has ever been set, i.e.

    QFileDialog fileDialog;
    fileDialog.setOption(QFileDialog::DontUseNativeDialog);
    fileDialog.setOption(QFileDialog::DontUseNativeDialog, false);
    fileDialog.selectFile("test.txt");

will not properly set the name in the native file dialog, which
broke 'setDefaultName' for the KDE5FilePicker.

This makes it work again, even though I think that the underlying
issue is a Qt bug
(s. https://bugreports.qt.io/browse/QTBUG-73682 ).

Change-Id: I99a1e7c97d594925d600fa8eaf3303f9013551c2
Reviewed-on: https://gerrit.libreoffice.org/68058
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Use the custom controls widgets from the parent class
Qt5FileWidget and drop the own class members that were
used for this.

Also call the base class's implementations for the methods
that interact with the custom controls.
Since the native Plasma/kde5 file picker handles automatic
file extensions by itself while the non-native qt5 one does
not, the methods in KDE5FilePicker only forward those
method calls that are not related to the corresponding
control ('CHECKBOX_AUTOEXTENSION').

Change-Id: Ia2de3211ffba7814683914a5e629208b19b2ed82
Reviewed-on: https://gerrit.libreoffice.org/68057
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Take over functionality from 'KDE5FilePicker::addCustomControl'
that has not been implemented in qt5 one yet.

Change-Id: I9690e163b3b739bfec6813d9a4e1e0170b730187
Reviewed-on: https://gerrit.libreoffice.org/68056
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Directly access member 'm_pExtraControls' from parent class
Qt5FilePicker for managing custom widgets, rather than maintaining
an own one.

This is meant as an intermediate step, further refactoring will
follow.

Change-Id: I0568d3db68dc24042e198d36f4b5e49608f93a0e
Reviewed-on: https://gerrit.libreoffice.org/68055
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Turn existing functions in Qt5FilePicker into protected
static class methods and reuse them in KDE5FilePicker.

The qt5 implementation covers everything that kde5 had,
and a little more (e.g. covers case 'ControlActions::DELETE_ITEM'
in 'handleSetListValue' as well).

Change-Id: I9673b20e3313c0628a76f0d94e018327f4af8523
Reviewed-on: https://gerrit.libreoffice.org/68054
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>