- 03 Eki, 2013 16 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I58e01473f1ab3045b203baad643ae0225140511e
-
Caolán McNamara yazdı
Change-Id: I67b703446cd83540ebc24ea373c5b2d7e80fb496
-
Caolán McNamara yazdı
Change-Id: I72b882292f62c4a2b4999fa3e553db3c617e03f4
-
Caolán McNamara yazdı
Change-Id: I77e2f0a9298c20b56bc8f18d2d1e7a80fb94f44f
-
Caolán McNamara yazdı
Change-Id: I6bb013cc32d5b363dd08738543b1fb834d39f516
-
Caolán McNamara yazdı
Change-Id: I12e3037ede0c07c0a2ff8e6f2f620b70ba11b1e0
-
Caolán McNamara yazdı
Change-Id: I8626e60d802b1c966667867d8c59ececff0a4255
-
Caolán McNamara yazdı
Change-Id: I9254b18e0acac6a730ee4150c295018b4d88948f
-
Caolán McNamara yazdı
Change-Id: Ica07e23920d751757ab5d14d5216615d5fcdbfd9
-
Caolán McNamara yazdı
Change-Id: I51c1e553339810f7de61c2c4a506482339829b31
-
Caolán McNamara yazdı
This is catastrophically wrong, just appear to be lucky that this code path is never called, so remove it entirely rather than mess around fixing it Change-Id: I4a8a443ed20b7e11cd9cc69b3d66d28087f09db8
-
Caolán McNamara yazdı
Change-Id: Ia39e8c53427347088aa8d58ae1220950f191cd91
-
Miklos Vajna yazdı
This was introduced in commit 9c7ffb6b ([cbosdo03]Applied the patches to upstream, 2009-12-02), as setting the outline level also set the NumberingStyleName to "Outline" as well, which is not what we want. Since then, commit b95d203b (Don't load the default values of the styles in writerfilter, 2012-08-20) already disabled default styles, so the previous manual clearing is no longer necessary (testcases already fail if this later commit is reverted). As a result, just remove this manual clearing, it's no longer necessary and it is problematic, as it triggers copying the SvxLRSpaceItem from the parent style with no good reason. Change-Id: Ie17547a979a6b0feadbd2eed0f06e84fcb17fca6
-
Nagy Akos yazdı
Project: dictionaries 17eed4af567c101b4306f95c345d50131a353a99 Patch for bug 68699 Change-Id: Id6d76d4fd6000d4ea79297286bfb2f3d1bbd5c51 Reviewed-on: https://gerrit.libreoffice.org/6116Reviewed-by:
Németh László <nemeth@numbertext.org> Tested-by:
Németh László <nemeth@numbertext.org>
-
Miklos Vajna yazdı
Change-Id: I9fb67a1b7ccd4c8fbc17274902a16d8c0b13d598
-
Tor Lillqvist yazdı
Change-Id: I885c2bf3dd04b18850d983ab34199074bd41c175
-
- 02 Eki, 2013 24 kayıt (commit)
-
-
Michael Stahl yazdı
Avoid deadlock by disposing the accesibility context without the Mutex locked, since it will eventually try to acquire the SolarMutex... Thread 1 in UnoControl::getPosSize() calling from sdr::contact::ControlHolder::getPosSize() Thread 2 calling from UnoControl::setDesignMode() trying to get SolarMutex in VCLXWindow::disposing() Change-Id: I7d0ffe4fa0f8cd0c48e9b9b5e923ce229f97ca57
-
Michael Stahl yazdı
It is evidently possible that SelectionManager::run() exits while shutdown() is still trying to write to its end of the pipe, so close the pipe when run() exits to avoid that. (regression from ec5a7256) Change-Id: Ibc2823c61ea5df5b5227676c6e37ae5de44cde6b
-
Michael Stahl yazdı
Check that SolarMutex is locked after return from Yield(), and in LazyDelete::flush(). Change-Id: I12ff312bd946b97b5f2c79169892719910884381
-
Michael Stahl yazdı
De facto this class is locked by SolarMutex, which is what the OExternalLockGuard actually locks; do not lock m_Mutex because it may cause deadlock. Change-Id: I88b226d73dbef9a5803347b0ac3191bec2ba4515
-
Michael Meeks yazdı
Frame #10 in libatk-bridge.so calls atk_misc_threads_enter(), and having a look at the RHEL 6.5 at-spi package in ./at-spi-1.28.1/atk-bridge/bridge.c there is always the same call pattern: bridge_threads_leave (); [one function call] bridge_threads_enter (); ... so the bridge_threads_leave() has called the VCL gtk-plug function GtkHookedYieldMutex::ThreadsLeave() which releases the SolarMutex. This is of course not a good idea while there is a Window being deleted, and is the reason why the same Window is being deleted in thread 1 and thread 2: 31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 Try to avoid the problem by delaying the atk_object_notify_state_change() that will release SolarMutex until idle, when deletion of the Window is finished. Thread 2 (Thread 0xfff4cbcf110 (LWP 17011)): 2 0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6 3 0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114 4 0x00000fff963a7908 in acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:58 5 ClearableGuard (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:177 6 cppu::WeakAggComponentImplHelperBase::dispose (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:392 7 0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114 8 0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326 9 0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612 10 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136 11 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121 12 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123 13 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66 14 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272 15 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255 16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 17 0x00000fff94a61138 in Window::~Window (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4683 18 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 19 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 20 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff70115a80) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263 21 0x00000fff94a60130 in Window::~Window (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334 22 0x00000fff949cc8b4 in DockingAreaWindow::~DockingAreaWindow (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96 23 0x00000fff949cc918 in DockingAreaWindow::~DockingAreaWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96 24 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 25 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 26 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff7001a320) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263 27 0x00000fff94a60130 in Window::~Window (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334 28 0x00000fff94a1f7fc in SystemWindow::~SystemWindow (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/syswin.cxx:89 29 0x00000fff94a6c744 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150 30 0x00000fff94a6c7e8 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150 31 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 32 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 33 0x00000fff88258ec0 in framework::Frame::impl_disposeContainerWindow (this=<value optimized out>, xWindow=...) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:2689 34 0x00000fff8826d71c in framework::Frame::dispose (this=0xfff8c308a08) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1887 35 0x00000fff88263018 in framework::Frame::close (this=0xfff8c308a08, bDeliverOwnerShip=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1650 36 0x00000fff88255908 in framework::Desktop::impl_closeFrames (this=<value optimized out>, bAllowUI=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:1928 37 0x00000fff88256120 in framework::Desktop::terminate (this=0xfff8b3de388) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:292 Thread 1 (Thread 0xfff930e82a0 (LWP 16956)): 2 0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6 3 0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114 4 0x00000fff946cd114 in vcl::SolarMutexObject::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/solarmutex.cxx:35 5 0x00000fff94a6ecb8 in SalYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/generic/app/geninst.cxx:49 6 0x00000fff8c24cb90 in GtkHookedYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:91 7 0x00000fff8c24cd2c in GtkHookedYieldMutex::ThreadsEnter (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:64 8 0x00000fff8b6dfabc in ?? () from /usr/lib64/gtk-2.0/modules/libgail.so 9 0x00000fff8b9f333c in .atk_misc_threads_enter () from /usr/lib64/libatk-1.0.so.0 10 0x00000fff8c1d534c in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so 11 0x00000fff8c1d65fc in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so 12 0x00000fff936af4e0 in ?? () from /lib64/libgobject-2.0.so.0 13 0x00000fff936b13d0 in .g_signal_emit_valist () from /lib64/libgobject-2.0.so.0 14 0x00000fff936b18f8 in .g_signal_emit () from /lib64/libgobject-2.0.so.0 15 0x00000fff8b9e5f3c in .atk_object_notify_state_change () from /usr/lib64/libatk-1.0.so.0 16 0x00000fff8c23083c in AtkListener::disposing (this=0xfff5f98dbc8) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/a11y/atklistener.cxx:81 17 0x00000fff963aee2c in cppu::OInterfaceContainerHelper::disposeAndClear (this=<value optimized out>, rEvt=...) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/interfacecontainer.cxx:316 18 0x00000fff9659d944 in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing (_nClient=<value optimized out>, _rxEventSource=...) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessibleeventnotifier.cxx:162 19 0x00000fff9659b20c in comphelper::OAccessibleContextHelper::disposing (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessiblecontexthelper.cxx:130 20 0x00000fff5f275898 in VCLXAccessibleToolBoxItem::disposing (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolboxitem.cxx:265 21 0x00000fff963a79fc in cppu::WeakAggComponentImplHelperBase::dispose (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:404 22 0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114 23 0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326 24 0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612 25 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136 26 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121 27 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123 28 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66 29 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272 30 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255 31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 32 0x00000fff949d41c4 in DockingWindow::~DockingWindow (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockwin.cxx:473 33 0x00000fff94a35944 in ToolBox::~ToolBox (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/toolbox.cxx:1698 34 0x00000fff88343e40 in framework::ToolBar::~ToolBar (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35 35 0x00000fff88343e88 in framework::ToolBar::~ToolBar (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35 36 0x00000fff94a66a00 in ~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:162 37 vcl::LazyDeletor<Window>::~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:164 38 0x00000fff94998868 in vcl::LazyDelete::flush () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/helper/lazydelete.cxx:54 39 0x00000fff946d2294 in ImplYield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:434 40 Application::Yield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:463 41 0x00000fff946d22f8 in Application::Execute () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:408 Change-Id: Ic742442dd6ffeba59655c2e66df8dbabc906f061
-
Matúš Kukan yazdı
Change-Id: Id305df9d963276c13b0920bdfa24287c8792d25a
-
Janos Farago yazdı
Change-Id: I9cc4472b37d24e426a67661806805c11b521dfb1 Reviewed-on: https://gerrit.libreoffice.org/6074Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Matúš Kukan yazdı
No idea what the '--path $(gb_Configuration_registry)' parameter was for. Change-Id: I892e178a62fa2ea971101815ea558f79d32f85ed
-
Matúš Kukan yazdı
Change-Id: If549f6f5fba14067290b9ec0325381e6d590a472
-
Matúš Kukan yazdı
Change-Id: I1d54d98b8aa50f778de87e6ebb17ec2eed0d65dc
-
Matúš Kukan yazdı
Change-Id: Ifad958524cc75ead4d2bb383369f63457a2237fc
-
Matúš Kukan yazdı
Change-Id: I91444ed4fb98b094ba45bfc2a789abc83eb67212
-
Matúš Kukan yazdı
Change-Id: I5c97347cfaefb23cd985b7776a83337856e4d55c
-
Matúš Kukan yazdı
Change-Id: I88a402bf26852e8e216de11d71cbd42edb0aff23
-
Matúš Kukan yazdı
Change-Id: I55144900bedd79e26979438e9e689488a3bfe2ae
-
Matúš Kukan yazdı
Change-Id: Ic08b12b0deb7342c520a5385c226d864596fc858
-
Caolán McNamara yazdı
Change-Id: If41d78ce424e85390c7a92eaa36f912c43eef390
-
Caolán McNamara yazdı
Change-Id: Iade3e4cedddb2428d2df8243525d14121722c776
-
Caolán McNamara yazdı
Change-Id: I73aa4dd524f9d0d9afbf254fc095da93400b2a54
-
Stephan Bergmann yazdı
Change-Id: I9c56428f6ff015abc585e070b18ad181c48e31e6
-
Stephan Bergmann yazdı
Change-Id: I8729123a34bedfa1f9d5dfd04438da96e422a003
-
Tor Lillqvist yazdı
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
-
Stephan Bergmann yazdı
Change-Id: I26e06392cda5f79cc6914f00f55848b6706dcb9c
-
Stephan Bergmann yazdı
Change-Id: I9d4c40224def46647aa6d6003125cbe7b3a7d0b2
-