...and get member function const'ness right overall

Change-Id: Idb422039108d1dde9f6a8b881f6dff742030f6f0

Change-Id: Ide32700aab3427a8bf18c806968822cdf3f91bf2

Change-Id: Ia315f446c374ac08d8a4b7247c571b70cbbab5ae

Change-Id: I8711bb5c676194d9b34df2584a31851dfcc901e6
Reviewed-on: https://gerrit.libreoffice.org/35143Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I81a59c7847e2109198a35cbdb49f5bcf3505c4ba

Change-Id: I3afb31b642a47e767dda0614d223b6b7f22e5d54

Change-Id: If728a1da99d9146d60d15b5273a7a89764b82d51

I guess you can only see the problem if you not only do a from-scratch
build (like Jenkins does) but also empty the tarball cache.

Change-Id: I1238e35abe1a6009ce0e0c3406e20aa1879c65bc

if we are a hairline along the very right/bottom edge
of the canvas then distory the polygon inwards one pixel right/bottom so that
the hairline falls inside the paintable area and becomes visible

Change-Id: Ie5713f6916cf5b47fdf14f86f034e38cda9900fd
Reviewed-on: https://gerrit.libreoffice.org/34243Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8e61163de7e6192bdf613ab6b58906326499d6c2
Reviewed-on: https://gerrit.libreoffice.org/35137Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

... so only SvNumberFormatter can use it, as intended.

Change-Id: I91875dfd00d1f83b3ae988bda922782336489f73

(user-provided virtual dtor in class with dependent base)

Change-Id: I37b3cc3d32e76a0286ecc91f999920e3dfe706cc

(vs. uses of sal_uInt16 representing such items' IDs).  APPEND and ITEM_NOTFOUND
are members of ToolBox now (and have been bumped to the corresponding type's
max).  The payload of VclEventIds

  ToolboxButtonStateChanged
  ToolboxClick
  ToolboxHighlightOff
  ToolboxItemAdded
  ToolboxItemDisabled
  ToolboxItemEnabled
  ToolboxItemRemoved
  ToolboxItemTextChanged
  ToolboxItemUpdated
  ToolboxItemWindowChanged
  ToolboxSelect

has been changed too (note that reading/writing of those payloads isn't very
consistent, though: for some of these, values are written that are never read,
while for some others no values are ever written but the reading code would like
to receive some value if the payload wasn't a nullptr).

Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141

Is suspect something has changed in gtk3, and I think we're
not supposed to use gdk_drag_drop_succeeded at this point, but
instead we'd get a dragFailed signal on the failure case

Change-Id: I6b305db56a29255b468ca9182d1f7e57cb4c10f4

...not positions in the [0..GetItemCount()) range, so what's probably missing
here is to map from positions to IDs.  Code was originally introduced with
8a429819 "findbar01: enhancements for findbar".

Change-Id: Ia95b65e14bb81dac940269b167434f83cefbd4d8
Reviewed-on: https://gerrit.libreoffice.org/35102Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...not positions in the [0..GetItemCount()) range, so what's probably missing
here is to map from positions to IDs.  Code was introduced with
f25cdaa7 "fdo#74132: Do not interrupt search in
Writer."

Change-Id: I0049b76c91c8ed5a9f4051f170454fb3d49c46f9
Reviewed-on: https://gerrit.libreoffice.org/35101Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

MSWord normally does NOT specify "nextPage" for the sectionBreak,
since that is the default type. That is imported as BreakType == -1.
However, Writer ALWAYS exports the section type name, which of
course is imported explicitly.
**There is an import hack that treats the very first -1 section as
continuous IF there are columns**. Since Writer explicitly defines
the section type, these documents import differently.

When Writer round-trips these types of files, they get totally
messed up in Writer, although they look fine in Word. So, treat
both implicit and explicit nextPage identically for
bTreatAsContinuous during import.

Another unit test demonstrated that headers/footers are lost when
treating as continuous, so preventing that situation now also.

This fix allows several import-only unit tests to round-trip.

Change-Id: I37fa861d82e8da564d28d8e9089fe0f2777650fb
Reviewed-on: https://gerrit.libreoffice.org/35013Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

As it causes "unopkg.bin:
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/comphelper/source/misc/threadpool.cxx:96:
comphelper::ThreadPool::~ThreadPool(): Assertion `mbTerminate' failed."
in
<https://ci.libreoffice.org/job/lo_gerrit/8283/Config=linux_clang_dbgutil_64/console>
and also locally. Revert till it's clear if that assert() should be a
SAL_WARN() or unopkg has to be fixed.

This reverts commit 9899ffd2.

Change-Id: I72902f7da410012340aa8231d84c6871a3f7b976

Change-Id: If96fbf097e2314303e60fd4f10ae314d12f2c468

Change-Id: I960768ff98137a50da44348bffeec329295ea95f

Change-Id: I7acdea720ba29eb9b9fb3ef8e8cbc76a673d17c2

Change-Id: Iaf6310055b60da772187fdbeaca74d6eb296cfca

Change-Id: Ibb1625ff974cc1a35e5547b6ce88bf13d186d4bb

Change-Id: Ifd818cdf81516bd449db14bb1e84ed508e4b7d96

in preparation for "scoped UNO enums".

This is a little hacky: In order to limit the scope of this change,
the templated SvXMLEnumMapEntry struct actually has a fixed size field,
and we cast it to SvXMLEnumMapEntry<sal_uInt16>* in various
places, to avoid carrying the type param around.

Change-Id: Idfbc5561303c557598dd5564b7a7259ae5261d83
Reviewed-on: https://gerrit.libreoffice.org/34987Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I18eec89c4e1ebb86d64297e7cef4b36bf12df59f
Reviewed-on: https://gerrit.libreoffice.org/35004Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after faef35d8 "Move file download
verification from md5sum to sha256sum".

ATTENTION: A proper SHA from the source of that
b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext_0.9.5.oxt is needed. The value
substituted for now is just my local sha256sum after download.

Change-Id: Id31508f10c6cd936e5c6318731ceed71bdc25f48

I.e. show only 64bit JRE for 64bit LO and 32bit JRE for 32bit LO

Change-Id: Id5e890637c7e1014bcb4e6fdd9ed9a33765112d5
Reviewed-on: https://gerrit.libreoffice.org/35026Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

some stuff cppcheck missed in this file.
plus use empty() and front()

Change-Id: I612078d503c555afd681526f95d17502ffd585ba
Reviewed-on: https://gerrit.libreoffice.org/35094Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and make it easier to debug.
top crasher in 5.3.0.3 is around this area:
https://cgit.freedesktop.org/libreoffice/core/tree/vcl/source/gdi/
bmpacc2.cxx?h=libreoffice-5.3.0.3#n235

http://crashreport.libreoffice.org/stats/signature/
BitmapReadAccess::GetPixelForN32BitTcRgba(
unsigned%20char%20const%20*,long,ColorMask%20const%20&)#summary

in case someone wonders suffix increment '++' precedes dereference '*'

Change-Id: I15876711db569d55739da3514f61ef1b981269ab
Reviewed-on: https://gerrit.libreoffice.org/35099Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

That is always MD5 sum, but we expect SHA256 now.

Change-Id: I8edf61b9a663f6f1ecc5cf23c93211e0b3201631
Reviewed-on: https://gerrit.libreoffice.org/35067Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

This makes it MUCH easier to see what sort option is currently
selected. Removed the mechanism of switching between labels when
the option is toggled, and instead put all the options into a menu.

Change-Id: I44142dc842d983d5438faeb06b67046bad235308
Reviewed-on: https://gerrit.libreoffice.org/34640Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>

Fixes "Random Config" tb run #289

Change-Id: Ib1d672ac0a68e977f8d32f87c730ff1b0822f32c
Reviewed-on: https://gerrit.libreoffice.org/35109Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I12817adc50d45e2f08b3b5d4cb43daa527d274e9

Change-Id: I323be5e042e0ccb21956def70a8c481833f43998

Change-Id: I63da858b3f264cd099e60192633b44d362b6fad7
Reviewed-on: https://gerrit.libreoffice.org/35055Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If1216b03a313885bb284ca5ddcd8a91167a3638b

change for cicle to generate only one .vcxproj and .filter pr module

Change-Id: I93f2279e368e11ef5b9d442c6dcdfa4bf39bd6c2
Reviewed-on: https://gerrit.libreoffice.org/35075Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>

...so doesn't need to be passed through GetItemId.  Apparent thinko in
e3bd10f8 "adjust the hide of the zoom so its
dynamic on docking/undocking navigators".

Change-Id: I26c300522f048b8fd661856bfe2789ee7718ad15

...return value from ToolBox::GetItemId, as is done in all other places where
such is returned from one of the ToolBox::GetItemId overloads.  And
TOOLBOX_ITEM_NOTFOUND is otherwise only used for item positions, not item IDs.
(This lone odd use of TOOLBOX_ITEM_NOTFOUND was introduced with
ae5f75ab "Allow a common op. on a disposed
toolbox", probably by accident.)

Change-Id: Id767b1d8d0b3cdfdc0ec525f165d75ae0cef7301