Kayıtlar (commit) · a05e5adc62c74b42262fce9a309c1bc6c685893c · LibreOffice / core

24 Agu, 2017 12 kayıt (commit)

dbaccess: avoid deadlock in ODatabaseContext::registerObject() · a05e5adc

Michael Stahl Agu 24, 2017 yazdı

Limit the scope of m_aMutex lock to what is necessary.

As observed by Jan-Marek Glogowski:

[Switching to thread 198 (Thread 0x2aab44e5b700 (LWP 46847))]
3  osl_acquireMutex(oslMutexImpl*) (pMutex=0x1e59d10) at sal/osl/unx/mutex.cxx:97
4  osl::Mutex::acquire() (this=0x1ebbe28) at include/osl/mutex.hxx:56
5  osl::Guard<osl::Mutex>::Guard(osl::Mutex&, bool) (this=0x2aab44e56198, rT=..., bAquire=true) at include/osl/mutex.hxx:135
6  dbaccess::ODatabaseContext::getElementNames() (this=0x1ebbd90) at dbaccess/source/core/dataaccess/databasecontext.cxx:661
7  non-virtual thunk to dbaccess::ODatabaseContext::getElementNames() () at dbaccess/source/core/dataaccess/databasecontext.cxx:659
8  dbaui::SbaTableQueryBrowser::initializeTreeModel() (this=0xb174890) at dbaccess/source/ui/browser/unodatbr.cxx:2086
9  dbaui::SbaTableQueryBrowser::impl_initialize() (this=0xb174890) at dbaccess/source/ui/browser/unodatbr.cxx:3201
10 dbaui::OGenericUnoController::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0xb174890, aArguments=uno::Sequence of length 9 = {...}) at dbaccess/source/ui/browser/genericcontroller.cxx:299
11 DBContentLoader::load(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XLoadEventListener> const&) (this=0xb1730a0, rFrame=uno::Reference to ((anonymous namespace)::Frame *) 0xb162690, rURL=".component:DB/DataSourceBrowser", rArgs=uno::Sequence of length 8 = {...}, rListener=uno::Reference to (framework::LoadEnvListener *) 0xb174228) at dbaccess/source/ui/browser/dbloader.cxx:270
12 framework::LoadEnv::impl_loadContent() (this=0xb16f5b8) at framework/source/loadenv/loadenv.cxx:1077
13 framework::LoadEnv::startLoading() (this=0xb16f5b8) at framework/source/loadenv/loadenv.cxx:372

[Switching to thread 196 (Thread 0x2aab4565f700 (LWP 42841))]
3  osl_acquireMutex(oslMutexImpl*) (pMutex=0x773cd0) at sal/osl/unx/mutex.cxx:97
4  osl::Mutex::acquire() (this=0x77b4a8) at include/osl/mutex.hxx:56
5  comphelper::GenericSolarMutex::doAcquire(unsigned int) (this=0x77b4a0, nLockCount=1) at comphelper/source/misc/solarmutex.cxx:61
6  comphelper::SolarMutex::acquire(unsigned int) (this=0x77b4a0, nLockCount=1) at include/comphelper/solarmutex.hxx:74
7  osl::ClearableGuard<comphelper::SolarMutex>::ClearableGuard(comphelper::SolarMutex&) (this=0x2aab4565d478, t=...) at include/osl/mutex.hxx:170
8  osl::ResettableGuard<comphelper::SolarMutex>::ResettableGuard(comphelper::SolarMutex&) (this=0x2aab4565d478, rT=...) at include/osl/mutex.hxx:215
9  SolarMutexResettableGuard::SolarMutexResettableGuard() (this=0x2aab4565d478) at include/vcl/svapp.hxx:1416
10 dbaccess::ModelMethodGuard::ModelMethodGuard(dbaccess::ModelDependentComponent const&) (this=0x2aab4565d478, _component=...) at dbaccess/source/core/dataaccess/ModelImpl.hxx:587
11 dbaccess::ODatabaseSource::getDatabaseDocument() (this=0x281d690) at dbaccess/source/core/dataaccess/datasource.cxx:1300
12 non-virtual thunk to dbaccess::ODatabaseSource::getDatabaseDocument() () at dbaccess/source/core/dataaccess/datasource.cxx:1298
13 dbaccess::ODatabaseContext::registerObject(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (this=0x1ebbd90, _rName="MyFactory", _rxObject=uno::Reference to (dbaccess::ODatabaseSource *) 0x281d708) at dbaccess/source/core/dataaccess/databasecontext.cxx:433
14 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) (pThis=0x1ebbdf8, nVtableIndex=4, pRegisterReturn=0x0, pReturnTypeRef=0x781090, bSimpleReturn=true, pStack=0x2aab4565d810, nStack=0, pGPR=0x2aab4565db30, pFPR=0x2aab4565daf0) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77

Change-Id: I06e91d9c4e193c97f98f29f6b73eaf01b12922c0

a05e5adc

VBA tests-add VAL,VARTYPE,WEEKDAY,WEEKDAYNAME,YEAR tests · 74da6d5f

Zdeněk Crhonek Agu 24, 2017 yazdı

Change-Id: I3f1803617a2bdeaab9922ebb375ec4fd67318d20
Reviewed-on: https://gerrit.libreoffice.org/41499Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

74da6d5f

loplugin:constparam in sc part4 · fd736c4f

Noel Grandin Agu 24, 2017 yazdı

Change-Id: I745f50257948a53ca07766955c4f4e86dd2a366e
Reviewed-on: https://gerrit.libreoffice.org/41497Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

fd736c4f

loplugin:constparam in sc part3 · 3eb5ab6e

Noel Grandin Agu 23, 2017 yazdı

Change-Id: I8abc44b9f0bcd5e39fd8a94abafaf80aadcd26ca
Reviewed-on: https://gerrit.libreoffice.org/41496Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

3eb5ab6e

loplugin:useuniqueptr in filter · 4fb9d7b6

Noel Grandin Agu 23, 2017 yazdı

Change-Id: I127b570bb1563dc75b21633019b3640f93715d77
Reviewed-on: https://gerrit.libreoffice.org/41495Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4fb9d7b6

Consistently use OUString in test::Directories · 66604baf

Stephan Bergmann Agu 23, 2017 yazdı

Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2
Reviewed-on: https://gerrit.libreoffice.org/41466Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

66604baf

remove unused error code in vcl · 844b3c06

Noel Grandin Agu 23, 2017 yazdı

ever since

    commit 920d4463
    Date:   Thu Jun 23 13:13:28 2016 +0200
    loplugin:singlevalfields in vcl(part1)

Change-Id: I3691d03dadff10585a119ca8db8aa193b5a01702
Reviewed-on: https://gerrit.libreoffice.org/41492Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

844b3c06

loplugin:useuniqueptr in cppcanvas · 95b04f52

Noel Grandin Agu 23, 2017 yazdı

Change-Id: I8e995128a7a1c5911efc82a762dbe7be015b2050
Reviewed-on: https://gerrit.libreoffice.org/41493Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

95b04f52

Replace some lists by vectors in xstorage (package module) · a4231a1e

Julien Nabet Agu 23, 2017 yazdı

Change-Id: I0093b87ff70d9ea31ca08f8df161899d5ff4bb9f
Reviewed-on: https://gerrit.libreoffice.org/41478Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

a4231a1e

oox: kill redundant breaks · d34f669f

Thorsten Behrens Agu 01, 2017 yazdı

Change-Id: I18aadb7b6b2fa50159624df1b4a7de9270473785
Reviewed-on: https://gerrit.libreoffice.org/41480Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

d34f669f

unnecessary condition:rGraphic.IsDummyContext() · 290d7a4e

ccsheller Agu 24, 2017 yazdı

when bDummyContext is true at pre code,and call the rGraphic.SetDummyContext( false ).
so this is unnecessary condition at follow code.

Change-Id: I69da58485fd7b81c9111e188d47b98fe8065fc47
Reviewed-on: https://gerrit.libreoffice.org/41489Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

290d7a4e

remove unused error codes in svtools · 02c53f74

Noel Grandin Agu 23, 2017 yazdı

which seem to be unused since initial import

Change-Id: Id5216bac53fafc1020003de10d8dde381b1121cf
Reviewed-on: https://gerrit.libreoffice.org/41491Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

02c53f74

23 Agu, 2017 28 kayıt (commit)

Eike Rathke Agu 23, 2017 yazdı

Substitute with the current work locale, using MsLangId::getSystemLanguage()
instead was also wrong.

Change-Id: I55db3bc1f76329320afc1f366d7426a8c2f66fb2
Reviewed-on: https://gerrit.libreoffice.org/41476Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

311be7d7

Eike Rathke Agu 23, 2017 yazdı

An SvxAutoCorrect instance is shared via SvxAutoCorrCfg::Get().GetAutoCorrect().
Since commit 284eb106 and following the
SvxAutoCorrect::bRunNext/HasRunNext() introduced a state whether a previously
inserted NO-BREAK SPACE should be removed again, depending on the next
character input. That does not work, for example, if
SvxAutoCorrect::DoAutoCorrect() is called from two different EditEngine
instances, like it is the case in the Calc input line and cell which are
synchronized; or any other two or more instances for that matter. The caller
has to pass and remember a flag that is maintained by SvxAutoCorrect.

Change-Id: I79a26d2ba44cc40771979a78b686c89f0c80b412
Reviewed-on: https://gerrit.libreoffice.org/41475Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

06d14411

Fix typo · 5a9b20c8

Andrea Gelmini Agu 23, 2017 yazdı

Change-Id: I04ca767a317af6afa8f3ef82fee137c86211e34a
Reviewed-on: https://gerrit.libreoffice.org/41479Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

5a9b20c8

tdf#111795 - Special character preview control should have border · 890e1fb5

Akshay Deep Agu 20, 2017 yazdı

Change-Id: Ic26888829c24f65b3d8039e74a632c14be338d44
Reviewed-on: https://gerrit.libreoffice.org/41356Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

890e1fb5

tdf#45904 Move Java _XUniqueCellFormatRangesSupplier test to C++ · 4818ee60

Jens Carl Agu 23, 2017 yazdı

Change-Id: I66c62f1676515437197d1875600407408040ca74
Reviewed-on: https://gerrit.libreoffice.org/41445Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

4818ee60

tdf#45904 Remove/disable obsolete _XSpreadsheetDocument Java test · 40fdfea0

Jens Carl Agu 22, 2017 yazdı

The _XSpreadsheetDocument test is already written in C++ since commit
b9337e22.

Change-Id: Icc0fc266f6e375ceb94edd5a95d396540972a908
Reviewed-on: https://gerrit.libreoffice.org/41409Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

40fdfea0

tdf#45904 Remove/disable obsolete _XSheetOutline Java tests · 494b7089

Jens Carl Agu 22, 2017 yazdı

The _XSheetOutline tests are already written in C++ since commit
b9337e22.

Change-Id: I0803df8dec6fd2f18e89c7bd8b8d15d0e4ee4aa2
Reviewed-on: https://gerrit.libreoffice.org/41408Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

494b7089

tdf#45905 Remove/disable obsolete _XNamedRanges Java tests · da25c627

Jens Carl Agu 20, 2017 yazdı

The _XNamedRanges test are already written in C++ since commit
b9337e22.

Change-Id: I8610cc50ce23de7183efb5d9b6b436f1b9dceae1
Reviewed-on: https://gerrit.libreoffice.org/41349Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

da25c627

tdf#45904 Remove/disable obsolete _XDataPilotTable Java tests · fcbabad4

Jens Carl Agu 12, 2017 yazdı

The _XDataPilotTable tests are already written in C++ since commit
95780ec7.

Change-Id: I5785a2b8edbe3166c8f81348cb36c117a4b9b736
Reviewed-on: https://gerrit.libreoffice.org/41079Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

fcbabad4

tdf#45904 Move Java _XAreaLink tests to C++ · aeb525c0

Jens Carl Agu 07, 2017 yazdı

Change-Id: I95112555de3a5dd5a75c478edb5856cf79919db9
Reviewed-on: https://gerrit.libreoffice.org/40859Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

aeb525c0

DOCX: Fix an other test case of ActiveX control export · b1294217

Tamás Zolnai Agu 23, 2017 yazdı

When LO control is anchored to the end of the run, it
is exported into a new run.

Change-Id: I9269fd1b34924780aad61c452d1e2094dc8e4aad
Reviewed-on: https://gerrit.libreoffice.org/41472Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

b1294217

loplugin:useuniqueptr, look for containers.. · c66568d6

Noel Grandin Agu 23, 2017 yazdı

that can use std::unique_ptr, and apply it in i18npool

Change-Id: Ib410abaf73d5f392c7a7a9a322872b08c948f9e9
Reviewed-on: https://gerrit.libreoffice.org/41438Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

c66568d6

VML, Watermark: detect shapetype from other subdocuments · 87f1f7fd

Szymon Kłos Agu 21, 2017 yazdı

In some documents Watermark wasn't visible
because shapetype wasn't detected.
It was impossible to use shapetype defined in header1.xml
in shape placed in the header2.xml.

Change-Id: Ib406c8fc702968684ad46efd0857b768af2820f5
Reviewed-on: https://gerrit.libreoffice.org/41395Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

87f1f7fd

Android: Enable HAVE_FEATURE_NSS and package the NSS libraries with apk · 511ae02c

Gautam Prajapati Agu 18, 2017 yazdı

This commit enables HAVE_FEATURE_NSS for Android and fixes the svl/ vcl/
and xmlsecurity/ module to use NSS.

xmlsecurity/ wasn't built for Android previously, this commit enables
building xmlsecurity/ for Android and disables the support of gpgme
in the same module(Only for Android).

It also enables the linking of NSS shared libraries with
liblo-native-code.so and adds a rule to package them along with the apk.

Change-Id: I7d0341688ac979ae92e9145c37dd107670417fe1
Reviewed-on: https://gerrit.libreoffice.org/41308Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

511ae02c

Clean up string construction · f8fa4631
Stephan Bergmann Agu 23, 2017 yazdı
```
Change-Id: I41ca0c7c9ac1892cc87eb4dbba858527aa340c75
```
f8fa4631
ScFiltersTest::testUnicodeFileNameGnumeric only works with UTF-8 · 9a19e96d
Stephan Bergmann Agu 23, 2017 yazdı
```
Change-Id: If31062abf50125c65a90566f1276f37d6725f73c
```
9a19e96d
libxml2: bunch of CVE fixes · 486d3b21
Michael Stahl Agu 23, 2017 yazdı
```
Change-Id: Ic786fef17cbdb574c342925a4c57875123ef3151
```
486d3b21
osl::Directory::createPath with excess slashes fails with E_INVAL on Windows · 7aedcf09
Stephan Bergmann Agu 23, 2017 yazdı
```
Change-Id: Ic7d8a2e9bdad9a255f984116c4fdecd0e1c0d265
```
7aedcf09
Report osl::Directory::createPath failure · 63e1596a
Stephan Bergmann Agu 23, 2017 yazdı
```
Change-Id: I75ede7f03edf80c00d33281afdebc3b620fb33eb
```
63e1596a

Make ScBootstrapFixture::createFileURL generate properly encoded URLs · 7aaa3fe5

Stephan Bergmann Agu 23, 2017 yazdı

Requires the rsBaseString arg to the ScBootstrapFixture ctor to consitently be
passed as a relative path without a leading slash.

Change-Id: Ieff38d465b0053fdae42acc4babfb34d1a4827bd

7aaa3fe5

drop SwBackgroundDestinationItem wrapper · 11f81f2b

Jochen Nitschke Agu 22, 2017 yazdı

other call sites just use SfxUInt16Item and overridden Clone does
same as base class.

Change-Id: I50acb4fbb08b3c2fdc4c7605d0ccecac0e9cc209
Reviewed-on: https://gerrit.libreoffice.org/41449Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

11f81f2b

loplugin:constparam in sc part2 · 53d0a6de

Noel Grandin Agu 23, 2017 yazdı

Change-Id: I4fd18096d7d22d8c146a2437906187d5df1cb268
Reviewed-on: https://gerrit.libreoffice.org/41447Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

53d0a6de

tdf#111964: only trim XML whitespace · 5b518ab0

Mike Kaganski Agu 23, 2017 yazdı

OUString::trim() uses rtl_uString_newTrim, which relies upon
rtl_ImplIsWhitespace. The latter treats as whitespaces not only
characters with values less than or equal to 32, but also Unicode
General Punctuation area Space and some Control characters. Thus,
using OUString::trim() is incorrect when the goal is to trim XML
whitespace, which is defined as one of 0x09, 0x0A, 0x0D, 0x20.

The comments for OUString::trim() and rtl_uString_newTrim are
corrected to describe which characters are considered whitespace.

A unit test included.

Change-Id: I45a132be923a52dcd5a4c35aeecb53d423b49fec
Reviewed-on: https://gerrit.libreoffice.org/41444Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

5b518ab0

tdf#109184 auto cell color should be transparent · d239bf6d

Szymon Kłos Agu 17, 2017 yazdı

Don't add color to the property map if is set to auto.
In this case white color was assumed and tables were
white instead of transparent.

Change-Id: I7f203b8f3831b86ba8de33dc57de227b3029c6d9
Reviewed-on: https://gerrit.libreoffice.org/41255Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

d239bf6d

configure: attempt to fix Android build · 93904913

Michael Stahl Agu 23, 2017 yazdı

Can't find CONF-FOR-BUILD/donwload.lst

Change-Id: Ie6bb993a2d6fcd7723b9f4437284b862eb194316

93904913

Don't crash if aProfileId is null · 45050470
Tor Lillqvist Agu 23, 2017 yazdı
```
Change-Id: I1505469200c4bcc82f07eae325882fd6454ebcc5
```
45050470

fix bug in ScTable::LastHiddenColRow · 4feccde5

Noel Grandin Agu 23, 2017 yazdı

found by inspection, noticed that the for loop is not actually using
it's index variable

introduced in

    commit b3579d71
    koheirowlimitperf: #i109369# #i109373# #i109384# #i109385# #i109386#
million, and integrated lots of speed optimization and bug fixes to
ensure Calc remains usable after the row limit increase.

Change-Id: Icfee19ddb051e8d4333ed4c91d384379bf494444
Reviewed-on: https://gerrit.libreoffice.org/41439Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4feccde5

tdf#108943 RTF import: handle \tx inside a list level definition · 57d53530

Miklos Vajna Agu 23, 2017 yazdı

\tx in the list level definition has a different meaning (we should map
it to the ListtabStopPosition UNO property), compared to when it's used
as a plain text property.

Change-Id: I7b98ae3d82bbd2c4ad41d0d7f4ad50525c4d0f9a
Reviewed-on: https://gerrit.libreoffice.org/41442Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

57d53530