Change-Id: Icb9a40c5ded676ff3f8f7db198a90bb94540bdf4

... and comment on what to do if we really wanted a copy-swap-idiom.
The need to doc comment about not to use assign() after default ctor is
also gone with the temporary swap.

Change-Id: I2a49091b2a41cf155e912e3c373dbbe81c7f9737

Change-Id: Iea7788f985e2c5dc7a96eab711bf7d13732ab86e

Posting of the .uno:Something commands is asynchronous.  To be able to find
out when eg. .uno:Save finished, this commit introduces a callback that fires
when that happens.

To be able to receive such a notification, the appropriate postUnoCommand()
must be called with 'true' as the parameter for bNotifyWhenFinished (defaults
to 'false').

Change-Id: I254939ebc8ea5f309ae39686dcaaeddd5148b0c9

Change-Id: Iccd5b39f6bdf1c7a43131fc50186ea5a2838d77e

Change-Id: Ic009398d1d00550577d9f25b4d904632b063d54f

Change-Id: Ic0a3083c05ba1cce974d76aecf60ed7bc4c72a36

Change-Id: I0ddaf1cf9d0a3f36f88bea3101b7059e04d755ff

Change-Id: Ia19d3512d156be725840c24d441a3eaa08e83a5e

Change-Id: I11ef97b4b4589d21afc40e862bb68a512db18831
Reviewed-on: https://gerrit.libreoffice.org/19741Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I89c4d9752ef650d516bed8fcdc5873de8ae87e18

Lets separate the task of painting the tile, and saving the tile
in tile buffer using GAsyncReadyCallback. This will provide us
with better control over tiles -- cancelling the painting operation,
and filtering tiles that should not be saved in the tile buffer.

Change-Id: I6aae928d8cc0c906034570ed0e9a054763d493a3
Reviewed-on: https://gerrit.libreoffice.org/19725Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

The short-lived SwBorderAttrAccess is manually deleted
which is not exception safe and can potentially leak.
This wraps it in unique_ptr.

Change-Id: Ib45c1c36214583e0bf205231f9f793e023d106c7
Reviewed-on: https://gerrit.libreoffice.org/19701Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

EditCharAttrib doesn't inherit from or related to SvxFieldItem
Moreover, we can see lines like this:
const SvxFieldItem* pFieldItem = dynamic_cast<const SvxFieldItem*>(pAttr->GetItem());

Change-Id: I9f5710dc4a9a4e71d31538620a9ddc1dedee063f
Reviewed-on: https://gerrit.libreoffice.org/19575Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I082e644857a6eb139b5f805e2920a40164ed4cd7

terminated buf correctly before calling printf.
This should be done automatically but coverity does not see it.

Change-Id: I0bcf8486b27dbfa9f7c49b338bbf483029b523cb
Reviewed-on: https://gerrit.libreoffice.org/19751Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ibff6caedae0c5ed84cf4864c7a52af56a7cea527

Change-Id: I00bb0a4390524b569609d36d97120bdd2b55496e

Change-Id: Idc0290d82bb51fec0fcc1db003bd48f3cc402a0f

Change-Id: I0f38c87d46f913a3bbb5f3e40b6ae71c515a8c9c

Change-Id: I3f55c4b8b12832b82e071d8cf62b2aa55f8913e7

Change-Id: Ib35a951ea813151ca330c3eb2286cbada91bd972

Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I05a6d15a0c54ca5457d662c2467cb15c14991a0a

...and not that MSVC-special _DEBUG

Change-Id: I927f1d49dcbb24fd8fb91032ded6215390c97d79

Change-Id: I3f97625552bf993d67b537456e09c9acf3cba6b8
Reviewed-on: https://gerrit.libreoffice.org/19671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Project: help  43d4ce551111e9acea598a4572bdc7959522accf

update description of Horizontal/Vertical Grid buttons

Change-Id: I5859c7f3d4a5dd7af8ee72f437d26dce68ee6e5d
Reviewed-on: https://gerrit.libreoffice.org/19729Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

...as on all the other platforms

Change-Id: I12def7c50b5aabf29e156e87321cd76d216191ad

Change-Id: I4225281e280ea780805b3dc68ed63433f8466bc1

Since df62a2c8 gb_DEBUG_CFLAGS
was passed to bridge_noopt_objects target for MSVC to track
down EH breakage on 64 bit architecture. It was erroneously
done unconditionally. Fix it to only pass when one of:

--enable-dbgutil
--enable-debug
--enable-symbols

is present.

Change-Id: I2728c30156541be418c88a0ea284c0c6a16abba5
Reviewed-on: https://gerrit.libreoffice.org/19744Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I51d87693bdb3d57c36d8cafb851fdad10cd93589

Change-Id: I7967f0ee333eda4db320dc50bd91f2229792f0a8

Change-Id: I21719d513aa4af7a7f9621e19d529fd0c4425f58

...in code introduced with be1b03a4 "dock icon's
menu doesn't begin with separator anymore," causing CppunitTest_vcl_lifecycle to
fail

Change-Id: If6eb1f3a0f52d05284ac01f448888aaaa7523a98

Chose not to use lambdas instead because the number of arguments in these calls
would have made it way too verbose, hurting readability.

Change-Id: I8662a937ec10ca0fac6cd7e0d78b6268e8023ada
Reviewed-on: https://gerrit.libreoffice.org/19707Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

... just ... why ... was ... that ... ? ...

Change-Id: I1bc1ea12600859872c6d238b1ef6fc55f6ff2e04

... that only results in a performance penalty.

Change-Id: Ia161ab7fb03f2d32cf966ce9da9d0319d919fc4c

... to just assign a new value, which takes a significant amount of time
(~13% of ScTable::ValidQuery()) in ScRefCellValue::operator=() due to
its implementation using a temporary and swap.

Change-Id: Ia205850e10c5fa9083eec5fb7563d98561b52462

corrupted with 7408498d
"loplugin:stringconstant"

Change-Id: Ia7af4b7276fb30485f39e24c9afcdc82f7cef447

Change-Id: I077a17eada47b9c1509c21c18a6e4cd06172de3b