End-user VB6 applications might not like the exception. Better to just
ignore.

Change-Id: I42718de7855079e38c7983db39180c184ab7224f

OpenOld() just forwards to the regular Open(), passing empty extra
parameters. CustomizationContext is fully dummy for now.

Change-Id: I167494700853768d971fe16afea35e90a647a00e

Which shows that m_rSdrExport was unused.

Change-Id: I74c305dd2088764c8971bcad09e60b7714eae05d
Reviewed-on: https://gerrit.libreoffice.org/66661Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

...as emitted by at least GCC 8.2 with --enable-optimized, e.g. at:

> In file included from include/rtl/ustring.hxx:37,
>                  from include/cppuhelper/factory.hxx:26,
>                  from unoxml/source/rdf/librdf_repository.hxx:24,
>                  from unoxml/source/rdf/librdf_repository.cxx:20:
> include/rtl/string.hxx: In static member function ‘static std::shared_ptr<{anonymous}::librdf_TypeConverter::Node> {anonymous}::librdf_TypeConverter::extractNode_NoLock(const com::sun::star::uno::Reference<com::sun::star::rdf::XNode>&)’:
> include/rtl/string.hxx:294:27: error: ‘*((void*)(& type)+8).rtl::OString::pData’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>          rtl_string_release( pData );
>          ~~~~~~~~~~~~~~~~~~^~~~~~~~~
> unoxml/source/rdf/librdf_repository.cxx:2094:30: note: ‘*((void*)(& type)+8).rtl::OString::pData’ was declared here
>      boost::optional<OString> type;
>                               ^~~~

This appears to be a common pattern of false positives with uses of
boost::optional, common enough to disable the warning globally for affected
compilers, even if there would also be useful findings by that warning (e.g.,
<https://gerrit.libreoffice.org/#/c/66619/> "Fix -Werror=maybe-uninitialized").

I didn't bother to file a GCC bug for the reproducer used in configure.ac,
<https://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=maybe-uninitialized>
already shows lots of open bugs in that area, and the documentation at
<https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Warning-Options.html> states that
"GCC may not be able to determine when the code is correct in spite of appearing
to have an error."

(Clang appears to not support -Wmaybe-uninitialized at all, so exclude it from
the configure.ac check, to not have the check's failure result in an unsupported
-Wno-maybe-uninitialized end up on the compiler command line.)

Change-Id: Ifb9ca4c342750eae54f7e1a01506101310484c7e
Reviewed-on: https://gerrit.libreoffice.org/66621
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized.  These are not
actually problems, as in both cases strncpy(p,...,N-1) is used to copy a
string into an area p of length N that has initially been zero-initialized, so
p[N-1] will already contain NUL.  But add the (redundant) p[N-1]=NUL just in
case, and to silence GCC (where the documentation explicitly recommends this
additional write as a way to silence the warning).  Unfortunately, in hstyle.cxx
at least GCC 8.2 with --enable-optimized would still emit the warning, even
though it uses the recommended way of handling it, so needs to be silenced with
a #pragma.

Change-Id: Ie41f420c732c2bfb699903ebd21ce1a89dd2b236
Reviewed-on: https://gerrit.libreoffice.org/66620
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized:

> In file included from vcl/source/gdi/pngread.cxx:27:
> include/vcl/pngread.hxx: In member function ‘bool vcl::PNGReaderImpl::ReadNextChunk()’:
> include/vcl/pngread.hxx:49:12: error: ‘aDummyChunk.vcl::PNGReader::ChunkData::nType’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      struct ChunkData
>             ^~~~~~~~~

The immediately relevant part is initializing

        sal_uInt32 nType = 0;

in the ChunkData ctor, but while at it, also make the Read*Int32 calls in
PNGReaderImpl::ReadNextChunk more robust.

Change-Id: Id6ad10a4382a8d063fd70c7bac595c3693475ca3
Reviewed-on: https://gerrit.libreoffice.org/66619
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized, by making the buffers
large enough for the (hypothetical) largest values of the various date/time
components

Change-Id: I82e9b08fa099546b2d6f29c702e1440df9e6c6e0
Reviewed-on: https://gerrit.libreoffice.org/66618
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized, about trying to
output up to 4 bytes into a destionation of size 3

Change-Id: I42c3c9bb7a0355a7d4a1574c6c65d6f74a97f1dc
Reviewed-on: https://gerrit.libreoffice.org/66617
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie9b605eb5340f9e47a977020a8f3688c2412a3c9
Reviewed-on: https://gerrit.libreoffice.org/66635
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Use range-based loop or replace with STL functions.

Change-Id: Ide655aa3633f548ac38c71b452b0ecfc91ee9128
Reviewed-on: https://gerrit.libreoffice.org/66636
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one

Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e
Reviewed-on: https://gerrit.libreoffice.org/66545
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

And remove the "handle" nonsense and just pass plain honest pointers to
a real type around

Change-Id: Ic49443f5f8b20890d8335088331fff81585e8981
Reviewed-on: https://gerrit.libreoffice.org/66615
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If58a22a3d9536ade5f63a3708fd0b6c53f2e21c3
Reviewed-on: https://gerrit.libreoffice.org/66585
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Print dialog text's capitalization changed to follow the styles used in GNOME user interface elements.

Change-Id: I718c4776eaa28e98c5209d160cd47e27782b1101
Reviewed-on: https://gerrit.libreoffice.org/66093Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I14fba5feb45ee2f8de5f017b6da95bd1fe4908f8
Reviewed-on: https://gerrit.libreoffice.org/66660
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

* Update helpcontent2 from branch 'master'
  - Removed executable permission on image files
    
    Change-Id: Ia148161e36c046bfd6374c686c5074d8524dbf06
    Reviewed-on: https://gerrit.libreoffice.org/66638
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#121065 Replace SetOperations, Relations Symbols with SVGs
    
    Replace SetOperations, Relations Symbols PNG images with SVG and
    updated 03090800.xhp, 03090200.xhp and Package_html_media.mk
    
    Change-Id: I2066c1e692a4549a5ab9e020adf1d25ceb7d75c0
    Reviewed-on: https://gerrit.libreoffice.org/66643
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update dictionaries from branch 'master'
  - Bring shipped Spanish dictionary up to version 2.4
    
    Change-Id: Ie814270a83d7459d402e8e92dab4959f2f0793e5
    Reviewed-on: https://gerrit.libreoffice.org/66654Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

It passed "make check" on Linux

Change-Id: I9e6779003639e4b90e8fcbe3ef8a7f7dc1ed85f3
Reviewed-on: https://gerrit.libreoffice.org/66652
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I19809e68542d5795310dcfccbaec70fa931c5147
Reviewed-on: https://gerrit.libreoffice.org/66651
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I24ecf429d26c19823cd76128d2b5e0ec3bdf82c7
Reviewed-on: https://gerrit.libreoffice.org/66639Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9872b27450e9b50d8bef33abc267a763d7d516cb
Reviewed-on: https://gerrit.libreoffice.org/66632
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I11fa408a446aa9fd36780392ae10457822acbb68
Reviewed-on: https://gerrit.libreoffice.org/66606Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Calling the DeleteObject function with a stock object does nothing [1].

1. https://docs.microsoft.com/en-us/previous-versions/ms969928(v=msdn.10)

Change-Id: Icfa1eb834dae33132ff49633035d52606e0cc236
Reviewed-on: https://gerrit.libreoffice.org/66646Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I0bbe9da97de8a71824888ee0d4387aaa338e40a0
Reviewed-on: https://gerrit.libreoffice.org/66645
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I98e90e817782dbd1776a053a9a0fd098a8d2be9d
Reviewed-on: https://gerrit.libreoffice.org/66641
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I503e6e96a6a61b45e741f2131107ecaef8566b83
Reviewed-on: https://gerrit.libreoffice.org/66640
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

* Update helpcontent2 from branch 'master'
  - tdf#121065 Replace Other Symbols PNG images with SVG
    
    Replace Other Symbols PNG images with SVG and updated 03091600.xhp and Package_html_media.mk
    
    Change-Id: I31fc96a7aaac023fd63afc45468fa17d3442e6c8
    Reviewed-on: https://gerrit.libreoffice.org/66246
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Id421cade7a6e81adf47c5caa77b5997e136ed30d
Reviewed-on: https://gerrit.libreoffice.org/66630
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I0ec220642295bd5a855ac38d8e5f721a20351836
Reviewed-on: https://gerrit.libreoffice.org/66633
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

* Add an enum and some methods to DocumentToGraphicRenderer
  to differentiate between the doc/module types:
    isWriter(), isCalc(), isImpress()
* Put some checks for module/doc type
* The result seems ok for a Calc document of multiple sheets
  with hundreds of pages

Change-Id: Idf3e1966d4239df30a48a947a95c9085c25ee1bb
Reviewed-on: https://gerrit.libreoffice.org/66605
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

This patch is a interim solution for document exchange between
Karbon and LibreOffice, till layer-set for page and for
master-page is implemented some day.

Change-Id: I2f12eeeb9c742f65999fd4c0d95c418273ae008f
Reviewed-on: https://gerrit.libreoffice.org/66518
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: Ie6f097984950d306453f0735eb299cfa65d4d74e
Reviewed-on: https://gerrit.libreoffice.org/66225
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: If1ef69d537c67bf0e6f9f5236ce97b1264e82c51
Reviewed-on: https://gerrit.libreoffice.org/66236
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I2ce2d16c24f7fd90c7ba16175ea99f7e1cb46fc9
Reviewed-on: https://gerrit.libreoffice.org/66233
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: If9ec36565cf42d11a0e1715f4aac28c365843a56
Reviewed-on: https://gerrit.libreoffice.org/66226
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I3642ea9e474c06943ea8bfb88e4209749db1fd83
Reviewed-on: https://gerrit.libreoffice.org/66578
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

It’s a label for a combo box in the Font Features dialog,
so give it appropriate text and a colon.

Change-Id: I2403b77283eef118d2e7701dfdcbe190fe504f36

PowerPoint renders these as bent connectors, not as arrow shapes.

Also add a bit of vertical spacing between the nodes, otherwise the
connectors have no way to be visible. Their position is still incorrect,
though.

Change-Id: I995930c0bbc1bdb1014face2490be392571548a2
Reviewed-on: https://gerrit.libreoffice.org/66627Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

The patch fixes missing numFmt. numFmt element has been added as child
under the dLbl element.

Change-Id: Ic81ac58c2ea087cd7599351034eb4298ee613843
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/66493Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins