Change-Id: I03655bb502d6480d8f7f3f1adef17d8f635b8ed9

This touches up lightly on e986d3e3

Change-Id: If4d940433b27abec63a85c5975f5e9ebf672b79a

OLDPRODUCT2 - it was a workaround for OOo 1.9, obsolete
SAMEPRODUCTS - same product have the same ProductCode, so installer detect it
anyway under normal circumstances. It is possible that a tester/developer tries
to install the same version with different ProductCode over an existing installation
(e.g. dailyes or RCs). Then we are in trouble. However, SAMEPRODUCTS was not in use.
Moreover, Windows Installer uses only the first three fields of the product version.
So we cannot make difference between e.g. 4.0.3.1 and 4.0.3.2, and this is the new versioning
scheme.
BETAPRODUCTS - LibreOffice have never used different upgrade code (BETAUPGRADECODE) for betas.
OLDPRODUCTSPATCH, SAMEPRODUCTSPATCH, NEWPRODUCTSPATCH - related to old Star Division patching
mechanism, they were commented out anyway.
STUBPRODUCTS, STUBUPGRADECODE - these look useless

Change-Id: I77d67b72e18fa6b3ba4182b99e198c42f247cea4

Or, as it might happen, not... If there are differing opinions, please revert
and/or amend. Or start a discussion on the development list.

Change-Id: Ide5060802fda2d59a1c098d1ba8398fc095007c8

Also, don't claim TDF would be doing 64-bit Windows builds.

Change-Id: I3abdb13cf7b29c6d249d49fd6f66ce1b9993d97e

Try to make it more likely that a build without any autogen.sh options
succeeds. We didn't even get past the autogen.sh phase on openSUSE 12.3 thanks
to some krb5 stuff needed by the postgresql-sdbc checks.

To compensate, add --enable-postgresql-sdbc to those distro-configs/*.conf
files that didn't already have --disable-postgresql-sdbc.

Change-Id: I967616993875b99d9d5a9fd0721f281bb1161a87

commit f837c428 moved the handling of
w10:wrap tag in oox, but thus no wrapping was imported any more.

The fix consists in letting the w10:wrap element be handled by writerfilter's
dmapper if the shape has already been retrieved from oox (which is the
case for textboxes). In other cases, make sure that we don't set the
Surround property once again in writerfilter as that would override what
has been done in oox.

(cherry picked from commit 51d5e90b)

Conflicts:
	oox/inc/oox/vml/vmlshape.hxx
	sw/qa/extras/ooxmlimport/ooxmlimport.cxx

Change-Id: I8ab158641afcf6b9945c52238e7f5adb9e8b3adf

Change-Id: Ia09e30958392b660f694e8eefb6605108b3c0b57

Change-Id: I11a2a7e8e1f3f089c3b475df1147cefafecdb376

Some of these were doing nothing useful at all. I removed those.
A couple were protecting static data, and I fixed those to use Mutex
and MutexGuard properly.

Change-Id: I444d13f8b6c50e526cce8d69d09aeaf240e5c6ca
Reviewed-on: https://gerrit.libreoffice.org/3678Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>

Change-Id: Ic8af47b52b06ef440b3fdaa966075780fb7a609b

Change-Id: I27df97ab6e35b03dfe70c7a979dd06f977086069

Seems this had bitrotted quite a lot. Calling it now like a cppunit
test works again.

Change-Id: I27479c3c3e1c1fe0639629e9bf8844456e0b0515

Change-Id: Ifd51f0c25418085ba8a6e8d331ac5c6d8139d18a

Yes, a simple test would have answered the question in the comment and
made clear that nanoseconds are not accepted by MSO.

Let's go with normal seconds as MSO does. It seems it also accepts
1/100s but who really needs that for a file timestamp.

Change-Id: Iaec6f9c08dc94d5086b83cb4bf520d0053b71b28

Change-Id: I6c70c000f60e7e6e43bd068ccb98b693b80746f2

Change-Id: I78e778408abb72772771daf5776a26f08c313ee2

Seems poppler changed outputdev virt func signatures with version
12, so with system poppler, we never got any image import functions
called. Added override annotation to prevent this from happening in
the future.

Change-Id: I565de80ce218e831e276d3a1d88ded3baee876e7

We shouldn't be trying to free the font table buffer when destroying the
blob, so pass NULL for destroy function instead of free(), and also use
HB_MEMORY_MODE_READONLY just to be safe.

Change-Id: I85b5a575249b4efc0f5799db205ee17cbeb66d22

Change-Id: Id7cb705b2b719cdd3bf16b8aba858c0319686599

Change-Id: I7a6ee4dce338b7529fa7500bb0c8341a4f2ebc22

Change-Id: I25794499711845cb8183664d1345e5513587d81c
Reviewed-on: https://gerrit.libreoffice.org/3679Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>

Change-Id: I6ddeff7ae72693fd0951d71bd7b5444938bc7286

Change-Id: Iaec745dc1c8eb0614cc2fe1d70a94a00d18cc934

Add "$COMMONPROGRAMFILES\Merge Modules" (on current versions of Windows
that probably is "C:\Program Files (x86)\Common Files\Merge Modules") as
fallback, since for example on Windows Server 2012, the registry entry
has not been created when installing Visual Studio Express

Change-Id: I16f58b8a1d453c8628c6eb66c2cea37ab3da913a
Reviewed-on: https://gerrit.libreoffice.org/3680Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>

Project: dictionaries  acf0ae3fdec65df75f4983d2b943582f9ab99fa2

The things are not even enums, so there's no error checking either.

Change-Id: Ib33cd96b49a840cbe486dbed9a7c370827b54c2d

And another step closer to opening my test file correctly in Excel.

Change-Id: Ib6aa8ddb2f2792513c7263d86865e08fe5f1483d

Change-Id: I12ddd18c1b4476d42c097704c2af2d0af4e15a1e

One step closer to opening my simple test file correctly in Excel.

Change-Id: I1bfa76a46081ba478e44d8d90d8a91790a9a9ff3

The extra semi-colons were confusing clang. Just remove the macro,
it's not adding any real value.

Change-Id: I7f7c312d2c0167a17e31624e197ae75b77fa0c2f
Reviewed-on: https://gerrit.libreoffice.org/3677Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>

...since 81af84c0 "gbuild: let JunitTests run
with MSVC."

Change-Id: I4ba97431c3439c0bed74149fe66cbb76db5317ce

Change-Id: I36c62fc677de70c08d0d59e45debc6a86375d3b7

...rather than a TypeDescriptionManager service that is no longer available.

Change-Id: I1054ab0a658597a60d11e2f9aa0960df25d14bc4

Change-Id: I7c750debaeee5d9804be378e0f65bec13ac296eb

Project: help  eddac30b5afa84c2420a553d2e822722dc857228

Let foo.odb be a database file that has a macro that connects to the
Database on "Open Document" event (and needs to prompt user for
user/password).

There was a race condition between two actions:

 1) the asynchronous treatment of "OnFirstControllerConnected" in dbaui::OApplicationController,
    which tries to get dbaui::OApplicationController's mutex

 2) the StarBasic macro calling dbaui::OApplicationController::connect
    which needs to display a dialog (to get username and password),
    and thus puts that dialog in the main thread's event queue
    and waits for it ... with dbaui::OApplicationController's mutex held

Now, if "1)" is before "2)" in the event queue of the the main thread,
*but* "1)" is executed *after* "2)" has taken the lock, there is a deadlock.

Fix:

 1) Make OnFirstControllerConnected synchronous.
    Make sure (by taking mutex in dbaui::OApplicationController::attachFrame, its ancestor in the call graph)
    that nothing else will happen with the OApplicationController as long as it is not finished.
    ---> it does not need to take mutex itself anymore

    This avoids the "order in the asynchronous events" dependency.

 2) Change dbaui::OApplicationController::ensureConnection to do the user prompting
    WITHOUT HOLDING the mutex, and use the mutex "only" to protect actually assigning
    the connection to m_xDataSourceConnection.

    Theoretically, in some race condition, we could connect twice and then discard one connection <shrug>.
    ensureConnection will never return the discarded connection, though.

    (I think I got that right with respect to http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html)

    This keeps it from locking on another condition while holding the mutex.

Change-Id: Iab1bbec5d5df12bb89d027d43e498c78c92ffc32
Reviewed-on: https://gerrit.libreoffice.org/3310Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I2555dc113b2fb4c77bec187b15f0bb545811b07b

Change-Id: I7a4f782235a23f50bceaef041a92e42e47860a78