Change-Id: I64ae6c2a45e0ed880f5b76ca2ad420d684fdfeb4
Reviewed-on: https://gerrit.libreoffice.org/21308Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>

The change I made in commit 7b974e05 ("vcl: merge
ImplFontMetricData with ImplFontAttributes") was... ill-advised. For
starters, there really needs to be this split as FontSelectPattern
needs it, and PhysicalFontFace only requires the font attributes, not
the metric data.

So the merge was unfortunately, in my mind, a failure and I'm manually
backing it out now.

Change-Id: Iac38f0815f984541e2f55099c965376dd88eeb43
Reviewed-on: https://gerrit.libreoffice.org/21380Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I5edacec5c74398777ab0006c0d4e76d7d3050876
Reviewed-on: https://gerrit.libreoffice.org/21376Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I7b326d8fc8d2b6ecd9642ba958015285d0929a44
Reviewed-on: https://gerrit.libreoffice.org/21341Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: If764e87a90d57b473019ec96a1ef9026dc9675ae
Reviewed-on: https://gerrit.libreoffice.org/21340Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Ib2acc963704c7613e1d3bd1761b619ece1aef79f
Reviewed-on: https://gerrit.libreoffice.org/21339Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I6173cd191cd771b1f030fa737617b1067278ee10
Reviewed-on: https://gerrit.libreoffice.org/21338Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

... with how framework::MenuBarManager works, following my
work of converting context menus to use it instead of
SfxPopupMenuManager (see tdf#93837).

MenuBarManager sets menu item properties/select handler
when the menu activates - in MenuBarManager::Activate, but
it was never called for submenus. The solution is to adapt
the menuNeedsUpdate delegate to call Menu::Activate.

This makes submenu items work, but doesn't update their
visual state (e.g. title). The reason is that
AquaSalMenu::ShowNativePopupMenu is creating a copy of the
NSMenu, so AquaSalMenu::SetItemText is modifying the wrong
NSMenu instance.

Another problem is that AquaSalMenu::ShowNativePopupMenu
tries to removes (via removeUnusedItemsRunner function)
all disabled items, but the correct state is set by
MenuBarManager only when the menu activates. So we must
handle disabled items only after MenuBarManager::Activate
did its job.

Turns out that we can just hide items in NSMenu instead
of removing them, so no need to clone the NSMenu anymore.

Change-Id: If0785b7f9d5f0ad98ced23585379039a51dc13bf
Reviewed-on: https://gerrit.libreoffice.org/21374Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: I96b0a80962e1dc6925a57e5fe07041f2dccdacc6
Reviewed-on: https://gerrit.libreoffice.org/21375Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I919f9f5f9ccb1429624f9c8e75574fec71a2b370

Change-Id: I60c66ae8944cb4cfe82bfb762d9739446362b61b

Change-Id: I5a74dd60f61fc0fdb88f08383d579b14222aa55d
Reviewed-on: https://gerrit.libreoffice.org/21365Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

Change-Id: I5f9c64f8c4b0868d2cbf4c53007076450ed7fc86
Reviewed-on: https://gerrit.libreoffice.org/21372Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

There was erroneously added code before check in
45e8e0fb.

Change-Id: Ie2e84cfc061097c25e5d799e9c388abd9724bd93

Change-Id: I3376daf1731be6f02d62d8d659c8c3fff7605171

Change-Id: I3839bc134b337ccb7cfdb2ee70524e4721c8f83c

_length must at the tail of filename.

Change-Id: I434e89bf052d8f3130bfca62d71eaf8588c2bac9
Reviewed-on: https://gerrit.libreoffice.org/21213Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Not displayed in the Function Wizard's function list, unless used then
displayed when travelling through the formula expression.

Change-Id: I7489ce1eb9197a84c64c5293321553430baadebb

removed garbage in svg-base64, added svg close tag, fixed ul tag.
Added test case for the added code.

Change-Id: I4f07036300031e1e97b118466ebf75d8b9c46e01
Reviewed-on: https://gerrit.libreoffice.org/21218Tested-by: jan iversen <jani@documentfoundation.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Change-Id: If6f74d968025dd21ee1d1c4bb52df5ffe2002905
Reviewed-on: https://gerrit.libreoffice.org/19780Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Change-Id: Icc0d11cfe421d6328739211511379a39195436b9

Change-Id: Ida3a34fb74e4f956f865c8a52bdcf63811e290cc

Fails with either commit 88cbfe58's last
hunk to xsecctl.cxx (export) or commit
a968893e's last hunk to xsecparser.cxx
(import) reverted.

Change-Id: I0f303c8489f451ebf175ed836d3679b6a13aca42

Change-Id: I64dbf379a2d01ff46c5c32655958c63b04d86895

Change-Id: Iee4aec239bf095233aac800f70688ad9db7949df

Change-Id: I8cab0aac2f67b88936e4bed459dd43b08429b136

Number format such as "0.???" is saved in ODF with number:decimal-replacement=" "

Change-Id: I0dd19b5ea126f380bcf17a3ccc5d8c355119e23b
Reviewed-on: https://gerrit.libreoffice.org/21021Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

A GError needs a valid GQuark as the domain. Passing 0 leads to:
  GLib-WARNING **: (gerror.c:408):g_error_new_valist: runtime check
    failed: (domain != 0)

Change-Id: I2f252eaa83a1519b5d16c7ba22c8f593732807ca
Reviewed-on: https://gerrit.libreoffice.org/21261Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Pranav Kant <pranavk@gnome.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Change-Id: I83ce360622eea0fb805833650c0d2126bcd5d8db

...to flag places that implicitly derive a class privately instead of publicly,
where accidental private derivation can cause unexpected failure of
dynamic_cast, cf. 63b67ab5 "Use public
derivation, and remove then-unnecessary downcasts."

Change-Id: I4bcd5c79c7e27380c820e2dd072fa4c4e8980078

...assuming they were implicitly made private by accident rather than by design.
(And private derivation can cause unexpected failure of dynamic_cast, cf.
63b67ab5 "Use public derivation, and remove
then-unnecessary downcasts.")

Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde

Change-Id: If63a6b2f145f2fa956206e7e591243cf6b981c61

Change-Id: I9c61aee4cbf3f461c84f064ac8259e51aa7b0ada

Change-Id: I5c3bcd19bb63f78c8d06961d39b0932220cb3762

Somewhat arbitrarily prefer public over private derivation.

Change-Id: I444babc5c5dbbf46d77d3e1439c12399976d8fe8

Somewhat arbitrarily prefer public over private derivation; the former is what
is used by default across the code base.

Change-Id: I936c1b0d3231ac97015863f396a5af49f6c9647b

Somewhat arbitrarily prefer public over private derivation; ultimately,
derivation from those deprecated (C++11)/removed (C++17) classes should be
removed, anyway.

Change-Id: I5ed24427d37586e72f8c16509cf5002a54af73f1

Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127

Change-Id: I790fea8b88ca99d17de14f1e91081671422dd8db

Change-Id: I29844009f8357301265421325fc2070f2c9296bf