- 15 Eyl, 2015 7 kayıt (commit)
-
-
Miklos Vajna yazdı
The bug document has: <style:page-layout-properties ... style:repeat="no-repeat"> <style:background-image ... style:repeat="stretch"/> </style:page-layout-properties> When a stretched background image is set on a page style using the Writer UI, then these two style:repeat attributes always match, but not in the bugdoc. The later used to have priority, till commit 7d9bb549 (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02). Fix the problem by extending XMLBackgroundImageContext::EndElement(): if we know that the <style:page-layout-properties> sets the FillBitmapMode property, then don't blindly set BackGraphicLocation, but try to overwrite the exiting FillBitmapMode one. Change-Id: I64ab4363b20cc95003d35acd63ea421472b1c071 (cherry picked from commit 6621da38) Reviewed-on: https://gerrit.libreoffice.org/18582Tested-by:Jenkins <ci@libreoffice.org> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Michael Stahl yazdı
5 ms timers cause SwTextFrm::CollectAutoCmplWrds() to return early, and unlike the auto-spelling stuff there is nothing to store the already-checked range of the paragraph, so on the next iteration it will start from the beginning and time-out again. Prevent that by excluding TIMER events here, as is already done for the ONLINE_SPELLING case. Change-Id: Iac781f10ce0aef902fa921030e61b4cff65d0cb3 (cherry picked from commit b4f35a74) Reviewed-on: https://gerrit.libreoffice.org/18590Reviewed-by:
-
Michael Stahl yazdı
So the auto-spell-checking is hyper-optimized to add the words to the auto-complete list as well, and call SetAutoCompleteWordDirty(). But if you disable the auto-spell-checking, then a separate function SwTextFrm::CollectAutoCmplWrds() will be called, which is buggy because it only resets the dirty flag if at least one word of sufficient length was found in the paragraph, which is never the case for an empty paragraph. Change-Id: Idec64fc3c379301426a44e06a1114c474de36014 (cherry picked from commit 97c6dac6) Reviewed-on: https://gerrit.libreoffice.org/18589Reviewed-by:
-
Samuel Mehrbrodt yazdı
Need to update the tooltip also on state change. This partially reverts the fix for tdf#83558, 1fb8724f Verified that the fix for tdf#83558 still works. Change-Id: I023a5e4b101dc91522f19b0d3ed2ed0c4a47e64b Reviewed-on: https://gerrit.libreoffice.org/18586Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
Tomáš Chvátal yazdı
Otherwise this would needlessly fail on some compilers. Change-Id: I4e46e9e452de0703b6556cd55e4606b02be5c41c Reviewed-on: https://gerrit.libreoffice.org/18584Tested-by:
Michael Stahl <mstahl@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ie066c7f83ad15bec198f2091a3b084468c502766 (cherry picked from commit 064fd834) Reviewed-on: https://gerrit.libreoffice.org/18499Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> Tested-by:
-
Caolán McNamara yazdı
Change-Id: Id0be728602b3c58b2853ff464336d68303531efe (cherry picked from commit f3f1919a) Reviewed-on: https://gerrit.libreoffice.org/18434Reviewed-by:
-
- 14 Eyl, 2015 5 kayıt (commit)
-
-
Szymon Kłos yazdı
While opening folders in SvtFileView using doubleclick, sometimes GtkSalFrame::gestureLongPress method is executed with a null frame pointer and LO crashes. I noticed this only with remote dirs, probably this bug occurs only when the doubleclick handler routine takes a lot of time. (cherry picked from commit db33c785) Change-Id: I432046994b3e1662bd7e499681bd20e9696b2d52 Reviewed-on: https://gerrit.libreoffice.org/18571Reviewed-by:
-
Julien Nabet yazdı
Change-Id: Ic57611be96f160037fbff2e9452f9206083c80e4 Reviewed-on: https://gerrit.libreoffice.org/18324Reviewed-by:
-
Katarina Behrens yazdı
Regression from commit 8b779997, which replaced named GtkFrame with GtkBox, but didn't rename the box accordingly. Change-Id: I321dbee05faded81dbf575bca3c578ecb09f1a3e Reviewed-on: https://gerrit.libreoffice.org/18562Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I233c2fff9c06a81117f8114ccee83b53ea4026db (cherry picked from commit b43e0335) Reviewed-on: https://gerrit.libreoffice.org/18505Tested-by:
David Tardon <dtardon@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I3e8aa5c48ba802cd363688502b44e27bfdf67f01 (cherry picked from commit b02f1c58) Reviewed-on: https://gerrit.libreoffice.org/18464Tested-by:
-
- 13 Eyl, 2015 1 kayıt (commit)
-
-
Julien Nabet yazdı
+ Typo: excecptionTypeSizeArray->exceptionTypeSizeArray Cherry-picked from 81d62c5f Change-Id: I6fac3bea1eba094e87717d20a08ec7cf6151e2df Reviewed-on: https://gerrit.libreoffice.org/18527Tested-by:
Noel Grandin <noelgrandin@gmail.com>
-
- 12 Eyl, 2015 4 kayıt (commit)
-
-
László Németh yazdı
with disabled rulers. (This fix was suggested by Tomaž Vajngerl.) (Cherry-picked from the commit ed031895) Conflicts: svtools/source/control/ruler.cxx Change-Id: I161237cdb4941c0eaf934223b078acd94d72e21d Reviewed-on: https://gerrit.libreoffice.org/18507Tested-by:
Tomaž Vajngerl <quikee@gmail.com>
-
Niklas Johansson yazdı
Project: dictionaries 1a7a5f8de5e79e1f96095acf98bc5541a0cbac8f Update the Swedish spelling dictionary Change-Id: I5ae96f88587f5eeb0811290ab24bba28d3bc5013 Reviewed-on: https://gerrit.libreoffice.org/18514Reviewed-by:
-
Michael Stahl yazdı
There is a sort of intentional infinite loop in the idle spell checking handler: while the user is typing a word, it should not be marked as invalid yet, in order not to annoy them with red underlines. So the word where the cursor is positioned always remained dirty, unless you happen to have a grammar checker enabled, which clears the paragraph's dirty flag from a separate thread. To avoid the infinite loop, add another spell checking state "PENDING" which is the same as dirty except that it should cancel the idle spell checking. The idle spell checking will run again when the user does the next editing operation. Notably this means if the user just moves the cursor out of the wrongly spelled word, it won't be underlined yet, but that appears a minor issue, and checking when the cursor leaves the word appears too hard to implement. (cherry picked from commit 4c91e94e) Change-Id: Ifb3d6d17f94f9f1cfad82e70dfa79f1594c38647 Reviewed-on: https://gerrit.libreoffice.org/18511Tested-by:
-
Michael Stahl yazdı
This reverts commit 9099e21b. It causes the problem that frames anchored to the same node where redlines start or end get duplicated during Hide. Jan-Marek said that the original mail-merge related problem this change was fixing is now most likely fixed differently, and the test in testMultiPageAnchoredDraws() still passes. (cherry picked from commit e84f0a9b) sw: add unit test for the redline frame duplication regression (cherry picked from commit d5ffcba0) Change-Id: Ie84fed3f64be7696782bc557004eb18fccc5b64b Reviewed-on: https://gerrit.libreoffice.org/18509Reviewed-by:
-
- 11 Eyl, 2015 10 kayıt (commit)
-
-
Lubosz Sarnecki yazdı
Change-Id: Ib139e81f770531f7d808764dd3a77c7ac8d6fa3c Signed-off-by:Michael Meeks <michael.meeks@collabora.com>
-
Regina Henschel yazdı
Change wrong PROP_FILENAME to correct PROP_DIRECTORY Change-Id: Iab2e16c486f487699e1574ed508539d95884bf9b Reviewed-on: https://gerrit.libreoffice.org/18127Tested-by:
-
Eike Rathke yazdı
Drag&Drop Undo is a special case of ownership.. Change-Id: I2fe7769c4d84efe09d432335d5d8e72d506bf7a1 (cherry picked from commit 44f34c11) Reviewed-on: https://gerrit.libreoffice.org/18470Tested-by:
-
Miklos Vajna yazdı
in JunitTest_sc_unoapi_3. Change-Id: Ic7e32979f31a3376b67eb3bef59373632461e39f (cherry picked from commit 0e682d47) Reviewed-on: https://gerrit.libreoffice.org/18490Reviewed-by:
-
Miklos Vajna yazdı
So that large images are written only once to the ZIP container when they are exported using both markups. This affects drawinglayer images, the Writer ones are handled directly in sw and were already deduplicated. (cherry picked from commit b484e981) Conflicts: oox/source/export/drawingml.cxx Change-Id: Iff7c769329b42939833056b727b070f6a60da5e3 Reviewed-on: https://gerrit.libreoffice.org/18491Reviewed-by:
-
Miklos Vajna yazdı
in JunitTest_sc_unoapi_3. Change-Id: Ibe12a31c1158f782bd7df115171b07e1843d025c (cherry picked from commit 57fc41ad) Reviewed-on: https://gerrit.libreoffice.org/18489Tested-by:
-
Miklos Vajna yazdı
Change-Id: Ic8065d4f656d42f1e2e7d8b4c602010fa0ae2d34 Reviewed-on: https://gerrit.libreoffice.org/18343Reviewed-by:
-
Miklos Vajna yazdı
There were two problems here: 1) The OpenGLContext ctor registered the instance on the list of contexts, but platform-specific call (e.g. wglMakeCurrent()) was only made later. Add a registerAsCurrent() member function that helps ensuring that the last item in the context list is indeed the current context. 2) OpenGLContext::prepareForYield() is called without the solar mutex being locked, but it still assumes that the last context in the context list is the thread's current context, which may not be true. The result is that during JunitTest_sd_unoapi, we end up in a situation like: debug:4640:5240: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA65F8 debug:4640:7944: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 000D0003, pSVData->maGDIData.mpLastContext is 00FA6C70 debug:4640:5240: OpenGLContext::prepareForYield: start, wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA6C70 I.e. one thread registers as current, an other registers as current, too (while the other thread has the solar mutex), then once the original thread wants to release the solar mutex, the real current context and the last item in the context list won't match, so the assert at the end of prepareForYield() will fail. Fix this by releasing the GL context in WinSalInstance::DestroyFrame(). With this, JunitTest_sd_unoapi passes on Windows with GL enabled. Change-Id: Icfb9c65c871586b5df69b5a2ab3aa91843dfc799 Reviewed-on: https://gerrit.libreoffice.org/18473Reviewed-by:
-
Julien Nabet yazdı
When Slide Show/Slide Show Settings is selected and Ok button is clicked the slide from "From" list box is stored in maPresPage and the fact that this var is not empty makes slideshow considers it must be used. So 2 things must be done: 1) Check first if "All Slides" has been selected In this case, don't read slide from "From" in next block (ATTR_PRESENT_DIANAME) and so let maPresPage empty 2) Empty maPresPage if "All Slides" has been selected to remove any existing value Change-Id: I6042ae2db6260e1f441a1c9db90f5de6de966f2a Reviewed-on: https://gerrit.libreoffice.org/18253Tested-by:
-
Miklos Vajna yazdı
Commit a6b00d16 (Related bnc#822625: Cache FontEntry with the original FontSelectPattern.) and the follow-up 16a62079 (Oops, this reference can't be const., 2014-05-28) changed the font cache key, so that it's directly what was the argument to ImplFontCache::GetFontEntry(), which leads to missing glyphs in the bugdoc, e.g. the 4 check mark characters are rendered as a check mark only in the DejaVu Sans case on my machine, the other 3 cases result in placeholders. Fix the problem by changing back the key to aFontSelData, which is possibly modified in ImplFontCache::GetFontEntry() before used as a key. Change-Id: I80eb4ba0f986a10100b6ae421d1346f235ce83b7 (cherry picked from commit e047caf4) Reviewed-on: https://gerrit.libreoffice.org/18437Tested-by:
-
- 10 Eyl, 2015 1 kayıt (commit)
-
-
Miklos Vajna yazdı
(cherry picked from commit b5df051c) Change-Id: I4a7199633d0d940ae009ac144989da7d6c9262ec Reviewed-on: https://gerrit.libreoffice.org/18399Tested-by:
Andras Timar <andras.timar@collabora.com>
-
- 09 Eyl, 2015 4 kayıt (commit)
-
-
Matthias Freund yazdı
-drawchart icons has now three pieces but only one seperated one. -lc version of the formatdialog icons has now a non equal sign. -dark pie same size as the seperated one. Change-Id: If6373232cff67ec18ad8e5f8bb9e65176cce20ad
-
Matthias Freund yazdı
drawchart with 3 pieces and cleanups wich had prevent sharp symbols. Change-Id: I0733f68b59a66dc6476fa183615e9429b2904275 Reviewed-on: https://gerrit.libreoffice.org/16957Tested-by:
-
Caolán McNamara yazdı
Change-Id: I525009b9d037387b236cb4605fe0b93c94858d89 (cherry picked from commit b95175cc)
-
Michael Meeks yazdı
Removes a large number of spurious GL errors left & right. Change-Id: I0b5639478812982b39d3b88be2600dad5d3f1fd0 Reviewed-on: https://gerrit.libreoffice.org/18422Tested-by:
-
- 08 Eyl, 2015 8 kayıt (commit)
-
-
Michael Stahl yazdı
Change-Id: Ib8294e66cb9482ae2502f4741c90dccac36a117b
-
Michael Stahl yazdı
Change-Id: I7b6910a131d95a74168ccee9140bc58393ceddb0
-
Michael Stahl yazdı
Ugly hack in ExternalProject_liborcus.mk as apparently it fails with the define on Windows, and without on MacOSX :( Change-Id: If0b52825122edd956044f61d413c57a76f485101
-
Michael Meeks yazdı
Previously we would get an explicit ~OpenGLContext - and potentially leave FMR's around for other OGC users, now we treat the other users properly - we need an explicit dispose() to get Window::dispose ordering right. Reviewed-on: https://gerrit.libreoffice.org/18412Tested-by:
Markus Mohrhard <markus.mohrhard@googlemail.com> Conflicts: vcl/source/window/openglwin.cxx Change-Id: I5edcbd73399b6db3dbcfb391570f364f9ab0c70d Reviewed-on: https://gerrit.libreoffice.org/18414Reviewed-by:
-
Markus Mohrhard yazdı
Change-Id: Iab0a53abd723f0309f40742636315079a4b2c532 (cherry picked from commit c94d60d6) Signed-off-by:
-
Michael Meeks yazdı
Squashes two related patches from master: Don't use rtl::Reference for the global / list state, so the ref-count reflects the number of real users. Hold a reference during ~OpenGLContext. Fix mis-use in: gltf rendering, OpenGL canvas, GL transitions & GL capable (charts) Avoid GLX operations on un-initialized contexts. Signed-off-by: -
Michael Meeks yazdı
Change-Id: I4a61595294c24a609a5952ce72f9f88524969784 Reviewed-on: https://gerrit.libreoffice.org/18384Reviewed-by:
-
Michael Stahl yazdı
After the document is created, an event is dispatched on the main loop that calls SfxPickList::Notify(), which modifies document properties. It tries to prevent setting the document to modified by calling SfxObjectShell::EnableSetModified(false), but Writer cunningly outwits it by simply having its own independent(?) modified flag that is set unconditionally in DocumentStatisticsManager::DocInfoChgd(). Let's assume that if the modified flag shouldn't be modified in SfxObjectShell, it shouldn't be modified in DocumentStatisticsManager. Somehow in 4.4 and 4.3 the same thing was going on, but it didn't result in a visibly enabled Save icon in the UI, but with 5.0 it does - cannot easily bisect why that changed due to tdf#91383. Change-Id: Id30fd831eb29910c9fb44ed3031bf8da23586bea (cherry picked from commit 5adc8ee3) Reviewed-on: https://gerrit.libreoffice.org/18388Reviewed-by:
-
