That sanity check was added in
615fae2f but we lost it at some stage.

The codesigning script has a very confusing history, in part caused by
its use for two purposes, when building for the Mac App Store and when
building for a TDF style distribution on a dmg disk image. Those who
work with the former and those who work with the latter haven't
necessarily checked that it doesn't break for the other case. Sorry.

Change-Id: I79011302f60b1f6551328c8b80e00f5d3698504c

Change-Id: Ibde5189ecf09ec8dfaf3223683c5480974084865

Change-Id: Ie56cea7fdee7ff6c9e72880e56f9e31ce5f7e03b
Reviewed-on: https://gerrit.libreoffice.org/32970Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: I14bf283fe8a795944a08a4cde2fff3d670f6e3ed
Reviewed-on: https://gerrit.libreoffice.org/32969Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Don't rely on current implementation details of TerminateListener.

Change-Id: I7977c73669f0ab5afac1c93be620e7aeebfe68a2

Installing random 3rd-party "devel packages" is exactly what we don't
want people to do when building on macOS. And anyway, there is no
reason to believe this particular check will ever fail (there even is
a comment that says "MacOS X has system MIT Kerberos 5 since 10.4"),
unless something is very wrong.

Change-Id: Ic880e59358c7c510de9db29e66dfeee7f4e85b4d

There was also a wrong relation. Now blob resets its position.

Change-Id: I41caf7cdfa261cafa5b9e66c9523c7f15225bfd8
Reviewed-on: https://gerrit.libreoffice.org/32937Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

seen examining rhbz#1409011

insert three 0x2F940 in insert special character

click on end and press backspace and text was mangled
clise inside the 3 glyph sequence and press delete/backspace and more mangling

Change-Id: I5898e9272e7a90e8b9dabb0be65f493df7dcbaf9

Change-Id: Iee24a1b7bc4ada389dfa5f0f39c9d06938ed1481

Change-Id: Idf99aab4bc136ac4a8a07945001e4f34a34a0e17

Considering the valid indexes are extended by "-1" for backwards
iterators and "size()" for forward iterators, it's obvious that a
not-yet-at-the-end-in-the-other-direction iterator can be incremented
once, but not necessarily twice.

Why this code even wants to increment it twice isn't obvious to me.

Change-Id: I578c8c6202049ebe6dbed41b8276a6bfa0566bbc

ImplConstruct sets mnAnimationLoopCount, but is always followed by
ImplAssignGraphicData which overwrites it so we can omit that

ImplConstruct sets mnDataChangeTimeStamp, but is always
followed by ImplAssignGraphicData which always calls
ImplAfterDataChange which overwrites it so we can omit that

Change-Id: I2304dc1ea590071a83ca30768426f721c1bd259c
Reviewed-on: https://gerrit.libreoffice.org/32953Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7e32a57cf6941d36e0bbcfb447065c4b0d56f8c3

Change-Id: I3f6e9ec0343074b506cb07b1ad5c9b3e1ef20b5e

Change-Id: I283da52c0ee2b63c19e31e9a61ab24997c037a6a

Change-Id: I14bd0d9d55a03f4cd33aaf131e66f859569f5b18
Reviewed-on: https://gerrit.libreoffice.org/32968Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: Ifc78ba8ae27544e8588c18cd5ba962a9fdeb1497

It's only used at one call site, which already uses
std::unique_ptr.

Change-Id: I5ff528ebc560bb6eb8783d20002cea40a451761e
Reviewed-on: https://gerrit.libreoffice.org/32946Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>

This class is only used inside package module, and totally private
to the module.

Change-Id: Ib00e7066c22a74c0b16c8d6ecf72b99ac42682dd
Reviewed-on: https://gerrit.libreoffice.org/32945Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: I03f76aada322a7222795795d32553ae2425092c3
Reviewed-on: https://gerrit.libreoffice.org/32962Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: I1f9569cb5ca05faf12663b3df8508d10a8cd75e6
Reviewed-on: https://gerrit.libreoffice.org/32957Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic216c7b901bf6da779e161f35e5143739267b066

Change-Id: I6f4c294cb15a4426545d05be7b0a7f26f580563c

Change-Id: I0f967f75dc41b3dc65790cf97bdac992033d1c92

Change-Id: I9efdd5136fdf793e0075b91fcfae4fed42050109

Change-Id: Iebf83ccfb9e7128fd328a548ce77cdee4ef7ca4b

Change-Id: I81877e46cf95dcc7de16b797fca33658036bf9e8

Change-Id: I29c40113f9248f9041dacc398416f39889f5ddf8

Change-Id: Ie2a96299d8d3cc9c1ccad7cfb8fbee05c6734148

Change-Id: I638199f1455bead71f0a03f15e4b6f418a0cd0e2

Change-Id: Ic7e4ba1ada97a0fff1ae6d209b22e372431cc6e7

Change-Id: I034eeb9525bbb8fdc39e176a2433f1b3dfff566a

Change-Id: I7219f2e720b7c1581c59cefe39e152c5aa20a8fe

Change-Id: Ibbcb8b6dfaf1c979db2e7930c4f6c8475d693ac8

Change-Id: Ied0ee5f637e83fe7819c68e3f4ea4634f21ac3f6

Change-Id: I55f1ff2be091ea5e8475e22abdf62aa5c0c435be
Reviewed-on: https://gerrit.libreoffice.org/32921Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

opens a dialog box from which user can choose to take online help or cancel it

Change-Id: I8c1278aab88d55901a65c38b15fcc8519360dc59
Reviewed-on: https://gerrit.libreoffice.org/31385Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I73f694e6dedb84b3fb3b63ffb9dcda2481bc403c

Change-Id: I8b026b61b8744e21584bc64d80a957aca08aae2b

Change-Id: I30fee1c51ff3e0b8e3e74b4293227a5bfbfe0837